[igt-dev] [PATCH i-g-t v2 0/3] Initial tests for the lima drm driver

[igt-dev] [PATCH i-g-t v2 0/3] Initial tests for the lima drm driver

[Erico Nunes]

I started working on something for the lima drm driver and realized that
there is no coverage for it in igt yet. It would be nice to have some to
check the driver specific ioctls and support that work.
Here are some to get some basic support and if we can get these in, we
can follow up with more tests to cover the remaining ioctls.
I used the panfrost and v3d gem tests as a reference for these initial
tests.

v2: fixed build after CI failure

Erico Nunes (3):
  lib: Add support for opening lima devices
  lib/lima: Add lima helpers
  tests/lima: Add initial tests for lima

 lib/drmtest.c        |  3 ++
 lib/drmtest.h        |  1 +
 lib/igt_lima.c       | 97 ++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_lima.h       | 26 ++++++++++++
 lib/meson.build      |  1 +
 tests/lima_gem_new.c | 78 +++++++++++++++++++++++++++++++++++
 tests/meson.build    |  1 +
 7 files changed, 207 insertions(+)
 create mode 100644 lib/igt_lima.c
 create mode 100644 lib/igt_lima.h
 create mode 100644 tests/lima_gem_new.c

-- 
2.40.1

[igt-dev] [PATCH i-g-t v2 1/3] lib: Add support for opening lima devices

[Erico Nunes]

This will be to test the lima drm driver specific ioctls, so adding lima
to the list.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
 lib/drmtest.c | 3 +++
 lib/drmtest.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/lib/drmtest.c b/lib/drmtest.c
index aa2e6b08..677f411c 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -195,6 +195,7 @@ static const struct module {
 } modules[] = {
 	{ DRIVER_AMDGPU, "amdgpu" },
 	{ DRIVER_INTEL, "i915", modprobe_i915 },
+	{ DRIVER_LIMA, "lima" },
 	{ DRIVER_MSM, "msm" },
 	{ DRIVER_PANFROST, "panfrost" },
 	{ DRIVER_V3D, "v3d" },
@@ -596,6 +597,8 @@ static const char *chipset_to_str(int chipset)
 		return "xe";
 	case DRIVER_VMWGFX:
 		return "vmwgfx";
+	case DRIVER_LIMA:
+		return "lima";
 	case DRIVER_ANY:
 		return "any";
 	default:
diff --git a/lib/drmtest.h b/lib/drmtest.h
index ae86ee19..cedac89b 100644
--- a/lib/drmtest.h
+++ b/lib/drmtest.h
@@ -53,6 +53,7 @@
 #define DRIVER_MSM	(1 << 6)
 #define DRIVER_XE	(1 << 7)
 #define DRIVER_VMWGFX   (1 << 8)
+#define DRIVER_LIMA	(1 << 9)
 
 /*
  * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
-- 
2.40.1

Re: [igt-dev] [PATCH i-g-t v2 1/3] lib: Add support for opening lima devices

[Kamil Konieczny]

On 2023-05-26 at 14:59:59 +0200, Erico Nunes wrote:
> This will be to test the lima drm driver specific ioctls, so adding lima
> to the list.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>

Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  lib/drmtest.c | 3 +++
>  lib/drmtest.h | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index aa2e6b08..677f411c 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -195,6 +195,7 @@ static const struct module {
>  } modules[] = {
>  	{ DRIVER_AMDGPU, "amdgpu" },
>  	{ DRIVER_INTEL, "i915", modprobe_i915 },
> +	{ DRIVER_LIMA, "lima" },
>  	{ DRIVER_MSM, "msm" },
>  	{ DRIVER_PANFROST, "panfrost" },
>  	{ DRIVER_V3D, "v3d" },
> @@ -596,6 +597,8 @@ static const char *chipset_to_str(int chipset)
>  		return "xe";
>  	case DRIVER_VMWGFX:
>  		return "vmwgfx";
> +	case DRIVER_LIMA:
> +		return "lima";
>  	case DRIVER_ANY:
>  		return "any";
>  	default:
> diff --git a/lib/drmtest.h b/lib/drmtest.h
> index ae86ee19..cedac89b 100644
> --- a/lib/drmtest.h
> +++ b/lib/drmtest.h
> @@ -53,6 +53,7 @@
>  #define DRIVER_MSM	(1 << 6)
>  #define DRIVER_XE	(1 << 7)
>  #define DRIVER_VMWGFX   (1 << 8)
> +#define DRIVER_LIMA	(1 << 9)
>  
>  /*
>   * Exclude DRVER_VGEM from DRIVER_ANY since if you run on a system
> -- 
> 2.40.1
> 

[igt-dev] [PATCH i-g-t v2 2/3] lib/lima: Add lima helpers

[Erico Nunes]

Add initial gem helpers for lima tests, based on the panfrost ones.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
 lib/igt_lima.c  | 97 +++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_lima.h  | 26 +++++++++++++
 lib/meson.build |  1 +
 3 files changed, 124 insertions(+)
 create mode 100644 lib/igt_lima.c
 create mode 100644 lib/igt_lima.h

diff --git a/lib/igt_lima.c b/lib/igt_lima.c
new file mode 100644
index 00000000..0d0f3c80
--- /dev/null
+++ b/lib/igt_lima.c
@@ -0,0 +1,97 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Erico Nunes
+ */
+
+#include <assert.h>
+#include <string.h>
+#include <signal.h>
+#include <errno.h>
+#include <sys/mman.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <fcntl.h>
+
+#include "drmtest.h"
+#include "igt_aux.h"
+#include "igt_core.h"
+#include "igt_lima.h"
+#include "ioctl_wrappers.h"
+#include "lima_drm.h"
+
+/**
+ * SECTION:igt_lima
+ * @short_description: LIMA support library
+ * @title: LIMA
+ * @include: igt.h
+ *
+ * This library provides various auxiliary helper functions for writing Lima
+ * tests.
+ */
+
+struct lima_bo *
+igt_lima_gem_new(int fd, size_t size)
+{
+	struct lima_bo *bo = calloc(1, sizeof(*bo));
+
+	struct drm_lima_gem_create create_bo = {
+		.size = size,
+		.flags = 0,
+	};
+
+	do_ioctl(fd, DRM_IOCTL_LIMA_GEM_CREATE, &create_bo);
+
+	bo->handle = create_bo.handle;
+	bo->size = size;
+	return bo;
+}
+
+void
+igt_lima_free_bo(int fd, struct lima_bo *bo)
+{
+	if (!bo)
+		return;
+
+	if (bo->map)
+		munmap(bo->map, bo->size);
+	gem_close(fd, bo->handle);
+	free(bo);
+}
+
+uint64_t
+igt_lima_get_bo_offset(int fd, uint32_t handle)
+{
+	struct drm_lima_gem_info gem_info = {
+		.handle = handle,
+	};
+
+	do_ioctl(fd, DRM_IOCTL_LIMA_GEM_INFO, &gem_info);
+
+	return gem_info.offset;
+}
+
+uint32_t
+igt_lima_get_param(int fd, int param)
+{
+	struct drm_lima_get_param get = {
+		.param = param,
+	};
+
+	do_ioctl(fd, DRM_IOCTL_LIMA_GET_PARAM, &get);
+
+	return get.value;
+}
+
+void *
+igt_lima_mmap_bo(int fd, uint32_t handle, uint32_t size, unsigned int prot)
+{
+	uint64_t offset = igt_lima_get_bo_offset(fd, handle);
+	void *ptr;
+
+	ptr = mmap(0, size, prot, MAP_SHARED, fd, offset);
+	if (ptr == MAP_FAILED)
+		return NULL;
+	else
+		return ptr;
+}
diff --git a/lib/igt_lima.h b/lib/igt_lima.h
new file mode 100644
index 00000000..3c4eaf3d
--- /dev/null
+++ b/lib/igt_lima.h
@@ -0,0 +1,26 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2023 Erico Nunes
+ */
+
+#ifndef IGT_LIMA_H
+#define IGT_LIMA_H
+
+#include "lima_drm.h"
+
+struct lima_bo {
+	int handle;
+	uint64_t offset;
+	uint32_t size;
+	void *map;
+};
+
+struct lima_bo *igt_lima_gem_new(int fd, size_t size);
+void igt_lima_free_bo(int fd, struct lima_bo *bo);
+
+/* IOCTL wrappers */
+uint64_t igt_lima_get_bo_offset(int fd, uint32_t handle);
+uint32_t igt_lima_get_param(int fd, int param);
+void *igt_lima_mmap_bo(int fd, uint32_t handle, uint32_t size, unsigned int prot);
+
+#endif /* IGT_LIMA_H */
diff --git a/lib/meson.build b/lib/meson.build
index 85f100f7..a0f92941 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -89,6 +89,7 @@ lib_sources = [
 	'uwildmat/uwildmat.c',
 	'igt_kmod.c',
 	'igt_panfrost.c',
+	'igt_lima.c',
 	'igt_v3d.c',
 	'igt_vc4.c',
 	'igt_vmwgfx.c',
-- 
2.40.1

Re: [igt-dev] [PATCH i-g-t v2 2/3] lib/lima: Add lima helpers

[Kamil Konieczny]

Hi Erico,

On 2023-05-26 at 15:00:00 +0200, Erico Nunes wrote:
> Add initial gem helpers for lima tests, based on the panfrost ones.
> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  lib/igt_lima.c  | 97 +++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/igt_lima.h  | 26 +++++++++++++
>  lib/meson.build |  1 +
>  3 files changed, 124 insertions(+)
>  create mode 100644 lib/igt_lima.c
>  create mode 100644 lib/igt_lima.h
> 
> diff --git a/lib/igt_lima.c b/lib/igt_lima.c
> new file mode 100644
> index 00000000..0d0f3c80
> --- /dev/null
> +++ b/lib/igt_lima.c
> @@ -0,0 +1,97 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Erico Nunes
> + */
> +
> +#include <assert.h>
> +#include <string.h>
> +#include <signal.h>
------------ ^
Please sort all system headers alphabetically.

> +#include <errno.h>
------------ ^

> +#include <sys/mman.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <fcntl.h>
------------ ^

> +
> +#include "drmtest.h"
> +#include "igt_aux.h"
> +#include "igt_core.h"
> +#include "igt_lima.h"
> +#include "ioctl_wrappers.h"
> +#include "lima_drm.h"
> +
> +/**
> + * SECTION:igt_lima
> + * @short_description: LIMA support library
> + * @title: LIMA
> + * @include: igt.h
> + *
> + * This library provides various auxiliary helper functions for writing Lima
> + * tests.
> + */
> +

Remove empty line.

> +struct lima_bo *
> +igt_lima_gem_new(int fd, size_t size)
> +{
> +	struct lima_bo *bo = calloc(1, sizeof(*bo));
> +
> +	struct drm_lima_gem_create create_bo = {
> +		.size = size,
> +		.flags = 0,
> +	};
> +
> +	do_ioctl(fd, DRM_IOCTL_LIMA_GEM_CREATE, &create_bo);
> +
> +	bo->handle = create_bo.handle;
> +	bo->size = size;
> +	return bo;
> +}
> +

Please add descriptions to all new public functions.

> +void
> +igt_lima_free_bo(int fd, struct lima_bo *bo)
> +{
> +	if (!bo)
> +		return;
> +
> +	if (bo->map)
> +		munmap(bo->map, bo->size);

You ignore error here.

> +	gem_close(fd, bo->handle);
> +	free(bo);
> +}
> +

Write description for igt_lima_get_bo_offset.

> +uint64_t
> +igt_lima_get_bo_offset(int fd, uint32_t handle)
> +{
> +	struct drm_lima_gem_info gem_info = {
> +		.handle = handle,
> +	};
> +
> +	do_ioctl(fd, DRM_IOCTL_LIMA_GEM_INFO, &gem_info);
> +
> +	return gem_info.offset;
> +}
> +

Same here.

> +uint32_t
> +igt_lima_get_param(int fd, int param)
> +{
> +	struct drm_lima_get_param get = {
> +		.param = param,
> +	};
> +
> +	do_ioctl(fd, DRM_IOCTL_LIMA_GET_PARAM, &get);
> +
> +	return get.value;
> +}
> +

Same here.

> +void *
> +igt_lima_mmap_bo(int fd, uint32_t handle, uint32_t size, unsigned int prot)
> +{
> +	uint64_t offset = igt_lima_get_bo_offset(fd, handle);
> +	void *ptr;
> +
> +	ptr = mmap(0, size, prot, MAP_SHARED, fd, offset);
> +	if (ptr == MAP_FAILED)
> +		return NULL;

We name __igt_function for functions which run regardless of
error, while igt_function fails on error. Above you used
do_ioctl which will fail on error. Your choice.

Regards,
Kamil

> +	else
> +		return ptr;
> +}
> diff --git a/lib/igt_lima.h b/lib/igt_lima.h
> new file mode 100644
> index 00000000..3c4eaf3d
> --- /dev/null
> +++ b/lib/igt_lima.h
> @@ -0,0 +1,26 @@
> +/* SPDX-License-Identifier: MIT */
> +/*
> + * Copyright © 2023 Erico Nunes
> + */
> +
> +#ifndef IGT_LIMA_H
> +#define IGT_LIMA_H
> +
> +#include "lima_drm.h"
> +
> +struct lima_bo {
> +	int handle;
> +	uint64_t offset;
> +	uint32_t size;
> +	void *map;
> +};
> +
> +struct lima_bo *igt_lima_gem_new(int fd, size_t size);
> +void igt_lima_free_bo(int fd, struct lima_bo *bo);
> +
> +/* IOCTL wrappers */
> +uint64_t igt_lima_get_bo_offset(int fd, uint32_t handle);
> +uint32_t igt_lima_get_param(int fd, int param);
> +void *igt_lima_mmap_bo(int fd, uint32_t handle, uint32_t size, unsigned int prot);
> +
> +#endif /* IGT_LIMA_H */
> diff --git a/lib/meson.build b/lib/meson.build
> index 85f100f7..a0f92941 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -89,6 +89,7 @@ lib_sources = [
>  	'uwildmat/uwildmat.c',
>  	'igt_kmod.c',
>  	'igt_panfrost.c',
> +	'igt_lima.c',
>  	'igt_v3d.c',
>  	'igt_vc4.c',
>  	'igt_vmwgfx.c',
> -- 
> 2.40.1
> 

[igt-dev] [PATCH i-g-t v2 3/3] tests/lima: Add initial tests for lima

[Erico Nunes]

Some gem tests based on the panfrost and v3d ones.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
---
 tests/lima_gem_new.c | 78 ++++++++++++++++++++++++++++++++++++++++++++
 tests/meson.build    |  1 +
 2 files changed, 79 insertions(+)
 create mode 100644 tests/lima_gem_new.c

diff --git a/tests/lima_gem_new.c b/tests/lima_gem_new.c
new file mode 100644
index 00000000..3b054317
--- /dev/null
+++ b/tests/lima_gem_new.c
@@ -0,0 +1,78 @@
+// SPDX-License-Identifier: MIT
+/*
+ * Copyright © 2023 Erico Nunes
+ */
+
+#include "igt.h"
+#include "igt_lima.h"
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include "lima_drm.h"
+
+igt_main
+{
+	int fd;
+
+	igt_fixture {
+		fd = drm_open_driver(DRIVER_LIMA);
+	}
+
+	igt_describe("Sanity check for creating a BO with size 4096.");
+	igt_subtest("gem-new-4096") {
+		struct lima_bo *bo = igt_lima_gem_new(fd, 4096);
+
+		igt_lima_free_bo(fd, bo);
+	}
+
+	igt_describe("Make sure a BO cannot be created with size zero.");
+	igt_subtest("gem-new-0") {
+		struct drm_lima_gem_create arg = {
+			.size = 0,
+		};
+
+		do_ioctl_err(fd, DRM_IOCTL_LIMA_GEM_CREATE, &arg, EINVAL);
+	}
+
+	igt_describe("Make sure that BOs can be allocated in different fd without "
+		     "carrying old contents from one another.");
+	igt_subtest("gem-new-zeroed") {
+		int fd2 = drm_open_driver(DRIVER_LIMA);
+		struct lima_bo *bo;
+		uint32_t *map;
+		/* A size different from any used in our other tests, to try
+		 * to convince it to land as the only one of its size in the
+		 * kernel BO cache
+		 */
+		size_t size = 3 * 4096;
+		size_t i;
+
+		/* Make a BO and free it on our main fd. */
+		bo = igt_lima_gem_new(fd, size);
+		map = igt_lima_mmap_bo(fd, bo->handle, size, PROT_READ | PROT_WRITE);
+		memset(map, 0xd0, size);
+		munmap(map, size);
+		igt_lima_free_bo(fd, bo);
+
+		/* Now, allocate a BO on the other fd and make sure it doesn't
+		 * have the old contents.
+		 */
+		bo = igt_lima_gem_new(fd2, size);
+		map = igt_lima_mmap_bo(fd2, bo->handle, size, PROT_READ | PROT_WRITE);
+		for (i = 0; i < size / 4; i++)
+			igt_assert_eq_u32(map[i], 0x0);
+		munmap(map, size);
+		igt_lima_free_bo(fd2, bo);
+
+		close(fd2);
+	}
+
+	igt_fixture
+		close(fd);
+}
diff --git a/tests/meson.build b/tests/meson.build
index f71be1db..980e77e9 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -62,6 +62,7 @@ test_progs = [
 	'kms_vblank',
 	'kms_vrr',
 	'kms_writeback',
+	'lima_gem_new',
 	'meta_test',
 	'panfrost_get_param',
 	'panfrost_gem_new',
-- 
2.40.1

Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/lima: Add initial tests for lima

[Kamil Konieczny]

Hi Erico,

On 2023-05-26 at 15:00:01 +0200, Erico Nunes wrote:
> Some gem tests based on the panfrost and v3d ones.

Could you write a little more what new tests you added ?

> 
> Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
> ---
>  tests/lima_gem_new.c | 78 ++++++++++++++++++++++++++++++++++++++++++++
>  tests/meson.build    |  1 +
>  2 files changed, 79 insertions(+)
>  create mode 100644 tests/lima_gem_new.c
> 
> diff --git a/tests/lima_gem_new.c b/tests/lima_gem_new.c
> new file mode 100644
> index 00000000..3b054317
> --- /dev/null
> +++ b/tests/lima_gem_new.c
> @@ -0,0 +1,78 @@
> +// SPDX-License-Identifier: MIT
> +/*
> + * Copyright © 2023 Erico Nunes
> + */
> +
> +#include "igt.h"
------------ ^
> +#include "igt_lima.h"
------------ ^
Move this after system includes.

> +#include <unistd.h>
------------ ^
Sort includes alphabetically.

> +#include <stdlib.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>

Add newline after system includes.
Put here "igt...h" headers.

> +#include "lima_drm.h"
> +

Write here global description with

IGT_TEST_DESCRIPTION("Global test description.")

> +igt_main
> +{
> +	int fd;
> +
> +	igt_fixture {
> +		fd = drm_open_driver(DRIVER_LIMA);

You can put here
		igt_require(fd > 0);

> +	}
> +
> +	igt_describe("Sanity check for creating a BO with size 4096.");
> +	igt_subtest("gem-new-4096") {
> +		struct lima_bo *bo = igt_lima_gem_new(fd, 4096);
> +
> +		igt_lima_free_bo(fd, bo);
> +	}
> +
> +	igt_describe("Make sure a BO cannot be created with size zero.");
> +	igt_subtest("gem-new-0") {
> +		struct drm_lima_gem_create arg = {
> +			.size = 0,
> +		};
> +
> +		do_ioctl_err(fd, DRM_IOCTL_LIMA_GEM_CREATE, &arg, EINVAL);
> +	}
> +
> +	igt_describe("Make sure that BOs can be allocated in different fd without "
> +		     "carrying old contents from one another.");
> +	igt_subtest("gem-new-zeroed") {
> +		int fd2 = drm_open_driver(DRIVER_LIMA);
> +		struct lima_bo *bo;
> +		uint32_t *map;
> +		/* A size different from any used in our other tests, to try
> +		 * to convince it to land as the only one of its size in the
> +		 * kernel BO cache
> +		 */
> +		size_t size = 3 * 4096;
> +		size_t i;
> +
> +		/* Make a BO and free it on our main fd. */
> +		bo = igt_lima_gem_new(fd, size);
> +		map = igt_lima_mmap_bo(fd, bo->handle, size, PROT_READ | PROT_WRITE);
--------------- ^
In your current implementation you can get NULL here.

> +		memset(map, 0xd0, size);
> +		munmap(map, size);
> +		igt_lima_free_bo(fd, bo);
> +
> +		/* Now, allocate a BO on the other fd and make sure it doesn't
> +		 * have the old contents.
> +		 */
> +		bo = igt_lima_gem_new(fd2, size);
> +		map = igt_lima_mmap_bo(fd2, bo->handle, size, PROT_READ | PROT_WRITE);
--------------- ^
Same here, mey be NULL.

> +		for (i = 0; i < size / 4; i++)
-------------------------------------- ^
It may be also sizeof(map[0]) instead of 4.

Regards,
Kamil

> +			igt_assert_eq_u32(map[i], 0x0);
> +		munmap(map, size);
> +		igt_lima_free_bo(fd2, bo);
> +
> +		close(fd2);
> +	}
> +
> +	igt_fixture
> +		close(fd);
> +}
> diff --git a/tests/meson.build b/tests/meson.build
> index f71be1db..980e77e9 100644
> --- a/tests/meson.build
> +++ b/tests/meson.build
> @@ -62,6 +62,7 @@ test_progs = [
>  	'kms_vblank',
>  	'kms_vrr',
>  	'kms_writeback',
> +	'lima_gem_new',
>  	'meta_test',
>  	'panfrost_get_param',
>  	'panfrost_gem_new',
> -- 
> 2.40.1
> 

Re: [igt-dev] [PATCH i-g-t v2 3/3] tests/lima: Add initial tests for lima

[Erico Nunes]

Hi Kamil,

On Mon, Jun 5, 2023 at 1:18 PM Kamil Konieczny
<kamil.konieczny@linux.intel.com> wrote:
> > +             map = igt_lima_mmap_bo(fd, bo->handle, size, PROT_READ | PROT_WRITE);
> --------------- ^
> In your current implementation you can get NULL here.
>
> > +             memset(map, 0xd0, size);
> > +             munmap(map, size);
> > +             igt_lima_free_bo(fd, bo);
> > +
> > +             /* Now, allocate a BO on the other fd and make sure it doesn't
> > +              * have the old contents.
> > +              */
> > +             bo = igt_lima_gem_new(fd2, size);
> > +             map = igt_lima_mmap_bo(fd2, bo->handle, size, PROT_READ | PROT_WRITE);
> --------------- ^
> Same here, mey be NULL.
>
> > +             for (i = 0; i < size / 4; i++)
> -------------------------------------- ^
> It may be also sizeof(map[0]) instead of 4.

Thanks for the review. I'll send a v3 addressing these and the reviews
on previous patches in this series.
I just didn't do some of the changes pointed out here as I carried it
on as-is from the v3d/panfrost tests which I used as a reference. But
I can address they here for the initial lima tests.

Thanks

Erico

[igt-dev] ✗ GitLab.Pipeline: warning for Initial tests for the lima drm driver (rev2)

[Patchwork]

== Series Details ==

Series: Initial tests for the lima drm driver (rev2)
URL   : https://patchwork.freedesktop.org/series/118303/
State : warning

== Summary ==

Pipeline status: FAILED.

see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/891503 for the overview.

containers:igt has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/42512495):
  79e0b4c6546bf7feb4a58a5d3ffc2d327606c0abaa6f168ce0555e1813683630
  STEP 3: COPY .gitlab-ci/docker-help.sh /usr/local/bin/docker-help.sh
  c0a5e93463d207d46b394a3998d49d40873c849e0d44a358ac7b06a7795ba44e
  STEP 4: ENV PATH="/opt/igt/bin:${PATH}"
  67503cf473505a2d95acdd6a635dac7201c0e69dcebebea8e8509ae0de925c62
  STEP 5: ENV LD_LIBRARY_PATH="/opt/igt/lib:/opt/igt/lib64:${LD_LIBRARY_PATH}"
  4a9c16f09f33cc59e1bceb96430c018d71a48d43043c7377d5244d55adf8250c
  STEP 6: ENV IGT_TEST_ROOT="/opt/igt/libexec/igt-gpu-tools"
  78926b36e30e189fed5f10c33fc2bc5674355eb2f17ccef54eaba3acc96e18b4
  STEP 7: CMD docker-help.sh
  STEP 8: COMMIT registry.freedesktop.org/gfx-ci/igt-ci-tags/igt:commit-43a10068b6717c10050d32dfa1db421611566f09
  935f635cfc5b322e1d7f8faf4dbccb17a920f5866a2b837e00ed12025adfc735
  Getting image source signatures
  Error: Error copying image to the remote destination: Error trying to reuse blob sha256:3504a8337d3b7eaabfd338d6a971d02441d28ebef8bd81f730d87f936ed58079 at destination: failed to read from destination repository gfx-ci/igt-ci-tags/igt: 500 (Internal Server Error)
  section_end:1685106533:step_script
  section_start:1685106533:cleanup_file_variables
  Cleaning up project directory and file based variables
  section_end:1685106536:cleanup_file_variables
  ERROR: Job failed: exit code 1

== Logs ==

For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/891503

[igt-dev] ✓ Fi.CI.BAT: success for Initial tests for the lima drm driver (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7331 bytes --]

== Series Details ==

Series: Initial tests for the lima drm driver (rev2)
URL   : https://patchwork.freedesktop.org/series/118303/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13195 -> IGTPW_9045
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/index.html

Participating hosts (38 -> 39)
------------------------------

  Additional (2): fi-kbl-soraka bat-mtlp-6 
  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in IGTPW_9045 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#2190])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613]) +3 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][3] ([i915#5334] / [i915#7872])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/fi-kbl-soraka/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][4] ([i915#1886] / [i915#7913])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@i915_suspend@basic-s2idle-without-i915:
    - bat-rpls-2:         NOTRUN -> [ABORT][5] ([i915#6687])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html

  * igt@kms_chamelium_frames@hdmi-crc-fast:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][6] ([fdo#109271]) +14 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/fi-kbl-soraka/igt@kms_chamelium_frames@hdmi-crc-fast.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4579])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/fi-kbl-soraka/igt@kms_setmode@basic-clone-single-crtc.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_mocs:
    - {bat-mtlp-8}:       [DMESG-FAIL][8] ([i915#7059]) -> [PASS][9]
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-2:         [ABORT][10] ([i915#7913] / [i915#7982]) -> [PASS][11]
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-2/igt@i915_selftest@live@requests.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/bat-rpls-2/igt@i915_selftest@live@requests.html

  * igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1:
    - bat-dg2-8:          [FAIL][12] ([i915#7932]) -> [PASS][13]
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-1.html

  
#### Warnings ####

  * igt@i915_selftest@live@reset:
    - bat-rpls-1:         [ABORT][14] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384]) -> [ABORT][15] ([i915#4983] / [i915#7461] / [i915#7981] / [i915#8347] / [i915#8384])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/bat-rpls-1/igt@i915_selftest@live@reset.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/bat-rpls-1/igt@i915_selftest@live@reset.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3595]: https://gitlab.freedesktop.org/drm/intel/issues/3595
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
  [i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7872]: https://gitlab.freedesktop.org/drm/intel/issues/7872
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
  [i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
  [i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
  [i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7305 -> IGTPW_9045

  CI-20190529: 20190529
  CI_DRM_13195: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9045: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/index.html
  IGT_7305: 09aa9628059a93510b658dcc731ae4c8bd223790 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git


Testlist changes
----------------

+igt@lima_gem_new@gem-new-0
+igt@lima_gem_new@gem-new-4096
+igt@lima_gem_new@gem-new-zeroed

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/index.html

[-- Attachment #2: Type: text/html, Size: 7157 bytes --]

[igt-dev] ✓ Fi.CI.IGT: success for Initial tests for the lima drm driver (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 18352 bytes --]

== Series Details ==

Series: Initial tests for the lima drm driver (rev2)
URL   : https://patchwork.freedesktop.org/series/118303/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13195_full -> IGTPW_9045_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/index.html

Participating hosts (8 -> 8)
------------------------------

  Additional (1): shard-tglu0 
  Missing    (1): shard-rkl0 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_9045_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@lima_gem_new@gem-new-0} (NEW):
    - {shard-rkl}:        NOTRUN -> [SKIP][1] +2 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-rkl-6/igt@lima_gem_new@gem-new-0.html

  * {igt@lima_gem_new@gem-new-zeroed} (NEW):
    - {shard-dg1}:        NOTRUN -> [SKIP][2] +2 similar issues
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-dg1-15/igt@lima_gem_new@gem-new-zeroed.html

  
#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@perf_pmu@busy-hang@vecs0:
    - {shard-dg1}:        [PASS][3] -> [FAIL][4] +2 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-16/igt@perf_pmu@busy-hang@vecs0.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-dg1-14/igt@perf_pmu@busy-hang@vecs0.html

  
New tests
---------

  New tests have been introduced between CI_DRM_13195_full and IGTPW_9045_full:

### New IGT tests (3) ###

  * igt@lima_gem_new@gem-new-0:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@lima_gem_new@gem-new-4096:
    - Statuses : 6 skip(s)
    - Exec time: [0.0] s

  * igt@lima_gem_new@gem-new-zeroed:
    - Statuses : 5 skip(s)
    - Exec time: [0.0] s

  

Known issues
------------

  Here are the changes found in IGTPW_9045_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gen9_exec_parse@allowed-all:
    - shard-apl:          [PASS][5] -> [ABORT][6] ([i915#5566])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl6/igt@gen9_exec_parse@allowed-all.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl2/igt@gen9_exec_parse@allowed-all.html

  * igt@kms_big_fb@x-tiled-32bpp-rotate-90:
    - shard-apl:          NOTRUN -> [SKIP][7] ([IGT#6] / [fdo#109271]) +9 similar issues
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl2/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html

  * igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
    - shard-apl:          NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#3886])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl7/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

  * igt@kms_content_protection@lic@pipe-a-dp-1:
    - shard-apl:          NOTRUN -> [TIMEOUT][9] ([i915#7173])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl7/igt@kms_content_protection@lic@pipe-a-dp-1.html

  * igt@kms_cursor_crc@cursor-sliding-32x32:
    - shard-apl:          NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4579]) +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl7/igt@kms_cursor_crc@cursor-sliding-32x32.html

  * igt@kms_hdr@static-toggle:
    - shard-apl:          NOTRUN -> [SKIP][11] ([IGT#6] / [fdo#109271] / [i915#4579])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl2/igt@kms_hdr@static-toggle.html

  * igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1:
    - shard-snb:          NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#4579]) +22 similar issues
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-snb5/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-5@pipe-b-vga-1.html

  * igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1:
    - shard-snb:          NOTRUN -> [SKIP][13] ([fdo#109271]) +82 similar issues
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1.html

  * {igt@lima_gem_new@gem-new-4096} (NEW):
    - shard-apl:          NOTRUN -> [SKIP][14] ([fdo#109271]) +13 similar issues
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl4/igt@lima_gem_new@gem-new-4096.html
    - {shard-tglu}:       NOTRUN -> [SKIP][15] ([i915#2575]) +1 similar issue
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-tglu-4/igt@lima_gem_new@gem-new-4096.html
    - shard-glk:          NOTRUN -> [SKIP][16] ([fdo#109271]) +2 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-glk5/igt@lima_gem_new@gem-new-4096.html

  * igt@perf_pmu@module-unload:
    - shard-snb:          [PASS][17] -> [ABORT][18] ([i915#4528])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-snb6/igt@perf_pmu@module-unload.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-snb5/igt@perf_pmu@module-unload.html

  
#### Possible fixes ####

  * igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
    - {shard-rkl}:        [FAIL][19] ([i915#7742]) -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html

  * igt@gem_busy@close-race:
    - shard-snb:          [ABORT][21] -> [PASS][22]
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-snb2/igt@gem_busy@close-race.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-snb6/igt@gem_busy@close-race.html

  * igt@gem_exec_fair@basic-none@vecs0:
    - {shard-rkl}:        [FAIL][23] ([i915#2842]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-4/igt@gem_exec_fair@basic-none@vecs0.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-rkl-4/igt@gem_exec_fair@basic-none@vecs0.html

  * igt@gem_exec_fair@basic-pace@vcs0:
    - shard-glk:          [FAIL][25] ([i915#2842]) -> [PASS][26] +2 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk4/igt@gem_exec_fair@basic-pace@vcs0.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-glk7/igt@gem_exec_fair@basic-pace@vcs0.html

  * igt@gem_lmem_swapping@smem-oom@lmem0:
    - {shard-dg1}:        [TIMEOUT][27] ([i915#5493]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-14/igt@gem_lmem_swapping@smem-oom@lmem0.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html

  * igt@gen9_exec_parse@allowed-single:
    - shard-apl:          [ABORT][29] ([i915#5566]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl7/igt@gen9_exec_parse@allowed-single.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl3/igt@gen9_exec_parse@allowed-single.html

  * igt@i915_pm_dc@dc9-dpms:
    - {shard-tglu}:       [SKIP][31] ([i915#4281]) -> [PASS][32]
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-tglu-5/igt@i915_pm_dc@dc9-dpms.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-tglu-4/igt@i915_pm_dc@dc9-dpms.html

  * igt@i915_pm_rpm@modeset-lpsp-stress:
    - {shard-rkl}:        [SKIP][33] ([i915#1397]) -> [PASS][34] +2 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-1/igt@i915_pm_rpm@modeset-lpsp-stress.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress.html

  * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
    - {shard-rkl}:        [FAIL][35] ([i915#3743]) -> [PASS][36]
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-rkl-7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-rkl-1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

  * igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4:
    - {shard-dg1}:        [INCOMPLETE][37] -> [PASS][38]
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-14/igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-dg1-17/igt@kms_color@ctm-blue-to-red@pipe-b-hdmi-a-4.html

  * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
    - shard-apl:          [FAIL][39] ([IGT#6] / [i915#2346]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

  * igt@kms_fbcon_fbt@fbc-suspend:
    - shard-apl:          [FAIL][41] ([IGT#6] / [i915#4767]) -> [PASS][42]
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-apl1/igt@kms_fbcon_fbt@fbc-suspend.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-apl6/igt@kms_fbcon_fbt@fbc-suspend.html

  * igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
    - shard-glk:          [FAIL][43] ([i915#79]) -> [PASS][44] +1 similar issue
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-glk5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html

  * igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4:
    - {shard-dg1}:        [FAIL][45] ([i915#8151]) -> [PASS][46] +3 similar issues
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-dg1-14/igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4.html
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-dg1-17/igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4.html

  
#### Warnings ####

  * igt@kms_content_protection@mei_interface:
    - shard-glk:          [SKIP][47] ([IGT#6] / [fdo#109271] / [i915#4579]) -> [SKIP][48] ([IGT#6] / [fdo#109271])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13195/shard-glk9/igt@kms_content_protection@mei_interface.html
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/shard-glk8/igt@kms_content_protection@mei_interface.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#6]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/6
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
  [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
  [fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
  [fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
  [fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
  [fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
  [fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
  [fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
  [fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
  [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
  [fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
  [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
  [i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
  [i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
  [i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
  [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
  [i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
  [i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
  [i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
  [i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
  [i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
  [i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
  [i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
  [i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
  [i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
  [i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
  [i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
  [i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
  [i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
  [i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
  [i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
  [i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
  [i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
  [i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
  [i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
  [i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
  [i915#4521]: https://gitlab.freedesktop.org/drm/intel/issues/4521
  [i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
  [i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
  [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
  [i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
  [i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
  [i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
  [i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
  [i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
  [i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
  [i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
  [i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
  [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
  [i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
  [i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
  [i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
  [i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
  [i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
  [i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
  [i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
  [i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
  [i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
  [i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
  [i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
  [i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
  [i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
  [i915#7173]: https://gitlab.freedesktop.org/drm/intel/issues/7173
  [i915#7276]: https://gitlab.freedesktop.org/drm/intel/issues/7276
  [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
  [i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
  [i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
  [i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
  [i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
  [i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
  [i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
  [i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
  [i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
  [i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
  [i915#8304]: https://gitlab.freedesktop.org/drm/intel/issues/8304
  [i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
  [i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7305 -> IGTPW_9045
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_13195: 8de6f7d7e58a51740d5bcaf203d2eb4a94762f5d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9045: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/index.html
  IGT_7305: 09aa9628059a93510b658dcc731ae4c8bd223790 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9045/index.html

[-- Attachment #2: Type: text/html, Size: 15538 bytes --]

Re: [igt-dev] [PATCH i-g-t v2 0/3] Initial tests for the lima drm driver

[Erico Nunes]

Hello,

On Fri, May 26, 2023 at 3:00 PM Erico Nunes <nunes.erico@gmail.com> wrote:
>
> I started working on something for the lima drm driver and realized that
> there is no coverage for it in igt yet. It would be nice to have some to
> check the driver specific ioctls and support that work.
> Here are some to get some basic support and if we can get these in, we
> can follow up with more tests to cover the remaining ioctls.
> I used the panfrost and v3d gem tests as a reference for these initial
> tests.
>
> v2: fixed build after CI failure
>
> Erico Nunes (3):
>   lib: Add support for opening lima devices
>   lib/lima: Add lima helpers
>   tests/lima: Add initial tests for lima
>
>  lib/drmtest.c        |  3 ++
>  lib/drmtest.h        |  1 +
>  lib/igt_lima.c       | 97 ++++++++++++++++++++++++++++++++++++++++++++
>  lib/igt_lima.h       | 26 ++++++++++++
>  lib/meson.build      |  1 +
>  tests/lima_gem_new.c | 78 +++++++++++++++++++++++++++++++++++
>  tests/meson.build    |  1 +
>  7 files changed, 207 insertions(+)
>  create mode 100644 lib/igt_lima.c
>  create mode 100644 lib/igt_lima.h
>  create mode 100644 tests/lima_gem_new.c

Looks like this series got stuck, maybe because there are no owners
for it yet in igt.
Could any of the igt maintainers take a look?

Thanks

Erico

Re: [igt-dev] [PATCH i-g-t v2 0/3] Initial tests for the lima drm driver

[Zbigniew Kempczyński]

On Sun, Jun 04, 2023 at 09:05:56PM +0200, Erico Nunes wrote:
> Hello,
> 
> On Fri, May 26, 2023 at 3:00 PM Erico Nunes <nunes.erico@gmail.com> wrote:
> >
> > I started working on something for the lima drm driver and realized that
> > there is no coverage for it in igt yet. It would be nice to have some to
> > check the driver specific ioctls and support that work.
> > Here are some to get some basic support and if we can get these in, we
> > can follow up with more tests to cover the remaining ioctls.
> > I used the panfrost and v3d gem tests as a reference for these initial
> > tests.
> >
> > v2: fixed build after CI failure
> >
> > Erico Nunes (3):
> >   lib: Add support for opening lima devices
> >   lib/lima: Add lima helpers
> >   tests/lima: Add initial tests for lima
> >
> >  lib/drmtest.c        |  3 ++
> >  lib/drmtest.h        |  1 +
> >  lib/igt_lima.c       | 97 ++++++++++++++++++++++++++++++++++++++++++++
> >  lib/igt_lima.h       | 26 ++++++++++++
> >  lib/meson.build      |  1 +
> >  tests/lima_gem_new.c | 78 +++++++++++++++++++++++++++++++++++
> >  tests/meson.build    |  1 +
> >  7 files changed, 207 insertions(+)
> >  create mode 100644 lib/igt_lima.c
> >  create mode 100644 lib/igt_lima.h
> >  create mode 100644 tests/lima_gem_new.c
> 
> Looks like this series got stuck, maybe because there are no owners
> for it yet in igt.
> Could any of the igt maintainers take a look?
> 
> Thanks
> 
> Erico

Hi.

I'm not the maintainer but sometimes I put my fingers here and there
so I got a question and a nit. Do you have people involved in the
project who contains the hardware and may verify test is working fine?
And definitely they can better review internal aspects of the test.
IGT imo is correct place to put your tests in, only what I would change
is to create additional 'lima/' directory. We treat 'tests/' directory
as common so your specific driver tests should land to separate dir.
lib/igt_lima.* is fine, but lima_gem_new.c should land to 'lima/'.

--
Zbigniew

Re: [igt-dev] [PATCH i-g-t v2 0/3] Initial tests for the lima drm driver

[Erico Nunes]

Hi,

On Mon, Jun 5, 2023 at 11:22 AM Zbigniew Kempczyński
<zbigniew.kempczynski@intel.com> wrote:
> I'm not the maintainer but sometimes I put my fingers here and there
> so I got a question and a nit. Do you have people involved in the
> project who contains the hardware and may verify test is working fine?

I'm one of the project contributors in both mesa and kernel, I should
be able to test/review contributions on what is related to the
specific hardware. Other project contributors are in cc.
As a side note I also noticed that there is hardware enrolled in
kernel-ci which can run the tests. Currently they already run igt, but
run generic igt tests since there have been no hardware specific ones
until now, and we could change it with these new tests.

> And definitely they can better review internal aspects of the test.
> IGT imo is correct place to put your tests in, only what I would change
> is to create additional 'lima/' directory. We treat 'tests/' directory
> as common so your specific driver tests should land to separate dir.
> lib/igt_lima.* is fine, but lima_gem_new.c should land to 'lima/'.

I'm fine with that, I'll change it in the next revision.

Thanks

Erico