From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t V4 01/82] tests/chamelium: Move chamelium helpers to lib
Date: Mon, 29 May 2023 10:57:14 +0530 [thread overview]
Message-ID: <20230529052835.860047-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230529052835.860047-1-bhanuprakash.modem@intel.com>
The correct place for helpers is lib as the tests directory is
supposed to have test files, also having the helpers in tests
dir will break the compilation of testplan. Hence move all
helpers to library.
Expectation is to have an executable binary for each .c file
the "tests" dir.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
.../kms_chamelium_helper.c => lib/igt_chamelium_helper.c | 4 ++--
.../kms_chamelium_helper.h => lib/igt_chamelium_helper.h | 0
lib/meson.build | 1 +
tests/chamelium/kms_chamelium_audio.c | 2 +-
tests/chamelium/kms_chamelium_edid.c | 2 +-
tests/chamelium/kms_chamelium_frames.c | 2 +-
tests/chamelium/kms_chamelium_hpd.c | 2 +-
tests/meson.build | 3 +--
8 files changed, 8 insertions(+), 8 deletions(-)
rename tests/chamelium/kms_chamelium_helper.c => lib/igt_chamelium_helper.c (99%)
rename tests/chamelium/kms_chamelium_helper.h => lib/igt_chamelium_helper.h (100%)
diff --git a/tests/chamelium/kms_chamelium_helper.c b/lib/igt_chamelium_helper.c
similarity index 99%
rename from tests/chamelium/kms_chamelium_helper.c
rename to lib/igt_chamelium_helper.c
index 197d29be9..3c1a802d3 100644
--- a/tests/chamelium/kms_chamelium_helper.c
+++ b/lib/igt_chamelium_helper.c
@@ -25,7 +25,7 @@
*/
#include "igt_edid.h"
-#include "kms_chamelium_helper.h"
+#include "igt_chamelium_helper.h"
void chamelium_init_test(chamelium_data_t *data)
{
@@ -344,4 +344,4 @@ bool chamelium_check_analog_bridge(chamelium_data_t *data,
return true;
return false;
-}
\ No newline at end of file
+}
diff --git a/tests/chamelium/kms_chamelium_helper.h b/lib/igt_chamelium_helper.h
similarity index 100%
rename from tests/chamelium/kms_chamelium_helper.h
rename to lib/igt_chamelium_helper.h
diff --git a/lib/meson.build b/lib/meson.build
index 85f100f75..2d3456577 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -17,6 +17,7 @@ lib_sources = [
'i915/intel_cmds_info.c',
'i915/i915_blt.c',
'i915/i915_crc.c',
+ 'igt_chamelium_helper.c',
'igt_collection.c',
'igt_color_encoding.c',
'igt_crc.c',
diff --git a/tests/chamelium/kms_chamelium_audio.c b/tests/chamelium/kms_chamelium_audio.c
index 6c6177fc5..a4204fbb6 100644
--- a/tests/chamelium/kms_chamelium_audio.c
+++ b/tests/chamelium/kms_chamelium_audio.c
@@ -26,7 +26,7 @@
#include "igt_eld.h"
#include "igt_infoframe.h"
-#include "kms_chamelium_helper.h"
+#include "igt_chamelium_helper.h"
/* Playback parameters control the audio signal we synthesize and send */
#define PLAYBACK_CHANNELS 2
diff --git a/tests/chamelium/kms_chamelium_edid.c b/tests/chamelium/kms_chamelium_edid.c
index 4a52e6922..fc78d4a07 100644
--- a/tests/chamelium/kms_chamelium_edid.c
+++ b/tests/chamelium/kms_chamelium_edid.c
@@ -42,7 +42,7 @@
#include "igt_eld.h"
#include "igt_vc4.h"
#include "igt_infoframe.h"
-#include "kms_chamelium_helper.h"
+#include "igt_chamelium_helper.h"
#include "monitor_edids/dp_edids.h"
#include "monitor_edids/hdmi_edids.h"
#include "monitor_edids/monitor_edids_helper.h"
diff --git a/tests/chamelium/kms_chamelium_frames.c b/tests/chamelium/kms_chamelium_frames.c
index 22a7ba936..2d90b45b2 100644
--- a/tests/chamelium/kms_chamelium_frames.c
+++ b/tests/chamelium/kms_chamelium_frames.c
@@ -31,7 +31,7 @@
#include "igt_eld.h"
#include "igt_infoframe.h"
-#include "kms_chamelium_helper.h"
+#include "igt_chamelium_helper.h"
#define connector_dynamic_subtest(name__, type__) \
igt_subtest_with_dynamic(name__) \
diff --git a/tests/chamelium/kms_chamelium_hpd.c b/tests/chamelium/kms_chamelium_hpd.c
index efd40ba54..ea0ee10e7 100644
--- a/tests/chamelium/kms_chamelium_hpd.c
+++ b/tests/chamelium/kms_chamelium_hpd.c
@@ -29,7 +29,7 @@
* Category: Display
*/
-#include "kms_chamelium_helper.h"
+#include "igt_chamelium_helper.h"
#define HPD_STORM_PULSE_INTERVAL_DP 100 /* ms */
#define HPD_STORM_PULSE_INTERVAL_HDMI 200 /* ms */
diff --git a/tests/meson.build b/tests/meson.build
index f71be1dbe..5d2c573d5 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -343,8 +343,7 @@ endforeach
if chamelium.found()
foreach prog : chamelium_progs
test_executables += executable(prog,
- [join_paths('chamelium', prog + '.c'),
- join_paths('chamelium', 'kms_chamelium_helper.c')],
+ join_paths('chamelium', prog + '.c'),
dependencies : test_deps,
install_dir : libexecdir,
install_rpath : libexecdir_rpathdir,
--
2.40.0
next prev parent reply other threads:[~2023-05-29 5:34 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 5:27 [igt-dev] [i-g-t V4 00/82] Document KMS tests Bhanuprakash Modem
2023-05-29 5:27 ` Bhanuprakash Modem [this message]
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 02/82] tests/dsc: Move dsc helpers to lib Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 03/82] tests/color: Move color " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 04/82] testplan/kms: Include testdisplay to kms testplan config Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 05/82] testplan/kms: Add support to differentiate b/w drivers Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 06/82] tests/chamelium/kms_chamelium_audio: Document each subtest for testplan Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 07/82] tests/chamelium/kms_chamelium_color: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 08/82] tests/chamelium/kms_chamelium_edid: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 09/82] tests/chamelium/kms_chamelium_frames: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 10/82] tests/chamelium/kms_chamelium_hpd: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 11/82] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 12/82] tests/i915/kms_big_joiner: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 13/82] tests/i915/kms_busy: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 14/82] tests/i915/kms_ccs: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 15/82] tests/i915/kms_cdclk: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 16/82] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 17/82] tests/i915/kms_dsc: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 18/82] tests/i915/kms_fb_coherency: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 19/82] tests/i915/kms_fbcon_fbt: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 20/82] tests/i915/kms_fence_pin_leak: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 21/82] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 22/82] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 23/82] tests/i915/kms_frontbuffer_tracking: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 24/82] tests/i915/kms_legacy_colorkey: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 25/82] tests/i915/kms_mmap_write_crc: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 26/82] tests/i915/kms_pipe_b_c_ivb: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 27/82] tests/i915/kms_psr: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 28/82] tests/i915/kms_psr2_sf: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 29/82] tests/i915/kms_psr2_su: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 30/82] tests/i915/kms_psr_stress_test: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 31/82] tests/i915/kms_pwrite_crc: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 32/82] tests/kms_3d: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 33/82] tests/kms_addfb_basic: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 34/82] tests/kms_async_flips: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 35/82] tests/kms_atomic: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 36/82] tests/kms_atomic_interruptible: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 37/82] tests/kms_atomic_transition: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 38/82] tests/kms_bw: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 39/82] tests/kms_color: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 40/82] tests/kms_concurrent: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 41/82] tests/kms_content_protection: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 42/82] tests/kms_cursor_crc: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 43/82] tests/kms_cursor_edge_walk: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 44/82] tests/kms_cursor_legacy: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 45/82] tests/kms_display_modes: " Bhanuprakash Modem
2023-05-29 5:27 ` [igt-dev] [i-g-t V4 46/82] tests/kms_dither: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 47/82] tests/kms_dp_aux_dev: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 48/82] tests/kms_dp_tiled_display: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 49/82] tests/kms_flip: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 50/82] tests/kms_flip_event_leak: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 51/82] tests/kms_force_connector_basic: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 52/82] tests/kms_getfb: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 53/82] tests/kms_hdmi_inject: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 54/82] tests/kms_hdr: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 55/82] tests/kms_invalid_mode: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 56/82] tests/kms_lease: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 57/82] tests/kms_multipipe_modeset: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 58/82] tests/kms_panel_fitting: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 59/82] tests/kms_pipe_crc_basic: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 60/82] tests/kms_plane: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 61/82] tests/kms_plane_alpha_blend: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 62/82] tests/kms_plane_cursor: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 63/82] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 64/82] tests/kms_plane_multiple: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 65/82] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 66/82] tests/kms_prime: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 67/82] tests/kms_prop_blob: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 68/82] tests/kms_properties: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 69/82] tests/kms_rmfb: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 70/82] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 71/82] tests/kms_scaling_modes: " Bhanuprakash Modem
2023-05-30 16:44 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 72/82] tests/kms_selftest: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 73/82] tests/kms_sequence: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 74/82] tests/kms_setmode: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 75/82] tests/kms_sysfs_edid_timing: " Bhanuprakash Modem
2023-05-30 16:40 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 76/82] tests/kms_tv_load_detect: " Bhanuprakash Modem
2023-05-30 16:38 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 77/82] tests/kms_universal_plane: " Bhanuprakash Modem
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 78/82] tests/kms_vblank: " Bhanuprakash Modem
2023-05-30 16:10 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 79/82] tests/kms_vrr: " Bhanuprakash Modem
2023-05-30 15:17 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 80/82] tests/kms_writeback: " Bhanuprakash Modem
2023-05-30 15:06 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 81/82] tests/testdisplay: " Bhanuprakash Modem
2023-05-30 15:11 ` Sharma, Swati2
2023-05-29 5:28 ` [igt-dev] [i-g-t V4 82/82] testplan/kms: Make documentation is mandatory for all kms subtests Bhanuprakash Modem
2023-05-29 6:08 ` [igt-dev] ✗ GitLab.Pipeline: warning for Document KMS tests (rev11) Patchwork
2023-05-29 6:38 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-05-29 8:07 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-05-30 15:00 ` [igt-dev] [i-g-t V4 00/82] Document KMS tests Sharma, Swati2
2023-05-31 6:52 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230529052835.860047-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox