Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] lib/intel_batchbuffer: Use COMPUTE instead RENDER engine for Xe on PVC
Date: Mon, 29 May 2023 18:54:17 +0200	[thread overview]
Message-ID: <20230529165417.347129-3-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20230529165417.347129-1-zbigniew.kempczynski@intel.com>

For gpgpu fill currently we select I915_EXEC_RENDER which is correct
as pipeline selection allows to submit compute job on it. However
newer platforms like PVC have no render engine so replacing to compute
engine is necessary. At the moment this is workaround - more rework
in intel-bb is necessary to better support both - i915 and xe.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
 lib/intel_batchbuffer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index 9f65536173..71f62973c8 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -2315,7 +2315,10 @@ __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
 			inst.engine_class = DRM_XE_ENGINE_CLASS_VIDEO_DECODE;
 			break;
 		case I915_EXEC_RENDER:
-			inst.engine_class = DRM_XE_ENGINE_CLASS_RENDER;
+			if (IS_PONTEVECCHIO(xe_dev_id(ibb->fd)))
+				inst.engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
+			else
+				inst.engine_class = DRM_XE_ENGINE_CLASS_RENDER;
 			break;
 		case I915_EXEC_VEBOX:
 			inst.engine_class = DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE;
-- 
2.34.1

  parent reply	other threads:[~2023-05-29 16:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-29 16:54 [igt-dev] [PATCH i-g-t 0/2] Add PVC support for gpgpu fill Zbigniew Kempczyński
2023-05-29 16:54 ` [igt-dev] [PATCH i-g-t 1/2] lib/gpgpu_fill/xehpc: Adjust gpgpu_fillfunc for PVC Zbigniew Kempczyński
2023-05-30 14:53   ` Manszewski, Christoph
2023-05-30 16:49     ` Zbigniew Kempczyński
2023-05-29 16:54 ` Zbigniew Kempczyński [this message]
2023-05-30  7:13   ` [igt-dev] [PATCH i-g-t 2/2] lib/intel_batchbuffer: Use COMPUTE instead RENDER engine for Xe on PVC Manszewski, Christoph
2023-05-30 12:25     ` Zbigniew Kempczyński
2023-05-30 14:50       ` Manszewski, Christoph
2023-05-30 16:50         ` Zbigniew Kempczyński
2023-05-30 15:29 ` [igt-dev] ✓ Fi.CI.BAT: success for Add PVC support for gpgpu fill Patchwork
2023-05-31  9:54 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230529165417.347129-3-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox