* [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check
@ 2023-05-31 7:45 Swati Sharma
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Swati Sharma @ 2023-05-31 7:45 UTC (permalink / raw)
To: igt-dev
New test case added for nv12 crc sanity check.
Swati Sharma (3):
lib/igt_fb: round rgb->yuv conversion results
tests/kms_pipe_crc_basic: add nv12 crc sanity check
intel-ci: update fastfeedback testlist
lib/igt_fb.c | 25 +++++++-----
tests/intel-ci/fast-feedback.testlist | 3 +-
tests/intel-ci/xe-fast-feedback.testlist | 3 +-
tests/kms_pipe_crc_basic.c | 50 +++++++++++++++++-------
4 files changed, 54 insertions(+), 27 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
@ 2023-05-31 7:45 ` Swati Sharma
2023-06-02 11:57 ` Juha-Pekka Heikkila
2023-06-05 15:12 ` Kamil Konieczny
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/kms_pipe_crc_basic: add nv12 crc sanity check Swati Sharma
` (4 subsequent siblings)
5 siblings, 2 replies; 12+ messages in thread
From: Swati Sharma @ 2023-05-31 7:45 UTC (permalink / raw)
To: igt-dev
Round rgb->yuv conversion results.
Signed-off-by: Ville Syrjala <ville.syrjala@linux.intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
lib/igt_fb.c | 25 +++++++++++++++----------
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 71a199d4..11a5d6c0 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -3064,11 +3064,16 @@ static void igt_fb_destroy_cairo_shadow_buffer(struct igt_fb *shadow,
munmap(ptr, shadow->size);
}
-static uint8_t clamprgb(float val)
+static uint8_t clamp8(float val)
{
return clamp((int)(val + 0.5f), 0, 255);
}
+static uint8_t clamp16(float val)
+{
+ return clamp((int)(val + 0.5f), 0, 65535);
+}
+
static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
{
rgb->d[0] = rgb24[2];
@@ -3079,9 +3084,9 @@ static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
static void write_rgb(uint8_t *rgb24, const struct igt_vec4 *rgb)
{
- rgb24[2] = clamprgb(rgb->d[0]);
- rgb24[1] = clamprgb(rgb->d[1]);
- rgb24[0] = clamprgb(rgb->d[2]);
+ rgb24[2] = clamp8(rgb->d[0]);
+ rgb24[1] = clamp8(rgb->d[1]);
+ rgb24[0] = clamp8(rgb->d[2]);
}
struct fb_convert_buf {
@@ -3401,7 +3406,7 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
rgb_tmp += bpp;
- *y_tmp = yuv.d[0];
+ *y_tmp = clamp8(yuv.d[0]);
y_tmp += params.ay_inc;
if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
@@ -3431,8 +3436,8 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
read_rgb(&pair_rgb, pair_rgb24);
pair_yuv = igt_matrix_transform(&m, &pair_rgb);
- *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
- *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
+ *u_tmp = clamp8((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
+ *v_tmp = clamp8((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
u_tmp += params.uv_inc;
v_tmp += params.uv_inc;
@@ -3590,7 +3595,7 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
rgb_tmp += fpp;
- *y_tmp = yuv.d[0];
+ *y_tmp = clamp16(yuv.d[0]);
y_tmp += params.ay_inc;
if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
@@ -3620,8 +3625,8 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
read_rgbf(&pair_rgb, pair_float);
pair_yuv = igt_matrix_transform(&m, &pair_rgb);
- *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
- *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
+ *u_tmp = clamp16((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
+ *v_tmp = clamp16((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
u_tmp += params.uv_inc;
v_tmp += params.uv_inc;
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t v3 2/3] tests/kms_pipe_crc_basic: add nv12 crc sanity check
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
@ 2023-05-31 7:45 ` Swati Sharma
2023-06-02 11:57 ` Juha-Pekka Heikkila
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v2 3/3] intel-ci: update fastfeedback testlist Swati Sharma
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Swati Sharma @ 2023-05-31 7:45 UTC (permalink / raw)
To: igt-dev
New CRC sanitycheck test case is added with NV12 format.
kms_plane@pixel-format test is validating all formats.
To improve BAT coverage we can have one planar format crc
sanity test.
v2: -improved documentation (Bhanu)
v3: -added check to skip format if not supported (CI)
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_pipe_crc_basic.c | 50 ++++++++++++++++++++++++++------------
1 file changed, 35 insertions(+), 15 deletions(-)
diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
index 84c73fd7..9ce9f5e5 100644
--- a/tests/kms_pipe_crc_basic.c
+++ b/tests/kms_pipe_crc_basic.c
@@ -227,25 +227,31 @@ static void test_read_crc(data_t *data, enum pipe pipe,
}
/**
- * SUBTEST: compare-crc-sanitycheck
- * Description: Basic sanity check for CRC mismatches
+ * SUBTEST: compare-crc-sanitycheck-%s
+ * Description: Basic sanity check for CRC mismatches with %arg[1]
* Test category: functionality test
* Run type: BAT
* Functionality: crc
* Mega feature: General Display Features
+ *
+ * arg[1]:
+ *
+ * @xr24: XR24 format
+ * @nv12: NV12 format
*/
/*
* CRC-sanity test, to make sure there would be no CRC mismatches
*
- * - Create two framebuffers (FB0 & FB1) with same color info
- * - Flip FB0 with the Primary plane & collect the CRC as ref CRC.
- * - Flip FB1 with the Primary plane, collect the CRC & compare with
+ * - Create two framebuffers (FB0 & FB1).
+ * - Flip FB0 with the primary plane & collect the CRC as ref CRC.
+ * - Flip FB1 with the primary plane, collect the CRC & compare with
* the ref CRC.
*
* No CRC mismatch should happen
*/
-static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
+static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output,
+ uint32_t plane_format)
{
igt_display_t *display = &data->display;
igt_plane_t *primary;
@@ -259,7 +265,9 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
mode = igt_output_get_mode(output);
- /* Create two framebuffers with the same color info. */
+ primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_skip_on(!igt_plane_has_format_mod(primary, plane_format, DRM_FORMAT_MOD_LINEAR));
+
igt_create_color_fb(data->drm_fd,
mode->hdisplay, mode->vdisplay,
DRM_FORMAT_XRGB8888,
@@ -267,14 +275,12 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
1.0, 1.0, 1.0,
&fb0);
igt_create_color_fb(data->drm_fd,
- mode->hdisplay, mode->vdisplay,
- DRM_FORMAT_XRGB8888,
+ mode->hdisplay, mode->vdisplay, plane_format,
DRM_FORMAT_MOD_LINEAR,
1.0, 1.0, 1.0,
&fb1);
- /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */
- primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ /* Flip FB0 with the primary plane & collect the CRC as ref CRC. */
igt_plane_set_fb(primary, &fb0);
igt_display_commit(display);
@@ -282,7 +288,7 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
IGT_PIPE_CRC_SOURCE_AUTO);
igt_pipe_crc_collect_crc(pipe_crc, &ref_crc);
- /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */
+ /* Flip FB1 with the primary plane & compare the CRC with ref CRC. */
igt_plane_set_fb(primary, &fb1);
igt_display_commit(display);
@@ -475,8 +481,22 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
}
- igt_describe("Basic sanity check for CRC mismatches");
- igt_subtest_with_dynamic("compare-crc-sanitycheck") {
+ igt_describe("Basic sanity check for CRC mismatches with XR24 format");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-xr24") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ if (simulation_constraint(pipe))
+ continue;
+
+ if(!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
+ test_compare_crc(&data, pipe, output, DRM_FORMAT_XRGB8888);
+ }
+ }
+
+ igt_describe("Basic sanity check for CRC mismatches with NV12 format");
+ igt_subtest_with_dynamic("compare-crc-sanitycheck-nv12") {
for_each_pipe_with_single_output(&data.display, pipe, output) {
if (simulation_constraint(pipe))
continue;
@@ -485,7 +505,7 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
continue;
igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
- test_compare_crc(&data, pipe, output);
+ test_compare_crc(&data, pipe, output, DRM_FORMAT_NV12);
}
}
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t v2 3/3] intel-ci: update fastfeedback testlist
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/kms_pipe_crc_basic: add nv12 crc sanity check Swati Sharma
@ 2023-05-31 7:45 ` Swati Sharma
2023-06-02 11:58 ` Juha-Pekka Heikkila
2023-05-31 7:57 ` [igt-dev] ✗ GitLab.Pipeline: warning for nv12 crc sanity check Patchwork
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Swati Sharma @ 2023-05-31 7:45 UTC (permalink / raw)
To: igt-dev
Update fastfeedback testlist.
v2: -fixed typo, renamed xrg888 to xr24 (Bhanu)
-updated xe fastfeedback testlist too (Bhanu)
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/intel-ci/fast-feedback.testlist | 3 ++-
tests/intel-ci/xe-fast-feedback.testlist | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
index cfe7cb4a..31639c89 100644
--- a/tests/intel-ci/fast-feedback.testlist
+++ b/tests/intel-ci/fast-feedback.testlist
@@ -118,7 +118,8 @@ igt@kms_force_connector_basic@force-edid
igt@kms_force_connector_basic@force-load-detect
igt@kms_force_connector_basic@prune-stale-modes
igt@kms_frontbuffer_tracking@basic
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12
igt@kms_pipe_crc_basic@hang-read-crc
igt@kms_pipe_crc_basic@nonblocking-crc
igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 7242c8d8..bdd12e57 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -259,7 +259,8 @@ igt@kms_flip@basic-plain-flip
igt@kms_force_connector_basic@force-connector-state
igt@kms_force_connector_basic@force-edid
igt@kms_force_connector_basic@prune-stale-modes
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12
igt@kms_pipe_crc_basic@hang-read-crc
igt@kms_pipe_crc_basic@nonblocking-crc
igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
--
2.25.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for nv12 crc sanity check
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
` (2 preceding siblings ...)
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v2 3/3] intel-ci: update fastfeedback testlist Swati Sharma
@ 2023-05-31 7:57 ` Patchwork
2023-05-31 8:24 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-06-01 15:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-31 7:57 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
== Series Details ==
Series: nv12 crc sanity check
URL : https://patchwork.freedesktop.org/series/118633/
State : warning
== Summary ==
Pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/895230 for the overview.
build-containers:build-debian-arm64 has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/42760813):
time="2023-05-31T07:54:55Z" level=fatal msg="Error reading manifest dockerfile-f370b1c77e386827453db413b775a4c9bff41794 in registry.freedesktop.org/gfx-ci/igt-ci-tags/build-debian-arm64: received unexpected HTTP status: 500 Internal Server Error"
Building!
STEP 1: FROM debian:buster
Getting image source signatures
Copying blob sha256:c722db24a050621ee87ea07acd5d066d3d6a94737c32012f27d73a1ad5cc645c
Copying config sha256:8b5601a5a7f855241ac7f372ec0042e793b0b3eb3f3a601014845f22bd371c90
Writing manifest to image destination
Storing signatures
STEP 2: RUN apt-get update
error running container: error creating container for [/bin/sh -c apt-get update]: time="2023-05-31T07:55:00Z" level=warning msg="signal: killed"
time="2023-05-31T07:55:00Z" level=error msg="container_linux.go:346: starting container process caused \"process_linux.go:297: applying cgroup configuration for process caused \\\"mountpoint for cgroup not found\\\"\"\n"
container_linux.go:346: starting container process caused "process_linux.go:297: applying cgroup configuration for process caused \"mountpoint for cgroup not found\""
: exit status 1
Error: error building at STEP "RUN apt-get update": error while running runtime: exit status 1
section_end:1685519702:step_script
section_start:1685519702:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1685519706:cleanup_file_variables
ERROR: Job failed: exit code 1
build-containers:build-debian-armhf has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/42760812):
],
"Created": "2019-11-20T12:54:52.073706506Z",
"DockerVersion": "",
"Labels": {},
"Architecture": "amd64",
"Os": "linux",
"Layers": [
"sha256:45252bb38c9c74dfe76c4b3808269db61d3b2aebe5e26bf7fcd85e48b93e16f9"
]
}
Skipping, already built
Getting image source signatures
Copying blob sha256:45252bb38c9c74dfe76c4b3808269db61d3b2aebe5e26bf7fcd85e48b93e16f9
time="2023-05-31T07:54:59Z" level=fatal msg="Error reading config blob sha256:4a4103f1a476d355d866b481ff96ac05a32a3a715cefcc1cbc1356a8959fb5f8: Invalid status code returned when fetching blob 500 (Internal Server Error)"
section_end:1685519701:step_script
section_start:1685519701:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1685519701:cleanup_file_variables
ERROR: Job failed: exit code 1
build-containers:build-debian-mips has failed (https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/jobs/42760814):
time="2023-05-31T07:54:55Z" level=fatal msg="Error determining repository tags: Invalid status code returned when fetching tags list 500 (Internal Server Error)"
Building!
STEP 1: FROM debian:buster
Getting image source signatures
Copying blob sha256:c722db24a050621ee87ea07acd5d066d3d6a94737c32012f27d73a1ad5cc645c
Copying config sha256:8b5601a5a7f855241ac7f372ec0042e793b0b3eb3f3a601014845f22bd371c90
Writing manifest to image destination
Storing signatures
STEP 2: RUN apt-get update
error running container: error creating container for [/bin/sh -c apt-get update]: time="2023-05-31T07:55:00Z" level=warning msg="signal: killed"
time="2023-05-31T07:55:00Z" level=error msg="container_linux.go:346: starting container process caused \"process_linux.go:297: applying cgroup configuration for process caused \\\"mountpoint for cgroup not found\\\"\"\n"
container_linux.go:346: starting container process caused "process_linux.go:297: applying cgroup configuration for process caused \"mountpoint for cgroup not found\""
: exit status 1
Error: error building at STEP "RUN apt-get update": error while running runtime: exit status 1
section_end:1685519701:step_script
section_start:1685519701:cleanup_file_variables
Cleaning up project directory and file based variables
section_end:1685519702:cleanup_file_variables
ERROR: Job failed: exit code 1
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/-/pipelines/895230
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for nv12 crc sanity check
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
` (3 preceding siblings ...)
2023-05-31 7:57 ` [igt-dev] ✗ GitLab.Pipeline: warning for nv12 crc sanity check Patchwork
@ 2023-05-31 8:24 ` Patchwork
2023-06-01 15:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-05-31 8:24 UTC (permalink / raw)
To: Sharma, Swati2; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 19021 bytes --]
== Series Details ==
Series: nv12 crc sanity check
URL : https://patchwork.freedesktop.org/series/118633/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13204 -> IGTPW_9077
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/index.html
Participating hosts (36 -> 35)
------------------------------
Missing (1): bat-adlp-11
New tests
---------
New tests have been introduced between CI_DRM_13204 and IGTPW_9077:
### New IGT tests (58) ###
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- Statuses : 10 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-dp-1:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-dp-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-edp-1:
- Statuses : 6 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-2:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-1:
- Statuses : 3 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-2:
- Statuses : 1 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-edp-1:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-1:
- Statuses : 4 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-2:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-vga-1:
- Statuses : 2 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-1:
- Statuses : 2 pass(s) 3 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-edp-1:
- Statuses : 5 pass(s) 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-1:
- Statuses : 2 pass(s) 2 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2:
- Statuses : 2 pass(s) 2 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-vga-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-dp-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-dp-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-edp-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- Statuses : 10 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-dp-1:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-dp-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-edp-1:
- Statuses : 7 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-hdmi-a-1:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-hdmi-a-2:
- Statuses : 3 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-vga-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-dp-1:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-dp-2:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-dp-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-edp-1:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-hdmi-a-1:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-hdmi-a-2:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-vga-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-dp-1:
- Statuses : 5 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-dp-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-edp-1:
- Statuses : 6 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-hdmi-a-1:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-hdmi-a-2:
- Statuses : 4 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-vga-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-dp-3:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-edp-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-hdmi-a-3:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9077 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][1] ([i915#7077])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770: [PASS][2] -> [SKIP][3] ([fdo#109271])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-hsw-4770: [PASS][4] -> [FAIL][5] ([i915#7364])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][6] -> [DMESG-FAIL][7] ([i915#4258] / [i915#7913])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@mman:
- bat-rpls-2: [PASS][8] -> [TIMEOUT][9] ([i915#6794] / [i915#7392])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/bat-rpls-2/igt@i915_selftest@live@mman.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rpls-2/igt@i915_selftest@live@mman.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][10] -> [ABORT][11] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/bat-rpls-1/igt@i915_selftest@live@reset.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12 (NEW):
- bat-rpls-2: NOTRUN -> [SKIP][12] ([i915#1845]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rpls-2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html
- fi-bsw-nick: NOTRUN -> [SKIP][13] ([fdo#109271]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-bsw-nick/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html
- {bat-kbl-2}: NOTRUN -> [SKIP][14] ([fdo#109271]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-kbl-2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html
- fi-kbl-x1275: NOTRUN -> [SKIP][15] ([fdo#109271]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-kbl-x1275/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html
- bat-rpls-1: NOTRUN -> [SKIP][16] ([i915#1845]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rpls-1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1 (NEW):
- fi-elk-e7500: NOTRUN -> [SKIP][17] ([fdo#109271])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-2 (NEW):
- fi-skl-guc: NOTRUN -> [SKIP][18] ([fdo#109271]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-2.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1 (NEW):
- fi-hsw-4770: NOTRUN -> [SKIP][19] ([fdo#109271]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html
- fi-blb-e6850: NOTRUN -> [SKIP][20] ([fdo#109271])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-blb-e6850/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-1} (NEW):
- fi-apl-guc: NOTRUN -> [SKIP][21] ([fdo#109271]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-apl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-edp-1} (NEW):
- fi-skl-6600u: NOTRUN -> [SKIP][22] ([fdo#109271]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-edp-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-1} (NEW):
- fi-elk-e7500: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4579])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-elk-e7500/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-vga-1} (NEW):
- fi-blb-e6850: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-blb-e6850/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-vga-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-1} (NEW):
- fi-apl-guc: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4579])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-apl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-1.html
- fi-cfl-8109u: NOTRUN -> [SKIP][26] ([fdo#109271])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-1.html
- fi-kbl-7567u: NOTRUN -> [SKIP][27] ([fdo#109271])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-kbl-7567u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-edp-1} (NEW):
- fi-skl-6600u: NOTRUN -> [SKIP][28] ([fdo#109271] / [i915#4579])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-edp-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-1} (NEW):
- fi-cfl-guc: NOTRUN -> [SKIP][29] ([fdo#109271])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-cfl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-1.html
- fi-cfl-8700k: NOTRUN -> [SKIP][30] ([fdo#109271])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-cfl-8700k/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-1.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2 (NEW):
- fi-bsw-n3050: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#4579])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-bsw-n3050/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2.html
- fi-skl-guc: NOTRUN -> [SKIP][32] ([fdo#109271] / [i915#4579])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-2.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-vga-1} (NEW):
- fi-hsw-4770: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#4579])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-vga-1.html
* {igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24} (NEW):
- bat-adls-5: NOTRUN -> [SKIP][34] ([i915#1845]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-adls-5/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
- bat-dg1-7: NOTRUN -> [SKIP][35] ([i915#1845]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-dg1-7/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
- fi-kbl-8809g: NOTRUN -> [SKIP][36] ([fdo#109271]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
- fi-kbl-guc: NOTRUN -> [SKIP][37] ([fdo#109271]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/fi-kbl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
- bat-adlm-1: NOTRUN -> [SKIP][38] ([i915#1845]) +1 similar issue
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-adlm-1/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][39] ([i915#4579] / [i915#8260]) -> [SKIP][40] ([i915#3555] / [i915#4579])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6794]: https://gitlab.freedesktop.org/drm/intel/issues/6794
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7364]: https://gitlab.freedesktop.org/drm/intel/issues/7364
[i915#7392]: https://gitlab.freedesktop.org/drm/intel/issues/7392
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7311 -> IGTPW_9077
CI-20190529: 20190529
CI_DRM_13204: 83a048e62ecf7838b583389e60c1defa530a5668 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9077: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/index.html
IGT_7311: c031030f39aff973330668a5a2f1593408da78ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12
+igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24
-igt@kms_pipe_crc_basic@compare-crc-sanitycheck
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/index.html
[-- Attachment #2: Type: text/html, Size: 24350 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for nv12 crc sanity check
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
` (4 preceding siblings ...)
2023-05-31 8:24 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2023-06-01 15:13 ` Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-06-01 15:13 UTC (permalink / raw)
To: Swati Sharma; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 24468 bytes --]
== Series Details ==
Series: nv12 crc sanity check
URL : https://patchwork.freedesktop.org/series/118633/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13204_full -> IGTPW_9077_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9077_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_mmap_offset@clear@smem0:
- {shard-dg1}: NOTRUN -> [DMESG-FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-dg1-14/igt@gem_mmap_offset@clear@smem0.html
* igt@kms_plane@pixel-format@pipe-b-planes:
- {shard-dg1}: [PASS][2] -> [FAIL][3] +3 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-dg1-12/igt@kms_plane@pixel-format@pipe-b-planes.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-dg1-17/igt@kms_plane@pixel-format@pipe-b-planes.html
New tests
---------
New tests have been introduced between CI_DRM_13204_full and IGTPW_9077_full:
### New IGT tests (40) ###
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12:
- Statuses :
- Exec time: [None] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-dp-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-dp-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-2:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-b-vga-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-dp-1:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-c-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-d-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24:
- Statuses :
- Exec time: [None] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-dp-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-hdmi-a-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-a-vga-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-dp-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-hdmi-a-2:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-b-vga-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-dp-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-hdmi-a-1:
- Statuses : 2 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-c-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-hdmi-a-1:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24@pipe-d-hdmi-a-4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-c-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-a-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-b-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-c-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-3:
- Statuses : 1 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9077_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_close_race@multigpu-basic-process:
- shard-apl: NOTRUN -> [SKIP][4] ([fdo#109271]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-apl7/igt@gem_close_race@multigpu-basic-process.html
* igt@gem_exec_fair@basic-deadline:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2846])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-glk8/igt@gem_exec_fair@basic-deadline.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk6/igt@gem_exec_fair@basic-deadline.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][7] -> [FAIL][8] ([i915#2842]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-glk6/igt@gem_exec_fair@basic-pace@vcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk2/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@i915_module_load@load:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#6227])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk1/igt@i915_module_load@load.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][10] -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][12] -> [ABORT][13] ([i915#180])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-apl7/igt@kms_fbcon_fbt@fbc-suspend.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-apl3/igt@kms_fbcon_fbt@fbc-suspend.html
* igt@kms_hdmi_inject@inject-audio:
- shard-glk: [PASS][14] -> [SKIP][15] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-glk1/igt@kms_hdmi_inject@inject-audio.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk3/igt@kms_hdmi_inject@inject-audio.html
* igt@kms_plane@pixel-format-source-clamping@pipe-b-planes:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#1623]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-glk7/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk1/igt@kms_plane@pixel-format-source-clamping@pipe-b-planes.html
* igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-c-dp-1:
- shard-apl: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4579]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-apl1/igt@kms_plane_scaling@plane-downscale-with-pixel-format-factor-0-25@pipe-c-dp-1.html
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][19] ([fdo#109271]) +16 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-snb2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-rotation@pipe-a-vga-1.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3 (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][20] ([i915#5235]) +5 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-dg1-13/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-b-hdmi-a-3.html
* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-b-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4579]) +11 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-snb1/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-3 (NEW):
- {shard-dg1}: NOTRUN -> [SKIP][22] ([i915#4579] / [i915#5235]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-dg1-13/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-25@pipe-d-hdmi-a-3.html
* igt@kms_selftest@all-tests:
- shard-glk: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#4579]) +1 similar issue
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk3/igt@kms_selftest@all-tests.html
* igt@vc4/vc4_wait_bo@used-bo-0ns:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271]) +4 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk9/igt@vc4/vc4_wait_bo@used-bo-0ns.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][25] ([i915#7742]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-rkl-2/igt@drm_fdinfo@virtual-idle.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-rkl-3/igt@drm_fdinfo@virtual-idle.html
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-tglu}: [FAIL][27] ([i915#6268]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-tglu-10/igt@gem_ctx_exec@basic-nohangcheck.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-tglu-9/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_eio@hibernate:
- {shard-tglu}: [ABORT][29] ([i915#7975] / [i915#8213] / [i915#8398]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-tglu-10/igt@gem_eio@hibernate.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-tglu-8/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-tglu}: [FAIL][31] ([i915#2842]) -> [PASS][32] +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-tglu-6/igt@gem_exec_fair@basic-none-share@rcs0.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-tglu-7/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][33] ([i915#2842]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-rkl-6/igt@gem_exec_fair@basic-pace@rcs0.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-rkl-2/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@gem_userptr_blits@huge-split:
- shard-apl: [FAIL][35] ([i915#3318]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-apl3/igt@gem_userptr_blits@huge-split.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-apl1/igt@gem_userptr_blits@huge-split.html
* igt@gen9_exec_parse@allowed-single:
- shard-apl: [ABORT][37] ([i915#5566]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-apl6/igt@gen9_exec_parse@allowed-single.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-apl7/igt@gen9_exec_parse@allowed-single.html
* igt@i915_pm_rpm@dpms-mode-unset-non-lpsp:
- {shard-rkl}: [SKIP][39] ([i915#1397]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-rkl-3/igt@i915_pm_rpm@dpms-mode-unset-non-lpsp.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-dg1}: [SKIP][41] ([i915#1397]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-dg1-17/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-dg1-19/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- {shard-rkl}: [FAIL][43] ([i915#3743]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-rkl-7/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-rkl-1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-glk: [FAIL][45] ([i915#2346]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip_tiling@flip-change-tiling@hdmi-a-1-pipe-c-y-to-y:
- shard-glk: [INCOMPLETE][47] -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-glk7/igt@kms_flip_tiling@flip-change-tiling@hdmi-a-1-pipe-c-y-to-y.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-glk6/igt@kms_flip_tiling@flip-change-tiling@hdmi-a-1-pipe-c-y-to-y.html
* igt@kms_rotation_crc@multiplane-rotation:
- {shard-rkl}: [ABORT][49] ([i915#8311]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-rkl-4/igt@kms_rotation_crc@multiplane-rotation.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-rkl-3/igt@kms_rotation_crc@multiplane-rotation.html
#### Warnings ####
* igt@kms_hdmi_inject@inject-audio:
- shard-snb: [FAIL][51] ([IGT#3]) -> [SKIP][52] ([fdo#109271])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13204/shard-snb6/igt@kms_hdmi_inject@inject-audio.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/shard-snb6/igt@kms_hdmi_inject@inject-audio.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1623]: https://gitlab.freedesktop.org/drm/intel/issues/1623
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2846]: https://gitlab.freedesktop.org/drm/intel/issues/2846
[i915#2876]: https://gitlab.freedesktop.org/drm/intel/issues/2876
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4275]: https://gitlab.freedesktop.org/drm/intel/issues/4275
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6806]: https://gitlab.freedesktop.org/drm/intel/issues/6806
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7951]: https://gitlab.freedesktop.org/drm/intel/issues/7951
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311
[i915#8398]: https://gitlab.freedesktop.org/drm/intel/issues/8398
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7311 -> IGTPW_9077
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13204: 83a048e62ecf7838b583389e60c1defa530a5668 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9077: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/index.html
IGT_7311: c031030f39aff973330668a5a2f1593408da78ae @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9077/index.html
[-- Attachment #2: Type: text/html, Size: 22173 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
@ 2023-06-02 11:57 ` Juha-Pekka Heikkila
2023-06-05 15:12 ` Kamil Konieczny
1 sibling, 0 replies; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2023-06-02 11:57 UTC (permalink / raw)
To: Swati Sharma, igt-dev
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 31.5.2023 10.45, Swati Sharma wrote:
> Round rgb->yuv conversion results.
>
> Signed-off-by: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> lib/igt_fb.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 71a199d4..11a5d6c0 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -3064,11 +3064,16 @@ static void igt_fb_destroy_cairo_shadow_buffer(struct igt_fb *shadow,
> munmap(ptr, shadow->size);
> }
>
> -static uint8_t clamprgb(float val)
> +static uint8_t clamp8(float val)
> {
> return clamp((int)(val + 0.5f), 0, 255);
> }
>
> +static uint8_t clamp16(float val)
> +{
> + return clamp((int)(val + 0.5f), 0, 65535);
> +}
> +
> static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
> {
> rgb->d[0] = rgb24[2];
> @@ -3079,9 +3084,9 @@ static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
>
> static void write_rgb(uint8_t *rgb24, const struct igt_vec4 *rgb)
> {
> - rgb24[2] = clamprgb(rgb->d[0]);
> - rgb24[1] = clamprgb(rgb->d[1]);
> - rgb24[0] = clamprgb(rgb->d[2]);
> + rgb24[2] = clamp8(rgb->d[0]);
> + rgb24[1] = clamp8(rgb->d[1]);
> + rgb24[0] = clamp8(rgb->d[2]);
> }
>
> struct fb_convert_buf {
> @@ -3401,7 +3406,7 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
>
> rgb_tmp += bpp;
>
> - *y_tmp = yuv.d[0];
> + *y_tmp = clamp8(yuv.d[0]);
> y_tmp += params.ay_inc;
>
> if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
> @@ -3431,8 +3436,8 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
> read_rgb(&pair_rgb, pair_rgb24);
> pair_yuv = igt_matrix_transform(&m, &pair_rgb);
>
> - *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
> - *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
> + *u_tmp = clamp8((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
> + *v_tmp = clamp8((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
>
> u_tmp += params.uv_inc;
> v_tmp += params.uv_inc;
> @@ -3590,7 +3595,7 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
>
> rgb_tmp += fpp;
>
> - *y_tmp = yuv.d[0];
> + *y_tmp = clamp16(yuv.d[0]);
> y_tmp += params.ay_inc;
>
> if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
> @@ -3620,8 +3625,8 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
> read_rgbf(&pair_rgb, pair_float);
> pair_yuv = igt_matrix_transform(&m, &pair_rgb);
>
> - *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
> - *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
> + *u_tmp = clamp16((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
> + *v_tmp = clamp16((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
>
> u_tmp += params.uv_inc;
> v_tmp += params.uv_inc;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v3 2/3] tests/kms_pipe_crc_basic: add nv12 crc sanity check
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/kms_pipe_crc_basic: add nv12 crc sanity check Swati Sharma
@ 2023-06-02 11:57 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2023-06-02 11:57 UTC (permalink / raw)
To: Swati Sharma, igt-dev
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 31.5.2023 10.45, Swati Sharma wrote:
> New CRC sanitycheck test case is added with NV12 format.
> kms_plane@pixel-format test is validating all formats.
> To improve BAT coverage we can have one planar format crc
> sanity test.
>
> v2: -improved documentation (Bhanu)
> v3: -added check to skip format if not supported (CI)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_pipe_crc_basic.c | 50 ++++++++++++++++++++++++++------------
> 1 file changed, 35 insertions(+), 15 deletions(-)
>
> diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c
> index 84c73fd7..9ce9f5e5 100644
> --- a/tests/kms_pipe_crc_basic.c
> +++ b/tests/kms_pipe_crc_basic.c
> @@ -227,25 +227,31 @@ static void test_read_crc(data_t *data, enum pipe pipe,
> }
>
> /**
> - * SUBTEST: compare-crc-sanitycheck
> - * Description: Basic sanity check for CRC mismatches
> + * SUBTEST: compare-crc-sanitycheck-%s
> + * Description: Basic sanity check for CRC mismatches with %arg[1]
> * Test category: functionality test
> * Run type: BAT
> * Functionality: crc
> * Mega feature: General Display Features
> + *
> + * arg[1]:
> + *
> + * @xr24: XR24 format
> + * @nv12: NV12 format
> */
>
> /*
> * CRC-sanity test, to make sure there would be no CRC mismatches
> *
> - * - Create two framebuffers (FB0 & FB1) with same color info
> - * - Flip FB0 with the Primary plane & collect the CRC as ref CRC.
> - * - Flip FB1 with the Primary plane, collect the CRC & compare with
> + * - Create two framebuffers (FB0 & FB1).
> + * - Flip FB0 with the primary plane & collect the CRC as ref CRC.
> + * - Flip FB1 with the primary plane, collect the CRC & compare with
> * the ref CRC.
> *
> * No CRC mismatch should happen
> */
> -static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
> +static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output,
> + uint32_t plane_format)
> {
> igt_display_t *display = &data->display;
> igt_plane_t *primary;
> @@ -259,7 +265,9 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
>
> mode = igt_output_get_mode(output);
>
> - /* Create two framebuffers with the same color info. */
> + primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + igt_skip_on(!igt_plane_has_format_mod(primary, plane_format, DRM_FORMAT_MOD_LINEAR));
> +
> igt_create_color_fb(data->drm_fd,
> mode->hdisplay, mode->vdisplay,
> DRM_FORMAT_XRGB8888,
> @@ -267,14 +275,12 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
> 1.0, 1.0, 1.0,
> &fb0);
> igt_create_color_fb(data->drm_fd,
> - mode->hdisplay, mode->vdisplay,
> - DRM_FORMAT_XRGB8888,
> + mode->hdisplay, mode->vdisplay, plane_format,
> DRM_FORMAT_MOD_LINEAR,
> 1.0, 1.0, 1.0,
> &fb1);
>
> - /* Flip FB0 with the Primary plane & collect the CRC as ref CRC. */
> - primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
> + /* Flip FB0 with the primary plane & collect the CRC as ref CRC. */
> igt_plane_set_fb(primary, &fb0);
> igt_display_commit(display);
>
> @@ -282,7 +288,7 @@ static void test_compare_crc(data_t *data, enum pipe pipe, igt_output_t *output)
> IGT_PIPE_CRC_SOURCE_AUTO);
> igt_pipe_crc_collect_crc(pipe_crc, &ref_crc);
>
> - /* Flip FB1 with the Primary plane & compare the CRC with ref CRC. */
> + /* Flip FB1 with the primary plane & compare the CRC with ref CRC. */
> igt_plane_set_fb(primary, &fb1);
> igt_display_commit(display);
>
> @@ -475,8 +481,22 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> }
> }
>
> - igt_describe("Basic sanity check for CRC mismatches");
> - igt_subtest_with_dynamic("compare-crc-sanitycheck") {
> + igt_describe("Basic sanity check for CRC mismatches with XR24 format");
> + igt_subtest_with_dynamic("compare-crc-sanitycheck-xr24") {
> + for_each_pipe_with_single_output(&data.display, pipe, output) {
> + if (simulation_constraint(pipe))
> + continue;
> +
> + if(!pipe_output_combo_valid(&data.display, pipe, output))
> + continue;
> +
> + igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
> + test_compare_crc(&data, pipe, output, DRM_FORMAT_XRGB8888);
> + }
> + }
> +
> + igt_describe("Basic sanity check for CRC mismatches with NV12 format");
> + igt_subtest_with_dynamic("compare-crc-sanitycheck-nv12") {
> for_each_pipe_with_single_output(&data.display, pipe, output) {
> if (simulation_constraint(pipe))
> continue;
> @@ -485,7 +505,7 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
> continue;
>
> igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), output->name)
> - test_compare_crc(&data, pipe, output);
> + test_compare_crc(&data, pipe, output, DRM_FORMAT_NV12);
> }
> }
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 3/3] intel-ci: update fastfeedback testlist
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v2 3/3] intel-ci: update fastfeedback testlist Swati Sharma
@ 2023-06-02 11:58 ` Juha-Pekka Heikkila
0 siblings, 0 replies; 12+ messages in thread
From: Juha-Pekka Heikkila @ 2023-06-02 11:58 UTC (permalink / raw)
To: Swati Sharma, igt-dev
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
On 31.5.2023 10.45, Swati Sharma wrote:
> Update fastfeedback testlist.
>
> v2: -fixed typo, renamed xrg888 to xr24 (Bhanu)
> -updated xe fastfeedback testlist too (Bhanu)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/intel-ci/fast-feedback.testlist | 3 ++-
> tests/intel-ci/xe-fast-feedback.testlist | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist
> index cfe7cb4a..31639c89 100644
> --- a/tests/intel-ci/fast-feedback.testlist
> +++ b/tests/intel-ci/fast-feedback.testlist
> @@ -118,7 +118,8 @@ igt@kms_force_connector_basic@force-edid
> igt@kms_force_connector_basic@force-load-detect
> igt@kms_force_connector_basic@prune-stale-modes
> igt@kms_frontbuffer_tracking@basic
> -igt@kms_pipe_crc_basic@compare-crc-sanitycheck
> +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24
> +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12
> igt@kms_pipe_crc_basic@hang-read-crc
> igt@kms_pipe_crc_basic@nonblocking-crc
> igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 7242c8d8..bdd12e57 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -259,7 +259,8 @@ igt@kms_flip@basic-plain-flip
> igt@kms_force_connector_basic@force-connector-state
> igt@kms_force_connector_basic@force-edid
> igt@kms_force_connector_basic@prune-stale-modes
> -igt@kms_pipe_crc_basic@compare-crc-sanitycheck
> +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-xr24
> +igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12
> igt@kms_pipe_crc_basic@hang-read-crc
> igt@kms_pipe_crc_basic@nonblocking-crc
> igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
2023-06-02 11:57 ` Juha-Pekka Heikkila
@ 2023-06-05 15:12 ` Kamil Konieczny
2023-06-05 15:56 ` Sharma, Swati2
1 sibling, 1 reply; 12+ messages in thread
From: Kamil Konieczny @ 2023-06-05 15:12 UTC (permalink / raw)
To: igt-dev
Hi Swati,
On 2023-05-31 at 13:15:28 +0530, Swati Sharma wrote:
> Round rgb->yuv conversion results.
>
> Signed-off-by: Ville Syrjala <ville.syrjala@linux.intel.com>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
> lib/igt_fb.c | 25 +++++++++++++++----------
> 1 file changed, 15 insertions(+), 10 deletions(-)
>
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 71a199d4..11a5d6c0 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -3064,11 +3064,16 @@ static void igt_fb_destroy_cairo_shadow_buffer(struct igt_fb *shadow,
> munmap(ptr, shadow->size);
> }
>
> -static uint8_t clamprgb(float val)
> +static uint8_t clamp8(float val)
> {
> return clamp((int)(val + 0.5f), 0, 255);
> }
>
> +static uint8_t clamp16(float val)
------------- ^
imho this should be 16, uint16_t as name suggest and
following range is 64K ?
> +{
> + return clamp((int)(val + 0.5f), 0, 65535);
------------------------------------------ ^
This is 64K.
Regards,
Kamil
> +}
> +
> static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
> {
> rgb->d[0] = rgb24[2];
> @@ -3079,9 +3084,9 @@ static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
>
> static void write_rgb(uint8_t *rgb24, const struct igt_vec4 *rgb)
> {
> - rgb24[2] = clamprgb(rgb->d[0]);
> - rgb24[1] = clamprgb(rgb->d[1]);
> - rgb24[0] = clamprgb(rgb->d[2]);
> + rgb24[2] = clamp8(rgb->d[0]);
> + rgb24[1] = clamp8(rgb->d[1]);
> + rgb24[0] = clamp8(rgb->d[2]);
> }
>
> struct fb_convert_buf {
> @@ -3401,7 +3406,7 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
>
> rgb_tmp += bpp;
>
> - *y_tmp = yuv.d[0];
> + *y_tmp = clamp8(yuv.d[0]);
> y_tmp += params.ay_inc;
>
> if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
> @@ -3431,8 +3436,8 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
> read_rgb(&pair_rgb, pair_rgb24);
> pair_yuv = igt_matrix_transform(&m, &pair_rgb);
>
> - *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
> - *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
> + *u_tmp = clamp8((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
> + *v_tmp = clamp8((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
>
> u_tmp += params.uv_inc;
> v_tmp += params.uv_inc;
> @@ -3590,7 +3595,7 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
>
> rgb_tmp += fpp;
>
> - *y_tmp = yuv.d[0];
> + *y_tmp = clamp16(yuv.d[0]);
> y_tmp += params.ay_inc;
>
> if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
> @@ -3620,8 +3625,8 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
> read_rgbf(&pair_rgb, pair_float);
> pair_yuv = igt_matrix_transform(&m, &pair_rgb);
>
> - *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
> - *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
> + *u_tmp = clamp16((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
> + *v_tmp = clamp16((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
>
> u_tmp += params.uv_inc;
> v_tmp += params.uv_inc;
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results
2023-06-05 15:12 ` Kamil Konieczny
@ 2023-06-05 15:56 ` Sharma, Swati2
0 siblings, 0 replies; 12+ messages in thread
From: Sharma, Swati2 @ 2023-06-05 15:56 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Juha-Pekka Heikkila
Thanks Kamil for pointing this out.
Floated patch fixing this
https://patchwork.freedesktop.org/patch/541160/
On 05-Jun-23 8:42 PM, Kamil Konieczny wrote:
> Hi Swati,
>
> On 2023-05-31 at 13:15:28 +0530, Swati Sharma wrote:
>> Round rgb->yuv conversion results.
>>
>> Signed-off-by: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>> ---
>> lib/igt_fb.c | 25 +++++++++++++++----------
>> 1 file changed, 15 insertions(+), 10 deletions(-)
>>
>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>> index 71a199d4..11a5d6c0 100644
>> --- a/lib/igt_fb.c
>> +++ b/lib/igt_fb.c
>> @@ -3064,11 +3064,16 @@ static void igt_fb_destroy_cairo_shadow_buffer(struct igt_fb *shadow,
>> munmap(ptr, shadow->size);
>> }
>>
>> -static uint8_t clamprgb(float val)
>> +static uint8_t clamp8(float val)
>> {
>> return clamp((int)(val + 0.5f), 0, 255);
>> }
>>
>> +static uint8_t clamp16(float val)
> ------------- ^
> imho this should be 16, uint16_t as name suggest and
> following range is 64K ?
>
>> +{
>> + return clamp((int)(val + 0.5f), 0, 65535);
> ------------------------------------------ ^
> This is 64K.
>
> Regards,
> Kamil
>
>> +}
>> +
>> static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
>> {
>> rgb->d[0] = rgb24[2];
>> @@ -3079,9 +3084,9 @@ static void read_rgb(struct igt_vec4 *rgb, const uint8_t *rgb24)
>>
>> static void write_rgb(uint8_t *rgb24, const struct igt_vec4 *rgb)
>> {
>> - rgb24[2] = clamprgb(rgb->d[0]);
>> - rgb24[1] = clamprgb(rgb->d[1]);
>> - rgb24[0] = clamprgb(rgb->d[2]);
>> + rgb24[2] = clamp8(rgb->d[0]);
>> + rgb24[1] = clamp8(rgb->d[1]);
>> + rgb24[0] = clamp8(rgb->d[2]);
>> }
>>
>> struct fb_convert_buf {
>> @@ -3401,7 +3406,7 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
>>
>> rgb_tmp += bpp;
>>
>> - *y_tmp = yuv.d[0];
>> + *y_tmp = clamp8(yuv.d[0]);
>> y_tmp += params.ay_inc;
>>
>> if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
>> @@ -3431,8 +3436,8 @@ static void convert_rgb24_to_yuv(struct fb_convert *cvt)
>> read_rgb(&pair_rgb, pair_rgb24);
>> pair_yuv = igt_matrix_transform(&m, &pair_rgb);
>>
>> - *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
>> - *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
>> + *u_tmp = clamp8((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
>> + *v_tmp = clamp8((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
>>
>> u_tmp += params.uv_inc;
>> v_tmp += params.uv_inc;
>> @@ -3590,7 +3595,7 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
>>
>> rgb_tmp += fpp;
>>
>> - *y_tmp = yuv.d[0];
>> + *y_tmp = clamp16(yuv.d[0]);
>> y_tmp += params.ay_inc;
>>
>> if ((i % dst_fmt->vsub) || (j % dst_fmt->hsub))
>> @@ -3620,8 +3625,8 @@ static void convert_float_to_yuv16(struct fb_convert *cvt, bool alpha)
>> read_rgbf(&pair_rgb, pair_float);
>> pair_yuv = igt_matrix_transform(&m, &pair_rgb);
>>
>> - *u_tmp = (yuv.d[1] + pair_yuv.d[1]) / 2.0f;
>> - *v_tmp = (yuv.d[2] + pair_yuv.d[2]) / 2.0f;
>> + *u_tmp = clamp16((yuv.d[1] + pair_yuv.d[1]) / 2.0f);
>> + *v_tmp = clamp16((yuv.d[2] + pair_yuv.d[2]) / 2.0f);
>>
>> u_tmp += params.uv_inc;
>> v_tmp += params.uv_inc;
>> --
>> 2.25.1
>>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-06-05 15:57 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-31 7:45 [igt-dev] [PATCH i-g-t v3 0/3] nv12 crc sanity check Swati Sharma
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_fb: round rgb->yuv conversion results Swati Sharma
2023-06-02 11:57 ` Juha-Pekka Heikkila
2023-06-05 15:12 ` Kamil Konieczny
2023-06-05 15:56 ` Sharma, Swati2
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v3 2/3] tests/kms_pipe_crc_basic: add nv12 crc sanity check Swati Sharma
2023-06-02 11:57 ` Juha-Pekka Heikkila
2023-05-31 7:45 ` [igt-dev] [PATCH i-g-t v2 3/3] intel-ci: update fastfeedback testlist Swati Sharma
2023-06-02 11:58 ` Juha-Pekka Heikkila
2023-05-31 7:57 ` [igt-dev] ✗ GitLab.Pipeline: warning for nv12 crc sanity check Patchwork
2023-05-31 8:24 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-06-01 15:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox