* [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout
@ 2023-06-02 16:20 Zbigniew Kempczyński
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper Zbigniew Kempczyński
` (5 more replies)
0 siblings, 6 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-02 16:20 UTC (permalink / raw)
To: igt-dev
According to kernel proposal https://patchwork.freedesktop.org/series/118670/
add abstime and change relative to use nanoseconds instead of jiffies.
v2: separate changes for reltime and abstime (Kamil)
change abstime timeout behavior to stay intact (Chris)
Zbigniew Kempczyński (4):
lib/xe_ioctl: Add xe_wait_ufence_abstime() helper
lib/xe_ioctl: Return remaining timeout of user fence wait
tests/xe_waitfence: Rename vague subtest name "test" to reltime
tests/xe_waitfence: Add abstime subtest for user fence
lib/xe/xe_ioctl.c | 39 ++++++++++++++++++++-
lib/xe/xe_ioctl.h | 5 ++-
tests/intel-ci/xe-fast-feedback.testlist | 2 +-
tests/xe/xe_waitfence.c | 43 ++++++++++++++++++++----
4 files changed, 80 insertions(+), 9 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
@ 2023-06-02 16:20 ` Zbigniew Kempczyński
2023-06-14 9:30 ` Kamil Konieczny
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait Zbigniew Kempczyński
` (4 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-02 16:20 UTC (permalink / raw)
To: igt-dev
Xe user fences supports passing timeout in relative or absolute form.
Add helper for absolute one.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
v2: Add documentation and change subject (Kamil).
---
lib/xe/xe_ioctl.c | 35 +++++++++++++++++++++++++++++++++++
lib/xe/xe_ioctl.h | 3 +++
2 files changed, 38 insertions(+)
diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
index 66a8393fe9..3331046b46 100644
--- a/lib/xe/xe_ioctl.c
+++ b/lib/xe/xe_ioctl.c
@@ -36,6 +36,7 @@
#define major(__v__) (((__v__) >> 8) & 0xff)
#define minor(__v__) ((__v__) & 0xff)
#endif
+#include <time.h>
#include "config.h"
#include "drmtest.h"
@@ -418,6 +419,40 @@ void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
}
+/**
+ * xe_wait_ufence_abstime:
+ * @fd: xe device fd
+ * @addr: address of value to compare
+ * @value: expected value (equal) in @address
+ * @eci: engine class instance
+ * @timeout: absolute time when wait expire
+ *
+ * Function compares @value with memory pointed by @addr until they are equal.
+ *
+ * Returns elapsed time in nanoseconds if user fence was signalled.
+ */
+long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
+ struct drm_xe_engine_class_instance *eci,
+ int64_t timeout)
+{
+ struct drm_xe_wait_user_fence wait = {
+ .addr = to_user_pointer(addr),
+ .op = DRM_XE_UFENCE_WAIT_EQ,
+ .flags = !eci ? DRM_XE_UFENCE_WAIT_SOFT_OP | DRM_XE_UFENCE_WAIT_ABSTIME : 0,
+ .value = value,
+ .mask = DRM_XE_UFENCE_WAIT_U64,
+ .timeout = timeout,
+ .num_engines = eci ? 1 : 0,
+ .instances = eci ? to_user_pointer(eci) : 0,
+ };
+ struct timespec ts;
+
+ igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
+ igt_assert_eq(clock_gettime(CLOCK_MONOTONIC, &ts), 0);
+
+ return ts.tv_sec * 1e9 + ts.tv_nsec;
+}
+
void xe_force_gt_reset(int fd, int gt)
{
char reset_string[128];
diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
index 049cd183d6..9b44892fe9 100644
--- a/lib/xe/xe_ioctl.h
+++ b/lib/xe/xe_ioctl.h
@@ -82,6 +82,9 @@ void xe_exec_wait(int fd, uint32_t engine, uint64_t addr);
void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
struct drm_xe_engine_class_instance *eci,
int64_t timeout);
+long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
+ struct drm_xe_engine_class_instance *eci,
+ int64_t timeout);
void xe_force_gt_reset(int fd, int gt);
void xe_vm_madvise(int fd, uint32_t vm, uint64_t addr, uint64_t size,
uint32_t property, uint32_t value);
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper Zbigniew Kempczyński
@ 2023-06-02 16:20 ` Zbigniew Kempczyński
2023-06-14 10:34 ` Kamil Konieczny
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime Zbigniew Kempczyński
` (3 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-02 16:20 UTC (permalink / raw)
To: igt-dev
When user fence is signalled we may want to be aware how long did it
take. Return remaining timeout after fence was successfully signalled.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/xe/xe_ioctl.c | 4 +++-
lib/xe/xe_ioctl.h | 2 +-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
index 3331046b46..e73c581f9f 100644
--- a/lib/xe/xe_ioctl.c
+++ b/lib/xe/xe_ioctl.c
@@ -401,7 +401,7 @@ void xe_exec_wait(int fd, uint32_t engine, uint64_t addr)
syncobj_destroy(fd, sync.handle);
}
-void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
+long xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
struct drm_xe_engine_class_instance *eci,
int64_t timeout)
{
@@ -417,6 +417,8 @@ void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
};
igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
+
+ return wait.timeout;
}
/**
diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
index 9b44892fe9..860de9af58 100644
--- a/lib/xe/xe_ioctl.h
+++ b/lib/xe/xe_ioctl.h
@@ -79,7 +79,7 @@ void xe_exec(int fd, struct drm_xe_exec *exec);
void xe_exec_sync(int fd, uint32_t engine, uint64_t addr,
struct drm_xe_sync *sync, uint32_t num_syncs);
void xe_exec_wait(int fd, uint32_t engine, uint64_t addr);
-void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
+long xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
struct drm_xe_engine_class_instance *eci,
int64_t timeout);
long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper Zbigniew Kempczyński
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait Zbigniew Kempczyński
@ 2023-06-02 16:20 ` Zbigniew Kempczyński
2023-06-14 10:35 ` Kamil Konieczny
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_waitfence: Add abstime subtest for user fence Zbigniew Kempczyński
` (2 subsequent siblings)
5 siblings, 1 reply; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-02 16:20 UTC (permalink / raw)
To: igt-dev
Wait user fence supports two techniques of passing timeout - relative
and absolute. Rename current subtest name "test" to reltime to prepare
the ground for adding new abstime subtest.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/intel-ci/xe-fast-feedback.testlist | 2 +-
tests/xe/xe_waitfence.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index 69e70118ed..1552b6ea19 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -214,7 +214,7 @@ igt@xe_vm@munmap-style-unbind-userptr-end
igt@xe_vm@munmap-style-unbind-userptr-front
igt@xe_vm@munmap-style-unbind-userptr-inval-end
igt@xe_vm@munmap-style-unbind-userptr-inval-front
-igt@xe_waitfence@test
+igt@xe_waitfence@reltime
igt@kms_addfb_basic@addfb25-bad-modifier
igt@kms_addfb_basic@addfb25-modifier-no-flag
igt@kms_addfb_basic@bad-pitch-0
diff --git a/tests/xe/xe_waitfence.c b/tests/xe/xe_waitfence.c
index cdfcacdb47..390d9b3221 100644
--- a/tests/xe/xe_waitfence.c
+++ b/tests/xe/xe_waitfence.c
@@ -38,11 +38,11 @@ static void do_bind(int fd, uint32_t vm, uint32_t bo, uint64_t offset,
}
/**
- * SUBTEST: test
+ * SUBTEST: reltime
* Description: Check basic waitfences functionality
*/
static void
-test(int fd)
+waitfence(int fd)
{
uint32_t bo_1;
uint32_t bo_2;
@@ -93,8 +93,8 @@ igt_main
xe_device_get(fd);
}
- igt_subtest("test")
- test(fd);
+ igt_subtest("reltime")
+ waitfence(fd);
igt_fixture {
xe_device_put(fd);
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_waitfence: Add abstime subtest for user fence
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
` (2 preceding siblings ...)
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime Zbigniew Kempczyński
@ 2023-06-02 16:20 ` Zbigniew Kempczyński
2023-06-14 10:40 ` Kamil Konieczny
2023-06-02 19:32 ` [igt-dev] ✓ Fi.CI.BAT: success for Add absolute user fence timeout (rev2) Patchwork
2023-06-05 5:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 1 reply; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-02 16:20 UTC (permalink / raw)
To: igt-dev
Start testing timeout passed as absolute time.
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
tests/xe/xe_waitfence.c | 39 +++++++++++++++++++++++++++++++++++----
1 file changed, 35 insertions(+), 4 deletions(-)
diff --git a/tests/xe/xe_waitfence.c b/tests/xe/xe_waitfence.c
index 390d9b3221..8979a9c2d0 100644
--- a/tests/xe/xe_waitfence.c
+++ b/tests/xe/xe_waitfence.c
@@ -37,12 +37,23 @@ static void do_bind(int fd, uint32_t vm, uint32_t bo, uint64_t offset,
xe_vm_bind(fd, vm, bo, offset, addr, size, sync, 1);
}
+#define MS_TO_NS(ms) (((long)ms) * 1000000)
+enum waittype {
+ RELTIME,
+ ABSTIME,
+};
+
/**
* SUBTEST: reltime
- * Description: Check basic waitfences functionality
+ * Description: Check basic waitfences functionality with timeout
+ * as relative timeout in nanoseconds
+ *
+ * SUBTEST: abstime
+ * Description: Check basic waitfences functionality with timeout
+ * passed as absolute time in nanoseconds
*/
static void
-waitfence(int fd)
+waitfence(int fd, enum waittype wt)
{
uint32_t bo_1;
uint32_t bo_2;
@@ -51,6 +62,7 @@ waitfence(int fd)
uint32_t bo_5;
uint32_t bo_6;
uint32_t bo_7;
+ long timeout;
uint32_t vm = xe_vm_create(fd, 0, 0);
bo_1 = xe_bo_create_flags(fd, vm, 0x40000, MY_FLAG);
@@ -67,7 +79,23 @@ waitfence(int fd)
do_bind(fd, vm, bo_6, 0, 0xc0040000, 0x1c0000, 6);
bo_7 = xe_bo_create_flags(fd, vm, 0x10000, MY_FLAG);
do_bind(fd, vm, bo_7, 0, 0xeffff0000, 0x10000, 7);
- xe_wait_ufence(fd, &wait_fence, 7, NULL, 2000);
+
+ if (wt == RELTIME) {
+ timeout = xe_wait_ufence(fd, &wait_fence, 7, NULL, MS_TO_NS(10));
+ igt_debug("wait type: RELTIME - timeout: %ld, timeout left: %ld\n",
+ MS_TO_NS(10), timeout);
+ } else {
+ struct timespec ts;
+ long current, signalled;
+
+ clock_gettime(CLOCK_MONOTONIC, &ts);
+ current = ts.tv_sec * 1e9 + ts.tv_nsec;
+ timeout = current + MS_TO_NS(10);
+ signalled = xe_wait_ufence_abstime(fd, &wait_fence, 7, NULL, timeout);
+ igt_debug("wait type: ABSTIME - timeout: %ld, signalled: %ld, elapsed: %ld\n",
+ timeout, signalled, signalled - current);
+ }
+
xe_vm_unbind_sync(fd, vm, 0, 0x200000, 0x40000);
xe_vm_unbind_sync(fd, vm, 0, 0xc0000000, 0x40000);
xe_vm_unbind_sync(fd, vm, 0, 0x180000000, 0x40000);
@@ -94,7 +122,10 @@ igt_main
}
igt_subtest("reltime")
- waitfence(fd);
+ waitfence(fd, RELTIME);
+
+ igt_subtest("abstime")
+ waitfence(fd, ABSTIME);
igt_fixture {
xe_device_put(fd);
--
2.34.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Add absolute user fence timeout (rev2)
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
` (3 preceding siblings ...)
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_waitfence: Add abstime subtest for user fence Zbigniew Kempczyński
@ 2023-06-02 19:32 ` Patchwork
2023-06-05 5:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-06-02 19:32 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 8828 bytes --]
== Series Details ==
Series: Add absolute user fence timeout (rev2)
URL : https://patchwork.freedesktop.org/series/118671/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13222 -> IGTPW_9099
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/index.html
Participating hosts (38 -> 37)
------------------------------
Additional (1): bat-rpls-2
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_9099 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@fbdev@read.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#7561])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][6] ([i915#6621])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][7] ([i915#4258] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [PASS][8] -> [ABORT][9] ([i915#4983] / [i915#7461] / [i915#8347] / [i915#8384])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/bat-rpls-1/igt@i915_selftest@live@reset.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][10] ([i915#6687])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][11] ([i915#1845]) +14 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][12] ([i915#7828]) +7 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][13] ([i915#3637]) +3 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][14] ([fdo#109285])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][15] ([i915#1849])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][16] ([i915#1072]) +3 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rpls-2: NOTRUN -> [SKIP][17] ([i915#3555] / [i915#4579])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][18] ([fdo#109295] / [i915#1845] / [i915#3708])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-rpls-2: NOTRUN -> [SKIP][19] ([fdo#109295] / [i915#3708]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rpls-2/igt@prime_vgem@basic-fence-read.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- {bat-mtlp-8}: [DMESG-FAIL][20] ([i915#7059]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@slpc:
- {bat-mtlp-6}: [DMESG-WARN][22] ([i915#6367]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-mtlp-6/igt@i915_selftest@live@slpc.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [FAIL][24] ([i915#7932]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
#### Warnings ####
* igt@kms_psr@primary_mmap_gtt:
- bat-rplp-1: [SKIP][26] ([i915#1072]) -> [ABORT][27] ([i915#8442])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/bat-rplp-1/igt@kms_psr@primary_mmap_gtt.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7318 -> IGTPW_9099
CI-20190529: 20190529
CI_DRM_13222: 9f99072561664a4b16520f460ddf583c1c0be7d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9099: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/index.html
IGT_7318: c2d8ef8b9397d0976959f29dc1dd7c8a698d65fe @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
+igt@xe_waitfence@abstime
+igt@xe_waitfence@reltime
-igt@xe_waitfence@test
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/index.html
[-- Attachment #2: Type: text/html, Size: 10248 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Add absolute user fence timeout (rev2)
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
` (4 preceding siblings ...)
2023-06-02 19:32 ` [igt-dev] ✓ Fi.CI.BAT: success for Add absolute user fence timeout (rev2) Patchwork
@ 2023-06-05 5:23 ` Patchwork
5 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2023-06-05 5:23 UTC (permalink / raw)
To: Zbigniew Kempczyński; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 20174 bytes --]
== Series Details ==
Series: Add absolute user fence timeout (rev2)
URL : https://patchwork.freedesktop.org/series/118671/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13222_full -> IGTPW_9099_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9099_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-4}:
- {shard-dg1}: NOTRUN -> [SKIP][1] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-dg1-16/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-4.html
Known issues
------------
Here are the changes found in IGTPW_9099_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-glk: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4579] / [i915#6334])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk9/igt@gem_exec_capture@capture-invisible@smem0.html
* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][3] -> [FAIL][4] ([i915#2842]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk7/igt@gem_exec_fair@basic-pace@vcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk7/igt@gem_exec_fair@basic-pace@vcs0.html
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: NOTRUN -> [FAIL][5] ([i915#2842]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk6/igt@gem_exec_fair@basic-throttle@rcs0.html
* igt@gem_lmem_swapping@random:
- shard-glk: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +2 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk5/igt@gem_lmem_swapping@random.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][7] -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-apl4/igt@i915_pm_dc@dc9-dpms.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-glk: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1937] / [i915#4579])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-apl: NOTRUN -> [SKIP][10] ([fdo#109271]) +47 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl3/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#3886]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk3/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#3886]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl6/igt@kms_ccs@pipe-c-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x10:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl2/igt@kms_cursor_crc@cursor-rapid-movement-32x10.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][14] -> [FAIL][15] ([i915#2346])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#79])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk6/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank@ac-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1:
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#2122])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk9/igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk1/igt@kms_flip@flip-vs-absolute-wf_vblank@a-hdmi-a1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4579]) +10 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-snb7/igt@kms_plane_scaling@planes-downscale-factor-0-25@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][21] ([fdo#109271]) +15 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-snb4/igt@kms_plane_scaling@planes-downscale-factor-0-75@pipe-a-vga-1.html
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-glk: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#658]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk4/igt@kms_psr2_sf@overlay-plane-update-continuous-sf.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#658])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl1/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_scaling_modes@scaling-mode-full:
- shard-glk: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4579]) +7 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk7/igt@kms_scaling_modes@scaling-mode-full.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][25] ([i915#5465]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-snb6/igt@kms_setmode@basic@pipe-a-vga-1.html
* igt@kms_vblank@pipe-d-wait-busy-hang:
- shard-glk: NOTRUN -> [SKIP][26] ([fdo#109271]) +117 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk8/igt@kms_vblank@pipe-d-wait-busy-hang.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-glk: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#2437])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk6/igt@kms_writeback@writeback-invalid-parameters.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- {shard-rkl}: [FAIL][28] ([i915#7742]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-rkl-1/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_eio@hibernate:
- {shard-dg1}: [ABORT][30] ([i915#4391] / [i915#7975] / [i915#8213]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-dg1-14/igt@gem_eio@hibernate.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-dg1-16/igt@gem_eio@hibernate.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][32] ([i915#2842]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk8/igt@gem_exec_fair@basic-pace-share@rcs0.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk3/igt@gem_exec_fair@basic-pace-share@rcs0.html
- {shard-tglu}: [FAIL][34] ([i915#2842]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-tglu-4/igt@gem_exec_fair@basic-pace-share@rcs0.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-tglu-8/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_suspend@basic-s4-devices@lmem0:
- {shard-dg1}: [ABORT][36] ([i915#7975] / [i915#8213]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-dg1-17/igt@gem_exec_suspend@basic-s4-devices@lmem0.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- {shard-tglu}: [ABORT][38] ([i915#7975] / [i915#8213]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-tglu-10/igt@gem_exec_suspend@basic-s4-devices@smem.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-tglu-7/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [TIMEOUT][40] ([i915#5493]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-dg1-15/igt@gem_lmem_swapping@smem-oom@lmem0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-dg1-16/igt@gem_lmem_swapping@smem-oom@lmem0.html
* igt@gen9_exec_parse@allowed-all:
- shard-apl: [ABORT][42] ([i915#5566]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-apl3/igt@gen9_exec_parse@allowed-all.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl2/igt@gen9_exec_parse@allowed-all.html
- shard-glk: [ABORT][44] ([i915#5566]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk3/igt@gen9_exec_parse@allowed-all.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk4/igt@gen9_exec_parse@allowed-all.html
* igt@i915_pipe_stress@stress-xrgb8888-untiled:
- shard-apl: [FAIL][46] ([i915#7036]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-apl6/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl1/igt@i915_pipe_stress@stress-xrgb8888-untiled.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][48] ([i915#1397]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-glk: [FAIL][50] -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk3/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk2/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [ABORT][52] ([i915#180]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-apl6/igt@kms_flip@flip-vs-suspend@b-dp1.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl4/igt@kms_flip@flip-vs-suspend@b-dp1.html
#### Warnings ####
* igt@kms_content_protection@mei_interface:
- shard-apl: [SKIP][54] ([fdo#109271]) -> [SKIP][55] ([fdo#109271] / [i915#4579])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-apl6/igt@kms_content_protection@mei_interface.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-apl7/igt@kms_content_protection@mei_interface.html
- shard-snb: [SKIP][56] ([fdo#109271]) -> [SKIP][57] ([fdo#109271] / [i915#4579])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-snb2/igt@kms_content_protection@mei_interface.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-snb1/igt@kms_content_protection@mei_interface.html
- shard-glk: [SKIP][58] ([fdo#109271]) -> [SKIP][59] ([fdo#109271] / [i915#4579])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-glk6/igt@kms_content_protection@mei_interface.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-glk7/igt@kms_content_protection@mei_interface.html
* igt@kms_hdmi_inject@inject-audio:
- shard-snb: [FAIL][60] ([IGT#3]) -> [SKIP][61] ([fdo#109271])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13222/shard-snb7/igt@kms_hdmi_inject@inject-audio.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/shard-snb5/igt@kms_hdmi_inject@inject-audio.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4275]: https://gitlab.freedesktop.org/drm/intel/issues/4275
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5566]: https://gitlab.freedesktop.org/drm/intel/issues/5566
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6493]: https://gitlab.freedesktop.org/drm/intel/issues/6493
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#7036]: https://gitlab.freedesktop.org/drm/intel/issues/7036
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311
[i915#8414]: https://gitlab.freedesktop.org/drm/intel/issues/8414
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8555]: https://gitlab.freedesktop.org/drm/intel/issues/8555
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7318 -> IGTPW_9099
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13222: 9f99072561664a4b16520f460ddf583c1c0be7d4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9099: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/index.html
IGT_7318: c2d8ef8b9397d0976959f29dc1dd7c8a698d65fe @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9099/index.html
[-- Attachment #2: Type: text/html, Size: 19630 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper Zbigniew Kempczyński
@ 2023-06-14 9:30 ` Kamil Konieczny
0 siblings, 0 replies; 12+ messages in thread
From: Kamil Konieczny @ 2023-06-14 9:30 UTC (permalink / raw)
To: igt-dev
Hi Zbigniew,
On 2023-06-02 at 18:20:08 +0200, Zbigniew Kempczyński wrote:
> Xe user fences supports passing timeout in relative or absolute form.
> Add helper for absolute one.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> v2: Add documentation and change subject (Kamil).
> ---
> lib/xe/xe_ioctl.c | 35 +++++++++++++++++++++++++++++++++++
> lib/xe/xe_ioctl.h | 3 +++
> 2 files changed, 38 insertions(+)
>
> diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
> index 66a8393fe9..3331046b46 100644
> --- a/lib/xe/xe_ioctl.c
> +++ b/lib/xe/xe_ioctl.c
> @@ -36,6 +36,7 @@
> #define major(__v__) (((__v__) >> 8) & 0xff)
> #define minor(__v__) ((__v__) & 0xff)
> #endif
> +#include <time.h>
>
> #include "config.h"
> #include "drmtest.h"
> @@ -418,6 +419,40 @@ void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
> }
>
> +/**
> + * xe_wait_ufence_abstime:
> + * @fd: xe device fd
> + * @addr: address of value to compare
> + * @value: expected value (equal) in @address
> + * @eci: engine class instance
> + * @timeout: absolute time when wait expire
> + *
> + * Function compares @value with memory pointed by @addr until they are equal.
> + *
> + * Returns elapsed time in nanoseconds if user fence was signalled.
> + */
> +long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
> + struct drm_xe_engine_class_instance *eci,
> + int64_t timeout)
> +{
> + struct drm_xe_wait_user_fence wait = {
> + .addr = to_user_pointer(addr),
> + .op = DRM_XE_UFENCE_WAIT_EQ,
> + .flags = !eci ? DRM_XE_UFENCE_WAIT_SOFT_OP | DRM_XE_UFENCE_WAIT_ABSTIME : 0,
> + .value = value,
> + .mask = DRM_XE_UFENCE_WAIT_U64,
> + .timeout = timeout,
> + .num_engines = eci ? 1 : 0,
> + .instances = eci ? to_user_pointer(eci) : 0,
> + };
> + struct timespec ts;
> +
> + igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
> + igt_assert_eq(clock_gettime(CLOCK_MONOTONIC, &ts), 0);
> +
> + return ts.tv_sec * 1e9 + ts.tv_nsec;
> +}
> +
> void xe_force_gt_reset(int fd, int gt)
> {
> char reset_string[128];
> diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
> index 049cd183d6..9b44892fe9 100644
> --- a/lib/xe/xe_ioctl.h
> +++ b/lib/xe/xe_ioctl.h
> @@ -82,6 +82,9 @@ void xe_exec_wait(int fd, uint32_t engine, uint64_t addr);
> void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> struct drm_xe_engine_class_instance *eci,
> int64_t timeout);
> +long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
> + struct drm_xe_engine_class_instance *eci,
> + int64_t timeout);
> void xe_force_gt_reset(int fd, int gt);
> void xe_vm_madvise(int fd, uint32_t vm, uint64_t addr, uint64_t size,
> uint32_t property, uint32_t value);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait Zbigniew Kempczyński
@ 2023-06-14 10:34 ` Kamil Konieczny
2023-06-19 4:58 ` Zbigniew Kempczyński
0 siblings, 1 reply; 12+ messages in thread
From: Kamil Konieczny @ 2023-06-14 10:34 UTC (permalink / raw)
To: igt-dev
Hi Zbigniew,
On 2023-06-02 at 18:20:09 +0200, Zbigniew Kempczyński wrote:
> When user fence is signalled we may want to be aware how long did it
> take. Return remaining timeout after fence was successfully signalled.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> lib/xe/xe_ioctl.c | 4 +++-
> lib/xe/xe_ioctl.h | 2 +-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
> index 3331046b46..e73c581f9f 100644
> --- a/lib/xe/xe_ioctl.c
> +++ b/lib/xe/xe_ioctl.c
> @@ -401,7 +401,7 @@ void xe_exec_wait(int fd, uint32_t engine, uint64_t addr)
> syncobj_destroy(fd, sync.handle);
> }
>
> -void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> +long xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
-- ^^^^
imho this should be uint64_t
Regards,
Kamil
> struct drm_xe_engine_class_instance *eci,
> int64_t timeout)
> {
> @@ -417,6 +417,8 @@ void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> };
>
> igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
> +
> + return wait.timeout;
> }
>
> /**
> diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
> index 9b44892fe9..860de9af58 100644
> --- a/lib/xe/xe_ioctl.h
> +++ b/lib/xe/xe_ioctl.h
> @@ -79,7 +79,7 @@ void xe_exec(int fd, struct drm_xe_exec *exec);
> void xe_exec_sync(int fd, uint32_t engine, uint64_t addr,
> struct drm_xe_sync *sync, uint32_t num_syncs);
> void xe_exec_wait(int fd, uint32_t engine, uint64_t addr);
> -void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> +long xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> struct drm_xe_engine_class_instance *eci,
> int64_t timeout);
> long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime Zbigniew Kempczyński
@ 2023-06-14 10:35 ` Kamil Konieczny
0 siblings, 0 replies; 12+ messages in thread
From: Kamil Konieczny @ 2023-06-14 10:35 UTC (permalink / raw)
To: igt-dev
Hi Zbigniew,
On 2023-06-02 at 18:20:10 +0200, Zbigniew Kempczyński wrote:
> Wait user fence supports two techniques of passing timeout - relative
> and absolute. Rename current subtest name "test" to reltime to prepare
> the ground for adding new abstime subtest.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/intel-ci/xe-fast-feedback.testlist | 2 +-
> tests/xe/xe_waitfence.c | 8 ++++----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
> index 69e70118ed..1552b6ea19 100644
> --- a/tests/intel-ci/xe-fast-feedback.testlist
> +++ b/tests/intel-ci/xe-fast-feedback.testlist
> @@ -214,7 +214,7 @@ igt@xe_vm@munmap-style-unbind-userptr-end
> igt@xe_vm@munmap-style-unbind-userptr-front
> igt@xe_vm@munmap-style-unbind-userptr-inval-end
> igt@xe_vm@munmap-style-unbind-userptr-inval-front
> -igt@xe_waitfence@test
> +igt@xe_waitfence@reltime
> igt@kms_addfb_basic@addfb25-bad-modifier
> igt@kms_addfb_basic@addfb25-modifier-no-flag
> igt@kms_addfb_basic@bad-pitch-0
> diff --git a/tests/xe/xe_waitfence.c b/tests/xe/xe_waitfence.c
> index cdfcacdb47..390d9b3221 100644
> --- a/tests/xe/xe_waitfence.c
> +++ b/tests/xe/xe_waitfence.c
> @@ -38,11 +38,11 @@ static void do_bind(int fd, uint32_t vm, uint32_t bo, uint64_t offset,
> }
>
> /**
> - * SUBTEST: test
> + * SUBTEST: reltime
> * Description: Check basic waitfences functionality
> */
> static void
> -test(int fd)
> +waitfence(int fd)
> {
> uint32_t bo_1;
> uint32_t bo_2;
> @@ -93,8 +93,8 @@ igt_main
> xe_device_get(fd);
> }
>
> - igt_subtest("test")
> - test(fd);
> + igt_subtest("reltime")
> + waitfence(fd);
>
> igt_fixture {
> xe_device_put(fd);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_waitfence: Add abstime subtest for user fence
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_waitfence: Add abstime subtest for user fence Zbigniew Kempczyński
@ 2023-06-14 10:40 ` Kamil Konieczny
0 siblings, 0 replies; 12+ messages in thread
From: Kamil Konieczny @ 2023-06-14 10:40 UTC (permalink / raw)
To: igt-dev
Hi Zbigniew,
On 2023-06-02 at 18:20:11 +0200, Zbigniew Kempczyński wrote:
> Start testing timeout passed as absolute time.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/xe/xe_waitfence.c | 39 +++++++++++++++++++++++++++++++++++----
> 1 file changed, 35 insertions(+), 4 deletions(-)
>
> diff --git a/tests/xe/xe_waitfence.c b/tests/xe/xe_waitfence.c
> index 390d9b3221..8979a9c2d0 100644
> --- a/tests/xe/xe_waitfence.c
> +++ b/tests/xe/xe_waitfence.c
> @@ -37,12 +37,23 @@ static void do_bind(int fd, uint32_t vm, uint32_t bo, uint64_t offset,
> xe_vm_bind(fd, vm, bo, offset, addr, size, sync, 1);
> }
>
> +#define MS_TO_NS(ms) (((long)ms) * 1000000)
-------------------------- ^^^^
imho this should be uint64_t
Add newline here.
> +enum waittype {
> + RELTIME,
> + ABSTIME,
> +};
> +
> /**
> * SUBTEST: reltime
> - * Description: Check basic waitfences functionality
> + * Description: Check basic waitfences functionality with timeout
> + * as relative timeout in nanoseconds
> + *
> + * SUBTEST: abstime
> + * Description: Check basic waitfences functionality with timeout
> + * passed as absolute time in nanoseconds
> */
> static void
> -waitfence(int fd)
> +waitfence(int fd, enum waittype wt)
> {
> uint32_t bo_1;
> uint32_t bo_2;
> @@ -51,6 +62,7 @@ waitfence(int fd)
> uint32_t bo_5;
> uint32_t bo_6;
> uint32_t bo_7;
> + long timeout;
------- ^^^
uint64_t
>
> uint32_t vm = xe_vm_create(fd, 0, 0);
> bo_1 = xe_bo_create_flags(fd, vm, 0x40000, MY_FLAG);
> @@ -67,7 +79,23 @@ waitfence(int fd)
> do_bind(fd, vm, bo_6, 0, 0xc0040000, 0x1c0000, 6);
> bo_7 = xe_bo_create_flags(fd, vm, 0x10000, MY_FLAG);
> do_bind(fd, vm, bo_7, 0, 0xeffff0000, 0x10000, 7);
> - xe_wait_ufence(fd, &wait_fence, 7, NULL, 2000);
> +
> + if (wt == RELTIME) {
> + timeout = xe_wait_ufence(fd, &wait_fence, 7, NULL, MS_TO_NS(10));
> + igt_debug("wait type: RELTIME - timeout: %ld, timeout left: %ld\n",
> + MS_TO_NS(10), timeout);
> + } else {
> + struct timespec ts;
> + long current, signalled;
--------------- ^^^^
uint64_t
Regards,
Kamil
> +
> + clock_gettime(CLOCK_MONOTONIC, &ts);
> + current = ts.tv_sec * 1e9 + ts.tv_nsec;
> + timeout = current + MS_TO_NS(10);
> + signalled = xe_wait_ufence_abstime(fd, &wait_fence, 7, NULL, timeout);
> + igt_debug("wait type: ABSTIME - timeout: %ld, signalled: %ld, elapsed: %ld\n",
> + timeout, signalled, signalled - current);
> + }
> +
> xe_vm_unbind_sync(fd, vm, 0, 0x200000, 0x40000);
> xe_vm_unbind_sync(fd, vm, 0, 0xc0000000, 0x40000);
> xe_vm_unbind_sync(fd, vm, 0, 0x180000000, 0x40000);
> @@ -94,7 +122,10 @@ igt_main
> }
>
> igt_subtest("reltime")
> - waitfence(fd);
> + waitfence(fd, RELTIME);
> +
> + igt_subtest("abstime")
> + waitfence(fd, ABSTIME);
>
> igt_fixture {
> xe_device_put(fd);
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait
2023-06-14 10:34 ` Kamil Konieczny
@ 2023-06-19 4:58 ` Zbigniew Kempczyński
0 siblings, 0 replies; 12+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-19 4:58 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev, Zbigniew Kempczyński
On Wed, Jun 14, 2023 at 12:34:54PM +0200, Kamil Konieczny wrote:
> Hi Zbigniew,
>
> On 2023-06-02 at 18:20:09 +0200, Zbigniew Kempczyński wrote:
> > When user fence is signalled we may want to be aware how long did it
> > take. Return remaining timeout after fence was successfully signalled.
> >
> > Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> > ---
> > lib/xe/xe_ioctl.c | 4 +++-
> > lib/xe/xe_ioctl.h | 2 +-
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/xe/xe_ioctl.c b/lib/xe/xe_ioctl.c
> > index 3331046b46..e73c581f9f 100644
> > --- a/lib/xe/xe_ioctl.c
> > +++ b/lib/xe/xe_ioctl.c
> > @@ -401,7 +401,7 @@ void xe_exec_wait(int fd, uint32_t engine, uint64_t addr)
> > syncobj_destroy(fd, sync.handle);
> > }
> >
> > -void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> > +long xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> -- ^^^^
> imho this should be uint64_t
Agree, long might be 32bit on 32bit archs.
I'll change it to int64_t as input is s64.
Thank you for the review.
--
Zbigniew
>
> Regards,
> Kamil
>
> > struct drm_xe_engine_class_instance *eci,
> > int64_t timeout)
> > {
> > @@ -417,6 +417,8 @@ void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> > };
> >
> > igt_assert_eq(igt_ioctl(fd, DRM_IOCTL_XE_WAIT_USER_FENCE, &wait), 0);
> > +
> > + return wait.timeout;
> > }
> >
> > /**
> > diff --git a/lib/xe/xe_ioctl.h b/lib/xe/xe_ioctl.h
> > index 9b44892fe9..860de9af58 100644
> > --- a/lib/xe/xe_ioctl.h
> > +++ b/lib/xe/xe_ioctl.h
> > @@ -79,7 +79,7 @@ void xe_exec(int fd, struct drm_xe_exec *exec);
> > void xe_exec_sync(int fd, uint32_t engine, uint64_t addr,
> > struct drm_xe_sync *sync, uint32_t num_syncs);
> > void xe_exec_wait(int fd, uint32_t engine, uint64_t addr);
> > -void xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> > +long xe_wait_ufence(int fd, uint64_t *addr, uint64_t value,
> > struct drm_xe_engine_class_instance *eci,
> > int64_t timeout);
> > long xe_wait_ufence_abstime(int fd, uint64_t *addr, uint64_t value,
> > --
> > 2.34.1
> >
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2023-06-19 4:59 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 16:20 [igt-dev] [PATCH i-g-t v2 0/4] Add absolute user fence timeout Zbigniew Kempczyński
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 1/4] lib/xe_ioctl: Add xe_wait_ufence_abstime() helper Zbigniew Kempczyński
2023-06-14 9:30 ` Kamil Konieczny
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 2/4] lib/xe_ioctl: Return remaining timeout of user fence wait Zbigniew Kempczyński
2023-06-14 10:34 ` Kamil Konieczny
2023-06-19 4:58 ` Zbigniew Kempczyński
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 3/4] tests/xe_waitfence: Rename vague subtest name "test" to reltime Zbigniew Kempczyński
2023-06-14 10:35 ` Kamil Konieczny
2023-06-02 16:20 ` [igt-dev] [PATCH i-g-t v2 4/4] tests/xe_waitfence: Add abstime subtest for user fence Zbigniew Kempczyński
2023-06-14 10:40 ` Kamil Konieczny
2023-06-02 19:32 ` [igt-dev] ✓ Fi.CI.BAT: success for Add absolute user fence timeout (rev2) Patchwork
2023-06-05 5:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox