* [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up
@ 2023-06-05 18:03 Kamil Konieczny
2023-06-05 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Kamil Konieczny @ 2023-06-05 18:03 UTC (permalink / raw)
To: igt-dev; +Cc: Chris Wilson
From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
In case of tests which extensively use debugfs, tons of useless debug
messages about opening a debugfs directory are emitted. If the test fails
then important debug messages with details of the failure, interleaved
with sequences of those useless messages, are hard to find and read.
Replace igt_debug() with conditional igt_debug_on_f() emitting a message
about debugfs directory path only if open() fails.
v2: emit a message on NULL debugfs path
Cc: Chris Wilson <chris.p.wilson@intel.com>
Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/igt_debugfs.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
index afde2da62..a7b54bae5 100644
--- a/lib/igt_debugfs.c
+++ b/lib/igt_debugfs.c
@@ -208,13 +208,16 @@ char *igt_debugfs_path(int device, char *path, int pathlen)
*/
int igt_debugfs_dir(int device)
{
+ int debugfs_dir_fd;
char path[200];
- if (!igt_debugfs_path(device, path, sizeof(path)))
+ if (igt_debug_on(!igt_debugfs_path(device, path, sizeof(path))))
return -1;
- igt_debug("Opening debugfs directory '%s'\n", path);
- return open(path, O_RDONLY);
+ debugfs_dir_fd = open(path, O_RDONLY);
+ igt_debug_on_f(debugfs_dir_fd < 0, "path: %s\n", path);
+
+ return debugfs_dir_fd;
}
/**
--
2.39.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib: Shut some excessive debug messages up
2023-06-05 18:03 [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up Kamil Konieczny
@ 2023-06-05 19:47 ` Patchwork
2023-06-06 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-05 19:47 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 9320 bytes --]
== Series Details ==
Series: lib: Shut some excessive debug messages up
URL : https://patchwork.freedesktop.org/series/118880/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13232 -> IGTPW_9106
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/index.html
Participating hosts (37 -> 36)
------------------------------
Additional (1): bat-rpls-2
Missing (2): fi-kbl-soraka fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_9106 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- bat-rpls-2: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][2] ([i915#2582]) +4 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@fbdev@read.html
* igt@gem_lmem_swapping@verify-random:
- bat-rpls-2: NOTRUN -> [SKIP][3] ([i915#4613]) +3 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- bat-rpls-2: NOTRUN -> [SKIP][4] ([i915#3282])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- bat-rpls-2: NOTRUN -> [SKIP][5] ([i915#7561])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_backlight@basic-brightness@edp-1:
- bat-rplp-1: NOTRUN -> [ABORT][6] ([i915#7077])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rplp-1/igt@i915_pm_backlight@basic-brightness@edp-1.html
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: NOTRUN -> [SKIP][7] ([i915#6621])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: NOTRUN -> [DMESG-FAIL][8] ([i915#4258] / [i915#7913])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@reset:
- bat-rpls-2: NOTRUN -> [ABORT][9] ([i915#4983] / [i915#7461] / [i915#7913] / [i915#7981] / [i915#8347])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@i915_selftest@live@reset.html
* igt@i915_selftest@live@slpc:
- bat-rpls-1: NOTRUN -> [DMESG-WARN][10] ([i915#6367])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][11] ([i915#6687] / [i915#7978])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_busy@basic:
- bat-rpls-2: NOTRUN -> [SKIP][12] ([i915#1845]) +14 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_busy@basic.html
* igt@kms_chamelium_edid@hdmi-edid-read:
- bat-rpls-2: NOTRUN -> [SKIP][13] ([i915#7828]) +7 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_chamelium_edid@hdmi-edid-read.html
* igt@kms_flip@basic-flip-vs-dpms:
- bat-rpls-2: NOTRUN -> [SKIP][14] ([i915#3637]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_force_connector_basic@force-load-detect:
- bat-rpls-2: NOTRUN -> [SKIP][15] ([fdo#109285])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_frontbuffer_tracking@basic:
- bat-rpls-2: NOTRUN -> [SKIP][16] ([i915#1849])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_frontbuffer_tracking@basic.html
* igt@kms_psr@sprite_plane_onoff:
- bat-rpls-2: NOTRUN -> [SKIP][17] ([i915#1072]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rpls-2: NOTRUN -> [SKIP][18] ([i915#3555] / [i915#4579])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-fence-flip:
- bat-rpls-2: NOTRUN -> [SKIP][19] ([fdo#109295] / [i915#1845] / [i915#3708])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@prime_vgem@basic-fence-flip.html
* igt@prime_vgem@basic-fence-read:
- bat-rpls-2: NOTRUN -> [SKIP][20] ([fdo#109295] / [i915#3708]) +2 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-2/igt@prime_vgem@basic-fence-read.html
#### Possible fixes ####
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][21] ([i915#4983] / [i915#7461] / [i915#7981] / [i915#8347] / [i915#8384]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/bat-rpls-1/igt@i915_selftest@live@reset.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rpls-1/igt@i915_selftest@live@reset.html
* igt@kms_busy@basic@flip:
- {bat-adlp-11}: [ABORT][23] ([i915#4423]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/bat-adlp-11/igt@kms_busy@basic@flip.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-adlp-11/igt@kms_busy@basic@flip.html
#### Warnings ####
* igt@kms_setmode@basic-clone-single-crtc:
- bat-rplp-1: [ABORT][25] ([i915#4579] / [i915#8260]) -> [SKIP][26] ([i915#3555] / [i915#4579])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4093]: https://gitlab.freedesktop.org/drm/intel/issues/4093
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
[i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8497]: https://gitlab.freedesktop.org/drm/intel/issues/8497
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7319 -> IGTPW_9106
CI-20190529: 20190529
CI_DRM_13232: 450d228e38403a48aa273ec1e22b463dc64aaae6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9106: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/index.html
IGT_7319: 2e1bcd49944452b5f9516eecee48e1fa3ae6a636 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Testlist changes
----------------
-igt@xe_uevent_listener_fake_reset_failure@fake_reset_uevent_listener
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/index.html
[-- Attachment #2: Type: text/html, Size: 10868 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for lib: Shut some excessive debug messages up
2023-06-05 18:03 [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up Kamil Konieczny
2023-06-05 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-06 20:44 ` Patchwork
2023-06-07 6:26 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
2023-06-07 12:09 ` Janusz Krzysztofik
3 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-06-06 20:44 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 13257 bytes --]
== Series Details ==
Series: lib: Shut some excessive debug messages up
URL : https://patchwork.freedesktop.org/series/118880/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13232_full -> IGTPW_9106_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/index.html
Participating hosts (7 -> 6)
------------------------------
Missing (1): shard-dg1
Known issues
------------
Here are the changes found in IGTPW_9106_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: NOTRUN -> [FAIL][1] ([i915#2842])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk4/igt@gem_exec_fair@basic-pace@vecs0.html
* igt@gem_lmem_swapping@random:
- shard-glk: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#4613])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk1/igt@gem_lmem_swapping@random.html
* igt@i915_module_load@reload:
- shard-snb: [PASS][3] -> [ABORT][4] ([i915#4528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-snb6/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-snb1/igt@i915_module_load@reload.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][5] -> [SKIP][6] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-apl3/igt@i915_pm_dc@dc9-dpms.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#3886]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#3886]) +2 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_ccs:
- shard-apl: NOTRUN -> [SKIP][9] ([fdo#109271]) +31 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl2/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_ccs.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode:
- shard-glk: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#4579]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk4/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling@pipe-a-valid-mode.html
* igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#4579]) +12 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-snb2/igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling@pipe-b-vga-1.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-glk: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#658])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk8/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf.html
* igt@kms_setmode@clone-exclusive-crtc:
- shard-apl: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#4579])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl7/igt@kms_setmode@clone-exclusive-crtc.html
* igt@kms_tv_load_detect@load-detect:
- shard-snb: NOTRUN -> [SKIP][14] ([fdo#109271]) +43 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-snb2/igt@kms_tv_load_detect@load-detect.html
* igt@v3d/v3d_perfmon@create-perfmon-exceed:
- shard-glk: NOTRUN -> [SKIP][15] ([fdo#109271]) +44 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk1/igt@v3d/v3d_perfmon@create-perfmon-exceed.html
#### Possible fixes ####
* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-glk4/igt@gem_exec_fair@basic-none-share@rcs0.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk5/igt@gem_exec_fair@basic-none-share@rcs0.html
* igt@gem_exec_fair@basic-none@vecs0:
- {shard-rkl}: [FAIL][18] ([i915#2842]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-rkl-6/igt@gem_exec_fair@basic-none@vecs0.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-rkl-4/igt@gem_exec_fair@basic-none@vecs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][20] ([i915#2842]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-apl7/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][22] ([i915#4281]) -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-tglu-4/igt@i915_pm_dc@dc9-dpms.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-tglu-4/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- {shard-rkl}: [SKIP][24] ([i915#1397]) -> [PASS][25] +1 similar issue
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-rkl-2/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-rkl-7/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@i915_pm_rps@reset:
- shard-snb: [DMESG-FAIL][26] ([i915#8319]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-snb4/igt@i915_pm_rps@reset.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-snb7/igt@i915_pm_rps@reset.html
* igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1:
- shard-apl: [ABORT][28] ([i915#180]) -> [PASS][29] +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-apl4/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl1/igt@kms_cursor_crc@cursor-suspend@pipe-a-dp-1.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][30] ([i915#2346]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: [FAIL][32] ([i915#2346]) -> [PASS][33]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-glk2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- {shard-rkl}: [INCOMPLETE][34] ([i915#8011]) -> [PASS][35]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-rkl-7/igt@kms_cursor_legacy@single-bo@pipe-b.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-rkl-6/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-apl: [FAIL][36] ([i915#1188]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13232/shard-apl2/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/shard-apl7/igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2435]: https://gitlab.freedesktop.org/drm/intel/issues/2435
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3743]: https://gitlab.freedesktop.org/drm/intel/issues/3743
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
[i915#8311]: https://gitlab.freedesktop.org/drm/intel/issues/8311
[i915#8319]: https://gitlab.freedesktop.org/drm/intel/issues/8319
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7319 -> IGTPW_9106
CI-20190529: 20190529
CI_DRM_13232: 450d228e38403a48aa273ec1e22b463dc64aaae6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9106: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/index.html
IGT_7319: 2e1bcd49944452b5f9516eecee48e1fa3ae6a636 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9106/index.html
[-- Attachment #2: Type: text/html, Size: 12054 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up
2023-06-05 18:03 [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up Kamil Konieczny
2023-06-05 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-06 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-07 6:26 ` Zbigniew Kempczyński
2023-06-07 12:09 ` Janusz Krzysztofik
3 siblings, 0 replies; 5+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-07 6:26 UTC (permalink / raw)
To: Kamil Konieczny; +Cc: igt-dev, Chris Wilson
On Mon, Jun 05, 2023 at 08:03:59PM +0200, Kamil Konieczny wrote:
> From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
>
> In case of tests which extensively use debugfs, tons of useless debug
> messages about opening a debugfs directory are emitted. If the test fails
> then important debug messages with details of the failure, interleaved
> with sequences of those useless messages, are hard to find and read.
>
> Replace igt_debug() with conditional igt_debug_on_f() emitting a message
> about debugfs directory path only if open() fails.
>
> v2: emit a message on NULL debugfs path
>
> Cc: Chris Wilson <chris.p.wilson@intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> lib/igt_debugfs.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
> index afde2da62..a7b54bae5 100644
> --- a/lib/igt_debugfs.c
> +++ b/lib/igt_debugfs.c
> @@ -208,13 +208,16 @@ char *igt_debugfs_path(int device, char *path, int pathlen)
> */
> int igt_debugfs_dir(int device)
> {
> + int debugfs_dir_fd;
> char path[200];
>
> - if (!igt_debugfs_path(device, path, sizeof(path)))
> + if (igt_debug_on(!igt_debugfs_path(device, path, sizeof(path))))
> return -1;
>
> - igt_debug("Opening debugfs directory '%s'\n", path);
> - return open(path, O_RDONLY);
> + debugfs_dir_fd = open(path, O_RDONLY);
> + igt_debug_on_f(debugfs_dir_fd < 0, "path: %s\n", path);
> +
> + return debugfs_dir_fd;
> }
>
> /**
> --
> 2.39.2
>
LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up
2023-06-05 18:03 [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up Kamil Konieczny
` (2 preceding siblings ...)
2023-06-07 6:26 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
@ 2023-06-07 12:09 ` Janusz Krzysztofik
3 siblings, 0 replies; 5+ messages in thread
From: Janusz Krzysztofik @ 2023-06-07 12:09 UTC (permalink / raw)
To: igt-dev, Kamil Konieczny; +Cc: Chris Wilson
Hi Kamil,
On Monday, 5 June 2023 20:03:59 CEST Kamil Konieczny wrote:
> From: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
>
> In case of tests which extensively use debugfs, tons of useless debug
> messages about opening a debugfs directory are emitted. If the test fails
> then important debug messages with details of the failure, interleaved
> with sequences of those useless messages, are hard to find and read.
>
> Replace igt_debug() with conditional igt_debug_on_f() emitting a message
> about debugfs directory path only if open() fails.
>
> v2: emit a message on NULL debugfs path
>
> Cc: Chris Wilson <chris.p.wilson@intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
As an author, I'm probably not expected to provide any kind of an ack, but
since nobody responded, I'm providing one, in case it helps you to apply the
change to upstream.
Acked-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Thanks,
Janusz
> ---
> lib/igt_debugfs.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
> index afde2da62..a7b54bae5 100644
> --- a/lib/igt_debugfs.c
> +++ b/lib/igt_debugfs.c
> @@ -208,13 +208,16 @@ char *igt_debugfs_path(int device, char *path, int
pathlen)
> */
> int igt_debugfs_dir(int device)
> {
> + int debugfs_dir_fd;
> char path[200];
>
> - if (!igt_debugfs_path(device, path, sizeof(path)))
> + if (igt_debug_on(!igt_debugfs_path(device, path, sizeof(path))))
> return -1;
>
> - igt_debug("Opening debugfs directory '%s'\n", path);
> - return open(path, O_RDONLY);
> + debugfs_dir_fd = open(path, O_RDONLY);
> + igt_debug_on_f(debugfs_dir_fd < 0, "path: %s\n", path);
> +
> + return debugfs_dir_fd;
> }
>
> /**
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-07 12:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-05 18:03 [igt-dev] [PATCH i-g-t] lib: Shut some excessive debug messages up Kamil Konieczny
2023-06-05 19:47 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-06 20:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-07 6:26 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
2023-06-07 12:09 ` Janusz Krzysztofik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox