Re: [igt-dev] [PATCH i-g-t 6/8] lib/igt_kmod: place KUnit tests on a subtest

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On Tue, 06 Jun 2023 10:41:40 +0200
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> wrote:

> > > > +	 * and for documentation.
> > > > +	 */
> > > > +	igt_subtest_with_dynamic("all-tests")    
> > > 
> > > Why can't we use module_name as subtest name?  
> > 
> > We can, but this preserves the old behavior. So, the existing documentation
> > won't break.  
> 
> Where is this old behavior documented?  In the current code I can't find any 
> occurrence of "test-all" other than inside igt_kmod.c:igt_ksleftest(), not 
> documented in any way.
> 
> Wasn't the old behavior a result of a limitation rather than a feature?

Take a look at igt_kselftests():

        igt_subtest_with_dynamic(filter ?: "all-tests") {
                igt_list_for_each_entry_safe(tl, tn, &tests, link) {
                        unsigned long taints;

                        igt_dynamic_f("%s", unfilter(filter, tl->name))
                                igt_kselftest_execute(&tst, tl, options, result);
                        free(tl);

The default when "filter" is not used is "all-tests".

Regards,
Mauro