From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 6/8] lib/igt_kmod: place KUnit tests on a subtest
Date: Wed, 7 Jun 2023 10:10:24 +0200 [thread overview]
Message-ID: <20230607101024.75ad82bc@maurocar-mobl2> (raw)
In-Reply-To: <2884858.e9J7NaK4W3@jkrzyszt-mobl2.ger.corp.intel.com>
On Tue, 06 Jun 2023 16:22:21 +0200
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> wrote:
> > We can use whatever other name, provided that the output of
> > --list-subtests will be identical to the dynamic subtest. If not,
> > build will fail when checking for documentation inconsistencies.
>
> AFAICU, that checking process compares subtest names found in a documentation,
> here the source code, as pointed by you in one of your previouse answers as
> the source of the documentation, against --list output. But that sounds
> weird. What a sophisticated code parser must be used to resolve subtest names
> potentially provided via expressions? Another compiler?
> Or is there another source of documentation, which I already asked you for a
> reference to, and you didn't clearly answered yet, used by the build process
> for that checking?
There's no other source of documentation. The documentation toolset
has a --check tool that calls the binaries using "--list" parameter,
comparing them with the documentation inside the source code.
So, for tests/drm_mm.c file, the documentation is on its source:
/**
* TEST: drm mm
* Description: Basic sanity check of DRM's range manager (struct drm_mm)
* Feature: mapping
* Run type: FULL
*
* SUBTEST: all-tests
*
* SUBTEST: all-tests@align
* Category: Infrastructure
* Description: drm_mm range manager SW validation
* Functionality: DRM memory mangemnt
* Test category: GEM_Legacy
...
It will run build/tests/drm_mm --list in order to compare "SUBTEST"
the fields. The ones with "@" are dynamic subtests and are currently
ignored, as --list is currently not capable of reporting dynamic
subtests.
Now, it is possible to change from "all-tests" to something else, but
such patch also needs to change it inside tests/drm_mm.c.
Regards,
Mauro
next prev parent reply other threads:[~2023-06-07 8:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 10:47 [igt-dev] [PATCH v5 i-g-t 0/8] Introduce KUnit Dominik Karol Piatkowski
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 1/8] lib/igt_kmod: rename kselftest functions to ktest Dominik Karol Piatkowski
2023-06-05 10:55 ` Mauro Carvalho Chehab
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 2/8] lib/igt_kmod.c: check if module is builtin before attempting to unload it Dominik Karol Piatkowski
2023-06-05 10:56 ` Mauro Carvalho Chehab
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 3/8] lib/igt_kmod: add compatibility for KUnit Dominik Karol Piatkowski
2023-06-05 10:59 ` Mauro Carvalho Chehab
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 4/8] tests: DRM selftests: switch to KUnit Dominik Karol Piatkowski
2023-06-05 11:00 ` Mauro Carvalho Chehab
2023-06-07 10:24 ` Janusz Krzysztofik
2023-06-07 12:45 ` Mauro Carvalho Chehab
2023-06-07 14:35 ` Janusz Krzysztofik
2023-06-07 14:39 ` Janusz Krzysztofik
2023-06-07 15:59 ` Mauro Carvalho Chehab
2023-06-07 17:40 ` Janusz Krzysztofik
2023-06-08 7:56 ` Mauro Carvalho Chehab
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 5/8] Change logic of ktap parser to run on a thread Dominik Karol Piatkowski
2023-06-05 11:03 ` Mauro Carvalho Chehab
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 6/8] lib/igt_kmod: place KUnit tests on a subtest Dominik Karol Piatkowski
2023-06-06 7:44 ` Janusz Krzysztofik
2023-06-06 8:21 ` Mauro Carvalho Chehab
2023-06-06 8:41 ` Janusz Krzysztofik
2023-06-06 9:18 ` Mauro Carvalho Chehab
2023-06-06 10:03 ` Janusz Krzysztofik
2023-06-06 13:57 ` Mauro Carvalho Chehab
2023-06-06 14:22 ` Janusz Krzysztofik
2023-06-07 8:10 ` Mauro Carvalho Chehab [this message]
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 7/8] kunit tests: add an optional name for the selftests Dominik Karol Piatkowski
2023-06-05 10:47 ` [igt-dev] [PATCH i-g-t 8/8] lib/igt_kmod: fix nesting igt_fixture in igt_subtest Dominik Karol Piatkowski
2023-06-05 11:05 ` Mauro Carvalho Chehab
2023-06-06 7:42 ` Janusz Krzysztofik
2023-06-08 13:31 ` Mauro Carvalho Chehab
2023-06-05 12:12 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce KUnit (rev5) Patchwork
2023-06-06 7:46 ` [igt-dev] [PATCH v5 i-g-t 0/8] Introduce KUnit Janusz Krzysztofik
2023-06-06 7:54 ` Piatkowski, Dominik Karol
2023-06-06 8:18 ` Mauro Carvalho Chehab
2023-06-06 8:35 ` Piatkowski, Dominik Karol
2023-06-07 14:07 ` Janusz Krzysztofik
2023-06-06 9:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for Introduce KUnit (rev5) Patchwork
2023-06-09 10:15 ` [igt-dev] [PATCH v5 i-g-t 0/8] Introduce KUnit Janusz Krzysztofik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230607101024.75ad82bc@maurocar-mobl2 \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=janusz.krzysztofik@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox