Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/xe/intel_bb: remove full-batch
@ 2023-06-07 11:32 Matthew Auld
  2023-06-07 13:02 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Matthew Auld @ 2023-06-07 11:32 UTC (permalink / raw)
  To: igt-dev

Currently this generates CAT errors due to over-fetch going beyond the
boundaries of the GTT. However we also don't use scratch pages by
default in Xe (hopeful plan is to get rid them completely), so no
address with full-batch will be valid if HW over-fetches into the next
page, unless we either inflate the batch size with padding, which
defeats the purpose of the test, or enable scratch pages, which is not
something we really want moving forward. With that rather just remove
full-batch on Xe.

Bspec: 60223
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/262
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 tests/intel-ci/xe-fast-feedback.testlist |  1 -
 tests/xe/xe_intel_bb.c                   | 31 ------------------------
 2 files changed, 32 deletions(-)

diff --git a/tests/intel-ci/xe-fast-feedback.testlist b/tests/intel-ci/xe-fast-feedback.testlist
index be243197a..fb5acd8a0 100644
--- a/tests/intel-ci/xe-fast-feedback.testlist
+++ b/tests/intel-ci/xe-fast-feedback.testlist
@@ -169,7 +169,6 @@ igt@xe_intel_bb@blit-simple
 igt@xe_intel_bb@create-in-region
 igt@xe_intel_bb@delta-check
 igt@xe_intel_bb@destroy-bb
-igt@xe_intel_bb@full-batch
 igt@xe_intel_bb@intel-bb-blit-none
 igt@xe_intel_bb@intel-bb-blit-x
 igt@xe_intel_bb@intel-bb-blit-y
diff --git a/tests/xe/xe_intel_bb.c b/tests/xe/xe_intel_bb.c
index ed3529a1b..29b5ececb 100644
--- a/tests/xe/xe_intel_bb.c
+++ b/tests/xe/xe_intel_bb.c
@@ -941,34 +941,6 @@ static void delta_check(struct buf_ops *bops)
 		     expected, val);
 }
 
-/**
- * SUBTEST: full-batch
- * Description: check bb totally filled is executing correct
- * Run type: FULL
- * TODO: change ``'Run type' == FULL`` to a better category
- */
-static void full_batch(struct buf_ops *bops)
-{
-	int xe = buf_ops_get_fd(bops);
-	struct intel_bb *ibb;
-	int i;
-
-	ibb = intel_bb_create(xe, PAGE_SIZE);
-	if (debug_bb)
-		intel_bb_set_debug(ibb, true);
-
-	for (i = 0; i < PAGE_SIZE / sizeof(uint32_t) - 1; i++)
-		intel_bb_out(ibb, 0);
-	intel_bb_emit_bbe(ibb);
-
-	igt_assert(intel_bb_offset(ibb) == PAGE_SIZE);
-	intel_bb_exec(ibb, intel_bb_offset(ibb),
-		      I915_EXEC_DEFAULT | I915_EXEC_NO_RELOC, true);
-	intel_bb_reset(ibb, false);
-
-	intel_bb_destroy(ibb);
-}
-
 /**
  * SUBTEST: render
  * Description: check intel-bb render pipeline
@@ -1166,9 +1138,6 @@ igt_main_args("dpib", NULL, help_str, opt_handler, NULL)
 	igt_subtest("delta-check")
 		delta_check(bops);
 
-	igt_subtest("full-batch")
-		full_batch(bops);
-
 	igt_subtest_with_dynamic("render") {
 		igt_require(xe_has_engine_class(xe, DRM_XE_ENGINE_CLASS_RENDER));
 
-- 
2.40.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2023-06-09  7:29 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-07 11:32 [igt-dev] [PATCH i-g-t] tests/xe/intel_bb: remove full-batch Matthew Auld
2023-06-07 13:02 ` [igt-dev] ✗ GitLab.Pipeline: warning for " Patchwork
2023-06-07 13:19 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-06-07 17:27 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
2023-06-08  9:01 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/xe/intel_bb: remove full-batch (rev2) Patchwork
2023-06-08  9:27 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-06-09  7:29 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox