From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
Date: Tue, 20 Jun 2023 23:55:08 +0530 [thread overview]
Message-ID: <20230620182508.6043-1-jeevan.b@intel.com> (raw)
basic-clone-single-crtc and invalid-clone-exclusive-crtc were not
part of dynamic subtest so tests were getting skipped. fixed the
test to execute skipping tests as expected.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_setmode.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index a611d938..b1883b10 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -647,20 +647,19 @@ static void test_one_combination(const struct test_config *tconf,
struct crtc_config crtcs[MAX_CRTCS];
int crtc_count;
bool config_valid;
+ int i, pos = 0;
+ char test_name[256];
setup_crtcs(tconf, cconfs, connector_count, crtcs,
&crtc_count, &config_valid);
- if (config_valid == !(tconf->flags & TEST_INVALID)) {
- int i, pos = 0;
- char test_name[256];
-
- for (i = 0; i < crtc_count; i++) {
- if (i > 0)
- pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
- pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
- }
+ for (i = 0; i < crtc_count; i++) {
+ if (i > 0)
+ pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
+ pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
+ }
+ if (config_valid == !(tconf->flags & TEST_INVALID)) {
for (i = 0; i < crtc_count; i++) {
struct crtc_config *crtc = &crtcs[i];
@@ -685,7 +684,8 @@ static void test_one_combination(const struct test_config *tconf,
igt_dynamic_f("%s", test_name)
test_crtc_config(tconf, crtcs, crtc_count);
- }
+ } else
+ igt_dynamic_f("%s", test_name)
out:
cleanup_crtcs(crtcs, crtc_count);
--
2.36.0
next reply other threads:[~2023-06-20 18:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 18:25 Jeevan B [this message]
2023-06-20 20:00 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_setmode: Fix dynamic subtests Patchwork
2023-06-21 3:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-21 16:43 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
-- strict thread matches above, loose matches on Subject: below --
2023-06-22 11:16 Jeevan B
2023-06-22 12:55 ` Kamil Konieczny
2023-06-22 13:02 ` B, Jeevan
2023-06-23 3:52 ` Modem, Bhanuprakash
2023-06-23 3:49 ` Modem, Bhanuprakash
2023-06-23 4:20 ` B, Jeevan
2023-06-23 4:49 ` B, Jeevan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230620182508.6043-1-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox