* [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
@ 2023-06-20 18:25 Jeevan B
2023-06-20 20:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Jeevan B @ 2023-06-20 18:25 UTC (permalink / raw)
To: igt-dev
basic-clone-single-crtc and invalid-clone-exclusive-crtc were not
part of dynamic subtest so tests were getting skipped. fixed the
test to execute skipping tests as expected.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_setmode.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index a611d938..b1883b10 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -647,20 +647,19 @@ static void test_one_combination(const struct test_config *tconf,
struct crtc_config crtcs[MAX_CRTCS];
int crtc_count;
bool config_valid;
+ int i, pos = 0;
+ char test_name[256];
setup_crtcs(tconf, cconfs, connector_count, crtcs,
&crtc_count, &config_valid);
- if (config_valid == !(tconf->flags & TEST_INVALID)) {
- int i, pos = 0;
- char test_name[256];
-
- for (i = 0; i < crtc_count; i++) {
- if (i > 0)
- pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
- pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
- }
+ for (i = 0; i < crtc_count; i++) {
+ if (i > 0)
+ pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
+ pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
+ }
+ if (config_valid == !(tconf->flags & TEST_INVALID)) {
for (i = 0; i < crtc_count; i++) {
struct crtc_config *crtc = &crtcs[i];
@@ -685,7 +684,8 @@ static void test_one_combination(const struct test_config *tconf,
igt_dynamic_f("%s", test_name)
test_crtc_config(tconf, crtcs, crtc_count);
- }
+ } else
+ igt_dynamic_f("%s", test_name)
out:
cleanup_crtcs(crtcs, crtc_count);
--
2.36.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_setmode: Fix dynamic subtests
2023-06-20 18:25 [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests Jeevan B
@ 2023-06-20 20:00 ` Patchwork
2023-06-21 3:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-21 16:43 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-06-20 20:00 UTC (permalink / raw)
To: Jeevan B; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 5954 bytes --]
== Series Details ==
Series: tests/kms_setmode: Fix dynamic subtests
URL : https://patchwork.freedesktop.org/series/119631/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13295 -> IGTPW_9222
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/index.html
Participating hosts (43 -> 42)
------------------------------
Additional (1): bat-dg1-8
Missing (2): fi-kbl-soraka fi-snb-2520m
New tests
---------
New tests have been introduced between CI_DRM_13295 and IGTPW_9222:
### New IGT tests (4) ###
* igt@kms_setmode@basic-clone-single-crtc@pipe-a-dp-1-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_setmode@basic-clone-single-crtc@pipe-a-hdmi-a-2-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_setmode@basic-clone-single-crtc@pipe-b-dp-1-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_setmode@basic-clone-single-crtc@pipe-b-hdmi-a-2-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9222 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][1] -> [DMESG-FAIL][2] ([i915#4258] / [i915#7913])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@migrate:
- bat-dg2-11: [PASS][3] -> [DMESG-WARN][4] ([i915#7699])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/bat-dg2-11/igt@i915_selftest@live@migrate.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-dg2-11/igt@i915_selftest@live@migrate.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-8: [PASS][5] -> [DMESG-WARN][6] ([i915#6367])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/bat-mtlp-8/igt@i915_selftest@live@slpc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-mtlp-8/igt@i915_selftest@live@slpc.html
- bat-rpls-1: NOTRUN -> [DMESG-WARN][7] ([i915#6367])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-rpls-1/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][8] ([i915#6687] / [i915#7978])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_mocs:
- bat-mtlp-6: [DMESG-FAIL][9] ([i915#7059]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [ABORT][11] ([i915#4983] / [i915#7911] / [i915#7920]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/bat-rpls-1/igt@i915_selftest@live@requests.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-rpls-1/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@slpc:
- bat-mtlp-6: [DMESG-WARN][13] ([i915#6367]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/bat-mtlp-6/igt@i915_selftest@live@slpc.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/bat-mtlp-6/igt@i915_selftest@live@slpc.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7920]: https://gitlab.freedesktop.org/drm/intel/issues/7920
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8513]: https://gitlab.freedesktop.org/drm/intel/issues/8513
[i915#8676]: https://gitlab.freedesktop.org/drm/intel/issues/8676
[i915#8678]: https://gitlab.freedesktop.org/drm/intel/issues/8678
[i915#8679]: https://gitlab.freedesktop.org/drm/intel/issues/8679
[i915#8698]: https://gitlab.freedesktop.org/drm/intel/issues/8698
[i915#8699]: https://gitlab.freedesktop.org/drm/intel/issues/8699
[i915#8700]: https://gitlab.freedesktop.org/drm/intel/issues/8700
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7340 -> IGTPW_9222
CI-20190529: 20190529
CI_DRM_13295: b2f9aed208bc3b745326d995c5a88dfac0ec9ff2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9222: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/index.html
IGT_7340: e975155e9167f0fed8f3da9c5b61de71d082b5c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/index.html
[-- Attachment #2: Type: text/html, Size: 6057 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_setmode: Fix dynamic subtests
2023-06-20 18:25 [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests Jeevan B
2023-06-20 20:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-21 3:00 ` Patchwork
2023-06-21 16:43 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
2 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2023-06-21 3:00 UTC (permalink / raw)
To: Jeevan B; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 35605 bytes --]
== Series Details ==
Series: tests/kms_setmode: Fix dynamic subtests
URL : https://patchwork.freedesktop.org/series/119631/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13295_full -> IGTPW_9222_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/index.html
Participating hosts (8 -> 7)
------------------------------
Missing (1): shard-rkl0
New tests
---------
New tests have been introduced between CI_DRM_13295_full and IGTPW_9222_full:
### New IGT tests (4) ###
* igt@kms_setmode@basic-clone-single-crtc@pipe-a-hdmi-a-1-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_setmode@basic-clone-single-crtc@pipe-b-hdmi-a-1-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_setmode@invalid-clone-exclusive-crtc@pipe-a-hdmi-a-1-pipe-b-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_setmode@invalid-clone-exclusive-crtc@pipe-b-hdmi-a-1-pipe-a-hdmi-a-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_9222_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- shard-rkl: NOTRUN -> [SKIP][1] ([i915#7456])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@debugfs_test@basic-hwmon.html
* igt@drm_fdinfo@most-busy-check-all@rcs0:
- shard-rkl: NOTRUN -> [FAIL][2] ([i915#7742])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@drm_fdinfo@most-busy-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-apl: [PASS][3] -> [ABORT][4] ([i915#7461] / [i915#8211] / [i915#8234])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl3/igt@gem_barrier_race@remote-request@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl6/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglu: NOTRUN -> [FAIL][5] ([i915#6268])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-8/igt@gem_ctx_exec@basic-nohangcheck.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-rkl: [PASS][6] -> [FAIL][7] ([i915#2842])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-7/igt@gem_exec_fair@basic-none@vcs0.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglu: NOTRUN -> [FAIL][8] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-9/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [PASS][9] -> [FAIL][10] ([i915#2842])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl2/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_exec_reloc@basic-cpu-read:
- shard-rkl: NOTRUN -> [SKIP][11] ([i915#3281]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@gem_exec_reloc@basic-cpu-read.html
* igt@gem_exec_suspend@basic-s4-devices@smem:
- shard-rkl: NOTRUN -> [ABORT][12] ([i915#7975] / [i915#8213])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@gem_exec_suspend@basic-s4-devices@smem.html
* igt@gem_lmem_swapping@massive-random:
- shard-rkl: NOTRUN -> [SKIP][13] ([i915#4613]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@gem_lmem_swapping@massive-random.html
* igt@gem_pwrite@basic-exhaustion:
- shard-tglu: NOTRUN -> [WARN][14] ([i915#2658])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-9/igt@gem_pwrite@basic-exhaustion.html
* igt@gem_pwrite@basic-random:
- shard-rkl: NOTRUN -> [SKIP][15] ([i915#3282])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@gem_pwrite@basic-random.html
* igt@gem_set_tiling_vs_blt@tiled-to-untiled:
- shard-rkl: NOTRUN -> [SKIP][16] ([i915#8411])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@gem_set_tiling_vs_blt@tiled-to-untiled.html
* igt@gem_userptr_blits@unsync-overlap:
- shard-rkl: NOTRUN -> [SKIP][17] ([i915#3297]) +1 similar issue
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-6/igt@gem_userptr_blits@unsync-overlap.html
* igt@gem_userptr_blits@vma-merge:
- shard-rkl: NOTRUN -> [FAIL][18] ([i915#3318])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@gem_userptr_blits@vma-merge.html
* igt@gen9_exec_parse@batch-invalid-length:
- shard-rkl: NOTRUN -> [SKIP][19] ([i915#2527]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@gen9_exec_parse@batch-invalid-length.html
* igt@i915_pm_backlight@basic-brightness:
- shard-rkl: NOTRUN -> [SKIP][20] ([i915#7561])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_pm_dc@dc6-psr:
- shard-tglu: NOTRUN -> [SKIP][21] ([i915#658])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-6/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_dc@dc9-dpms:
- shard-tglu: [PASS][22] -> [SKIP][23] ([i915#4281])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-tglu-4/igt@i915_pm_dc@dc9-dpms.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-8/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a:
- shard-rkl: [PASS][24] -> [SKIP][25] ([i915#1937] / [i915#4579])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
- shard-tglu: NOTRUN -> [FAIL][26] ([i915#3825])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-7/igt@i915_pm_lpsp@kms-lpsp@kms-lpsp-hdmi-a.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-rkl: [PASS][27] -> [SKIP][28] ([i915#1397])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-2/igt@i915_pm_rpm@modeset-non-lpsp.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglu: NOTRUN -> [SKIP][29] ([fdo#111644] / [i915#1397])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-8/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs:
- shard-rkl: NOTRUN -> [SKIP][30] ([i915#8502]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-hdmi-a-2-y-rc_ccs.html
* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-y-rc_ccs:
- shard-tglu: NOTRUN -> [SKIP][31] ([i915#8502]) +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-9/igt@kms_async_flips@async-flip-with-page-flip-events@pipe-c-hdmi-a-1-y-rc_ccs.html
* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][32] ([i915#5286]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@kms_big_fb@4-tiled-32bpp-rotate-90.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-tglu: NOTRUN -> [SKIP][33] ([fdo#111615] / [i915#5286])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-9/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-180-hflip.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-90:
- shard-rkl: NOTRUN -> [SKIP][34] ([fdo#111614] / [i915#3638])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_big_fb@x-tiled-32bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-rkl: NOTRUN -> [SKIP][35] ([fdo#110723])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_ccs@pipe-a-missing-ccs-buffer-4_tiled_mtl_mc_ccs:
- shard-rkl: NOTRUN -> [SKIP][36] ([i915#5354] / [i915#6095]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@kms_ccs@pipe-a-missing-ccs-buffer-4_tiled_mtl_mc_ccs.html
* igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs:
- shard-rkl: NOTRUN -> [SKIP][37] ([i915#3734] / [i915#5354] / [i915#6095]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_ccs@pipe-b-crc-primary-basic-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-rkl: NOTRUN -> [SKIP][38] ([i915#3886] / [i915#5354] / [i915#6095]) +2 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_ccs:
- shard-rkl: NOTRUN -> [SKIP][39] ([i915#5354]) +11 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@kms_ccs@pipe-c-bad-pixel-format-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglu: NOTRUN -> [SKIP][40] ([fdo#111615] / [i915#3689] / [i915#5354] / [i915#6095]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-5/igt@kms_ccs@pipe-c-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-4_tiled_mtl_mc_ccs:
- shard-tglu: NOTRUN -> [SKIP][41] ([i915#5354] / [i915#6095]) +2 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-3/igt@kms_ccs@pipe-c-missing-ccs-buffer-4_tiled_mtl_mc_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglu: NOTRUN -> [SKIP][42] ([i915#3742])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-7/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_chamelium_color@ctm-green-to-red:
- shard-tglu: NOTRUN -> [SKIP][43] ([fdo#111827])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-6/igt@kms_chamelium_color@ctm-green-to-red.html
* igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode:
- shard-rkl: NOTRUN -> [SKIP][44] ([i915#7828]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_chamelium_hpd@dp-hpd-enable-disable-mode.html
* igt@kms_cursor_crc@cursor-offscreen-512x512:
- shard-rkl: NOTRUN -> [SKIP][45] ([i915#3359])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_cursor_crc@cursor-offscreen-512x512.html
* igt@kms_cursor_crc@cursor-onscreen-512x170:
- shard-tglu: NOTRUN -> [SKIP][46] ([fdo#109279] / [i915#3359])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-8/igt@kms_cursor_crc@cursor-onscreen-512x170.html
* igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions:
- shard-tglu: NOTRUN -> [SKIP][47] ([fdo#109274]) +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-8/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic-transitions.html
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-rkl: NOTRUN -> [SKIP][48] ([fdo#111767] / [fdo#111825])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-6/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][49] -> [FAIL][50] ([i915#2346])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_cursor_legacy@single-bo@pipe-b:
- shard-rkl: [PASS][51] -> [INCOMPLETE][52] ([i915#8011])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-1/igt@kms_cursor_legacy@single-bo@pipe-b.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@kms_cursor_legacy@single-bo@pipe-b.html
* igt@kms_display_modes@extended-mode-basic:
- shard-rkl: NOTRUN -> [SKIP][53] ([i915#4579])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_display_modes@extended-mode-basic.html
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][54] ([i915#3804] / [i915#4579])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-2.html
* igt@kms_dsc@dsc-basic:
- shard-rkl: NOTRUN -> [SKIP][55] ([i915#3840] / [i915#4579])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-6/igt@kms_dsc@dsc-basic.html
* igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset:
- shard-tglu: NOTRUN -> [SKIP][56] ([fdo#109274] / [i915#3637]) +1 similar issue
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-3/igt@kms_flip@2x-flip-vs-dpms-off-vs-modeset.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][57] -> [FAIL][58] ([i915#79])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@2x-modeset-vs-vblank-race:
- shard-rkl: NOTRUN -> [SKIP][59] ([fdo#111825]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@kms_flip@2x-modeset-vs-vblank-race.html
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][60] -> [ABORT][61] ([i915#180])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl1/igt@kms_flip@flip-vs-suspend@a-dp1.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl4/igt@kms_flip@flip-vs-suspend@a-dp1.html
* igt@kms_flip@flip-vs-suspend@b-dp1:
- shard-apl: [PASS][62] -> [DMESG-WARN][63] ([i915#180])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl1/igt@kms_flip@flip-vs-suspend@b-dp1.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl4/igt@kms_flip@flip-vs-suspend@b-dp1.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode:
- shard-tglu: NOTRUN -> [SKIP][64] ([i915#2587] / [i915#2672] / [i915#4579])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-rkl: NOTRUN -> [SKIP][65] ([i915#2672] / [i915#4579])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-16bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt:
- shard-rkl: NOTRUN -> [SKIP][66] ([fdo#111825] / [i915#1825]) +10 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render:
- shard-tglu: NOTRUN -> [SKIP][67] ([fdo#109280]) +4 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-primscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt:
- shard-rkl: NOTRUN -> [SKIP][68] ([i915#3023]) +4 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-mmap-gtt.html
* igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-wc:
- shard-tglu: NOTRUN -> [SKIP][69] ([fdo#110189]) +4 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-7/igt@kms_frontbuffer_tracking@psr-rgb565-draw-mmap-wc.html
* igt@kms_hdr@static-swap:
- shard-tglu: NOTRUN -> [SKIP][70] ([i915#3555] / [i915#4579])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-10/igt@kms_hdr@static-swap.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1:
- shard-tglu: [PASS][71] -> [FAIL][72] ([i915#8292])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-tglu-4/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-5/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [FAIL][73] ([i915#8292])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1:
- shard-rkl: NOTRUN -> [SKIP][74] ([i915#5176]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@kms_plane_scaling@plane-downscale-with-modifiers-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][75] ([i915#5176]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-3/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-b-hdmi-a-1.html
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-hdmi-a-1:
- shard-tglu: NOTRUN -> [SKIP][76] ([i915#4579] / [i915#5176])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-3/igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-hdmi-a-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][77] ([i915#4579] / [i915#5176]) +3 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#4579]) +12 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-snb2/igt@kms_plane_scaling@plane-upscale-with-rotation-20x20@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][79] ([i915#5235])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-a-hdmi-a-2.html
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2:
- shard-rkl: NOTRUN -> [SKIP][80] ([i915#4579] / [i915#5235])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-b-hdmi-a-2.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][81] ([fdo#109271]) +14 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-snb1/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-hdmi-a-1.html
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-rkl: NOTRUN -> [SKIP][82] ([fdo#111068] / [i915#658]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-7/igt@kms_psr2_su@frontbuffer-xrgb8888.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-rkl: NOTRUN -> [SKIP][83] ([i915#1072]) +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-rkl: NOTRUN -> [SKIP][84] ([i915#5289])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_rotation_crc@primary-4-tiled-reflect-x-0.html
* igt@kms_setmode@basic@pipe-a-vga-1:
- shard-snb: NOTRUN -> [FAIL][85] ([i915#5465]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-snb6/igt@kms_setmode@basic@pipe-a-vga-1.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-rkl: NOTRUN -> [SKIP][86] ([i915#8623])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-6/igt@kms_tiled_display@basic-test-pattern.html
* igt@kms_vblank@pipe-c-accuracy-idle:
- shard-rkl: NOTRUN -> [SKIP][87] ([i915#4070] / [i915#6768]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_vblank@pipe-c-accuracy-idle.html
* igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend:
- shard-rkl: NOTRUN -> [SKIP][88] ([i915#4070] / [i915#533] / [i915#6768]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@kms_vblank@pipe-d-ts-continuation-dpms-suspend.html
* igt@kms_vrr@flip-dpms:
- shard-rkl: NOTRUN -> [SKIP][89] ([i915#3555] / [i915#4579])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@kms_vrr@flip-dpms.html
* igt@v3d/v3d_job_submission@array-job-submission:
- shard-rkl: NOTRUN -> [SKIP][90] ([fdo#109315]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-2/igt@v3d/v3d_job_submission@array-job-submission.html
* igt@v3d/v3d_wait_bo@bad-pad:
- shard-tglu: NOTRUN -> [SKIP][91] ([fdo#109315] / [i915#2575]) +2 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-3/igt@v3d/v3d_wait_bo@bad-pad.html
* igt@vc4/vc4_perfmon@create-two-perfmon:
- shard-rkl: NOTRUN -> [SKIP][92] ([i915#7711]) +3 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@vc4/vc4_perfmon@create-two-perfmon.html
#### Possible fixes ####
* igt@drm_fdinfo@most-busy-idle-check-all@rcs0:
- shard-rkl: [FAIL][93] ([i915#7742]) -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-7/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-6/igt@drm_fdinfo@most-busy-idle-check-all@rcs0.html
* igt@gem_barrier_race@remote-request@rcs0:
- shard-rkl: [ABORT][95] ([i915#8178]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-7/igt@gem_barrier_race@remote-request@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@gem_barrier_race@remote-request@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][97] ([i915#2842]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-glk9/igt@gem_exec_fair@basic-pace-share@rcs0.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-glk2/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [SKIP][99] ([fdo#109271]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl2/igt@i915_pm_dc@dc9-dpms.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl1/igt@i915_pm_dc@dc9-dpms.html
* igt@i915_pm_rpm@dpms-non-lpsp:
- {shard-dg1}: [SKIP][101] ([i915#1397]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-dg1-19/igt@i915_pm_rpm@dpms-non-lpsp.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-dg1-18/igt@i915_pm_rpm@dpms-non-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-rkl: [SKIP][103] ([i915#1397]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-4/igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [DMESG-FAIL][105] ([i915#5334]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-glk9/igt@i915_selftest@live@gt_heartbeat.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-glk8/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][107] ([i915#2346]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
- shard-glk: [FAIL][109] ([i915#2346]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-glk1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4:
- {shard-dg1}: [FAIL][111] ([i915#8151]) -> [PASS][112] +3 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-dg1-15/igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-dg1-14/igt@kms_plane_lowres@tiling-x@pipe-d-hdmi-a-4.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-tglu: [WARN][113] ([i915#2681]) -> [FAIL][114] ([i915#2681] / [i915#3591])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-tglu-3/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-tglu-5/igt@i915_pm_rc6_residency@rc6-idle@vcs0.html
* igt@kms_fbcon_fbt@psr-suspend:
- shard-rkl: [SKIP][115] ([fdo#110189] / [i915#3955]) -> [SKIP][116] ([i915#3955]) +1 similar issue
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-2/igt@kms_fbcon_fbt@psr-suspend.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-6/igt@kms_fbcon_fbt@psr-suspend.html
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-rkl: [SKIP][117] ([i915#4816]) -> [SKIP][118] ([i915#4070] / [i915#4816])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13295/shard-rkl-7/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/shard-rkl-1/igt@kms_multipipe_modeset@basic-max-pipe-crc-check.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111767]: https://bugs.freedesktop.org/show_bug.cgi?id=111767
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5465]: https://gitlab.freedesktop.org/drm/intel/issues/5465
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8151]: https://gitlab.freedesktop.org/drm/intel/issues/8151
[i915#8178]: https://gitlab.freedesktop.org/drm/intel/issues/8178
[i915#8211]: https://gitlab.freedesktop.org/drm/intel/issues/8211
[i915#8213]: https://gitlab.freedesktop.org/drm/intel/issues/8213
[i915#8234]: https://gitlab.freedesktop.org/drm/intel/issues/8234
[i915#8247]: https://gitlab.freedesktop.org/drm/intel/issues/8247
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
[i915#8516]: https://gitlab.freedesktop.org/drm/intel/issues/8516
[i915#8623]: https://gitlab.freedesktop.org/drm/intel/issues/8623
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7340 -> IGTPW_9222
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13295: b2f9aed208bc3b745326d995c5a88dfac0ec9ff2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9222: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/index.html
IGT_7340: e975155e9167f0fed8f3da9c5b61de71d082b5c7 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9222/index.html
[-- Attachment #2: Type: text/html, Size: 41000 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-20 18:25 [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests Jeevan B
2023-06-20 20:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-21 3:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-21 16:43 ` Kamil Konieczny
2 siblings, 0 replies; 11+ messages in thread
From: Kamil Konieczny @ 2023-06-21 16:43 UTC (permalink / raw)
To: igt-dev
Hi Jeevan,
On 2023-06-20 at 23:55:08 +0530, Jeevan B wrote:
> basic-clone-single-crtc and invalid-clone-exclusive-crtc were not
> part of dynamic subtest so tests were getting skipped. fixed the
> test to execute skipping tests as expected.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_setmode.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index a611d938..b1883b10 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -647,20 +647,19 @@ static void test_one_combination(const struct test_config *tconf,
> struct crtc_config crtcs[MAX_CRTCS];
> int crtc_count;
> bool config_valid;
> + int i, pos = 0;
> + char test_name[256];
>
> setup_crtcs(tconf, cconfs, connector_count, crtcs,
> &crtc_count, &config_valid);
>
> - if (config_valid == !(tconf->flags & TEST_INVALID)) {
> - int i, pos = 0;
> - char test_name[256];
> -
> - for (i = 0; i < crtc_count; i++) {
> - if (i > 0)
> - pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> - pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> - }
> + for (i = 0; i < crtc_count; i++) {
> + if (i > 0)
> + pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> + pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> + }
>
> + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> for (i = 0; i < crtc_count; i++) {
> struct crtc_config *crtc = &crtcs[i];
>
> @@ -685,7 +684,8 @@ static void test_one_combination(const struct test_config *tconf,
>
> igt_dynamic_f("%s", test_name)
----------------------------------- ^
This declares test name.
> test_crtc_config(tconf, crtcs, crtc_count);
----------------------- ^
And this executes it.
> - }
> + } else
> + igt_dynamic_f("%s", test_name)
Call to test is missing here.
Regards,
Kamil
>
> out:
> cleanup_crtcs(crtcs, crtc_count);
> --
> 2.36.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
@ 2023-06-22 11:16 Jeevan B
2023-06-22 12:55 ` Kamil Konieczny
2023-06-23 3:49 ` Modem, Bhanuprakash
0 siblings, 2 replies; 11+ messages in thread
From: Jeevan B @ 2023-06-22 11:16 UTC (permalink / raw)
To: igt-dev
basic-clone-single-crtc and invalid-clone-exclusive-crtc were not
part of dynamic subtest so tests were getting skipped. fixed the
test to execute skipping tests as expected.
v2: add missing call.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_setmode.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
index a611d938..96fb0b4b 100644
--- a/tests/kms_setmode.c
+++ b/tests/kms_setmode.c
@@ -647,20 +647,19 @@ static void test_one_combination(const struct test_config *tconf,
struct crtc_config crtcs[MAX_CRTCS];
int crtc_count;
bool config_valid;
+ int i, pos = 0;
+ char test_name[256];
setup_crtcs(tconf, cconfs, connector_count, crtcs,
&crtc_count, &config_valid);
- if (config_valid == !(tconf->flags & TEST_INVALID)) {
- int i, pos = 0;
- char test_name[256];
-
- for (i = 0; i < crtc_count; i++) {
- if (i > 0)
- pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
- pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
- }
+ for (i = 0; i < crtc_count; i++) {
+ if (i > 0)
+ pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
+ pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
+ }
+ if (config_valid == !(tconf->flags & TEST_INVALID)) {
for (i = 0; i < crtc_count; i++) {
struct crtc_config *crtc = &crtcs[i];
@@ -679,16 +678,17 @@ static void test_one_combination(const struct test_config *tconf,
((i > 0) && (crtc[i - 1].mode.hdisplay > MAX_HDISPLAY_PER_CRTC) &&
(abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
igt_info("Combo: %s is not possible with selected mode(s).\n", test_name);
- goto out;
+ cleanup_crtcs(crtcs, crtc_count);
+ return;
}
}
igt_dynamic_f("%s", test_name)
test_crtc_config(tconf, crtcs, crtc_count);
+ } else {
+ igt_dynamic_f("%s", test_name)
+ cleanup_crtcs(crtcs, crtc_count);
}
-
-out:
- cleanup_crtcs(crtcs, crtc_count);
}
static int assign_crtc_to_connectors(const struct test_config *tconf,
--
2.41.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-22 11:16 Jeevan B
@ 2023-06-22 12:55 ` Kamil Konieczny
2023-06-22 13:02 ` B, Jeevan
2023-06-23 3:49 ` Modem, Bhanuprakash
1 sibling, 1 reply; 11+ messages in thread
From: Kamil Konieczny @ 2023-06-22 12:55 UTC (permalink / raw)
To: igt-dev
Hi Jeevan,
On 2023-06-22 at 16:46:51 +0530, Jeevan B wrote:
> basic-clone-single-crtc and invalid-clone-exclusive-crtc were not
> part of dynamic subtest so tests were getting skipped. fixed the
> test to execute skipping tests as expected.
>
> v2: add missing call.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_setmode.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index a611d938..96fb0b4b 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -647,20 +647,19 @@ static void test_one_combination(const struct test_config *tconf,
> struct crtc_config crtcs[MAX_CRTCS];
> int crtc_count;
> bool config_valid;
> + int i, pos = 0;
> + char test_name[256];
>
> setup_crtcs(tconf, cconfs, connector_count, crtcs,
> &crtc_count, &config_valid);
>
> - if (config_valid == !(tconf->flags & TEST_INVALID)) {
> - int i, pos = 0;
> - char test_name[256];
> -
> - for (i = 0; i < crtc_count; i++) {
> - if (i > 0)
> - pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> - pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> - }
> + for (i = 0; i < crtc_count; i++) {
> + if (i > 0)
> + pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> + pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> + }
>
> + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> for (i = 0; i < crtc_count; i++) {
> struct crtc_config *crtc = &crtcs[i];
>
> @@ -679,16 +678,17 @@ static void test_one_combination(const struct test_config *tconf,
> ((i > 0) && (crtc[i - 1].mode.hdisplay > MAX_HDISPLAY_PER_CRTC) &&
> (abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
> igt_info("Combo: %s is not possible with selected mode(s).\n", test_name);
> - goto out;
> + cleanup_crtcs(crtcs, crtc_count);
> + return;
> }
> }
>
> igt_dynamic_f("%s", test_name)
> test_crtc_config(tconf, crtcs, crtc_count);
> + } else {
> + igt_dynamic_f("%s", test_name)
> + cleanup_crtcs(crtcs, crtc_count);
----------------------- ^
The name of function and its placement just before function end
suggest it is a cleanup, not a test.
I would advise going with git log and finding when these two
tests where executed with "normal", non-dynamic way and then
adjusting this function, or adding them as separate subtests
with proper configuration.
> }
> -
> -out:
> - cleanup_crtcs(crtcs, crtc_count);
Drop this change, looks dangereous.
Regards,
Kamil
> }
>
> static int assign_crtc_to_connectors(const struct test_config *tconf,
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-22 12:55 ` Kamil Konieczny
@ 2023-06-22 13:02 ` B, Jeevan
2023-06-23 3:52 ` Modem, Bhanuprakash
0 siblings, 1 reply; 11+ messages in thread
From: B, Jeevan @ 2023-06-22 13:02 UTC (permalink / raw)
To: Kamil Konieczny, igt-dev@lists.freedesktop.org
Hi Kamil,
> -----Original Message-----
> From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Sent: Thursday, June 22, 2023 6:26 PM
> To: igt-dev@lists.freedesktop.org
> Cc: B, Jeevan <jeevan.b@intel.com>; Modem, Bhanuprakash
> <bhanuprakash.modem@intel.com>
> Subject: Re: [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
>
> Hi Jeevan,
>
> On 2023-06-22 at 16:46:51 +0530, Jeevan B wrote:
> > basic-clone-single-crtc and invalid-clone-exclusive-crtc were not part
> > of dynamic subtest so tests were getting skipped. fixed the test to
> > execute skipping tests as expected.
> >
> > v2: add missing call.
> >
> > Signed-off-by: Jeevan B <jeevan.b@intel.com>
> > ---
> > tests/kms_setmode.c | 26 +++++++++++++-------------
> > 1 file changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index
> > a611d938..96fb0b4b 100644
> > --- a/tests/kms_setmode.c
> > +++ b/tests/kms_setmode.c
> > @@ -647,20 +647,19 @@ static void test_one_combination(const struct
> test_config *tconf,
> > struct crtc_config crtcs[MAX_CRTCS];
> > int crtc_count;
> > bool config_valid;
> > + int i, pos = 0;
> > + char test_name[256];
> >
> > setup_crtcs(tconf, cconfs, connector_count, crtcs,
> > &crtc_count, &config_valid);
> >
> > - if (config_valid == !(tconf->flags & TEST_INVALID)) {
> > - int i, pos = 0;
> > - char test_name[256];
> > -
> > - for (i = 0; i < crtc_count; i++) {
> > - if (i > 0)
> > - pos += snprintf(&test_name[pos],
> ARRAY_SIZE(test_name) - pos, "-");
> > - pos += get_test_name_str(&crtcs[i],
> &test_name[pos], ARRAY_SIZE(test_name) - pos);
> > - }
> > + for (i = 0; i < crtc_count; i++) {
> > + if (i > 0)
> > + pos += snprintf(&test_name[pos],
> ARRAY_SIZE(test_name) - pos, "-");
> > + pos += get_test_name_str(&crtcs[i], &test_name[pos],
> ARRAY_SIZE(test_name) - pos);
> > + }
> >
> > + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> > for (i = 0; i < crtc_count; i++) {
> > struct crtc_config *crtc = &crtcs[i];
> >
> > @@ -679,16 +678,17 @@ static void test_one_combination(const struct
> test_config *tconf,
> > ((i > 0) && (crtc[i - 1].mode.hdisplay >
> MAX_HDISPLAY_PER_CRTC) &&
> > (abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
> > igt_info("Combo: %s is not possible with
> selected mode(s).\n", test_name);
> > - goto out;
> > + cleanup_crtcs(crtcs, crtc_count);
> > + return;
> > }
> > }
> >
> > igt_dynamic_f("%s", test_name)
> > test_crtc_config(tconf, crtcs, crtc_count);
> > + } else {
> > + igt_dynamic_f("%s", test_name)
> > + cleanup_crtcs(crtcs, crtc_count);
> ----------------------- ^
> The name of function and its placement just before function end suggest it is
> a cleanup, not a test.
>
> I would advise going with git log and finding when these two tests where
> executed with "normal", non-dynamic way and then adjusting this function,
> or adding them as separate subtests with proper configuration.
>
This was before tests were converted to dynamic. (9f32d552afd7e7bb34b4cc3542e184b3be1a1dc8)
@@ -664,8 +684,19 @@ static void test_one_combination(const struct test_config *tconf,
setup_crtcs(tconf, cconfs, connector_count, crtcs,
&crtc_count, &config_valid);
- if (config_valid == !(tconf->flags & TEST_INVALID))
- test_crtc_config(tconf, crtcs, crtc_count);
+ if (config_valid == !(tconf->flags & TEST_INVALID)) {
+ int i, pos = 0;
+ char test_name[256];
+
+ for (i = 0; i < crtc_count; i++) {
+ if (i > 0)
+ pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
+ pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
+ }
+
+ igt_dynamic_f("%s", test_name)
+ test_crtc_config(tconf, crtcs, crtc_count);
+ }
cleanup_crtcs(crtcs, crtc_count);
}
> > }
> > -
> > -out:
> > - cleanup_crtcs(crtcs, crtc_count);
>
> Drop this change, looks dangereous.
>
> Regards,
> Kamil
>
> > }
> >
> > static int assign_crtc_to_connectors(const struct test_config *tconf,
> > --
> > 2.41.0
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-22 11:16 Jeevan B
2023-06-22 12:55 ` Kamil Konieczny
@ 2023-06-23 3:49 ` Modem, Bhanuprakash
2023-06-23 4:20 ` B, Jeevan
2023-06-23 4:49 ` B, Jeevan
1 sibling, 2 replies; 11+ messages in thread
From: Modem, Bhanuprakash @ 2023-06-23 3:49 UTC (permalink / raw)
To: Jeevan B, igt-dev
Hi Jeevan,
On Thu-22-06-2023 04:46 pm, Jeevan B wrote:
> basic-clone-single-crtc and invalid-clone-exclusive-crtc were not
> part of dynamic subtest so tests were getting skipped. fixed the
> test to execute skipping tests as expected.
What does it mean these tests are not part of dynamic subtests?
AFAIK, all basic-* tests are positive test cases & there are
corresponding negative test cases (invalid-*)
If any positive test executed, the corresponding negative test is
supposed to skip & vice versa.
Example:
https://intel-gfx-ci.01.org/tree/drm-tip/shards-all.html?testfilter=kms_setmode&hosts=shard-glk
- basic-close-single-crtc: SKIP
- invalid-clone-single-crtc: PASS
- clone-executive-crtc: PASS
- invalid-clone-executive-crtc: SKIP
>
> v2: add missing call.
>
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
> tests/kms_setmode.c | 26 +++++++++++++-------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c
> index a611d938..96fb0b4b 100644
> --- a/tests/kms_setmode.c
> +++ b/tests/kms_setmode.c
> @@ -647,20 +647,19 @@ static void test_one_combination(const struct test_config *tconf,
> struct crtc_config crtcs[MAX_CRTCS];
> int crtc_count;
> bool config_valid;
> + int i, pos = 0;
> + char test_name[256];
>
> setup_crtcs(tconf, cconfs, connector_count, crtcs,
> &crtc_count, &config_valid);
>
> - if (config_valid == !(tconf->flags & TEST_INVALID)) {
> - int i, pos = 0;
> - char test_name[256];
> -
> - for (i = 0; i < crtc_count; i++) {
> - if (i > 0)
> - pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> - pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> - }
> + for (i = 0; i < crtc_count; i++) {
> + if (i > 0)
> + pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> + pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> + }
>
> + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> for (i = 0; i < crtc_count; i++) {
> struct crtc_config *crtc = &crtcs[i];
>
> @@ -679,16 +678,17 @@ static void test_one_combination(const struct test_config *tconf,
> ((i > 0) && (crtc[i - 1].mode.hdisplay > MAX_HDISPLAY_PER_CRTC) &&
> (abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
> igt_info("Combo: %s is not possible with selected mode(s).\n", test_name);
> - goto out;
> + cleanup_crtcs(crtcs, crtc_count);
> + return;
> }
> }
>
> igt_dynamic_f("%s", test_name)
> test_crtc_config(tconf, crtcs, crtc_count);
> + } else {
> + igt_dynamic_f("%s", test_name)
> + cleanup_crtcs(crtcs, crtc_count);
We are supposed to execute the test, not a cleanup. This will always
throw the test result as PASS (which is bogus) without even testing
anything.
- Bhanu
> }
> -
> -out:
> - cleanup_crtcs(crtcs, crtc_count);
> }
>
> static int assign_crtc_to_connectors(const struct test_config *tconf,
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-22 13:02 ` B, Jeevan
@ 2023-06-23 3:52 ` Modem, Bhanuprakash
0 siblings, 0 replies; 11+ messages in thread
From: Modem, Bhanuprakash @ 2023-06-23 3:52 UTC (permalink / raw)
To: B, Jeevan, Kamil Konieczny, igt-dev@lists.freedesktop.org
Hi Jeevan,
On Thu-22-06-2023 06:32 pm, B, Jeevan wrote:
> Hi Kamil,
>
>> -----Original Message-----
>> From: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>> Sent: Thursday, June 22, 2023 6:26 PM
>> To: igt-dev@lists.freedesktop.org
>> Cc: B, Jeevan <jeevan.b@intel.com>; Modem, Bhanuprakash
>> <bhanuprakash.modem@intel.com>
>> Subject: Re: [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
>>
>> Hi Jeevan,
>>
>> On 2023-06-22 at 16:46:51 +0530, Jeevan B wrote:
>>> basic-clone-single-crtc and invalid-clone-exclusive-crtc were not part
>>> of dynamic subtest so tests were getting skipped. fixed the test to
>>> execute skipping tests as expected.
>>>
>>> v2: add missing call.
>>>
>>> Signed-off-by: Jeevan B <jeevan.b@intel.com>
>>> ---
>>> tests/kms_setmode.c | 26 +++++++++++++-------------
>>> 1 file changed, 13 insertions(+), 13 deletions(-)
>>>
>>> diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index
>>> a611d938..96fb0b4b 100644
>>> --- a/tests/kms_setmode.c
>>> +++ b/tests/kms_setmode.c
>>> @@ -647,20 +647,19 @@ static void test_one_combination(const struct
>> test_config *tconf,
>>> struct crtc_config crtcs[MAX_CRTCS];
>>> int crtc_count;
>>> bool config_valid;
>>> + int i, pos = 0;
>>> + char test_name[256];
>>>
>>> setup_crtcs(tconf, cconfs, connector_count, crtcs,
>>> &crtc_count, &config_valid);
>>>
>>> - if (config_valid == !(tconf->flags & TEST_INVALID)) {
>>> - int i, pos = 0;
>>> - char test_name[256];
>>> -
>>> - for (i = 0; i < crtc_count; i++) {
>>> - if (i > 0)
>>> - pos += snprintf(&test_name[pos],
>> ARRAY_SIZE(test_name) - pos, "-");
>>> - pos += get_test_name_str(&crtcs[i],
>> &test_name[pos], ARRAY_SIZE(test_name) - pos);
>>> - }
>>> + for (i = 0; i < crtc_count; i++) {
>>> + if (i > 0)
>>> + pos += snprintf(&test_name[pos],
>> ARRAY_SIZE(test_name) - pos, "-");
>>> + pos += get_test_name_str(&crtcs[i], &test_name[pos],
>> ARRAY_SIZE(test_name) - pos);
>>> + }
>>>
>>> + if (config_valid == !(tconf->flags & TEST_INVALID)) {
>>> for (i = 0; i < crtc_count; i++) {
>>> struct crtc_config *crtc = &crtcs[i];
>>>
>>> @@ -679,16 +678,17 @@ static void test_one_combination(const struct
>> test_config *tconf,
>>> ((i > 0) && (crtc[i - 1].mode.hdisplay >
>> MAX_HDISPLAY_PER_CRTC) &&
>>> (abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
>>> igt_info("Combo: %s is not possible with
>> selected mode(s).\n", test_name);
>>> - goto out;
>>> + cleanup_crtcs(crtcs, crtc_count);
>>> + return;
>>> }
>>> }
>>>
>>> igt_dynamic_f("%s", test_name)
>>> test_crtc_config(tconf, crtcs, crtc_count);
>>> + } else {
>>> + igt_dynamic_f("%s", test_name)
>>> + cleanup_crtcs(crtcs, crtc_count);
>> ----------------------- ^
>> The name of function and its placement just before function end suggest it is
>> a cleanup, not a test.
>>
>> I would advise going with git log and finding when these two tests where
>> executed with "normal", non-dynamic way and then adjusting this function,
>> or adding them as separate subtests with proper configuration.
>>
> This was before tests were converted to dynamic. (9f32d552afd7e7bb34b4cc3542e184b3be1a1dc8)
> @@ -664,8 +684,19 @@ static void test_one_combination(const struct test_config *tconf,
> setup_crtcs(tconf, cconfs, connector_count, crtcs,
> &crtc_count, &config_valid);
>
> - if (config_valid == !(tconf->flags & TEST_INVALID))
> - test_crtc_config(tconf, crtcs, crtc_count);
> + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> + int i, pos = 0;
> + char test_name[256];
> +
> + for (i = 0; i < crtc_count; i++) {
> + if (i > 0)
> + pos += snprintf(&test_name[pos], ARRAY_SIZE(test_name) - pos, "-");
> + pos += get_test_name_str(&crtcs[i], &test_name[pos], ARRAY_SIZE(test_name) - pos);
> + }
> +
> + igt_dynamic_f("%s", test_name)
> + test_crtc_config(tconf, crtcs, crtc_count);
> + }
What is wrong in this logic & how your patch fixes that?
- Bhanu
>
> cleanup_crtcs(crtcs, crtc_count);
> }
>
>>> }
>>> -
>>> -out:
>>> - cleanup_crtcs(crtcs, crtc_count);
>>
>> Drop this change, looks dangereous.
>>
>> Regards,
>> Kamil
>
>>
>>> }
>>>
>>> static int assign_crtc_to_connectors(const struct test_config *tconf,
>>> --
>>> 2.41.0
>>>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-23 3:49 ` Modem, Bhanuprakash
@ 2023-06-23 4:20 ` B, Jeevan
2023-06-23 4:49 ` B, Jeevan
1 sibling, 0 replies; 11+ messages in thread
From: B, Jeevan @ 2023-06-23 4:20 UTC (permalink / raw)
To: Modem, Bhanuprakash, igt-dev@lists.freedesktop.org
Hi Bhanu,
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Friday, June 23, 2023 9:20 AM
> To: B, Jeevan <jeevan.b@intel.com>; igt-dev@lists.freedesktop.org
> Cc: kamil.konieczny@linux.intel.com
> Subject: Re: [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
>
> Hi Jeevan,
>
> On Thu-22-06-2023 04:46 pm, Jeevan B wrote:
> > basic-clone-single-crtc and invalid-clone-exclusive-crtc were not part
> > of dynamic subtest so tests were getting skipped. fixed the test to
> > execute skipping tests as expected.
>
> What does it mean these tests are not part of dynamic subtests?
>
> AFAIK, all basic-* tests are positive test cases & there are corresponding
> negative test cases (invalid-*)
>
> If any positive test executed, the corresponding negative test is supposed to
> skip & vice versa.
>
> Example:
> https://intel-gfx-ci.01.org/tree/drm-tip/shards-
> all.html?testfilter=kms_setmode&hosts=shard-glk
>
>
> - basic-close-single-crtc: SKIP
> - invalid-clone-single-crtc: PASS
>
> - clone-executive-crtc: PASS
> - invalid-clone-executive-crtc: SKIP
>
> >
> > v2: add missing call.
> >
> > Signed-off-by: Jeevan B <jeevan.b@intel.com>
> > ---
> > tests/kms_setmode.c | 26 +++++++++++++-------------
> > 1 file changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index
> > a611d938..96fb0b4b 100644
> > --- a/tests/kms_setmode.c
> > +++ b/tests/kms_setmode.c
> > @@ -647,20 +647,19 @@ static void test_one_combination(const struct
> test_config *tconf,
> > struct crtc_config crtcs[MAX_CRTCS];
> > int crtc_count;
> > bool config_valid;
> > + int i, pos = 0;
> > + char test_name[256];
> >
> > setup_crtcs(tconf, cconfs, connector_count, crtcs,
> > &crtc_count, &config_valid);
> >
> > - if (config_valid == !(tconf->flags & TEST_INVALID)) {
> > - int i, pos = 0;
> > - char test_name[256];
> > -
> > - for (i = 0; i < crtc_count; i++) {
> > - if (i > 0)
> > - pos += snprintf(&test_name[pos],
> ARRAY_SIZE(test_name) - pos, "-");
> > - pos += get_test_name_str(&crtcs[i],
> &test_name[pos], ARRAY_SIZE(test_name) - pos);
> > - }
> > + for (i = 0; i < crtc_count; i++) {
> > + if (i > 0)
> > + pos += snprintf(&test_name[pos],
> ARRAY_SIZE(test_name) - pos, "-");
> > + pos += get_test_name_str(&crtcs[i], &test_name[pos],
> ARRAY_SIZE(test_name) - pos);
> > + }
> >
> > + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> > for (i = 0; i < crtc_count; i++) {
> > struct crtc_config *crtc = &crtcs[i];
> >
> > @@ -679,16 +678,17 @@ static void test_one_combination(const struct
> test_config *tconf,
> > ((i > 0) && (crtc[i - 1].mode.hdisplay >
> MAX_HDISPLAY_PER_CRTC) &&
> > (abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
> > igt_info("Combo: %s is not possible with
> selected mode(s).\n", test_name);
> > - goto out;
> > + cleanup_crtcs(crtcs, crtc_count);
> > + return;
> > }
> > }
> >
> > igt_dynamic_f("%s", test_name)
> > test_crtc_config(tconf, crtcs, crtc_count);
> > + } else {
> > + igt_dynamic_f("%s", test_name)
> > + cleanup_crtcs(crtcs, crtc_count);
>
> We are supposed to execute the test, not a cleanup. This will always throw
> the test result as PASS (which is bogus) without even testing anything.
Understood. I will make the change for this.
>
> - Bhanu
>
> > }
> > -
> > -out:
> > - cleanup_crtcs(crtcs, crtc_count);
> > }
> >
> > static int assign_crtc_to_connectors(const struct test_config
> > *tconf,
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
2023-06-23 3:49 ` Modem, Bhanuprakash
2023-06-23 4:20 ` B, Jeevan
@ 2023-06-23 4:49 ` B, Jeevan
1 sibling, 0 replies; 11+ messages in thread
From: B, Jeevan @ 2023-06-23 4:49 UTC (permalink / raw)
To: Modem, Bhanuprakash, igt-dev@lists.freedesktop.org
> -----Original Message-----
> From: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Sent: Friday, June 23, 2023 9:20 AM
> To: B, Jeevan <jeevan.b@intel.com>; igt-dev@lists.freedesktop.org
> Cc: kamil.konieczny@linux.intel.com
> Subject: Re: [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests
>
> Hi Jeevan,
>
> On Thu-22-06-2023 04:46 pm, Jeevan B wrote:
> > basic-clone-single-crtc and invalid-clone-exclusive-crtc were not part
> > of dynamic subtest so tests were getting skipped. fixed the test to
> > execute skipping tests as expected.
>
> What does it mean these tests are not part of dynamic subtests?
>
> AFAIK, all basic-* tests are positive test cases & there are corresponding
> negative test cases (invalid-*)
>
> If any positive test executed, the corresponding negative test is supposed to
> skip & vice versa.
Hi Bhanu,
Got it. Tests before converting to dynamic.
Starting subtest: basic-clone-single-crtc
Testing: basic-clone-single-crtc 2 connector combinations
Subtest basic-clone-single-crtc: SUCCESS (0.242s)
Starting subtest: invalid-clone-single-crtc
Testing: invalid-clone-single-crtc 2 connector combinations
Test id#1 CRTC count 1
CRTC[80] [Pipe A] Mode: 1920x1080@60Hz Connectors: DP-1[236], HDMI-A-2[255]
Test id#2 CRTC count 1
CRTC[131] [Pipe B] Mode: 1920x1080@60Hz Connectors: DP-1[236], HDMI-A-2[255]
Subtest invalid-clone-single-crtc: SUCCESS (0.371s)
Starting subtest: invalid-clone-exclusive-crtc
Testing: invalid-clone-exclusive-crtc 2 connector combinations
Subtest invalid-clone-exclusive-crtc: SUCCESS (0.330s)
Starting subtest: clone-exclusive-crtc
Testing: clone-exclusive-crtc 2 connector combinations
Test id#1 CRTC count 2
CRTC[80] [Pipe A] Mode: 3840x2160@60Hz Connectors: DP-1[236]
CRTC[131] [Pipe B] Mode: 1920x1200@60Hz Connectors: HDMI-A-2[255]
Test id#2 CRTC count 2
CRTC[131] [Pipe B] Mode: 3840x2160@60Hz Connectors: DP-1[236]
CRTC[80] [Pipe A] Mode: 1920x1200@60Hz Connectors: HDMI-A-2[255]
Subtest clone-exclusive-crtc: SUCCESS (1.282s)
So, when tests now started to skip these are getting caught by filters.
Should these skips be kept as expected behavior or should we modify tests ??
Thanks
Jeevan B
>
> Example:
> https://intel-gfx-ci.01.org/tree/drm-tip/shards-
> all.html?testfilter=kms_setmode&hosts=shard-glk
>
>
> - basic-close-single-crtc: SKIP
> - invalid-clone-single-crtc: PASS
>
> - clone-executive-crtc: PASS
> - invalid-clone-executive-crtc: SKIP
>
> >
> > v2: add missing call.
> >
> > Signed-off-by: Jeevan B <jeevan.b@intel.com>
> > ---
> > tests/kms_setmode.c | 26 +++++++++++++-------------
> > 1 file changed, 13 insertions(+), 13 deletions(-)
> >
> > diff --git a/tests/kms_setmode.c b/tests/kms_setmode.c index
> > a611d938..96fb0b4b 100644
> > --- a/tests/kms_setmode.c
> > +++ b/tests/kms_setmode.c
> > @@ -647,20 +647,19 @@ static void test_one_combination(const struct
> test_config *tconf,
> > struct crtc_config crtcs[MAX_CRTCS];
> > int crtc_count;
> > bool config_valid;
> > + int i, pos = 0;
> > + char test_name[256];
> >
> > setup_crtcs(tconf, cconfs, connector_count, crtcs,
> > &crtc_count, &config_valid);
> >
> > - if (config_valid == !(tconf->flags & TEST_INVALID)) {
> > - int i, pos = 0;
> > - char test_name[256];
> > -
> > - for (i = 0; i < crtc_count; i++) {
> > - if (i > 0)
> > - pos += snprintf(&test_name[pos],
> ARRAY_SIZE(test_name) - pos, "-");
> > - pos += get_test_name_str(&crtcs[i],
> &test_name[pos], ARRAY_SIZE(test_name) - pos);
> > - }
> > + for (i = 0; i < crtc_count; i++) {
> > + if (i > 0)
> > + pos += snprintf(&test_name[pos],
> ARRAY_SIZE(test_name) - pos, "-");
> > + pos += get_test_name_str(&crtcs[i], &test_name[pos],
> ARRAY_SIZE(test_name) - pos);
> > + }
> >
> > + if (config_valid == !(tconf->flags & TEST_INVALID)) {
> > for (i = 0; i < crtc_count; i++) {
> > struct crtc_config *crtc = &crtcs[i];
> >
> > @@ -679,16 +678,17 @@ static void test_one_combination(const struct
> test_config *tconf,
> > ((i > 0) && (crtc[i - 1].mode.hdisplay >
> MAX_HDISPLAY_PER_CRTC) &&
> > (abs(crtc->crtc_idx - crtcs[i - 1].crtc_idx) <= 1))) {
> > igt_info("Combo: %s is not possible with
> selected mode(s).\n", test_name);
> > - goto out;
> > + cleanup_crtcs(crtcs, crtc_count);
> > + return;
> > }
> > }
> >
> > igt_dynamic_f("%s", test_name)
> > test_crtc_config(tconf, crtcs, crtc_count);
> > + } else {
> > + igt_dynamic_f("%s", test_name)
> > + cleanup_crtcs(crtcs, crtc_count);
>
> We are supposed to execute the test, not a cleanup. This will always throw
> the test result as PASS (which is bogus) without even testing anything.
>
> - Bhanu
>
> > }
> > -
> > -out:
> > - cleanup_crtcs(crtcs, crtc_count);
> > }
> >
> > static int assign_crtc_to_connectors(const struct test_config
> > *tconf,
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-06-23 4:49 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-20 18:25 [igt-dev] [PATCH i-g-t] tests/kms_setmode: Fix dynamic subtests Jeevan B
2023-06-20 20:00 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-21 3:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-21 16:43 ` [igt-dev] [PATCH i-g-t] " Kamil Konieczny
-- strict thread matches above, loose matches on Subject: below --
2023-06-22 11:16 Jeevan B
2023-06-22 12:55 ` Kamil Konieczny
2023-06-22 13:02 ` B, Jeevan
2023-06-23 3:52 ` Modem, Bhanuprakash
2023-06-23 3:49 ` Modem, Bhanuprakash
2023-06-23 4:20 ` B, Jeevan
2023-06-23 4:49 ` B, Jeevan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox