From: Tom Chung <chiahsuan.chung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Tom Chung <chiahsuan.chung@amd.com>
Subject: [igt-dev] [PATCH i-g-t 3/8] tests/amdgpu/amd_freesync_video_mode: Fix wrong resolution setting during the test
Date: Wed, 21 Jun 2023 14:57:28 +0800 [thread overview]
Message-ID: <20230621065733.840316-3-chiahsuan.chung@amd.com> (raw)
In-Reply-To: <20230621065733.840316-1-chiahsuan.chung@amd.com>
[Why]
Some monitors may have different resolution for non-Freesync video mode and it may
cause the IGT test set to a wrong resolution during the test.
[How]
Check the resolution and use the same one during select the video mode.
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
---
tests/amdgpu/amd_freesync_video_mode.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/tests/amdgpu/amd_freesync_video_mode.c b/tests/amdgpu/amd_freesync_video_mode.c
index 8d809015f..a7b10886d 100644
--- a/tests/amdgpu/amd_freesync_video_mode.c
+++ b/tests/amdgpu/amd_freesync_video_mode.c
@@ -420,10 +420,11 @@ static drmModeModeInfo* select_mode(
case FSV_NON_FREESYNC_VIDEO_MODE:
for (i = 0; i < data->count_modes; i++) {
mode = &data->modes[i];
- if (mode->vrefresh == refresh_rate &&
- !is_freesync_video_mode(data, mode)) {
- break;
- }
+ if (mode->hdisplay == data->hdisplay &&
+ mode->vdisplay == data->vdisplay &&
+ mode->vrefresh == refresh_rate &&
+ !is_freesync_video_mode(data, mode))
+ break;
}
if (i >= data->count_modes)
mode = NULL;
--
2.34.1
next prev parent reply other threads:[~2023-06-21 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 6:57 [igt-dev] [PATCH i-g-t 1/8] tests/amdgpu/amd_freesync_video_mode: Adjust indents and spacing Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 2/8] tests/amdgpu/amd_freesync_video_mode: Fix memory leak and corruption Tom Chung
2023-06-21 6:57 ` Tom Chung [this message]
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 4/8] tests/amdgpu/amd_freesync_video_mode: Add some code from kms_vrr to resolve tearing issue Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 5/8] tests/amdgpu/amd_freesync_video_mode: Add/remove some test progress messages Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 6/8] tests/amdgpu/amd_freesync_video_mode: Move the vrr setting and display reset Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 7/8] tests/amdgpu/amd_freesync_video_mode: Fix wrong resolution setting for some panel Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 8/8] tests/amdgpu/amd_freesync_video_mode: Add amd_freesync_video_mode to meson.build Tom Chung
2023-06-21 14:55 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] tests/amdgpu/amd_freesync_video_mode: Adjust indents and spacing Patchwork
2023-06-22 3:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-28 20:57 ` [igt-dev] [PATCH i-g-t 1/8] " Kamil Konieczny
2023-06-28 21:06 ` vitaly prosyak
2023-06-29 10:16 ` Chung, ChiaHsuan (Tom)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621065733.840316-3-chiahsuan.chung@amd.com \
--to=chiahsuan.chung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox