From: Tom Chung <chiahsuan.chung@amd.com>
To: <igt-dev@lists.freedesktop.org>
Cc: Tom Chung <chiahsuan.chung@amd.com>
Subject: [igt-dev] [PATCH i-g-t 7/8] tests/amdgpu/amd_freesync_video_mode: Fix wrong resolution setting for some panel
Date: Wed, 21 Jun 2023 14:57:32 +0800 [thread overview]
Message-ID: <20230621065733.840316-7-chiahsuan.chung@amd.com> (raw)
In-Reply-To: <20230621065733.840316-1-chiahsuan.chung@amd.com>
[Why]
Some eDP panel VRR range only has 48-60Hz and it will cause some of the test failed.
[How]
Use the VRR range fps to select the mode for test.
Signed-off-by: Tom Chung <chiahsuan.chung@amd.com>
---
tests/amdgpu/amd_freesync_video_mode.c | 27 +++++++++++++++++---------
1 file changed, 18 insertions(+), 9 deletions(-)
diff --git a/tests/amdgpu/amd_freesync_video_mode.c b/tests/amdgpu/amd_freesync_video_mode.c
index 000de4c84..be8ff3221 100644
--- a/tests/amdgpu/amd_freesync_video_mode.c
+++ b/tests/amdgpu/amd_freesync_video_mode.c
@@ -420,11 +420,18 @@ static drmModeModeInfo* select_mode(
case FSV_NON_FREESYNC_VIDEO_MODE:
for (i = 0; i < data->count_modes; i++) {
mode = &data->modes[i];
- if (mode->hdisplay == data->hdisplay &&
- mode->vdisplay == data->vdisplay &&
- mode->vrefresh == refresh_rate &&
- !is_freesync_video_mode(data, mode))
- break;
+ if (refresh_rate > 0) {
+ if (mode->hdisplay == data->hdisplay &&
+ mode->vdisplay == data->vdisplay &&
+ mode->vrefresh == refresh_rate &&
+ !is_freesync_video_mode(data, mode))
+ break;
+ } else {
+ if (mode->hdisplay == data->hdisplay &&
+ mode->vdisplay == data->vdisplay &&
+ !is_freesync_video_mode(data, mode))
+ break;
+ }
}
if (i >= data->count_modes)
mode = NULL;
@@ -778,16 +785,18 @@ mode_transition(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t sce
mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
break;
case SCENE_LOWER_FSV_MODE_TO_HIGHER_FSV_MODE:
- mode_start = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
- mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 120);
+ mode_start = select_mode(data, FSV_FREESYNC_VIDEO_MODE,
+ data->vrr_range.min);
+ mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE,
+ data->vrr_range.max);
break;
case SCENE_NON_FSV_MODE_TO_FSV_MODE:
- mode_start = select_mode(data, FSV_NON_FREESYNC_VIDEO_MODE, 60);
+ mode_start = select_mode(data, FSV_NON_FREESYNC_VIDEO_MODE, 0);
mode_playback = select_mode(data, FSV_FREESYNC_VIDEO_MODE, 60);
break;
case SCENE_BASE_MODE_TO_CUSTUM_MODE:
mode_start = select_mode(data, FSV_BASE_MODE, 0);
- ret = prepare_custom_mode(data, &mode_custom, 72);
+ ret = prepare_custom_mode(data, &mode_custom, data->vrr_range.min);
igt_assert_eq(ret, 0);
mode_playback = &mode_custom;
break;
--
2.34.1
next prev parent reply other threads:[~2023-06-21 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 6:57 [igt-dev] [PATCH i-g-t 1/8] tests/amdgpu/amd_freesync_video_mode: Adjust indents and spacing Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 2/8] tests/amdgpu/amd_freesync_video_mode: Fix memory leak and corruption Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 3/8] tests/amdgpu/amd_freesync_video_mode: Fix wrong resolution setting during the test Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 4/8] tests/amdgpu/amd_freesync_video_mode: Add some code from kms_vrr to resolve tearing issue Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 5/8] tests/amdgpu/amd_freesync_video_mode: Add/remove some test progress messages Tom Chung
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 6/8] tests/amdgpu/amd_freesync_video_mode: Move the vrr setting and display reset Tom Chung
2023-06-21 6:57 ` Tom Chung [this message]
2023-06-21 6:57 ` [igt-dev] [PATCH i-g-t 8/8] tests/amdgpu/amd_freesync_video_mode: Add amd_freesync_video_mode to meson.build Tom Chung
2023-06-21 14:55 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/8] tests/amdgpu/amd_freesync_video_mode: Adjust indents and spacing Patchwork
2023-06-22 3:34 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-28 20:57 ` [igt-dev] [PATCH i-g-t 1/8] " Kamil Konieczny
2023-06-28 21:06 ` vitaly prosyak
2023-06-29 10:16 ` Chung, ChiaHsuan (Tom)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621065733.840316-7-chiahsuan.chung@amd.com \
--to=chiahsuan.chung@amd.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox