Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, kamil.konieczny@linux.intel.com
Cc: Maaz Mombasawala <mombasawalam@vmware.com>
Subject: [igt-dev] [V4 i-g-t 18/24] tests/vmwgfx: Use drm_close_driver() to close the drm fd
Date: Mon, 26 Jun 2023 10:40:25 +0530	[thread overview]
Message-ID: <20230626051031.2363120-19-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230626051031.2363120-1-bhanuprakash.modem@intel.com>

To close the drm file descriptor, use igt helper drm_close_driver()
instead of using close().

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Maaz Mombasawala <mombasawalam@vmware.com>
---
 lib/igt_vmwgfx.c                    | 2 +-
 tests/vmwgfx/vmw_execution_buffer.c | 2 +-
 tests/vmwgfx/vmw_ref_count.c        | 4 ++--
 tests/vmwgfx/vmw_surface_copy.c     | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/igt_vmwgfx.c b/lib/igt_vmwgfx.c
index 8fb6e553c..12b07b4a8 100644
--- a/lib/igt_vmwgfx.c
+++ b/lib/igt_vmwgfx.c
@@ -135,7 +135,7 @@ void vmw_svga_device_fini(struct vmw_svga_device *device)
 	vmw_bitvector_free(device->rt_view_bv);
 	vmw_bitvector_free(device->ds_view_bv);
 	vmw_bitvector_free(device->shader_bv);
-	close(device->drm_fd);
+	drm_close_driver(device->drm_fd);
 }
 
 bool vmw_save_data_as_png(struct vmw_surface *surface, void *data,
diff --git a/tests/vmwgfx/vmw_execution_buffer.c b/tests/vmwgfx/vmw_execution_buffer.c
index 42322514e..b89770b30 100644
--- a/tests/vmwgfx/vmw_execution_buffer.c
+++ b/tests/vmwgfx/vmw_execution_buffer.c
@@ -308,6 +308,6 @@ igt_main_args("st:", long_options, NULL, parse_options, NULL)
 	igt_fixture
 	{
 		vmw_ioctl_context_destroy(fd, cid);
-		close(fd);
+		drm_close_driver(fd);
 	}
 }
diff --git a/tests/vmwgfx/vmw_ref_count.c b/tests/vmwgfx/vmw_ref_count.c
index 013214ff0..da4b41f89 100644
--- a/tests/vmwgfx/vmw_ref_count.c
+++ b/tests/vmwgfx/vmw_ref_count.c
@@ -314,7 +314,7 @@ igt_main
 
 	igt_fixture
 	{
-		close(fd1);
-		close(fd2);
+		drm_close_driver(fd1);
+		drm_close_driver(fd2);
 	}
 }
diff --git a/tests/vmwgfx/vmw_surface_copy.c b/tests/vmwgfx/vmw_surface_copy.c
index d7c2711a8..57e90334f 100644
--- a/tests/vmwgfx/vmw_surface_copy.c
+++ b/tests/vmwgfx/vmw_surface_copy.c
@@ -336,6 +336,6 @@ igt_main
 	igt_fixture
 	{
 		vmw_ioctl_context_destroy(fd, cid);
-		close(fd);
+		drm_close_driver(fd);
 	}
 }
-- 
2.40.0

  parent reply	other threads:[~2023-06-26  5:17 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-26  5:10 [igt-dev] [V4 i-g-t 00/24] XE test cleanup to handle xe_device Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 01/24] lib: Interface to close the drm fd Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 02/24] lib: Cache xe_device at driver open/close level Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 03/24] lib/xe/xe_query: Add xe_config() interface Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 04/24] lib/igt_msm: Use drm_close_driver() to close the drm fd Bhanuprakash Modem
2023-06-26 16:17   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 05/24] tests/amdgpu: Close the fd before exit Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 06/24] tests/i915: " Bhanuprakash Modem
2023-06-26 16:19   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 07/24] tests/kms: " Bhanuprakash Modem
2023-06-26 16:22   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 08/24] tests/nouveau_crc: " Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 09/24] tests/xe/xe_gpgpu_fill: " Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 10/24] tests/i915/kms_mmap_write_crc: Avoid closing the closed fd Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 11/24] tests/i915/gem_close_race: Fix the double closure of fd Bhanuprakash Modem
2023-06-26 17:41   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 12/24] tests: Use drm_close_driver() to close the drm fd Bhanuprakash Modem
2023-06-26 16:13   ` Kamil Konieczny
2023-06-27  7:58     ` Modem, Bhanuprakash
2023-06-27  8:37   ` Bhanuprakash Modem
2023-06-27 16:26     ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 13/24] tests/amdgpu: " Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 14/24] tests/chamelium: " Bhanuprakash Modem
2023-06-26 16:16   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 15/24] tests/panfrost: " Bhanuprakash Modem
2023-06-26  6:59   ` Boris Brezillon
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 16/24] tests/v3d: " Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 17/24] tests/vc4: " Bhanuprakash Modem
2023-06-26  5:10 ` Bhanuprakash Modem [this message]
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 19/24] tests/kms: " Bhanuprakash Modem
2023-06-26 16:30   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 20/24] tests/xe: " Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 21/24] tests/i915: " Bhanuprakash Modem
2023-06-26 17:39   ` Kamil Konieczny
2023-06-27  8:38   ` Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 22/24] tests/xe/xe_debugfs: Use xe_config() helper to get the config Bhanuprakash Modem
2023-06-26 16:15   ` Kamil Konieczny
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 23/24] tests: Drop xe_device get/put from test level Bhanuprakash Modem
2023-06-26  5:10 ` [igt-dev] [V4 i-g-t 24/24] Revert "lib/igt_kms: Cache xe_device info for kms tests" Bhanuprakash Modem
2023-06-26  8:09 ` [igt-dev] ✓ Fi.CI.BAT: success for XE test cleanup to handle xe_device (rev7) Patchwork
2023-06-26 13:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-27 11:32 ` [igt-dev] ✓ Fi.CI.BAT: success for XE test cleanup to handle xe_device (rev9) Patchwork
2023-06-27 21:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-28  8:19   ` Modem, Bhanuprakash
2023-06-28  9:55     ` Yedireswarapu, SaiX Nandan
2023-06-28  9:21 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230626051031.2363120-19-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=mombasawalam@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox