From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, kamil.konieczny@linux.intel.com
Subject: [igt-dev] [V4 i-g-t 24/24] Revert "lib/igt_kms: Cache xe_device info for kms tests"
Date: Mon, 26 Jun 2023 10:40:31 +0530 [thread overview]
Message-ID: <20230626051031.2363120-25-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230626051031.2363120-1-bhanuprakash.modem@intel.com>
As this logic is moved to driver open/close level, this is
redundant, hence revert this logic.
This reverts commit 3e049d7c5048c8e4d0b0cfc22afca18e9e897e9a.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
---
lib/igt_kms.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 5341c6373..f2b0eed57 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -59,7 +59,6 @@
#include "igt_device.h"
#include "igt_sysfs.h"
#include "sw_sync.h"
-#include "xe/xe_query.h"
#ifdef HAVE_CHAMELIUM
#include "igt_chamelium.h"
#endif
@@ -2657,9 +2656,6 @@ void igt_display_require(igt_display_t *display, int drm_fd)
}
#endif
- if (is_xe_device(drm_fd))
- xe_device_get(drm_fd);
-
display->n_pipes = IGT_MAX_PIPES;
display->pipes = calloc(sizeof(igt_pipe_t), display->n_pipes);
igt_assert_f(display->pipes, "Failed to allocate memory for %d pipes\n", display->n_pipes);
@@ -2996,10 +2992,6 @@ static void igt_output_fini(igt_output_t *output)
void igt_display_fini(igt_display_t *display)
{
int i;
- int drm_fd = display->drm_fd;
-
- if (is_xe_device(drm_fd))
- xe_device_put(drm_fd);
for (i = 0; i < display->n_planes; ++i) {
igt_plane_t *plane = &display->planes[i];
--
2.40.0
next prev parent reply other threads:[~2023-06-26 5:17 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 5:10 [igt-dev] [V4 i-g-t 00/24] XE test cleanup to handle xe_device Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 01/24] lib: Interface to close the drm fd Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 02/24] lib: Cache xe_device at driver open/close level Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 03/24] lib/xe/xe_query: Add xe_config() interface Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 04/24] lib/igt_msm: Use drm_close_driver() to close the drm fd Bhanuprakash Modem
2023-06-26 16:17 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 05/24] tests/amdgpu: Close the fd before exit Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 06/24] tests/i915: " Bhanuprakash Modem
2023-06-26 16:19 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 07/24] tests/kms: " Bhanuprakash Modem
2023-06-26 16:22 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 08/24] tests/nouveau_crc: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 09/24] tests/xe/xe_gpgpu_fill: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 10/24] tests/i915/kms_mmap_write_crc: Avoid closing the closed fd Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 11/24] tests/i915/gem_close_race: Fix the double closure of fd Bhanuprakash Modem
2023-06-26 17:41 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 12/24] tests: Use drm_close_driver() to close the drm fd Bhanuprakash Modem
2023-06-26 16:13 ` Kamil Konieczny
2023-06-27 7:58 ` Modem, Bhanuprakash
2023-06-27 8:37 ` Bhanuprakash Modem
2023-06-27 16:26 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 13/24] tests/amdgpu: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 14/24] tests/chamelium: " Bhanuprakash Modem
2023-06-26 16:16 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 15/24] tests/panfrost: " Bhanuprakash Modem
2023-06-26 6:59 ` Boris Brezillon
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 16/24] tests/v3d: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 17/24] tests/vc4: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 18/24] tests/vmwgfx: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 19/24] tests/kms: " Bhanuprakash Modem
2023-06-26 16:30 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 20/24] tests/xe: " Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 21/24] tests/i915: " Bhanuprakash Modem
2023-06-26 17:39 ` Kamil Konieczny
2023-06-27 8:38 ` Bhanuprakash Modem
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 22/24] tests/xe/xe_debugfs: Use xe_config() helper to get the config Bhanuprakash Modem
2023-06-26 16:15 ` Kamil Konieczny
2023-06-26 5:10 ` [igt-dev] [V4 i-g-t 23/24] tests: Drop xe_device get/put from test level Bhanuprakash Modem
2023-06-26 5:10 ` Bhanuprakash Modem [this message]
2023-06-26 8:09 ` [igt-dev] ✓ Fi.CI.BAT: success for XE test cleanup to handle xe_device (rev7) Patchwork
2023-06-26 13:08 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-27 11:32 ` [igt-dev] ✓ Fi.CI.BAT: success for XE test cleanup to handle xe_device (rev9) Patchwork
2023-06-27 21:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-06-28 8:19 ` Modem, Bhanuprakash
2023-06-28 9:55 ` Yedireswarapu, SaiX Nandan
2023-06-28 9:21 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626051031.2363120-25-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox