From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t 2/2] tests/i915/kms_big_fb: take out blitter fallback path as it is replaced with Cairo
Date: Wed, 28 Jun 2023 15:52:58 +0300 [thread overview]
Message-ID: <20230628125258.6614-2-juhapekka.heikkila@gmail.com> (raw)
In-Reply-To: <20230628125258.6614-1-juhapekka.heikkila@gmail.com>
After adding Cairo fallback path blitter path will never be used anymore
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/i915/kms_big_fb.c | 19 ++++---------------
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 15bc35061..f8857d486 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -133,20 +133,9 @@ static void copy_pattern(data_t *data,
/*
* We expect the kernel to limit the max fb
* size/stride to something that can still
- * rendered with the blitter/render engine.
+ * rendered with the render engine.
*/
- if (data->render_copy) {
- data->render_copy(data->ibb, src, sx, sy, w, h, dst, dx, dy);
- } else {
- w = min(w, src_fb->width - sx);
- w = min(w, dst_fb->width - dx);
-
- h = min(h, src_fb->height - sy);
- h = min(h, dst_fb->height - dy);
-
- intel_bb_blt_copy(data->ibb, src, sx, sy, src->surface[0].stride,
- dst, dx, dy, dst->surface[0].stride, w, h, dst->bpp);
- }
+ data->render_copy(data->ibb, src, sx, sy, w, h, dst, dx, dy);
fini_buf(dst);
fini_buf(src);
@@ -976,10 +965,10 @@ igt_main
/*
* Gen3 render engine is limited to 2kx2k, whereas
- * the display engine can do 4kx4k. Use the blitter
+ * the display engine can do 4kx4k. Use fallback cairo path
* on gen3 to avoid exceeding the render engine limits.
* On gen2 we could use either, but let's go for the
- * blitter there as well.
+ * cairo there as well.
*/
if (intel_display_ver(data.devid) >= 4)
data.render_copy = igt_get_render_copyfunc(data.devid);
--
2.25.1
prev parent reply other threads:[~2023-06-28 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 12:52 [igt-dev] [PATCH i-g-t 1/2] tests/i915/kms_big_fb: Add Cairo fallback path for test image creation Juha-Pekka Heikkila
2023-06-28 12:52 ` Juha-Pekka Heikkila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230628125258.6614-2-juhapekka.heikkila@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox