[igt-dev] [PATCH i-g-t] scripts/test_list.py: fix __filter_subtest() logic

[igt-dev] [PATCH i-g-t] scripts/test_list.py: fix __filter_subtest() logic

[Mauro Carvalho Chehab]

From: Mauro Carvalho Chehab <mchehab@kernel.org>

The logic there is searching a value at the wrong place, as
"test" variable at the callers are a number inside doc.test
array. Fix it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 scripts/test_list.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/test_list.py b/scripts/test_list.py
index 19ed5e5467f5..4f580fb3de58 100755
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -569,7 +569,7 @@ class TestList:
 
             subtest_array = self.expand_subtest(fname, name, test, subtest_only)
             for subtest in subtest_array:
-                if self.__filter_subtest(test, subtest, True):
+                if self.__filter_subtest(self.doc[test], subtest, True):
                     continue
 
                 summary = subtest["Summary"]
@@ -851,7 +851,7 @@ class TestList:
         subtest_array.sort(key = lambda x : x.get('Summary'))
 
         for subtest in subtest_array:
-            if self.__filter_subtest(test, subtest, True):
+            if self.__filter_subtest(self.doc[test], subtest, True):
                 continue
 
             if sort_field:
-- 
2.40.1

[igt-dev] ✗ Fi.CI.BAT: failure for scripts/test_list.py: fix __filter_subtest() logic

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 8895 bytes --]

== Series Details ==

Series: scripts/test_list.py: fix __filter_subtest() logic
URL   : https://patchwork.freedesktop.org/series/120448/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13363 -> IGTPW_9375
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_9375 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_9375, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/index.html

Participating hosts (41 -> 40)
------------------------------

  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_9375:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@basic-rte:
    - fi-kbl-7567u:       [PASS][1] -> [FAIL][2] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-kbl-7567u/igt@i915_pm_rpm@basic-rte.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-kbl-7567u/igt@i915_pm_rpm@basic-rte.html

  
#### Warnings ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-cfl-8700k:       [FAIL][3] ([i915#7940]) -> [FAIL][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-cfl-8700k/igt@i915_pm_rpm@basic-pci-d3-state.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-cfl-8700k/igt@i915_pm_rpm@basic-pci-d3-state.html

  
Known issues
------------

  Here are the changes found in IGTPW_9375 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3@smem:
    - bat-rpls-2:         NOTRUN -> [ABORT][5] ([i915#6687] / [i915#7978] / [i915#8668])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-rpls-2/igt@gem_exec_suspend@basic-s3@smem.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-mtlp-8:         NOTRUN -> [SKIP][6] ([i915#4613]) +3 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@i915_pm_rpm@module-reload:
    - fi-rkl-11600:       [PASS][7] -> [FAIL][8] ([i915#7940])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-rkl-11600/igt@i915_pm_rpm@module-reload.html

  * igt@i915_pm_rps@basic-api:
    - bat-mtlp-8:         NOTRUN -> [SKIP][9] ([i915#6621])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-8:         NOTRUN -> [DMESG-FAIL][10] ([i915#7059])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@i915_selftest@live@gt_mocs.html

  * igt@i915_selftest@live@hangcheck:
    - bat-dg2-11:         [PASS][11] -> [ABORT][12] ([i915#7913])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-dg2-11/igt@i915_selftest@live@hangcheck.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-dg2-11/igt@i915_selftest@live@hangcheck.html

  * igt@i915_selftest@live@requests:
    - bat-mtlp-6:         [PASS][13] -> [ABORT][14] ([i915#7982])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-mtlp-6/igt@i915_selftest@live@requests.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-6/igt@i915_selftest@live@requests.html

  * igt@i915_selftest@live@slpc:
    - bat-rpls-2:         NOTRUN -> [DMESG-WARN][15] ([i915#6367])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-rpls-2/igt@i915_selftest@live@slpc.html

  * igt@i915_suspend@basic-s3-without-i915:
    - bat-mtlp-8:         NOTRUN -> [SKIP][16] ([i915#6645])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_chamelium_hpd@common-hpd-after-suspend:
    - bat-mtlp-8:         NOTRUN -> [SKIP][17] ([i915#7828])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@kms_chamelium_hpd@common-hpd-after-suspend.html

  * igt@prime_vgem@basic-fence-read:
    - bat-mtlp-8:         NOTRUN -> [SKIP][18] ([i915#3708]) +2 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@prime_vgem@basic-fence-read.html

  * igt@prime_vgem@basic-gtt:
    - bat-mtlp-8:         NOTRUN -> [SKIP][19] ([i915#3708] / [i915#4077]) +1 similar issue
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@prime_vgem@basic-gtt.html

  
#### Possible fixes ####

  * igt@i915_pm_rpm@basic-pci-d3-state:
    - fi-tgl-1115g4:      [FAIL][20] -> [PASS][21] +1 similar issue
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-tgl-1115g4/igt@i915_pm_rpm@basic-pci-d3-state.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-tgl-1115g4/igt@i915_pm_rpm@basic-pci-d3-state.html
    - fi-skl-guc:         [FAIL][22] -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-skl-guc/igt@i915_pm_rpm@basic-pci-d3-state.html
    - bat-mtlp-8:         [ABORT][24] ([i915#7077] / [i915#7977] / [i915#8668]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-mtlp-8/igt@i915_pm_rpm@basic-pci-d3-state.html

  * igt@i915_selftest@live@requests:
    - bat-rpls-2:         [ABORT][26] ([i915#4983] / [i915#7913]) -> [PASS][27]
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-rpls-2/igt@i915_selftest@live@requests.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-rpls-2/igt@i915_selftest@live@requests.html

  
#### Warnings ####

  * igt@i915_module_load@load:
    - bat-adlp-11:        [DMESG-WARN][28] ([i915#4423]) -> [ABORT][29] ([i915#4423])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/bat-adlp-11/igt@i915_module_load@load.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/bat-adlp-11/igt@i915_module_load@load.html

  * igt@i915_pm_rpm@basic-rte:
    - fi-kbl-8809g:       [FAIL][30] ([i915#7364]) -> [FAIL][31] ([i915#8843])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-kbl-8809g/igt@i915_pm_rpm@basic-rte.html
    - fi-kbl-guc:         [FAIL][32] ([i915#7364]) -> [FAIL][33] ([i915#8843])
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13363/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/fi-kbl-guc/igt@i915_pm_rpm@basic-rte.html

  
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
  [i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
  [i915#7059]: https://gitlab.freedesktop.org/drm/intel/issues/7059
  [i915#7077]: https://gitlab.freedesktop.org/drm/intel/issues/7077
  [i915#7364]: https://gitlab.freedesktop.org/drm/intel/issues/7364
  [i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
  [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
  [i915#7940]: https://gitlab.freedesktop.org/drm/intel/issues/7940
  [i915#7977]: https://gitlab.freedesktop.org/drm/intel/issues/7977
  [i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
  [i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#8843]: https://gitlab.freedesktop.org/drm/intel/issues/8843


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7377 -> IGTPW_9375

  CI-20190529: 20190529
  CI_DRM_13363: 9342b6645b02230f19f5abb923f3e01fca9e8bbd @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_9375: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/index.html
  IGT_7377: d1574543ba4bb322597345530053475c07be0eb9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9375/index.html

[-- Attachment #2: Type: text/html, Size: 10462 bytes --]

[igt-dev] ○ CI.xeBAT: info for scripts/test_list.py: fix __filter_subtest() logic

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

== Series Details ==

Series: scripts/test_list.py: fix __filter_subtest() logic
URL   : https://patchwork.freedesktop.org/series/120448/
State : info

== Summary ==

Participating hosts:
"bat-pvc-2n""bat-atsm-2n""bat-dg2-oem2n""bat-adlp-7n"Missing hosts results[0]:
Results: [IGTPW_9375](https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_9375/index.html)



[-- Attachment #2: Type: text/html, Size: 848 bytes --]

Re: [igt-dev] [PATCH i-g-t] scripts/test_list.py: fix __filter_subtest() logic

[Kamil Konieczny]

Hi Mauro,

On 2023-07-10 at 11:13:47 +0200, Mauro Carvalho Chehab wrote:
> From: Mauro Carvalho Chehab <mchehab@kernel.org>
> 
> The logic there is searching a value at the wrong place, as
> "test" variable at the callers are a number inside doc.test
> array. Fix it.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

Acked-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  scripts/test_list.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index 19ed5e5467f5..4f580fb3de58 100755
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -569,7 +569,7 @@ class TestList:
>  
>              subtest_array = self.expand_subtest(fname, name, test, subtest_only)
>              for subtest in subtest_array:
> -                if self.__filter_subtest(test, subtest, True):
> +                if self.__filter_subtest(self.doc[test], subtest, True):
>                      continue
>  
>                  summary = subtest["Summary"]
> @@ -851,7 +851,7 @@ class TestList:
>          subtest_array.sort(key = lambda x : x.get('Summary'))
>  
>          for subtest in subtest_array:
> -            if self.__filter_subtest(test, subtest, True):
> +            if self.__filter_subtest(self.doc[test], subtest, True):
>                  continue
>  
>              if sort_field:
> -- 
> 2.40.1
>