Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 10/13] scripts/test_list.py: add a check before deleting properties
Date: Wed, 12 Jul 2023 15:58:51 +0200	[thread overview]
Message-ID: <20230712135854.957128-11-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20230712135854.957128-1-mauro.chehab@linux.intel.com>

From: Mauro Carvalho Chehab <mchehab@kernel.org>

If the config file doesn't have empty _properties_, the current
logic causes an error. Well, if one is passing a dictionary via
config_dict, it may end using a simplified dict without any
_properties_ on it.

Add an extra check to avoid an error.

Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
 scripts/test_list.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/scripts/test_list.py b/scripts/test_list.py
index 9861306bd777..6e3cab206e82 100644
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -325,7 +325,8 @@ class TestList:
                 if sublevel_count[level - 1] == 1:
                     del item["_properties_"]["level"]
                     del item["_properties_"]["sublevel"]
-        del self.props["_properties_"]
+        if "_properties_" in self.props:
+            del self.props["_properties_"]
 
         has_implemented = False
         if not self.filenames:
-- 
2.40.1

  parent reply	other threads:[~2023-07-12 13:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 13:58 [igt-dev] [PATCH i-g-t v2 00/13] Make test_list.py more generic Mauro Carvalho Chehab
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 01/13] tests/intel-ci/meson.build: Generate and store an intel-ci.testlist Mauro Carvalho Chehab
2023-07-12 17:22   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 02/13] scripts/test_list.py: make the class more generic Mauro Carvalho Chehab
2023-07-12 17:29   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 03/13] scripts/test_list.py: rename the internal summary value Mauro Carvalho Chehab
2023-07-12 17:31   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 04/13] scripts/igt_doc.py: pass a single file when checking docs Mauro Carvalho Chehab
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 05/13] scripts/test_list.py: document what BAT stands for Mauro Carvalho Chehab
2023-07-12 18:30   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 06/13] scripts/test_list.py: close config file before start processing Mauro Carvalho Chehab
2023-07-12 18:38   ` Kamil Konieczny
2023-07-13  5:47     ` Mauro Carvalho Chehab
2023-07-13 10:20       ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 07/13] scripts/test_list.py: don't rely on file name to parse config Mauro Carvalho Chehab
2023-07-12 18:42   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 08/13] scripts/test_list.py: allow passing a config dict directly Mauro Carvalho Chehab
2023-07-12 18:45   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 09/13] scripts/igt_doc.py: use field names when create a TestList instance Mauro Carvalho Chehab
2023-07-12 18:50   ` Kamil Konieczny
2023-07-12 13:58 ` Mauro Carvalho Chehab [this message]
2023-07-12 18:52   ` [igt-dev] [PATCH i-g-t v2 10/13] scripts/test_list.py: add a check before deleting properties Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 11/13] scripts/test_list.py: filename arguments for print_ methods are optional Mauro Carvalho Chehab
2023-07-12 18:55   ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 12/13] scripts/test_list.py: skip some internal fields Mauro Carvalho Chehab
2023-07-12 19:12   ` Kamil Konieczny
2023-07-13  5:52     ` Mauro Carvalho Chehab
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 13/13] scripts/test_list.py: add support to return a string instead of print Mauro Carvalho Chehab
2023-07-12 14:44 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Make test_list.py more generic Patchwork
2023-07-13  9:12 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Make test_list.py more generic (rev2) Patchwork
2023-07-13 11:32 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Make test_list.py more generic (rev3) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230712135854.957128-11-mauro.chehab@linux.intel.com \
    --to=mauro.chehab@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox