From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 06/13] scripts/test_list.py: close config file before start processing
Date: Wed, 12 Jul 2023 15:58:47 +0200 [thread overview]
Message-ID: <20230712135854.957128-7-mauro.chehab@linux.intel.com> (raw)
In-Reply-To: <20230712135854.957128-1-mauro.chehab@linux.intel.com>
From: Mauro Carvalho Chehab <mchehab@kernel.org>
Reduce the identation level of the code which parses the config
file, as this can be done after closing the file.
This is a preparation for the next patch that will offer a different
way to pass the configuration.
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---
scripts/test_list.py | 114 +++++++++++++++++++++----------------------
1 file changed, 57 insertions(+), 57 deletions(-)
diff --git a/scripts/test_list.py b/scripts/test_list.py
index 0452be8d7994..cfcf6712bdc0 100644
--- a/scripts/test_list.py
+++ b/scripts/test_list.py
@@ -274,71 +274,71 @@ class TestList:
with open(config_fname, 'r', encoding='utf8') as handle:
self.config = json.load(handle)
- self.__add_field(None, 0, 0, self.config["fields"])
+ self.__add_field(None, 0, 0, self.config["fields"])
- sublevel_count = [ 0 ] * self.level_count
+ sublevel_count = [ 0 ] * self.level_count
- for field, item in self.props.items():
- if "sublevel" in item["_properties_"]:
- level = item["_properties_"]["level"]
- sublevel = item["_properties_"]["sublevel"]
- if sublevel > sublevel_count[level - 1]:
- sublevel_count[level - 1] = sublevel
+ for field, item in self.props.items():
+ if "sublevel" in item["_properties_"]:
+ level = item["_properties_"]["level"]
+ sublevel = item["_properties_"]["sublevel"]
+ if sublevel > sublevel_count[level - 1]:
+ sublevel_count[level - 1] = sublevel
- field_lc = field.lower()
- self.field_list[field_lc] = field
- field_plural = _plural(field_lc)
- if field_lc != field_plural:
- self.field_list[field_plural] = field
+ field_lc = field.lower()
+ self.field_list[field_lc] = field
+ field_plural = _plural(field_lc)
+ if field_lc != field_plural:
+ self.field_list[field_plural] = field
- if include_plan:
- self.props["Class"] = {}
- self.props["Class"]["_properties_"] = {}
- self.props["Class"]["_properties_"]["level"] = 1
- self.props["Class"]["_properties_"]["sublevel"] = sublevel_count[0] + 1
+ if include_plan:
+ self.props["Class"] = {}
+ self.props["Class"]["_properties_"] = {}
+ self.props["Class"]["_properties_"]["level"] = 1
+ self.props["Class"]["_properties_"]["sublevel"] = sublevel_count[0] + 1
- # Remove non-multilevel items, as we're only interested on
- # hierarchical item levels here
- for field, item in self.props.items():
- if "sublevel" in item["_properties_"]:
- level = item["_properties_"]["level"]
- if sublevel_count[level - 1] == 1:
- del item["_properties_"]["level"]
- del item["_properties_"]["sublevel"]
- del self.props["_properties_"]
+ # Remove non-multilevel items, as we're only interested on
+ # hierarchical item levels here
+ for field, item in self.props.items():
+ if "sublevel" in item["_properties_"]:
+ level = item["_properties_"]["level"]
+ if sublevel_count[level - 1] == 1:
+ del item["_properties_"]["level"]
+ del item["_properties_"]["sublevel"]
+ del self.props["_properties_"]
- has_implemented = False
- if not self.filenames:
- self.filenames = []
- exclude_files = []
- files = self.config["files"]
- exclude_file_glob = self.config.get("exclude_files", [])
- for cfg_file in exclude_file_glob:
- cfg_file = os.path.realpath(os.path.dirname(config_fname)) + "/" + cfg_file
- for fname in glob.glob(cfg_file):
- exclude_files.append(fname)
+ has_implemented = False
+ if not self.filenames:
+ self.filenames = []
+ exclude_files = []
+ files = self.config["files"]
+ exclude_file_glob = self.config.get("exclude_files", [])
+ for cfg_file in exclude_file_glob:
+ cfg_file = os.path.realpath(os.path.dirname(config_fname)) + "/" + cfg_file
+ for fname in glob.glob(cfg_file):
+ exclude_files.append(fname)
- for cfg_file in files:
- cfg_file = os.path.realpath(os.path.dirname(config_fname)) + "/" + cfg_file
- for fname in glob.glob(cfg_file):
- if fname in exclude_files:
- continue
- self.filenames.append(fname)
- has_implemented = True
- else:
- for cfg_file in self.filenames:
- if cfg_file:
- has_implemented = True
+ for cfg_file in files:
+ cfg_file = os.path.realpath(os.path.dirname(config_fname)) + "/" + cfg_file
+ for fname in glob.glob(cfg_file):
+ if fname in exclude_files:
+ continue
+ self.filenames.append(fname)
+ has_implemented = True
+ else:
+ for cfg_file in self.filenames:
+ if cfg_file:
+ has_implemented = True
- has_planned = False
- if include_plan and "planning_files" in self.config:
- implemented_class = "Implemented"
- files = self.config["planning_files"]
- for cfg_file in files:
- cfg_file = os.path.realpath(os.path.dirname(config_fname)) + "/" + cfg_file
- for fname in glob.glob(cfg_file):
- self.plan_filenames.append(fname)
- has_planned = True
+ has_planned = False
+ if include_plan and "planning_files" in self.config:
+ implemented_class = "Implemented"
+ files = self.config["planning_files"]
+ for cfg_file in files:
+ cfg_file = os.path.realpath(os.path.dirname(config_fname)) + "/" + cfg_file
+ for fname in glob.glob(cfg_file):
+ self.plan_filenames.append(fname)
+ has_planned = True
planned_class = None
if has_implemented:
--
2.40.1
next prev parent reply other threads:[~2023-07-12 13:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-12 13:58 [igt-dev] [PATCH i-g-t v2 00/13] Make test_list.py more generic Mauro Carvalho Chehab
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 01/13] tests/intel-ci/meson.build: Generate and store an intel-ci.testlist Mauro Carvalho Chehab
2023-07-12 17:22 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 02/13] scripts/test_list.py: make the class more generic Mauro Carvalho Chehab
2023-07-12 17:29 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 03/13] scripts/test_list.py: rename the internal summary value Mauro Carvalho Chehab
2023-07-12 17:31 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 04/13] scripts/igt_doc.py: pass a single file when checking docs Mauro Carvalho Chehab
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 05/13] scripts/test_list.py: document what BAT stands for Mauro Carvalho Chehab
2023-07-12 18:30 ` Kamil Konieczny
2023-07-12 13:58 ` Mauro Carvalho Chehab [this message]
2023-07-12 18:38 ` [igt-dev] [PATCH i-g-t v2 06/13] scripts/test_list.py: close config file before start processing Kamil Konieczny
2023-07-13 5:47 ` Mauro Carvalho Chehab
2023-07-13 10:20 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 07/13] scripts/test_list.py: don't rely on file name to parse config Mauro Carvalho Chehab
2023-07-12 18:42 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 08/13] scripts/test_list.py: allow passing a config dict directly Mauro Carvalho Chehab
2023-07-12 18:45 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 09/13] scripts/igt_doc.py: use field names when create a TestList instance Mauro Carvalho Chehab
2023-07-12 18:50 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 10/13] scripts/test_list.py: add a check before deleting properties Mauro Carvalho Chehab
2023-07-12 18:52 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 11/13] scripts/test_list.py: filename arguments for print_ methods are optional Mauro Carvalho Chehab
2023-07-12 18:55 ` Kamil Konieczny
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 12/13] scripts/test_list.py: skip some internal fields Mauro Carvalho Chehab
2023-07-12 19:12 ` Kamil Konieczny
2023-07-13 5:52 ` Mauro Carvalho Chehab
2023-07-12 13:58 ` [igt-dev] [PATCH i-g-t v2 13/13] scripts/test_list.py: add support to return a string instead of print Mauro Carvalho Chehab
2023-07-12 14:44 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Make test_list.py more generic Patchwork
2023-07-13 9:12 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Make test_list.py more generic (rev2) Patchwork
2023-07-13 11:32 ` [igt-dev] ✗ Fi.CI.BUILD: failure for Make test_list.py more generic (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230712135854.957128-7-mauro.chehab@linux.intel.com \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox