Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper.c: Fix helper to check dsc with output_format
Date: Mon,  7 Aug 2023 14:45:38 +0530	[thread overview]
Message-ID: <20230807091538.3172571-1-ankit.k.nautiyal@intel.com> (raw)

Fix the condition that checks whether DSC is supported with given
output format in is_dsc_output_format_supported.

Fixes: c365922f01c12 (tests/i915/kms_dsc: Enable validation for VDSC output formats)
Cc: Swati Sharma <swati2.sharma@intel.com>
Cc: Jouni H_gander <jouni.hogander@intel.com>
Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 tests/i915/kms_dsc_helper.c | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/tests/i915/kms_dsc_helper.c b/tests/i915/kms_dsc_helper.c
index ae59edb6bec9..160364cd28bf 100644
--- a/tests/i915/kms_dsc_helper.c
+++ b/tests/i915/kms_dsc_helper.c
@@ -133,13 +133,12 @@ static bool is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou
 bool is_dsc_output_format_supported(int drmfd, int disp_ver, igt_output_t *output,
 				    enum dsc_output_format output_format)
 {
-	if (!(igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format)) &&
-	     (is_dsc_output_format_supported_by_platform(disp_ver, output_format))) {
-		    igt_debug("DSC %s output format not supported on connector %s\n",
-			       kmstest_dsc_output_format_str(output_format),
-			       output->name);
-			return false;
-		}
+	if (is_dsc_output_format_supported_by_platform(disp_ver, output_format) &&
+	    igt_is_dsc_output_format_supported_by_sink(drmfd, output->name, output_format))
+		return true;
 
-	return true;
+	igt_debug("DSC %s output format not supported on connector %s\n",
+		  kmstest_dsc_output_format_str(output_format), output->name);
+
+	return false;
 }
-- 
2.40.1

             reply	other threads:[~2023-08-07  9:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07  9:15 Ankit Nautiyal [this message]
2023-08-07  9:47 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/i915/kms_dsc_helper.c: Fix helper to check dsc with output_format Patchwork
2023-08-07 10:21 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-07 10:23 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-07 10:42 ` [igt-dev] [PATCH i-g-t] " Hogander, Jouni
2023-08-07 13:55   ` Sharma, Swati2
2023-08-08  4:54     ` Nautiyal, Ankit K
2023-08-07 13:42 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230807091538.3172571-1-ankit.k.nautiyal@intel.com \
    --to=ankit.k.nautiyal@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox