Re: [igt-dev] [PATCH i-g-t] tests/i915/kms_dsc_helper.c: Fix helper to check dsc with output_format

["Nautiyal, Ankit K" <ankit.k.nautiyal@intel.com>]

Thanks for the reviews and comments.

I have addressed the comments and sent the updated version.

Seems like due to change in the subject line, patch work created a new link:

https://patchwork.freedesktop.org/series/122137/

Sorry for the confusion.


Regards,

Ankit

On 8/7/2023 7:25 PM, Sharma, Swati2 wrote:
> Hi Ankit,
>
> Thanks for the patch.
> Nitpick: Please remove .c from binary name in subject.
> Also, please add
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/9062
>
> Rest LGTM.
> Tested-by: Swati Sharma <swati2.sharma@intel.com>
>
> On 07-Aug-23 4:12 PM, Hogander, Jouni wrote:
>> On Mon, 2023-08-07 at 14:45 +0530, Ankit Nautiyal wrote:
>>> Fix the condition that checks whether DSC is supported with given
>>> output format in is_dsc_output_format_supported.
>>>
>>> Fixes: c365922f01c12 (tests/i915/kms_dsc: Enable validation for VDSC
>>> output formats)
>>> Cc: Swati Sharma <swati2.sharma@intel.com>
>>> Cc: Jouni H_gander <jouni.hogander@intel.com>
>>> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
>>
>> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>
>>> ---
>>>   tests/i915/kms_dsc_helper.c | 15 +++++++--------
>>>   1 file changed, 7 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/tests/i915/kms_dsc_helper.c
>>> b/tests/i915/kms_dsc_helper.c
>>> index ae59edb6bec9..160364cd28bf 100644
>>> --- a/tests/i915/kms_dsc_helper.c
>>> +++ b/tests/i915/kms_dsc_helper.c
>>> @@ -133,13 +133,12 @@ static bool
>>> is_dsc_output_format_supported_by_platform(int disp_ver, enum dsc_ou
>>>   bool is_dsc_output_format_supported(int drmfd, int disp_ver,
>>> igt_output_t *output,
>>>                                      enum dsc_output_format
>>> output_format)
>>>   {
>>> -       if (!(igt_is_dsc_output_format_supported_by_sink(drmfd,
>>> output->name, output_format)) &&
>>> - (is_dsc_output_format_supported_by_platform(disp_ver,
>>> output_format))) {
>>> -                   igt_debug("DSC %s output format not supported on
>>> connector %s\n",
>>> -
>>> kmstest_dsc_output_format_str(output_format),
>>> -                              output->name);
>>> -                       return false;
>>> -               }
>>> +       if (is_dsc_output_format_supported_by_platform(disp_ver,
>>> output_format) &&
>>> +           igt_is_dsc_output_format_supported_by_sink(drmfd, output-
>>>> name, output_format))
>>> +               return true;
>>>   -       return true;
>>> +       igt_debug("DSC %s output format not supported on connector
>>> %s\n",
>>> + kmstest_dsc_output_format_str(output_format),
>>> output->name);
>>> +
>>> +       return false;
>>>   }
>>