From: Melissa Wen <mwen@igalia.com>
To: igt-dev@lists.freedesktop.org,
Petri Latvala <adrinael@adrinael.net>,
Arkadiusz Hiler <arek@hiler.eu>,
Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>
Cc: Rob Clark <robdclark@chromium.org>, kernel-dev@igalia.com
Subject: [igt-dev] [PATCH i-g-t] tests/kms_atomic: remove zpos < N-planes assert
Date: Thu, 24 Aug 2023 15:15:24 -0100 [thread overview]
Message-ID: <20230824161524.14083-1-mwen@igalia.com> (raw)
Generalize plane-immutable-zpos test case by removing not-required
assert. zpos < N-planes is a condition not required by DRM
documentation. Removing this validation doesn't affect the test purpose
on verifying that planes with higher zpos always cover those with lower
zpos. Also, this assert doesn't fit driver's configuration where the
range of plane zpos is just defined by the plane type but its max value
doesn't need to be normalized to the number of planes in a CRTC, for
example, a cursor plane with the highest possible zpos value.
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
tests/kms_atomic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 22ddf5633..6986864f3 100644
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -458,7 +458,6 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
continue;
zpos = igt_plane_get_prop(temp, IGT_PLANE_ZPOS);
- igt_assert_lt(zpos, n_planes);
plane_ptr[zpos] = temp;
}
--
2.40.1
next reply other threads:[~2023-08-24 16:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 16:15 Melissa Wen [this message]
2023-08-24 18:24 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_atomic: remove zpos < N-planes assert Patchwork
2023-08-24 18:46 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-08-24 21:26 ` [igt-dev] [PATCH i-g-t] " Rodrigo Siqueira Jordao
2023-08-29 10:44 ` Melissa Wen
2023-08-25 6:33 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2023-08-25 14:55 ` Kamil Konieczny
2023-08-29 4:31 ` Yedireswarapu, SaiX Nandan
2023-08-29 3:58 ` Patchwork
2023-08-29 4:26 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824161524.14083-1-mwen@igalia.com \
--to=mwen@igalia.com \
--cc=adrinael@adrinael.net \
--cc=arek@hiler.eu \
--cc=ashutosh.dixit@intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=kernel-dev@igalia.com \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox