Re: [igt-dev] [PATCH i-g-t] tests/kms_atomic: remove zpos < N-planes assert

[Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>]

On 8/24/23 10:15, Melissa Wen wrote:
> Generalize plane-immutable-zpos test case by removing not-required
> assert. zpos < N-planes is a condition not required by DRM
> documentation. Removing this validation doesn't affect the test purpose
> on verifying that planes with higher zpos always cover those with lower
> zpos. Also, this assert doesn't fit driver's configuration where the
> range of plane zpos is just defined by the plane type but its max value
> doesn't need to be normalized to the number of planes in a CRTC, for
> example, a cursor plane with the highest possible zpos value.
> 
> Signed-off-by: Melissa Wen <mwen@igalia.com>
> ---
>   tests/kms_atomic.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
> index 22ddf5633..6986864f3 100644
> --- a/tests/kms_atomic.c
> +++ b/tests/kms_atomic.c
> @@ -458,7 +458,6 @@ plane_immutable_zpos(igt_display_t *display, igt_pipe_t *pipe,
>   			continue;
>   
>   		zpos = igt_plane_get_prop(temp, IGT_PLANE_ZPOS);
> -		igt_assert_lt(zpos, n_planes);
>   
>   		plane_ptr[zpos] = temp;
>   	}

lgtm,
Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>