Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [igt-dev] [i-g-t V2 09/16] tests/i915/kms_big_fb: Add tiling support for XE
Date: Fri, 25 Aug 2023 13:00:52 +0530	[thread overview]
Message-ID: <20230825073059.856371-10-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230825073059.856371-1-bhanuprakash.modem@intel.com>

Remove the tiling restrictions in Xe specific tests

V2: - Update XE blocklist
V3: - New patch for blocklist changes

Fixes: 34168d915 (tests/i915/kms_big_fb: Add XE support)
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
---
 tests/i915/kms_big_fb.c | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/tests/i915/kms_big_fb.c b/tests/i915/kms_big_fb.c
index 33008c40a..4f39a65f4 100644
--- a/tests/i915/kms_big_fb.c
+++ b/tests/i915/kms_big_fb.c
@@ -1111,10 +1111,6 @@ igt_main
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-overflow",
 			      modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_size_overflow(&data);
 		}
@@ -1124,10 +1120,6 @@ igt_main
 	for (int i = 1; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb-size-offset-overflow",
 			      modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_size_offset_overflow(&data);
 		}
@@ -1136,10 +1128,6 @@ igt_main
 	igt_describe("Sanity check if addfb ioctl works correctly for given size and strides of fb");
 	for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
 		igt_subtest_f("%s-addfb", modifiers[i].name) {
-			/* No tiling support in XE. */
-			igt_skip_on(is_xe_device(data.drm_fd) &&
-				    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 			data.modifier = modifiers[i].modifier;
 			test_addfb(&data);
 		}
@@ -1157,13 +1145,8 @@ igt_main
 				igt_describe("Sanity check if addfb ioctl works correctly for given "
 						"combination of modifier formats and rotation");
 				igt_subtest_f("%s-%dbpp-rotate-%d", modifiers[i].name,
-					      formats[j].bpp, rotations[k].angle) {
-					/* No tiling support in XE. */
-					igt_skip_on(is_xe_device(data.drm_fd) &&
-						    data.modifier != DRM_FORMAT_MOD_LINEAR);
-
+					      formats[j].bpp, rotations[k].angle)
 					test_scanout(&data);
-				}
 			}
 
 			igt_fixture
@@ -1205,10 +1188,6 @@ igt_main
 						igt_require(intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 5);
 						data.max_hw_fb_width = min(data.hw_stride / (formats[j].bpp >> 3), data.max_fb_width);
 
-						/* No tiling support in XE. */
-						igt_skip_on(is_xe_device(data.drm_fd) &&
-							    modifiers[i].modifier != DRM_FORMAT_MOD_LINEAR);
-
 						test_scanout(&data);
 					}
 
-- 
2.40.0

  parent reply	other threads:[~2023-08-25  7:39 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25  7:30 [igt-dev] [i-g-t V2 00/16] Add tiling support for display tests Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 01/16] lib: Add tiling support for XE Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 02/16] tests/kms_cursor_edge_walk: Fix intel specific checks Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 03/16] tests/kms_getfb: Extended ccs tests to support XE Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 04/16] tests/kms_addfb_basic: Add tiling support for XE Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 05/16] tests/kms_plane: " Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 06/16] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 07/16] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 08/16] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-08-25  7:30 ` Bhanuprakash Modem [this message]
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 10/16] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 11/16] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 12/16] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 13/16] tests/intel-ci: Drop tiling tests from xe blocklist Bhanuprakash Modem
2023-08-28  6:53   ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 14/16] tests/intel-ci: Update Xe BAT & blocklist for kms FBT Bhanuprakash Modem
2023-08-28  6:54   ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 15/16] tests/intel-ci: Add tiling tests to XE BAT Bhanuprakash Modem
2023-08-28  6:56   ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-08-25  7:30 ` [igt-dev] [i-g-t V2 16/16] HAX: Run tiling tests in XE fast-feedback Bhanuprakash Modem
2023-08-25  9:25 ` [igt-dev] ✗ CI.xeBAT: failure for Add tiling support for display tests (rev2) Patchwork
2023-08-25  9:40 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2023-08-29  5:39 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add tiling support for display tests (rev3) Patchwork
2023-08-29  6:01 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-08-29  6:04 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-29  8:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825073059.856371-10-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox