From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kunal Joshi <kunal1.joshi@intel.com>
Subject: [igt-dev] [i-g-t V2 01/16] lib: Add tiling support for XE
Date: Fri, 25 Aug 2023 13:00:44 +0530 [thread overview]
Message-ID: <20230825073059.856371-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20230825073059.856371-1-bhanuprakash.modem@intel.com>
Remove the tiling restrictions in all libraries those used by
the Xe driver.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
---
lib/igt_draw.c | 5 +----
lib/igt_fb.c | 8 ++++----
lib/intel_bufops.c | 13 +++++++++----
3 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 13b90702c..476778a13 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -677,14 +677,11 @@ static void draw_rect_blt(int fd, struct cmd_data *cmd_data,
int ver = intel_display_ver(devid);
int pitch;
- if (tiling)
- igt_require_i915(fd);
-
dst = create_buf(fd, cmd_data->bops, buf, tiling);
ibb = intel_bb_create(fd, PAGE_SIZE);
intel_bb_add_intel_buf(ibb, dst, true);
- if (is_i915_device(fd) && HAS_4TILE(intel_get_drm_devid(fd))) {
+ if (HAS_4TILE(intel_get_drm_devid(fd))) {
int buf_height = buf->size / buf->stride;
switch (buf->bpp) {
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 140711075..4b592825d 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -494,7 +494,7 @@ void igt_get_fb_tile_size(int fd, uint64_t modifier, int fb_bpp,
break;
case I915_FORMAT_MOD_Yf_TILED:
case I915_FORMAT_MOD_Yf_TILED_CCS:
- igt_require_i915(fd);
+ igt_require_intel(fd);
switch (fb_bpp) {
case 8:
*width_ret = 64;
@@ -767,7 +767,7 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
(fb->plane_bpp[plane] / 8);
if (fb->modifier != DRM_FORMAT_MOD_LINEAR &&
- is_i915_device(fb->fd) &&
+ is_intel_device(fb->fd) &&
intel_display_ver(intel_get_drm_devid(fb->fd)) <= 3) {
uint32_t stride;
@@ -836,7 +836,7 @@ static uint32_t calc_plane_stride(struct igt_fb *fb, int plane)
static uint64_t calc_plane_size(struct igt_fb *fb, int plane)
{
if (fb->modifier != DRM_FORMAT_MOD_LINEAR &&
- is_i915_device(fb->fd) &&
+ is_intel_device(fb->fd) &&
intel_display_ver(intel_get_drm_devid(fb->fd)) <= 3) {
uint64_t size = (uint64_t) fb->strides[plane] *
fb->plane_height[plane];
@@ -913,7 +913,7 @@ static unsigned int get_plane_alignment(struct igt_fb *fb, int color_plane)
unsigned int tile_row_size;
unsigned int alignment;
- if (!(is_i915_device(fb->fd) &&
+ if (!(is_intel_device(fb->fd) &&
is_gen12_ccs_modifier(fb->modifier) &&
is_yuv_semiplanar_plane(fb, color_plane)))
return 0;
diff --git a/lib/intel_bufops.c b/lib/intel_bufops.c
index 524757933..2c91adb88 100644
--- a/lib/intel_bufops.c
+++ b/lib/intel_bufops.c
@@ -927,7 +927,8 @@ static void __intel_buf_init(struct buf_ops *bops,
/* Store gem bo size */
buf->bo_size = size;
- set_hw_tiled(bops, buf);
+ if (bops->driver == INTEL_DRIVER_I915)
+ set_hw_tiled(bops, buf);
}
/**
@@ -1502,14 +1503,18 @@ static struct buf_ops *__buf_ops_create(int fd, bool check_idempotency)
bops->intel_gen, bops->supported_tiles,
bops->driver == INTEL_DRIVER_I915 ? "i915" : "xe");
- /* No tiling support in XE. */
if (bops->driver == INTEL_DRIVER_XE) {
- bops->supported_hw_tiles = TILE_NONE;
-
bops->linear_to_x = copy_linear_to_x;
bops->x_to_linear = copy_x_to_linear;
bops->linear_to_y = copy_linear_to_y;
bops->y_to_linear = copy_y_to_linear;
+ bops->linear_to_tile4 = copy_linear_to_tile4;
+ bops->tile4_to_linear = copy_tile4_to_linear;
+
+ bops->linear_to_yf = NULL;
+ bops->yf_to_linear = NULL;
+ bops->linear_to_ys = NULL;
+ bops->ys_to_linear = NULL;
return bops;
}
--
2.40.0
next prev parent reply other threads:[~2023-08-25 7:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 7:30 [igt-dev] [i-g-t V2 00/16] Add tiling support for display tests Bhanuprakash Modem
2023-08-25 7:30 ` Bhanuprakash Modem [this message]
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 02/16] tests/kms_cursor_edge_walk: Fix intel specific checks Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 03/16] tests/kms_getfb: Extended ccs tests to support XE Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 04/16] tests/kms_addfb_basic: Add tiling support for XE Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 05/16] tests/kms_plane: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 06/16] tests/kms_plane_lowres: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 07/16] tests/kms_plane_scaling: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 08/16] tests/kms_rotation_crc: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 09/16] tests/i915/kms_big_fb: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 10/16] tests/i915/kms_draw_crc: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 11/16] tests/i915/kms_flip_scaled_crc: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 12/16] tests/i915/kms_flip_tiling: " Bhanuprakash Modem
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 13/16] tests/intel-ci: Drop tiling tests from xe blocklist Bhanuprakash Modem
2023-08-28 6:53 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 14/16] tests/intel-ci: Update Xe BAT & blocklist for kms FBT Bhanuprakash Modem
2023-08-28 6:54 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 15/16] tests/intel-ci: Add tiling tests to XE BAT Bhanuprakash Modem
2023-08-28 6:56 ` [igt-dev] [i-g-t, V2, " Joshi, Kunal1
2023-08-25 7:30 ` [igt-dev] [i-g-t V2 16/16] HAX: Run tiling tests in XE fast-feedback Bhanuprakash Modem
2023-08-25 9:25 ` [igt-dev] ✗ CI.xeBAT: failure for Add tiling support for display tests (rev2) Patchwork
2023-08-25 9:40 ` [igt-dev] ✗ Fi.CI.BAT: " Patchwork
2023-08-29 5:39 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add tiling support for display tests (rev3) Patchwork
2023-08-29 6:01 ` [igt-dev] ✗ CI.xeBAT: failure " Patchwork
2023-08-29 6:04 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-29 8:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825073059.856371-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox