* [igt-dev] [PATCH i-g-t v2 0/2] IGT XE documentation cleanup
@ 2023-09-06 8:56 Katarzyna Dec
2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests Katarzyna Dec
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Katarzyna Dec @ 2023-09-06 8:56 UTC (permalink / raw)
To: igt-dev; +Cc: Gandi Ramadevi
Let's add missing documentation fileds that are causing warnings.
Some tests documentation needed changes to have more accurate naming.
Let's mark Negative and Stress tests.
Adding missing 'Run type' and 'Test category' for remaining test.
v2: Fix few typos and add xe_mmap to VMA subcategory
Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Gandi Ramadevi <ramadevi.gandi@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Katarzyna Dec (2):
tests/intel: Add missing documentation fields for tests
test/xe: Clean up of test documentation
tests/core_hotunplug.c | 1 +
tests/intel/xe_ccs.c | 7 +-
tests/intel/xe_create.c | 8 +-
tests/intel/xe_debugfs.c | 2 +-
tests/intel/xe_dma_buf_sync.c | 5 +-
tests/intel/xe_evict.c | 154 +++++++++++++++++++++++------
tests/intel/xe_exec_balancer.c | 11 +++
tests/intel/xe_exec_basic.c | 7 +-
tests/intel/xe_exec_compute_mode.c | 5 +-
tests/intel/xe_exec_fault_mode.c | 9 +-
tests/intel/xe_exercise_blt.c | 6 +-
tests/intel/xe_intel_bb.c | 2 +-
tests/intel/xe_media_fill.c | 1 +
tests/intel/xe_mmap.c | 10 +-
tests/intel/xe_mmio.c | 3 +-
tests/intel/xe_noexec_ping_pong.c | 25 +++--
tests/intel/xe_pm.c | 1 +
tests/intel/xe_query.c | 14 ++-
tests/intel/xe_spin_batch.c | 2 +-
tests/intel/xe_sysfs_scheduler.c | 5 +-
tests/intel/xe_sysfs_tile.c | 3 +
tests/intel/xe_uevent.c | 3 +
tests/intel/xe_vm.c | 25 ++++-
23 files changed, 246 insertions(+), 63 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests 2023-09-06 8:56 [igt-dev] [PATCH i-g-t v2 0/2] IGT XE documentation cleanup Katarzyna Dec @ 2023-09-06 8:56 ` Katarzyna Dec 2023-09-06 9:11 ` Mauro Carvalho Chehab 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 2/2] test/xe: Clean up of test documentation Katarzyna Dec 2023-09-06 9:40 ` [igt-dev] ✗ Fi.CI.BAT: failure for IGT XE documentation cleanup (rev2) Patchwork 2 siblings, 1 reply; 6+ messages in thread From: Katarzyna Dec @ 2023-09-06 8:56 UTC (permalink / raw) To: igt-dev; +Cc: Gandi Ramadevi Adding missing documentation for tests that show warnings during building IGTs. v2" s/Full/FULL in xe_sysfs_tile & xe_uevent tests Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Gandi Ramadevi <ramadevi.gandi@intel.com> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> --- tests/intel/xe_pm.c | 1 + tests/intel/xe_sysfs_scheduler.c | 1 + tests/intel/xe_sysfs_tile.c | 3 +++ tests/intel/xe_uevent.c | 3 +++ tests/intel/xe_vm.c | 1 + 5 files changed, 9 insertions(+) diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c index 2ec108d14..d31049d19 100644 --- a/tests/intel/xe_pm.c +++ b/tests/intel/xe_pm.c @@ -366,6 +366,7 @@ NULL)); /** * SUBTEST: vram-d3cold-threshold + * Functionality: pm - d3cold * Description: * Validate whether card is limited to d3hot while vram used * is greater than vram_d3cold_threshold. diff --git a/tests/intel/xe_sysfs_scheduler.c b/tests/intel/xe_sysfs_scheduler.c index 0315ce915..ec2190113 100644 --- a/tests/intel/xe_sysfs_scheduler.c +++ b/tests/intel/xe_sysfs_scheduler.c @@ -5,6 +5,7 @@ /** * TEST: xe sysfs scheduler + * Category: Software building block * Sub-category: sysman * Functionality: scheduler control interface * Test category: functionality test diff --git a/tests/intel/xe_sysfs_tile.c b/tests/intel/xe_sysfs_tile.c index 3be9c93f7..a7203e2b3 100644 --- a/tests/intel/xe_sysfs_tile.c +++ b/tests/intel/xe_sysfs_tile.c @@ -5,9 +5,12 @@ /** * TEST: Verify physical_vram_size_bytes of each tiles + * Category: Software building block * SUBTEST: physical_vram_size_bytes * Functionality: Vram * Sub-category: Total vram per tile + * Run type: FULL + * Test category: functionality test * Description: * Read sysfs entry for physical_vram_size_bytes and compare with * vram size. physical_vram_size_bytes should be more than vram size. diff --git a/tests/intel/xe_uevent.c b/tests/intel/xe_uevent.c index 4dc49057c..b8a92b698 100644 --- a/tests/intel/xe_uevent.c +++ b/tests/intel/xe_uevent.c @@ -5,9 +5,12 @@ /** * TEST: cause fake gt reset failure and listen uevent from KMD + * Category: Software building block * SUBTEST:fake_reset_uevent_listener * Functionality: uevent * Sub-category: GT reset failure uevent + * Run type: FULL + * Test category: functionality test * Description: * Test creates uevent listener and causes fake reset failure for gt0 * and returns success if uevent is sent by driver and listened by listener. diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c index e42c04e33..e48715aed 100644 --- a/tests/intel/xe_vm.c +++ b/tests/intel/xe_vm.c @@ -1628,6 +1628,7 @@ try_again_after_invalidate: /** * SUBTEST: mmap-style-bind-%s * Description: Test mmap style unbind with %arg[1] + * Functionality: bind * Run type: FULL * TODO: change ``'Run type' == FULL`` to a better category * -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests Katarzyna Dec @ 2023-09-06 9:11 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 6+ messages in thread From: Mauro Carvalho Chehab @ 2023-09-06 9:11 UTC (permalink / raw) To: Katarzyna Dec; +Cc: igt-dev, Gandi Ramadevi On Wed, 6 Sep 2023 08:56:27 +0000 Katarzyna Dec <katarzyna.dec@intel.com> wrote: > Adding missing documentation for tests that show warnings during building > IGTs. > > v2" s/Full/FULL in xe_sysfs_tile & xe_uevent tests > > Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> LGTM. Reviewed-by: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Gandi Ramadevi <ramadevi.gandi@intel.com> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> > --- > tests/intel/xe_pm.c | 1 + > tests/intel/xe_sysfs_scheduler.c | 1 + > tests/intel/xe_sysfs_tile.c | 3 +++ > tests/intel/xe_uevent.c | 3 +++ > tests/intel/xe_vm.c | 1 + > 5 files changed, 9 insertions(+) > > diff --git a/tests/intel/xe_pm.c b/tests/intel/xe_pm.c > index 2ec108d14..d31049d19 100644 > --- a/tests/intel/xe_pm.c > +++ b/tests/intel/xe_pm.c > @@ -366,6 +366,7 @@ NULL)); > > /** > * SUBTEST: vram-d3cold-threshold > + * Functionality: pm - d3cold > * Description: > * Validate whether card is limited to d3hot while vram used > * is greater than vram_d3cold_threshold. > diff --git a/tests/intel/xe_sysfs_scheduler.c b/tests/intel/xe_sysfs_scheduler.c > index 0315ce915..ec2190113 100644 > --- a/tests/intel/xe_sysfs_scheduler.c > +++ b/tests/intel/xe_sysfs_scheduler.c > @@ -5,6 +5,7 @@ > > /** > * TEST: xe sysfs scheduler > + * Category: Software building block > * Sub-category: sysman > * Functionality: scheduler control interface > * Test category: functionality test > diff --git a/tests/intel/xe_sysfs_tile.c b/tests/intel/xe_sysfs_tile.c > index 3be9c93f7..a7203e2b3 100644 > --- a/tests/intel/xe_sysfs_tile.c > +++ b/tests/intel/xe_sysfs_tile.c > @@ -5,9 +5,12 @@ > > /** > * TEST: Verify physical_vram_size_bytes of each tiles > + * Category: Software building block > * SUBTEST: physical_vram_size_bytes > * Functionality: Vram > * Sub-category: Total vram per tile > + * Run type: FULL > + * Test category: functionality test > * Description: > * Read sysfs entry for physical_vram_size_bytes and compare with > * vram size. physical_vram_size_bytes should be more than vram size. > diff --git a/tests/intel/xe_uevent.c b/tests/intel/xe_uevent.c > index 4dc49057c..b8a92b698 100644 > --- a/tests/intel/xe_uevent.c > +++ b/tests/intel/xe_uevent.c > @@ -5,9 +5,12 @@ > > /** > * TEST: cause fake gt reset failure and listen uevent from KMD > + * Category: Software building block > * SUBTEST:fake_reset_uevent_listener > * Functionality: uevent > * Sub-category: GT reset failure uevent > + * Run type: FULL > + * Test category: functionality test > * Description: > * Test creates uevent listener and causes fake reset failure for gt0 > * and returns success if uevent is sent by driver and listened by listener. > diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c > index e42c04e33..e48715aed 100644 > --- a/tests/intel/xe_vm.c > +++ b/tests/intel/xe_vm.c > @@ -1628,6 +1628,7 @@ try_again_after_invalidate: > /** > * SUBTEST: mmap-style-bind-%s > * Description: Test mmap style unbind with %arg[1] > + * Functionality: bind > * Run type: FULL > * TODO: change ``'Run type' == FULL`` to a better category > * ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t v2 2/2] test/xe: Clean up of test documentation 2023-09-06 8:56 [igt-dev] [PATCH i-g-t v2 0/2] IGT XE documentation cleanup Katarzyna Dec 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests Katarzyna Dec @ 2023-09-06 8:56 ` Katarzyna Dec 2023-09-06 9:14 ` Mauro Carvalho Chehab 2023-09-06 9:40 ` [igt-dev] ✗ Fi.CI.BAT: failure for IGT XE documentation cleanup (rev2) Patchwork 2 siblings, 1 reply; 6+ messages in thread From: Katarzyna Dec @ 2023-09-06 8:56 UTC (permalink / raw) To: igt-dev; +Cc: Gandi Ramadevi Change documentation fields: xe_ccs.c - HW blitter test xe_dma_buf_sync.c - functionality 'export' xe_exercise_blt.c - HW blitter test xe_intel_bb.c - IGT Lib test xe_query.c - uapi ioctl test Shortenning description for xe_noexec_ping_pong.c. Add/Change 'Test category' and 'Run Type': ../core_hotunplug.c xe_ccs.c xe_create.c xe_debugfs.c xe_dma_buf_sync.c xe_evict.c xe_exec_balancer.c xe_exec_basic.c xe_exec_compute_mode.c xe_exec_fault_mode.c xe_exercise_blt.c xe_intel_bb.c xe_media_fill.c xe_mmap.c xe_mmio.c xe_noexec_ping_pong.c xe_query.c xe_spin_batch.c xe_sysfs_scheduler.c xe_sysfs_tile.c xe_uevent.c xe_vm.c v2: s/Blitter/bliter/in xe_ccs & put xe_mmap to VMA subcategory Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Gandi Ramadevi <ramadevi.gandi@intel.com> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> --- tests/core_hotunplug.c | 1 + tests/intel/xe_ccs.c | 7 +- tests/intel/xe_create.c | 8 +- tests/intel/xe_debugfs.c | 2 +- tests/intel/xe_dma_buf_sync.c | 5 +- tests/intel/xe_evict.c | 154 +++++++++++++++++++++++------ tests/intel/xe_exec_balancer.c | 11 +++ tests/intel/xe_exec_basic.c | 7 +- tests/intel/xe_exec_compute_mode.c | 5 +- tests/intel/xe_exec_fault_mode.c | 9 +- tests/intel/xe_exercise_blt.c | 6 +- tests/intel/xe_intel_bb.c | 2 +- tests/intel/xe_media_fill.c | 1 + tests/intel/xe_mmap.c | 10 +- tests/intel/xe_mmio.c | 3 +- tests/intel/xe_noexec_ping_pong.c | 25 +++-- tests/intel/xe_query.c | 14 ++- tests/intel/xe_spin_batch.c | 2 +- tests/intel/xe_sysfs_scheduler.c | 4 +- tests/intel/xe_vm.c | 24 ++++- 20 files changed, 237 insertions(+), 63 deletions(-) diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c index b254447c7..be80d479f 100644 --- a/tests/core_hotunplug.c +++ b/tests/core_hotunplug.c @@ -43,6 +43,7 @@ * TEST: core hotunplug * Description: Examine behavior of a driver on device hot unplug * Feature: SMI, core + * Test category: functionality test * * SUBTEST: hotrebind * Category: Software building block diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c index a3c6c46d1..e9e13ab5c 100644 --- a/tests/intel/xe_ccs.c +++ b/tests/intel/xe_ccs.c @@ -18,10 +18,11 @@ #include "xe/xe_util.h" /** * TEST: xe ccs - * Category: Software building block - * Sub-category: IGT Lib - * Functionality: blitter + * Category: Hardware building block + * Sub-category: blitter + * Functionality: flat_ccs * Description: Exercise gen12 blitter with and without flatccs compression on Xe + * Test category: functionality test * Run type: FULL * * SUBTEST: block-copy-compressed diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c index 20e7a7da8..3e4bc1e3a 100644 --- a/tests/intel/xe_create.c +++ b/tests/intel/xe_create.c @@ -7,8 +7,6 @@ * TEST: Check bo create ioctl * Category: Software building block * Sub-category: uapi - * Functionality: device - * Test category: functionality test * Run type: BAT */ @@ -44,6 +42,8 @@ static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags, /** * SUBTEST: create-invalid-size + * Functionality: ioctl + * Test category: negative test * Description: Verifies xe bo create returns expected error code on invalid * buffer sizes. */ @@ -124,7 +124,9 @@ static uint32_t __xe_exec_queue_create(int fd, uint32_t vm, /** * SUBTEST: create-execqueues-%s + * Functionality: exequeues creation time * Description: Check process ability of multiple exec_queues creation + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -187,6 +189,8 @@ static void create_execqueues(int fd, enum exec_queue_destroy ed) /** * SUBTEST: create-massive-size + * Functionality: ioctl + * Test category: functionality test * Description: Verifies xe bo create returns expected error code on massive * buffer sizes. */ diff --git a/tests/intel/xe_debugfs.c b/tests/intel/xe_debugfs.c index 72c069bfc..1b8016450 100644 --- a/tests/intel/xe_debugfs.c +++ b/tests/intel/xe_debugfs.c @@ -6,7 +6,7 @@ /** * TEST: Check debugfs userspace API * Category: Software building block - * Sub-category: debugfs + * Sub-category: uapi * Functionality: debugfs * Test category: functionality test * Run type: BAT diff --git a/tests/intel/xe_dma_buf_sync.c b/tests/intel/xe_dma_buf_sync.c index 29d675154..8c400c8fd 100644 --- a/tests/intel/xe_dma_buf_sync.c +++ b/tests/intel/xe_dma_buf_sync.c @@ -7,7 +7,6 @@ * TEST: Check dmabuf functionality * Category: Software building block * Sub-category: dmabuf - * Functionality: dma_buf * Test category: functionality test */ @@ -72,18 +71,22 @@ static bool sync_file_busy(int sync_file) /** * SUBTEST: export-dma-buf-once * Description: Test exporting a sync file from a dma-buf + * Functionality: export * Run type: BAT * * SUBTEST: export-dma-buf-once-read-sync * Description: Test export prime BO as sync file and verify business + * Functionality: export * Run type: BAT * * SUBTEST: export-dma-buf-many * Description: Test exporting many sync files from a dma-buf + * Functionality: export * Run type: FULL * * SUBTEST: export-dma-buf-many-read-sync * Description: Test export many prime BO as sync file and verify business + * Functionality: export * Run type: FULL */ diff --git a/tests/intel/xe_evict.c b/tests/intel/xe_evict.c index b8f186809..7a508fdd2 100644 --- a/tests/intel/xe_evict.c +++ b/tests/intel/xe_evict.c @@ -467,6 +467,7 @@ static uint64_t calc_bo_size(uint64_t vram_size, int mul, int div) /** * SUBTEST: evict-%s * Description: %arg[1] evict test. + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -474,67 +475,160 @@ static uint64_t calc_bo_size(uint64_t vram_size, int mul, int div) * @small: small * @small-external: small external * @small-multi-vm: small multi VM - * @large: large - * @large-external: large external - * @large-multi-vm: large multi VM * @beng-small: small bind exec_queue * @beng-small-external: small external bind exec_queue * @beng-small-multi-vm: small multi VM bind ending + */ +/** + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Test category: stress test + * Run type: FULL + * + * arg[1]: + * + * @large: large + * @large-external: large external + * @large-multi-vm: large multi VM * @beng-large: large bind exec_queue * @beng-large-external: large external bind exec_queue * @beng-large-multi-vm: large multi VM bind exec_queue + */ +/** + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: compute machine + * Test category: functionality test + * Run type: FULL + * + * arg[1]: * * @small-cm: small compute machine * @small-external-cm: small external compute machine * @small-multi-vm-cm: small multi VM compute machine - * @large-cm: large compute machine - * @large-external-cm: large external compute machine - * @large-multi-vm-cm: large multi VM compute machine * @beng-small-cm: small bind exec_queue compute machine * @beng-small-external-cm: small external bind exec_queue compute machine * @beng-small-multi-vm-cm: small multi VM bind ending compute machine + */ +/** + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: compute machine + * Test category: stress test + * Run type: FULL + * + * arg[1]: + * + * @large-cm: large compute machine + * @large-external-cm: large external compute machine + * @large-multi-vm-cm: large multi VM compute machine * @beng-large-cm: large bind exec_queue compute machine * @beng-large-external-cm: large external bind exec_queue compute machine * @beng-large-multi-vm-cm: large multi VM bind exec_queue compute machine + */ +/** + * + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: mixted threads + * Test category: functionality test + * Run type: FULL + * + * arg[1]: * - * @threads-small: threads small - * @cm-threads-small: compute mode threads small * @mixed-threads-small: mixed threads small * @mixed-many-threads-small: mixed many threads small - * @threads-large: threads large - * @cm-threads-large: compute mode threads large - * @mixed-threads-large: mixed threads large - * @mixed-many-threads-large: mixed many threads large - * @threads-small-multi-vm: threads small multi vm - * @cm-threads-small-multi-vm: compute mode threads small multi vm * @mixed-threads-small-multi-vm: * mixed threads small multi vm - * @threads-large-multi-vm: threads large multi vm - * @cm-threads-large-multi-vm: compute mode threads large multi vm - * @mixed-threads-large-multi-vm: - * mixed threads large multi vm - * @beng-threads-small: bind exec_queue threads small - * @beng-cm-threads-small: bind exec_queue compute mode threads small * @beng-mixed-threads-small: bind exec_queue mixed threads small * @beng-mixed-many-threads-small: * bind exec_queue mixed many threads small - * @beng-threads-large: bind exec_queue threads large - * @beng-cm-threads-large: bind exec_queue compute mode threads large + * @beng-mixed-threads-small-multi-vm: + * bind exec_queue mixed threads small multi vm + */ +/** + * + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: mixted threads + * Test category: stress test + * Run type: FULL + * + * arg[1]: + * + * @beng-mixed-threads-large-multi-vm: + * bind exec_queue mixed threads large multi vm + * @mixed-threads-large: mixed threads large + * @mixed-many-threads-large: mixed many threads large + * @mixed-threads-large-multi-vm: + * mixed threads large multi vm * @beng-mixed-threads-large: bind exec_queue mixed threads large * @beng-mixed-many-threads-large: * bind exec_queue mixed many threads large - * @beng-threads-small-multi-vm: - * bind exec_queue threads small multi vm + */ +/** + * + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: compute mode threads + * Test category: functionality test + * Run type: FULL + * + * arg[1]: + * @cm-threads-small: compute mode threads small + * @cm-threads-small-multi-vm: compute mode threads small multi vm + * @beng-cm-threads-small: bind exec_queue compute mode threads small * @beng-cm-threads-small-multi-vm: * bind exec_queue compute mode threads small multi vm - * @beng-mixed-threads-small-multi-vm: - * bind exec_queue mixed threads small multi vm - * @beng-threads-large-multi-vm: - * bind exec_queue threads large multi vm + */ +/** + * + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: compute mode threads + * Test category: stress test + * Run type: FULL + * + * arg[1]: + * @cm-threads-large: compute mode threads large + * @cm-threads-large-multi-vm: compute mode threads large multi vm + * @beng-cm-threads-large: bind exec_queue compute mode threads large * @beng-cm-threads-large-multi-vm: * bind exec_queue compute mode threads large multi vm - * @beng-mixed-threads-large-multi-vm: - * bind exec_queue mixed threads large multi vm + */ +/** + * + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: threads + * Test category: functionality test + * Run type: FULL + * + * arg[1]: + * + * @threads-small: threads small + * @beng-threads-small: bind exec_queue threads small + * @threads-small-multi-vm: threads small multi vm + * @beng-threads-small-multi-vm: + * bind exec_queue threads small multi vm + * + */ +/** + * + * SUBTEST: evict-%s + * Description: %arg[1] evict test. + * Feature: threads + * Test category: stress test + * Run type: FULL + * + * arg[1]: + * + * @threads-large: threads large + * @threads-large-multi-vm: threads large multi vm + * @beng-threads-large-multi-vm: + * bind exec_queue threads large multi vm + * @beng-threads-large: bind exec_queue threads large + * */ /* diff --git a/tests/intel/xe_exec_balancer.c b/tests/intel/xe_exec_balancer.c index f364a4b7a..f571f13d9 100644 --- a/tests/intel/xe_exec_balancer.c +++ b/tests/intel/xe_exec_balancer.c @@ -30,6 +30,7 @@ * Description: * Run a test to check if virtual exec_queues can be running on all instances * of a class simultaneously + * Test category: functionality test * Run type: FULL */ static void test_all_active(int fd, int gt, int class) @@ -137,22 +138,27 @@ static void test_all_active(int fd, int gt, int class) /** * SUBTEST: once-%s * Description: Run %arg[1] test only once + * Test category: functionality test * Run type: FULL * * SUBTEST: many-%s * Description: Run %arg[1] test many times + * Test category: stress test * Run type: FULL * * SUBTEST: many-execqueues-%s * Description: Run %arg[1] test on many exec_queues + * Test category: stress test * Run type: FULL * * SUBTEST: twice-%s * Description: Run %arg[1] test twice + * Test category: functionality test * Run type: BAT * * SUBTEST: no-exec-%s * Description: Run no-exec %arg[1] test + * Test category: functionality test * Run type: BAT * * arg[1]: @@ -356,24 +362,29 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs, /** * SUBTEST: once-cm-%s * Description: Run compute mode virtual exec_queue arg[1] test only once + * Test category: functionality test * * Run type: FULL * * SUBTEST: twice-cm-%s * Description: Run compute mode virtual exec_queue arg[1] test twice + * Test category: functionality test * Run type: BAT * * SUBTEST: many-cm-%s * Description: Run compute mode virtual exec_queue arg[1] test many times + * Test category: stress test * Run type: FULL * * SUBTEST: many-execqueues-cm-%s * Description: Run compute mode virtual exec_queue arg[1] test on many exec_queues + * Test category: stress test * Run type: FULL * * * SUBTEST: no-exec-cm-%s * Description: Run compute mode virtual exec_queue arg[1] no-exec test + * Test category: functionality test * Run type: BAT * * arg[1]: diff --git a/tests/intel/xe_exec_basic.c b/tests/intel/xe_exec_basic.c index 46b8709a7..d1d36e086 100644 --- a/tests/intel/xe_exec_basic.c +++ b/tests/intel/xe_exec_basic.c @@ -8,7 +8,6 @@ * Category: Hardware building block * Sub-category: execbuf * Functionality: exec_queues - * Test category: functionality test */ #include "igt.h" @@ -33,26 +32,32 @@ /** * SUBTEST: once-%s * Description: Run %arg[1] test only once + * Test category: functionality test * Run type: FULL * * SUBTEST: many-%s * Description: Run %arg[1] test many times + * Test category: stress test * Run type: FULL * * SUBTEST: many-execqueues-%s * Description: Run %arg[1] test on many exec_queues + * Test category: stress test * Run type: FULL * * SUBTEST: many-execqueues-many-vm-%s * Description: Run %arg[1] test on many exec_queues and many VMs + * Test category: stress test * Run type: FULL * * SUBTEST: twice-%s * Description: Run %arg[1] test twice + * Test category: functionality test * Run type: BAT * * SUBTEST: no-exec-%s * Description: Run no-exec %arg[1] test + * Test category: functionality test * Run type: BAT * * arg[1]: diff --git a/tests/intel/xe_exec_compute_mode.c b/tests/intel/xe_exec_compute_mode.c index 679b84fa1..38c904ddd 100644 --- a/tests/intel/xe_exec_compute_mode.c +++ b/tests/intel/xe_exec_compute_mode.c @@ -8,7 +8,6 @@ * Category: Hardware building block * Sub-category: execbuf * Functionality: compute machine - * Test category: functionality test */ #include <fcntl.h> @@ -34,14 +33,17 @@ /** * SUBTEST: twice-%s * Description: Run %arg[1] compute machine test twice + * Test category: functionality test * Run type: BAT * * SUBTEST: once-%s * Description: Run %arg[1] compute machine test only once + * Test category: functionality test * Run type: FULL * * SUBTEST: many-%s * Description: Run %arg[1] compute machine test many times + * Test category: stress test * Run type: FULL * * arg[1]: @@ -65,6 +67,7 @@ * * SUBTEST: many-execqueues-%s * Description: Run %arg[1] compute machine test on many exec_queues + * Test category: functionality test * Run type: FULL * * arg[1]: diff --git a/tests/intel/xe_exec_fault_mode.c b/tests/intel/xe_exec_fault_mode.c index 85c010039..efd7ca2c2 100644 --- a/tests/intel/xe_exec_fault_mode.c +++ b/tests/intel/xe_exec_fault_mode.c @@ -8,7 +8,6 @@ * Category: Hardware building block * Sub-category: execbuf * Functionality: fault mode - * Test category: functionality test * GPU requirements: GPU needs support for DRM_XE_VM_CREATE_FAULT_MODE */ @@ -37,18 +36,22 @@ /** * SUBTEST: once-%s * Description: Run %arg[1] fault mode test only once + * Test category: functionality test * Run type: FULL * * SUBTEST: twice-%s * Description: Run %arg[1] fault mode test twice + * Test category: functionality test * Run type: FULL * * SUBTEST: many-%s * Description: Run %arg[1] fault mode test many times + * Test category: stress test * Run type: FULL * * SUBTEST: many-execqueues-%s * Description: Run %arg[1] fault mode test on many exec_queues + * Test category: stress test * Run type: FULL * * arg[1]: @@ -324,19 +327,23 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, /** * SUBTEST: atomic-once * Description: Run atomic fault mode test only once + * Test category: functionality test * Run type: FULL * * SUBTEST: atomic-once-wait * Description: Run atomic wait fault mode test once + * Test category: functionality test * Run type: FULL * * SUBTEST: atomic-many * Description: Run atomic fault mode test many times * Description: atomic many + * Test category: functionality test * Run type: FULL * * SUBTEST: atomic-many-wait * Description: Run atomic wait fault mode test many times + * Test category: functionality test * Run type: FULL * */ diff --git a/tests/intel/xe_exercise_blt.c b/tests/intel/xe_exercise_blt.c index 34522c0f8..2e2ec34dc 100644 --- a/tests/intel/xe_exercise_blt.c +++ b/tests/intel/xe_exercise_blt.c @@ -14,9 +14,9 @@ /** * TEST: xe exercise blt - * Category: Software building block - * Sub-category: IGT Lib - * Functionality: blitter + * Category: Hardware building block + * Sub-category: Blitter + * Functionality: flat_ccs * Description: Exercise blitter commands on Xe * Run type: FULL * Test category: functionality test diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c index a5531cf80..daab3496d 100644 --- a/tests/intel/xe_intel_bb.c +++ b/tests/intel/xe_intel_bb.c @@ -25,7 +25,7 @@ /** * TEST: Basic tests for intel-bb xe functionality * Category: Software building block - * Sub-category: xe + * Sub-category: IGT Lib * Functionality: intel-bb * Test category: functionality test */ diff --git a/tests/intel/xe_media_fill.c b/tests/intel/xe_media_fill.c index 4b2c235fa..84c721ba7 100644 --- a/tests/intel/xe_media_fill.c +++ b/tests/intel/xe_media_fill.c @@ -33,6 +33,7 @@ * Description: Basic test for the media_fill() function, * a very simple workload for the Media pipeline. * Feature: media + * Test category: functionality test * Run type: FULL * * SUBTEST: media-fill diff --git a/tests/intel/xe_mmap.c b/tests/intel/xe_mmap.c index 8a70a5c35..1b759207b 100644 --- a/tests/intel/xe_mmap.c +++ b/tests/intel/xe_mmap.c @@ -6,9 +6,8 @@ /** * TEST: Test if the driver is capable of doing mmap on different memory regions * Category: Software building block - * Sub-category: mmap + * Sub-category: VMA * Functionality: mmap - * Test category: functionality test * Run type: BAT */ @@ -24,6 +23,7 @@ /** * SUBTEST: system + * Test category: functionality test * Description: Test mmap on system memory */ @@ -31,12 +31,14 @@ * SUBTEST: small-bar * Description: Sanity check mmap behaviour on small-bar systems * GPU requirements: GPU needs to have dedicated VRAM and using small-bar + * Test category: functionality test */ /** * SUBTEST: %s * Description: Test mmap on %arg[1] memory * GPU requirements: GPU needs to have dedicated VRAM + * Test category: functionality test * * arg[1]: * @@ -64,6 +66,7 @@ test_mmap(int fd, uint32_t flags) /** * SUBTEST: bad-flags * Description: Test mmap offset with bad flags. + * Test category: negative test * */ static void test_bad_flags(int fd) @@ -82,6 +85,7 @@ static void test_bad_flags(int fd) /** * SUBTEST: bad-extensions * Description: Test mmap offset with bad extensions. + * Test category: negative test * */ static void test_bad_extensions(int fd) @@ -103,6 +107,7 @@ static void test_bad_extensions(int fd) /** * SUBTEST: bad-object * Description: Test mmap offset with bad object. + * Test category: negative test * */ static void test_bad_object(int fd) @@ -144,6 +149,7 @@ static void trap_sigbus(uint32_t *ptr) /** * SUBTEST: small-bar * Description: Test mmap behaviour on small-bar systems. + * Test category: functionality test * */ static void test_small_bar(int fd) diff --git a/tests/intel/xe_mmio.c b/tests/intel/xe_mmio.c index 02e79d7e4..4053faa56 100644 --- a/tests/intel/xe_mmio.c +++ b/tests/intel/xe_mmio.c @@ -8,7 +8,6 @@ * Category: Software building block * Sub-category: mmio * Functionality: mmap - * Test category: functionality test * Run type: BAT */ @@ -24,6 +23,7 @@ /** * SUBTEST: mmio-timestamp + * Test category: functionality test * Description: * Try to run mmio ioctl with 32 and 64 bits and check it a timestamp * matches @@ -51,6 +51,7 @@ static void test_xe_mmio_timestamp(int fd) /** * SUBTEST: mmio-invalid + * Test category: negative test * Description: Try to run mmio ioctl with 8, 16 and 32 and 64 bits mmio */ diff --git a/tests/intel/xe_noexec_ping_pong.c b/tests/intel/xe_noexec_ping_pong.c index cc61a77c1..a238f9d34 100644 --- a/tests/intel/xe_noexec_ping_pong.c +++ b/tests/intel/xe_noexec_ping_pong.c @@ -25,18 +25,25 @@ * SUBTEST: * Description: * This test creates compute vms, binds a couple of bos and an exec_queue each, - * thus redying it for execution. However, VRAM memory is over- - * committed and while there is still nothing to execute, an eviction - * will trigger the VM's rebind worker to rebind the evicted bo, which - * will in turn trigger another eviction and so on. + * thus redying it for execution. * - * Since we don't have eviction stats yet we need to watch "top" for - * the rebind kworkers using a lot of CPU while the test idles. - * - * The correct driver behaviour should be not to rebind anything unless - * there is worked queued on one of the VM's compute exec_queues. * Run type: FULL */ + /* + * More dailed test description: + * This test creates compute vms, binds a couple of bos and an exec_queue each, + * thus redying it for execution. However, VRAM memory is over- + * committed and while there is still nothing to execute, an eviction + * will trigger the VM's rebind worker to rebind the evicted bo, which + * will in turn trigger another eviction and so on. + * + * Since we don't have eviction stats yet we need to watch "top" for + * the rebind kworkers using a lot of CPU while the test idles. + * + * The correct driver behaviour should be not to rebind anything unless + * there is worked queued on one of the VM's compute exec_queues. + */ + static void test_ping_pong(int fd, struct drm_xe_engine_class_instance *eci) { size_t vram_size = xe_vram_size(fd, 0); diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c index a4e40afdd..8ec849130 100644 --- a/tests/intel/xe_query.c +++ b/tests/intel/xe_query.c @@ -6,9 +6,8 @@ /** * TEST: Check device configuration query * Category: Software building block - * Sub-category: ioctl - * Functionality: device - * Test category: functionality test + * Sub-category: uapi + * Functionality: ioctl * Run type: BAT * Description: Acquire configuration data for xe device */ @@ -175,6 +174,7 @@ const char *get_topo_name(int value) /** * SUBTEST: query-engines * Description: Display engine classes available for xe device + * Test category: functionality test */ static void test_query_engines(int fd) @@ -194,6 +194,7 @@ test_query_engines(int fd) /** * SUBTEST: query-mem-usage + * Test category: functionality test * Description: Display memory information like memory class, size * and alignment. */ @@ -254,6 +255,7 @@ test_query_mem_usage(int fd) /** * SUBTEST: query-gts + * Test category: functionality test * Description: Display information about available GTs for xe device. */ static void @@ -293,6 +295,7 @@ test_query_gts(int fd) /** * SUBTEST: query-topology + * Test category: functionality test * Description: Display topology information of GTs. */ static void @@ -336,6 +339,7 @@ test_query_gt_topology(int fd) /** * SUBTEST: query-config + * Test category: functionality test * Description: Display xe device id, revision and configuration. */ static void @@ -386,6 +390,7 @@ test_query_config(int fd) /** * SUBTEST: query-hwconfig + * Test category: functionality test * Description: Display hardware configuration of xe device. */ static void @@ -419,6 +424,7 @@ test_query_hwconfig(int fd) /** * SUBTEST: query-invalid-query + * Test category: negative test * Description: Check query with invalid arguments returns expected error code. */ static void @@ -436,6 +442,7 @@ test_query_invalid_query(int fd) /** * SUBTEST: query-invalid-size + * Test category: negative test * Description: Check query with invalid size returns expected error code. */ static void @@ -453,6 +460,7 @@ test_query_invalid_size(int fd) /** * SUBTEST: query-invalid-extension + * Test category: negative test * Description: Check query with invalid extension returns expected error code. */ static void diff --git a/tests/intel/xe_spin_batch.c b/tests/intel/xe_spin_batch.c index 26f9daf36..9bd3dc349 100644 --- a/tests/intel/xe_spin_batch.c +++ b/tests/intel/xe_spin_batch.c @@ -8,7 +8,7 @@ * TEST: Tests for spin batch submissons. * Category: Software building block * Sub-category: spin - * Functionality: intel-bb + * Functionality: parallel execution * Test category: functionality test */ diff --git a/tests/intel/xe_sysfs_scheduler.c b/tests/intel/xe_sysfs_scheduler.c index ec2190113..866b9d50a 100644 --- a/tests/intel/xe_sysfs_scheduler.c +++ b/tests/intel/xe_sysfs_scheduler.c @@ -8,17 +8,19 @@ * Category: Software building block * Sub-category: sysman * Functionality: scheduler control interface - * Test category: functionality test * Run type: FULL * * SUBTEST: %s-invalid * Description: Test to check if %s arg[1] schedule parameter rejects any unrepresentable intervals. + * Test category: negative test * * SUBTEST: %s-min-max * Description: Test to check if %s arg[1] schedule parameter checks for min max values. + * Test category: functionality test * * SUBTEST: %s-nonprivileged-user * Description: Test %s arg[1] schedule parameter for nonprivileged user. + * Test category: functionality test * * arg[1]: * diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c index e48715aed..5453f10c4 100644 --- a/tests/intel/xe_vm.c +++ b/tests/intel/xe_vm.c @@ -7,7 +7,6 @@ * TEST: Check if VMA functionality is working * Category: Software building block * Sub-category: VMA - * Test category: functionality test */ #include "igt.h" @@ -84,6 +83,7 @@ write_dwords(int fd, uint32_t vm, int n_dwords, uint64_t *addrs) * SUBTEST: scratch * Description: Test scratch page creation and write * Functionality: scratch page + * Test category: functionality test * Run type: FULL */ @@ -206,6 +206,7 @@ uint64_t addrs_57b[] = { * SUBTEST: bind-once * Description: bind once on one BO * Functionality: bind BO + * Test category: functionality test * Run type: FULL */ @@ -223,6 +224,7 @@ test_bind_once(int fd) * SUBTEST: bind-one-bo-many-times * Description: bind many times on one BO * Functionality: bind BO + * Test category: functionality test * Run type: FULL */ @@ -243,6 +245,7 @@ test_bind_one_bo_many_times(int fd) * SUBTEST: bind-one-bo-many-times-many-vm * Description: Test bind many times and many VM on one BO * Functionality: bind BO + * Test category: functionality test * Run type: FULL */ @@ -261,6 +264,7 @@ test_bind_one_bo_many_times_many_vm(int fd) * SUBTEST: unbind-all-%d-vmas * Description: Test unbind all with %arg[1] VMAs * Functionality: unbind + * Test category: functionality test * Run type: FULL * * arg[1].values: 2, 8 @@ -301,6 +305,7 @@ static void unbind_all(int fd, int n_vmas) * Verifies that mapping an invalid userptr returns -EFAULT, * and that it is correctly handled. * Functionality: userptr + * Test category: negative test * Run type: FULL */ static void userptr_invalid(int fd) @@ -337,11 +342,13 @@ struct vm_thread_data { * SUBTEST: vm-async-ops-err * Description: Test VM async ops error * Functionality: VM + * Test category: negative test * Run type: FULL * * SUBTEST: vm-async-ops-err-destroy * Description: Test VM async ops error destroy * Functionality: VM + * Test category: negative test * Run type: FULL */ @@ -502,6 +509,7 @@ static void vm_async_ops_err(int fd, bool destroy) /** * SUBTEST: shared-%s-page * Description: Test shared arg[1] page + * Test category: functionality test * Run type: BAT * * Functionality: %arg[1] page @@ -690,11 +698,13 @@ shared_pte_page(int fd, struct drm_xe_engine_class_instance *eci, int n_bo, * SUBTEST: bind-execqueues-independent * Description: Test independent bind exec_queues * Functionality: bind exec_queues + * Test category: functionality test * Run type: BAT * * SUBTEST: bind-execqueues-conflict * Description: Test conflict bind exec_queues * Functionality: bind exec_queues + * Test category: functionality test * Run type: BAT */ @@ -864,21 +874,25 @@ test_bind_execqueues_independent(int fd, struct drm_xe_engine_class_instance *ec * SUBTEST: bind-array-twice * Description: Test bind array twice * Functionality: bind exec_queues + * Test category: functionality test * Run type: FULL * * SUBTEST: bind-array-many * Description: Test bind array many times * Functionality: bind exec_queues + * Test category: functionality test * Run type: FULL * * SUBTEST: bind-array-exec_queue-twice * Description: Test bind array exec_queue twice * Functionality: bind exec_queues + * Test category: functionality test * Run type: FULL * * SUBTEST: bind-array-exec_queue-many * Description: Test bind array exec_queue many times * Functionality: bind exec_queues + * Test category: functionality test * Run type: FULL */ static void @@ -1005,6 +1019,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, * SUBTEST: %s-%ld * Description: Test %arg[1] with %arg[2] bind size * Functionality: bind + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -1023,6 +1038,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, * SUBTEST: %s-%ld * Description: Test %arg[1] with %arg[2] bind size * Functionality: userptr bind + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -1042,6 +1058,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, * SUBTEST: %s-%ld * Description: Test %arg[1] with %arg[2] bind size * Functionality: mixed bind + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -1057,6 +1074,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, * SUBTEST: %s-%ld * Description: Test %arg[1] with %arg[2] bind size * Functionality: mixed bind + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -1298,6 +1316,7 @@ static void *hammer_thread(void *tdata) * SUBTEST: munmap-style-unbind-%s * Description: Test munmap style unbind with %arg[1] * Functionality: unbind + * Test category: functionality test * * arg[1]: * @@ -1316,6 +1335,7 @@ static void *hammer_thread(void *tdata) * SUBTEST: munmap-style-unbind-%s * Description: Test munmap style unbind with %arg[1] * Functionality: unbind + * Test category: functionality test * Run type: FULL * * arg[1]: @@ -1629,8 +1649,8 @@ try_again_after_invalidate: * SUBTEST: mmap-style-bind-%s * Description: Test mmap style unbind with %arg[1] * Functionality: bind + * Test category: functionality test * Run type: FULL - * TODO: change ``'Run type' == FULL`` to a better category * * arg[1]: * -- 2.34.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2 2/2] test/xe: Clean up of test documentation 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 2/2] test/xe: Clean up of test documentation Katarzyna Dec @ 2023-09-06 9:14 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 6+ messages in thread From: Mauro Carvalho Chehab @ 2023-09-06 9:14 UTC (permalink / raw) To: Katarzyna Dec; +Cc: igt-dev, Gandi Ramadevi On Wed, 6 Sep 2023 08:56:28 +0000 Katarzyna Dec <katarzyna.dec@intel.com> wrote: > Change documentation fields: > xe_ccs.c - HW blitter test > xe_dma_buf_sync.c - functionality 'export' > xe_exercise_blt.c - HW blitter test > xe_intel_bb.c - IGT Lib test > xe_query.c - uapi ioctl test > Shortenning description for xe_noexec_ping_pong.c. > Add/Change 'Test category' and 'Run Type': > ../core_hotunplug.c > xe_ccs.c > xe_create.c > xe_debugfs.c > xe_dma_buf_sync.c > xe_evict.c > xe_exec_balancer.c > xe_exec_basic.c > xe_exec_compute_mode.c > xe_exec_fault_mode.c > xe_exercise_blt.c > xe_intel_bb.c > xe_media_fill.c > xe_mmap.c > xe_mmio.c > xe_noexec_ping_pong.c > xe_query.c > xe_spin_batch.c > xe_sysfs_scheduler.c > xe_sysfs_tile.c > xe_uevent.c > xe_vm.c > > v2: s/Blitter/bliter/in xe_ccs & put xe_mmap to VMA subcategory > > Signed-off-by: Katarzyna Dec <katarzyna.dec@intel.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Gandi Ramadevi <ramadevi.gandi@intel.com> > Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com> LGTM. Yet, if/when we apply: https://patchwork.freedesktop.org/series/123290/ the changes needed due to different run types here won't be needed anymore. So, maybe we can drop updating Run Type here. > --- > tests/core_hotunplug.c | 1 + > tests/intel/xe_ccs.c | 7 +- > tests/intel/xe_create.c | 8 +- > tests/intel/xe_debugfs.c | 2 +- > tests/intel/xe_dma_buf_sync.c | 5 +- > tests/intel/xe_evict.c | 154 +++++++++++++++++++++++------ > tests/intel/xe_exec_balancer.c | 11 +++ > tests/intel/xe_exec_basic.c | 7 +- > tests/intel/xe_exec_compute_mode.c | 5 +- > tests/intel/xe_exec_fault_mode.c | 9 +- > tests/intel/xe_exercise_blt.c | 6 +- > tests/intel/xe_intel_bb.c | 2 +- > tests/intel/xe_media_fill.c | 1 + > tests/intel/xe_mmap.c | 10 +- > tests/intel/xe_mmio.c | 3 +- > tests/intel/xe_noexec_ping_pong.c | 25 +++-- > tests/intel/xe_query.c | 14 ++- > tests/intel/xe_spin_batch.c | 2 +- > tests/intel/xe_sysfs_scheduler.c | 4 +- > tests/intel/xe_vm.c | 24 ++++- > 20 files changed, 237 insertions(+), 63 deletions(-) > > diff --git a/tests/core_hotunplug.c b/tests/core_hotunplug.c > index b254447c7..be80d479f 100644 > --- a/tests/core_hotunplug.c > +++ b/tests/core_hotunplug.c > @@ -43,6 +43,7 @@ > * TEST: core hotunplug > * Description: Examine behavior of a driver on device hot unplug > * Feature: SMI, core > + * Test category: functionality test > * > * SUBTEST: hotrebind > * Category: Software building block > diff --git a/tests/intel/xe_ccs.c b/tests/intel/xe_ccs.c > index a3c6c46d1..e9e13ab5c 100644 > --- a/tests/intel/xe_ccs.c > +++ b/tests/intel/xe_ccs.c > @@ -18,10 +18,11 @@ > #include "xe/xe_util.h" > /** > * TEST: xe ccs > - * Category: Software building block > - * Sub-category: IGT Lib > - * Functionality: blitter > + * Category: Hardware building block > + * Sub-category: blitter > + * Functionality: flat_ccs > * Description: Exercise gen12 blitter with and without flatccs compression on Xe > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: block-copy-compressed > diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c > index 20e7a7da8..3e4bc1e3a 100644 > --- a/tests/intel/xe_create.c > +++ b/tests/intel/xe_create.c > @@ -7,8 +7,6 @@ > * TEST: Check bo create ioctl > * Category: Software building block > * Sub-category: uapi > - * Functionality: device > - * Test category: functionality test > * Run type: BAT > */ > > @@ -44,6 +42,8 @@ static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags, > > /** > * SUBTEST: create-invalid-size > + * Functionality: ioctl > + * Test category: negative test > * Description: Verifies xe bo create returns expected error code on invalid > * buffer sizes. > */ > @@ -124,7 +124,9 @@ static uint32_t __xe_exec_queue_create(int fd, uint32_t vm, > > /** > * SUBTEST: create-execqueues-%s > + * Functionality: exequeues creation time > * Description: Check process ability of multiple exec_queues creation > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -187,6 +189,8 @@ static void create_execqueues(int fd, enum exec_queue_destroy ed) > > /** > * SUBTEST: create-massive-size > + * Functionality: ioctl > + * Test category: functionality test > * Description: Verifies xe bo create returns expected error code on massive > * buffer sizes. > */ > diff --git a/tests/intel/xe_debugfs.c b/tests/intel/xe_debugfs.c > index 72c069bfc..1b8016450 100644 > --- a/tests/intel/xe_debugfs.c > +++ b/tests/intel/xe_debugfs.c > @@ -6,7 +6,7 @@ > /** > * TEST: Check debugfs userspace API > * Category: Software building block > - * Sub-category: debugfs > + * Sub-category: uapi > * Functionality: debugfs > * Test category: functionality test > * Run type: BAT > diff --git a/tests/intel/xe_dma_buf_sync.c b/tests/intel/xe_dma_buf_sync.c > index 29d675154..8c400c8fd 100644 > --- a/tests/intel/xe_dma_buf_sync.c > +++ b/tests/intel/xe_dma_buf_sync.c > @@ -7,7 +7,6 @@ > * TEST: Check dmabuf functionality > * Category: Software building block > * Sub-category: dmabuf > - * Functionality: dma_buf > * Test category: functionality test > */ > > @@ -72,18 +71,22 @@ static bool sync_file_busy(int sync_file) > /** > * SUBTEST: export-dma-buf-once > * Description: Test exporting a sync file from a dma-buf > + * Functionality: export > * Run type: BAT > * > * SUBTEST: export-dma-buf-once-read-sync > * Description: Test export prime BO as sync file and verify business > + * Functionality: export > * Run type: BAT > * > * SUBTEST: export-dma-buf-many > * Description: Test exporting many sync files from a dma-buf > + * Functionality: export > * Run type: FULL > * > * SUBTEST: export-dma-buf-many-read-sync > * Description: Test export many prime BO as sync file and verify business > + * Functionality: export > * Run type: FULL > */ > > diff --git a/tests/intel/xe_evict.c b/tests/intel/xe_evict.c > index b8f186809..7a508fdd2 100644 > --- a/tests/intel/xe_evict.c > +++ b/tests/intel/xe_evict.c > @@ -467,6 +467,7 @@ static uint64_t calc_bo_size(uint64_t vram_size, int mul, int div) > /** > * SUBTEST: evict-%s > * Description: %arg[1] evict test. > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -474,67 +475,160 @@ static uint64_t calc_bo_size(uint64_t vram_size, int mul, int div) > * @small: small > * @small-external: small external > * @small-multi-vm: small multi VM > - * @large: large > - * @large-external: large external > - * @large-multi-vm: large multi VM > * @beng-small: small bind exec_queue > * @beng-small-external: small external bind exec_queue > * @beng-small-multi-vm: small multi VM bind ending > + */ > +/** > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Test category: stress test > + * Run type: FULL > + * > + * arg[1]: > + * > + * @large: large > + * @large-external: large external > + * @large-multi-vm: large multi VM > * @beng-large: large bind exec_queue > * @beng-large-external: large external bind exec_queue > * @beng-large-multi-vm: large multi VM bind exec_queue > + */ > +/** > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: compute machine > + * Test category: functionality test > + * Run type: FULL > + * > + * arg[1]: > * > * @small-cm: small compute machine > * @small-external-cm: small external compute machine > * @small-multi-vm-cm: small multi VM compute machine > - * @large-cm: large compute machine > - * @large-external-cm: large external compute machine > - * @large-multi-vm-cm: large multi VM compute machine > * @beng-small-cm: small bind exec_queue compute machine > * @beng-small-external-cm: small external bind exec_queue compute machine > * @beng-small-multi-vm-cm: small multi VM bind ending compute machine > + */ > +/** > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: compute machine > + * Test category: stress test > + * Run type: FULL > + * > + * arg[1]: > + * > + * @large-cm: large compute machine > + * @large-external-cm: large external compute machine > + * @large-multi-vm-cm: large multi VM compute machine > * @beng-large-cm: large bind exec_queue compute machine > * @beng-large-external-cm: large external bind exec_queue compute machine > * @beng-large-multi-vm-cm: large multi VM bind exec_queue compute machine > + */ > +/** > + * > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: mixted threads > + * Test category: functionality test > + * Run type: FULL > + * > + * arg[1]: > * > - * @threads-small: threads small > - * @cm-threads-small: compute mode threads small > * @mixed-threads-small: mixed threads small > * @mixed-many-threads-small: mixed many threads small > - * @threads-large: threads large > - * @cm-threads-large: compute mode threads large > - * @mixed-threads-large: mixed threads large > - * @mixed-many-threads-large: mixed many threads large > - * @threads-small-multi-vm: threads small multi vm > - * @cm-threads-small-multi-vm: compute mode threads small multi vm > * @mixed-threads-small-multi-vm: > * mixed threads small multi vm > - * @threads-large-multi-vm: threads large multi vm > - * @cm-threads-large-multi-vm: compute mode threads large multi vm > - * @mixed-threads-large-multi-vm: > - * mixed threads large multi vm > - * @beng-threads-small: bind exec_queue threads small > - * @beng-cm-threads-small: bind exec_queue compute mode threads small > * @beng-mixed-threads-small: bind exec_queue mixed threads small > * @beng-mixed-many-threads-small: > * bind exec_queue mixed many threads small > - * @beng-threads-large: bind exec_queue threads large > - * @beng-cm-threads-large: bind exec_queue compute mode threads large > + * @beng-mixed-threads-small-multi-vm: > + * bind exec_queue mixed threads small multi vm > + */ > +/** > + * > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: mixted threads > + * Test category: stress test > + * Run type: FULL > + * > + * arg[1]: > + * > + * @beng-mixed-threads-large-multi-vm: > + * bind exec_queue mixed threads large multi vm > + * @mixed-threads-large: mixed threads large > + * @mixed-many-threads-large: mixed many threads large > + * @mixed-threads-large-multi-vm: > + * mixed threads large multi vm > * @beng-mixed-threads-large: bind exec_queue mixed threads large > * @beng-mixed-many-threads-large: > * bind exec_queue mixed many threads large > - * @beng-threads-small-multi-vm: > - * bind exec_queue threads small multi vm > + */ > +/** > + * > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: compute mode threads > + * Test category: functionality test > + * Run type: FULL > + * > + * arg[1]: > + * @cm-threads-small: compute mode threads small > + * @cm-threads-small-multi-vm: compute mode threads small multi vm > + * @beng-cm-threads-small: bind exec_queue compute mode threads small > * @beng-cm-threads-small-multi-vm: > * bind exec_queue compute mode threads small multi vm > - * @beng-mixed-threads-small-multi-vm: > - * bind exec_queue mixed threads small multi vm > - * @beng-threads-large-multi-vm: > - * bind exec_queue threads large multi vm > + */ > +/** > + * > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: compute mode threads > + * Test category: stress test > + * Run type: FULL > + * > + * arg[1]: > + * @cm-threads-large: compute mode threads large > + * @cm-threads-large-multi-vm: compute mode threads large multi vm > + * @beng-cm-threads-large: bind exec_queue compute mode threads large > * @beng-cm-threads-large-multi-vm: > * bind exec_queue compute mode threads large multi vm > - * @beng-mixed-threads-large-multi-vm: > - * bind exec_queue mixed threads large multi vm > + */ > +/** > + * > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: threads > + * Test category: functionality test > + * Run type: FULL > + * > + * arg[1]: > + * > + * @threads-small: threads small > + * @beng-threads-small: bind exec_queue threads small > + * @threads-small-multi-vm: threads small multi vm > + * @beng-threads-small-multi-vm: > + * bind exec_queue threads small multi vm > + * > + */ > +/** > + * > + * SUBTEST: evict-%s > + * Description: %arg[1] evict test. > + * Feature: threads > + * Test category: stress test > + * Run type: FULL > + * > + * arg[1]: > + * > + * @threads-large: threads large > + * @threads-large-multi-vm: threads large multi vm > + * @beng-threads-large-multi-vm: > + * bind exec_queue threads large multi vm > + * @beng-threads-large: bind exec_queue threads large > + * > */ > > /* > diff --git a/tests/intel/xe_exec_balancer.c b/tests/intel/xe_exec_balancer.c > index f364a4b7a..f571f13d9 100644 > --- a/tests/intel/xe_exec_balancer.c > +++ b/tests/intel/xe_exec_balancer.c > @@ -30,6 +30,7 @@ > * Description: > * Run a test to check if virtual exec_queues can be running on all instances > * of a class simultaneously > + * Test category: functionality test > * Run type: FULL > */ > static void test_all_active(int fd, int gt, int class) > @@ -137,22 +138,27 @@ static void test_all_active(int fd, int gt, int class) > /** > * SUBTEST: once-%s > * Description: Run %arg[1] test only once > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: many-%s > * Description: Run %arg[1] test many times > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: many-execqueues-%s > * Description: Run %arg[1] test on many exec_queues > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: twice-%s > * Description: Run %arg[1] test twice > + * Test category: functionality test > * Run type: BAT > * > * SUBTEST: no-exec-%s > * Description: Run no-exec %arg[1] test > + * Test category: functionality test > * Run type: BAT > * > * arg[1]: > @@ -356,24 +362,29 @@ test_exec(int fd, int gt, int class, int n_exec_queues, int n_execs, > /** > * SUBTEST: once-cm-%s > * Description: Run compute mode virtual exec_queue arg[1] test only once > + * Test category: functionality test > * > * Run type: FULL > * > * SUBTEST: twice-cm-%s > * Description: Run compute mode virtual exec_queue arg[1] test twice > + * Test category: functionality test > * Run type: BAT > * > * SUBTEST: many-cm-%s > * Description: Run compute mode virtual exec_queue arg[1] test many times > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: many-execqueues-cm-%s > * Description: Run compute mode virtual exec_queue arg[1] test on many exec_queues > + * Test category: stress test > * Run type: FULL > * > * > * SUBTEST: no-exec-cm-%s > * Description: Run compute mode virtual exec_queue arg[1] no-exec test > + * Test category: functionality test > * Run type: BAT > * > * arg[1]: > diff --git a/tests/intel/xe_exec_basic.c b/tests/intel/xe_exec_basic.c > index 46b8709a7..d1d36e086 100644 > --- a/tests/intel/xe_exec_basic.c > +++ b/tests/intel/xe_exec_basic.c > @@ -8,7 +8,6 @@ > * Category: Hardware building block > * Sub-category: execbuf > * Functionality: exec_queues > - * Test category: functionality test > */ > > #include "igt.h" > @@ -33,26 +32,32 @@ > /** > * SUBTEST: once-%s > * Description: Run %arg[1] test only once > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: many-%s > * Description: Run %arg[1] test many times > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: many-execqueues-%s > * Description: Run %arg[1] test on many exec_queues > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: many-execqueues-many-vm-%s > * Description: Run %arg[1] test on many exec_queues and many VMs > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: twice-%s > * Description: Run %arg[1] test twice > + * Test category: functionality test > * Run type: BAT > * > * SUBTEST: no-exec-%s > * Description: Run no-exec %arg[1] test > + * Test category: functionality test > * Run type: BAT > * > * arg[1]: > diff --git a/tests/intel/xe_exec_compute_mode.c b/tests/intel/xe_exec_compute_mode.c > index 679b84fa1..38c904ddd 100644 > --- a/tests/intel/xe_exec_compute_mode.c > +++ b/tests/intel/xe_exec_compute_mode.c > @@ -8,7 +8,6 @@ > * Category: Hardware building block > * Sub-category: execbuf > * Functionality: compute machine > - * Test category: functionality test > */ > > #include <fcntl.h> > @@ -34,14 +33,17 @@ > /** > * SUBTEST: twice-%s > * Description: Run %arg[1] compute machine test twice > + * Test category: functionality test > * Run type: BAT > * > * SUBTEST: once-%s > * Description: Run %arg[1] compute machine test only once > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: many-%s > * Description: Run %arg[1] compute machine test many times > + * Test category: stress test > * Run type: FULL > * > * arg[1]: > @@ -65,6 +67,7 @@ > * > * SUBTEST: many-execqueues-%s > * Description: Run %arg[1] compute machine test on many exec_queues > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > diff --git a/tests/intel/xe_exec_fault_mode.c b/tests/intel/xe_exec_fault_mode.c > index 85c010039..efd7ca2c2 100644 > --- a/tests/intel/xe_exec_fault_mode.c > +++ b/tests/intel/xe_exec_fault_mode.c > @@ -8,7 +8,6 @@ > * Category: Hardware building block > * Sub-category: execbuf > * Functionality: fault mode > - * Test category: functionality test > * GPU requirements: GPU needs support for DRM_XE_VM_CREATE_FAULT_MODE > */ > > @@ -37,18 +36,22 @@ > /** > * SUBTEST: once-%s > * Description: Run %arg[1] fault mode test only once > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: twice-%s > * Description: Run %arg[1] fault mode test twice > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: many-%s > * Description: Run %arg[1] fault mode test many times > + * Test category: stress test > * Run type: FULL > * > * SUBTEST: many-execqueues-%s > * Description: Run %arg[1] fault mode test on many exec_queues > + * Test category: stress test > * Run type: FULL > * > * arg[1]: > @@ -324,19 +327,23 @@ test_exec(int fd, struct drm_xe_engine_class_instance *eci, > /** > * SUBTEST: atomic-once > * Description: Run atomic fault mode test only once > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: atomic-once-wait > * Description: Run atomic wait fault mode test once > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: atomic-many > * Description: Run atomic fault mode test many times > * Description: atomic many > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: atomic-many-wait > * Description: Run atomic wait fault mode test many times > + * Test category: functionality test > * Run type: FULL > * > */ > diff --git a/tests/intel/xe_exercise_blt.c b/tests/intel/xe_exercise_blt.c > index 34522c0f8..2e2ec34dc 100644 > --- a/tests/intel/xe_exercise_blt.c > +++ b/tests/intel/xe_exercise_blt.c > @@ -14,9 +14,9 @@ > > /** > * TEST: xe exercise blt > - * Category: Software building block > - * Sub-category: IGT Lib > - * Functionality: blitter > + * Category: Hardware building block > + * Sub-category: Blitter > + * Functionality: flat_ccs > * Description: Exercise blitter commands on Xe > * Run type: FULL > * Test category: functionality test > diff --git a/tests/intel/xe_intel_bb.c b/tests/intel/xe_intel_bb.c > index a5531cf80..daab3496d 100644 > --- a/tests/intel/xe_intel_bb.c > +++ b/tests/intel/xe_intel_bb.c > @@ -25,7 +25,7 @@ > /** > * TEST: Basic tests for intel-bb xe functionality > * Category: Software building block > - * Sub-category: xe > + * Sub-category: IGT Lib > * Functionality: intel-bb > * Test category: functionality test > */ > diff --git a/tests/intel/xe_media_fill.c b/tests/intel/xe_media_fill.c > index 4b2c235fa..84c721ba7 100644 > --- a/tests/intel/xe_media_fill.c > +++ b/tests/intel/xe_media_fill.c > @@ -33,6 +33,7 @@ > * Description: Basic test for the media_fill() function, > * a very simple workload for the Media pipeline. > * Feature: media > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: media-fill > diff --git a/tests/intel/xe_mmap.c b/tests/intel/xe_mmap.c > index 8a70a5c35..1b759207b 100644 > --- a/tests/intel/xe_mmap.c > +++ b/tests/intel/xe_mmap.c > @@ -6,9 +6,8 @@ > /** > * TEST: Test if the driver is capable of doing mmap on different memory regions > * Category: Software building block > - * Sub-category: mmap > + * Sub-category: VMA > * Functionality: mmap > - * Test category: functionality test > * Run type: BAT > */ > > @@ -24,6 +23,7 @@ > > /** > * SUBTEST: system > + * Test category: functionality test > * Description: Test mmap on system memory > */ > > @@ -31,12 +31,14 @@ > * SUBTEST: small-bar > * Description: Sanity check mmap behaviour on small-bar systems > * GPU requirements: GPU needs to have dedicated VRAM and using small-bar > + * Test category: functionality test > */ > > /** > * SUBTEST: %s > * Description: Test mmap on %arg[1] memory > * GPU requirements: GPU needs to have dedicated VRAM > + * Test category: functionality test > * > * arg[1]: > * > @@ -64,6 +66,7 @@ test_mmap(int fd, uint32_t flags) > /** > * SUBTEST: bad-flags > * Description: Test mmap offset with bad flags. > + * Test category: negative test > * > */ > static void test_bad_flags(int fd) > @@ -82,6 +85,7 @@ static void test_bad_flags(int fd) > /** > * SUBTEST: bad-extensions > * Description: Test mmap offset with bad extensions. > + * Test category: negative test > * > */ > static void test_bad_extensions(int fd) > @@ -103,6 +107,7 @@ static void test_bad_extensions(int fd) > /** > * SUBTEST: bad-object > * Description: Test mmap offset with bad object. > + * Test category: negative test > * > */ > static void test_bad_object(int fd) > @@ -144,6 +149,7 @@ static void trap_sigbus(uint32_t *ptr) > /** > * SUBTEST: small-bar > * Description: Test mmap behaviour on small-bar systems. > + * Test category: functionality test > * > */ > static void test_small_bar(int fd) > diff --git a/tests/intel/xe_mmio.c b/tests/intel/xe_mmio.c > index 02e79d7e4..4053faa56 100644 > --- a/tests/intel/xe_mmio.c > +++ b/tests/intel/xe_mmio.c > @@ -8,7 +8,6 @@ > * Category: Software building block > * Sub-category: mmio > * Functionality: mmap > - * Test category: functionality test > * Run type: BAT > */ > > @@ -24,6 +23,7 @@ > > /** > * SUBTEST: mmio-timestamp > + * Test category: functionality test > * Description: > * Try to run mmio ioctl with 32 and 64 bits and check it a timestamp > * matches > @@ -51,6 +51,7 @@ static void test_xe_mmio_timestamp(int fd) > > /** > * SUBTEST: mmio-invalid > + * Test category: negative test > * Description: Try to run mmio ioctl with 8, 16 and 32 and 64 bits mmio > */ > > diff --git a/tests/intel/xe_noexec_ping_pong.c b/tests/intel/xe_noexec_ping_pong.c > index cc61a77c1..a238f9d34 100644 > --- a/tests/intel/xe_noexec_ping_pong.c > +++ b/tests/intel/xe_noexec_ping_pong.c > @@ -25,18 +25,25 @@ > * SUBTEST: > * Description: > * This test creates compute vms, binds a couple of bos and an exec_queue each, > - * thus redying it for execution. However, VRAM memory is over- > - * committed and while there is still nothing to execute, an eviction > - * will trigger the VM's rebind worker to rebind the evicted bo, which > - * will in turn trigger another eviction and so on. > + * thus redying it for execution. > * > - * Since we don't have eviction stats yet we need to watch "top" for > - * the rebind kworkers using a lot of CPU while the test idles. > - * > - * The correct driver behaviour should be not to rebind anything unless > - * there is worked queued on one of the VM's compute exec_queues. > * Run type: FULL > */ > + /* > + * More dailed test description: > + * This test creates compute vms, binds a couple of bos and an exec_queue each, > + * thus redying it for execution. However, VRAM memory is over- > + * committed and while there is still nothing to execute, an eviction > + * will trigger the VM's rebind worker to rebind the evicted bo, which > + * will in turn trigger another eviction and so on. > + * > + * Since we don't have eviction stats yet we need to watch "top" for > + * the rebind kworkers using a lot of CPU while the test idles. > + * > + * The correct driver behaviour should be not to rebind anything unless > + * there is worked queued on one of the VM's compute exec_queues. > + */ > + > static void test_ping_pong(int fd, struct drm_xe_engine_class_instance *eci) > { > size_t vram_size = xe_vram_size(fd, 0); > diff --git a/tests/intel/xe_query.c b/tests/intel/xe_query.c > index a4e40afdd..8ec849130 100644 > --- a/tests/intel/xe_query.c > +++ b/tests/intel/xe_query.c > @@ -6,9 +6,8 @@ > /** > * TEST: Check device configuration query > * Category: Software building block > - * Sub-category: ioctl > - * Functionality: device > - * Test category: functionality test > + * Sub-category: uapi > + * Functionality: ioctl > * Run type: BAT > * Description: Acquire configuration data for xe device > */ > @@ -175,6 +174,7 @@ const char *get_topo_name(int value) > /** > * SUBTEST: query-engines > * Description: Display engine classes available for xe device > + * Test category: functionality test > */ > static void > test_query_engines(int fd) > @@ -194,6 +194,7 @@ test_query_engines(int fd) > > /** > * SUBTEST: query-mem-usage > + * Test category: functionality test > * Description: Display memory information like memory class, size > * and alignment. > */ > @@ -254,6 +255,7 @@ test_query_mem_usage(int fd) > > /** > * SUBTEST: query-gts > + * Test category: functionality test > * Description: Display information about available GTs for xe device. > */ > static void > @@ -293,6 +295,7 @@ test_query_gts(int fd) > > /** > * SUBTEST: query-topology > + * Test category: functionality test > * Description: Display topology information of GTs. > */ > static void > @@ -336,6 +339,7 @@ test_query_gt_topology(int fd) > > /** > * SUBTEST: query-config > + * Test category: functionality test > * Description: Display xe device id, revision and configuration. > */ > static void > @@ -386,6 +390,7 @@ test_query_config(int fd) > > /** > * SUBTEST: query-hwconfig > + * Test category: functionality test > * Description: Display hardware configuration of xe device. > */ > static void > @@ -419,6 +424,7 @@ test_query_hwconfig(int fd) > > /** > * SUBTEST: query-invalid-query > + * Test category: negative test > * Description: Check query with invalid arguments returns expected error code. > */ > static void > @@ -436,6 +442,7 @@ test_query_invalid_query(int fd) > > /** > * SUBTEST: query-invalid-size > + * Test category: negative test > * Description: Check query with invalid size returns expected error code. > */ > static void > @@ -453,6 +460,7 @@ test_query_invalid_size(int fd) > > /** > * SUBTEST: query-invalid-extension > + * Test category: negative test > * Description: Check query with invalid extension returns expected error code. > */ > static void > diff --git a/tests/intel/xe_spin_batch.c b/tests/intel/xe_spin_batch.c > index 26f9daf36..9bd3dc349 100644 > --- a/tests/intel/xe_spin_batch.c > +++ b/tests/intel/xe_spin_batch.c > @@ -8,7 +8,7 @@ > * TEST: Tests for spin batch submissons. > * Category: Software building block > * Sub-category: spin > - * Functionality: intel-bb > + * Functionality: parallel execution > * Test category: functionality test > */ > > diff --git a/tests/intel/xe_sysfs_scheduler.c b/tests/intel/xe_sysfs_scheduler.c > index ec2190113..866b9d50a 100644 > --- a/tests/intel/xe_sysfs_scheduler.c > +++ b/tests/intel/xe_sysfs_scheduler.c > @@ -8,17 +8,19 @@ > * Category: Software building block > * Sub-category: sysman > * Functionality: scheduler control interface > - * Test category: functionality test > * Run type: FULL > * > * SUBTEST: %s-invalid > * Description: Test to check if %s arg[1] schedule parameter rejects any unrepresentable intervals. > + * Test category: negative test > * > * SUBTEST: %s-min-max > * Description: Test to check if %s arg[1] schedule parameter checks for min max values. > + * Test category: functionality test > * > * SUBTEST: %s-nonprivileged-user > * Description: Test %s arg[1] schedule parameter for nonprivileged user. > + * Test category: functionality test > * > * arg[1]: > * > diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c > index e48715aed..5453f10c4 100644 > --- a/tests/intel/xe_vm.c > +++ b/tests/intel/xe_vm.c > @@ -7,7 +7,6 @@ > * TEST: Check if VMA functionality is working > * Category: Software building block > * Sub-category: VMA > - * Test category: functionality test > */ > > #include "igt.h" > @@ -84,6 +83,7 @@ write_dwords(int fd, uint32_t vm, int n_dwords, uint64_t *addrs) > * SUBTEST: scratch > * Description: Test scratch page creation and write > * Functionality: scratch page > + * Test category: functionality test > * Run type: FULL > */ > > @@ -206,6 +206,7 @@ uint64_t addrs_57b[] = { > * SUBTEST: bind-once > * Description: bind once on one BO > * Functionality: bind BO > + * Test category: functionality test > * Run type: FULL > */ > > @@ -223,6 +224,7 @@ test_bind_once(int fd) > * SUBTEST: bind-one-bo-many-times > * Description: bind many times on one BO > * Functionality: bind BO > + * Test category: functionality test > * Run type: FULL > */ > > @@ -243,6 +245,7 @@ test_bind_one_bo_many_times(int fd) > * SUBTEST: bind-one-bo-many-times-many-vm > * Description: Test bind many times and many VM on one BO > * Functionality: bind BO > + * Test category: functionality test > * Run type: FULL > */ > > @@ -261,6 +264,7 @@ test_bind_one_bo_many_times_many_vm(int fd) > * SUBTEST: unbind-all-%d-vmas > * Description: Test unbind all with %arg[1] VMAs > * Functionality: unbind > + * Test category: functionality test > * Run type: FULL > * > * arg[1].values: 2, 8 > @@ -301,6 +305,7 @@ static void unbind_all(int fd, int n_vmas) > * Verifies that mapping an invalid userptr returns -EFAULT, > * and that it is correctly handled. > * Functionality: userptr > + * Test category: negative test > * Run type: FULL > */ > static void userptr_invalid(int fd) > @@ -337,11 +342,13 @@ struct vm_thread_data { > * SUBTEST: vm-async-ops-err > * Description: Test VM async ops error > * Functionality: VM > + * Test category: negative test > * Run type: FULL > * > * SUBTEST: vm-async-ops-err-destroy > * Description: Test VM async ops error destroy > * Functionality: VM > + * Test category: negative test > * Run type: FULL > */ > > @@ -502,6 +509,7 @@ static void vm_async_ops_err(int fd, bool destroy) > /** > * SUBTEST: shared-%s-page > * Description: Test shared arg[1] page > + * Test category: functionality test > * Run type: BAT > * > * Functionality: %arg[1] page > @@ -690,11 +698,13 @@ shared_pte_page(int fd, struct drm_xe_engine_class_instance *eci, int n_bo, > * SUBTEST: bind-execqueues-independent > * Description: Test independent bind exec_queues > * Functionality: bind exec_queues > + * Test category: functionality test > * Run type: BAT > * > * SUBTEST: bind-execqueues-conflict > * Description: Test conflict bind exec_queues > * Functionality: bind exec_queues > + * Test category: functionality test > * Run type: BAT > */ > > @@ -864,21 +874,25 @@ test_bind_execqueues_independent(int fd, struct drm_xe_engine_class_instance *ec > * SUBTEST: bind-array-twice > * Description: Test bind array twice > * Functionality: bind exec_queues > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: bind-array-many > * Description: Test bind array many times > * Functionality: bind exec_queues > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: bind-array-exec_queue-twice > * Description: Test bind array exec_queue twice > * Functionality: bind exec_queues > + * Test category: functionality test > * Run type: FULL > * > * SUBTEST: bind-array-exec_queue-many > * Description: Test bind array exec_queue many times > * Functionality: bind exec_queues > + * Test category: functionality test > * Run type: FULL > */ > static void > @@ -1005,6 +1019,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, > * SUBTEST: %s-%ld > * Description: Test %arg[1] with %arg[2] bind size > * Functionality: bind > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -1023,6 +1038,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, > * SUBTEST: %s-%ld > * Description: Test %arg[1] with %arg[2] bind size > * Functionality: userptr bind > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -1042,6 +1058,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, > * SUBTEST: %s-%ld > * Description: Test %arg[1] with %arg[2] bind size > * Functionality: mixed bind > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -1057,6 +1074,7 @@ test_bind_array(int fd, struct drm_xe_engine_class_instance *eci, int n_execs, > * SUBTEST: %s-%ld > * Description: Test %arg[1] with %arg[2] bind size > * Functionality: mixed bind > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -1298,6 +1316,7 @@ static void *hammer_thread(void *tdata) > * SUBTEST: munmap-style-unbind-%s > * Description: Test munmap style unbind with %arg[1] > * Functionality: unbind > + * Test category: functionality test > * > * arg[1]: > * > @@ -1316,6 +1335,7 @@ static void *hammer_thread(void *tdata) > * SUBTEST: munmap-style-unbind-%s > * Description: Test munmap style unbind with %arg[1] > * Functionality: unbind > + * Test category: functionality test > * Run type: FULL > * > * arg[1]: > @@ -1629,8 +1649,8 @@ try_again_after_invalidate: > * SUBTEST: mmap-style-bind-%s > * Description: Test mmap style unbind with %arg[1] > * Functionality: bind > + * Test category: functionality test > * Run type: FULL > - * TODO: change ``'Run type' == FULL`` to a better category > * > * arg[1]: > * ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for IGT XE documentation cleanup (rev2) 2023-09-06 8:56 [igt-dev] [PATCH i-g-t v2 0/2] IGT XE documentation cleanup Katarzyna Dec 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests Katarzyna Dec 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 2/2] test/xe: Clean up of test documentation Katarzyna Dec @ 2023-09-06 9:40 ` Patchwork 2 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2023-09-06 9:40 UTC (permalink / raw) To: Katarzyna Dec; +Cc: igt-dev [-- Attachment #1: Type: text/plain, Size: 8602 bytes --] == Series Details == Series: IGT XE documentation cleanup (rev2) URL : https://patchwork.freedesktop.org/series/123107/ State : failure == Summary == CI Bug Log - changes from CI_DRM_13602 -> IGTPW_9729 ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with IGTPW_9729 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_9729, please notify your bug team (lgci.bug.filing@intel.com) to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/index.html Participating hosts (37 -> 37) ------------------------------ Additional (2): fi-kbl-soraka fi-tgl-1115g4 Missing (2): fi-hsw-4770 fi-snb-2520m Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_9729: ### IGT changes ### #### Possible regressions #### * igt@gem_exec_suspend@basic-s0@smem: - bat-dg2-9: [PASS][1] -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13602/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/bat-dg2-9/igt@gem_exec_suspend@basic-s0@smem.html Known issues ------------ Here are the changes found in IGTPW_9729 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@debugfs_test@basic-hwmon: - fi-tgl-1115g4: NOTRUN -> [SKIP][3] ([i915#7456]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html * igt@gem_huc_copy@huc-copy: - fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([i915#2190]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html - fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@basic: - fi-kbl-soraka: NOTRUN -> [SKIP][6] ([fdo#109271] / [i915#4613]) +3 other tests skip [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html * igt@gem_lmem_swapping@parallel-random-engines: - fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([i915#4613]) +3 other tests skip [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html * igt@i915_pm_backlight@basic-brightness: - fi-tgl-1115g4: NOTRUN -> [SKIP][8] ([i915#3546] / [i915#7561]) [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html * igt@i915_selftest@live@gt_heartbeat: - fi-cfl-8109u: [PASS][9] -> [DMESG-FAIL][10] ([i915#5334]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13602/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-cfl-8109u/igt@i915_selftest@live@gt_heartbeat.html * igt@i915_selftest@live@gt_pm: - fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886] / [i915#7913]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html * igt@i915_suspend@basic-s3-without-i915: - fi-tgl-1115g4: NOTRUN -> [INCOMPLETE][12] ([i915#7443] / [i915#8102]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic: - fi-kbl-soraka: NOTRUN -> [SKIP][13] ([fdo#109271]) +8 other tests skip [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-kbl-soraka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html - fi-tgl-1115g4: NOTRUN -> [SKIP][14] ([i915#4103]) +1 other test skip [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html * igt@kms_force_connector_basic@force-load-detect: - fi-tgl-1115g4: NOTRUN -> [SKIP][15] ([fdo#109285]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html * igt@kms_psr@cursor_plane_move: - fi-tgl-1115g4: NOTRUN -> [SKIP][16] ([fdo#110189]) +3 other tests skip [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@kms_psr@cursor_plane_move.html * igt@kms_psr@primary_page_flip: - bat-rplp-1: NOTRUN -> [SKIP][17] ([i915#1072]) +3 other tests skip [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/bat-rplp-1/igt@kms_psr@primary_page_flip.html * igt@kms_setmode@basic-clone-single-crtc: - bat-rplp-1: NOTRUN -> [ABORT][18] ([i915#8260] / [i915#8668]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/bat-rplp-1/igt@kms_setmode@basic-clone-single-crtc.html - fi-tgl-1115g4: NOTRUN -> [SKIP][19] ([i915#3555]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html #### Possible fixes #### * igt@kms_chamelium_edid@hdmi-edid-read: - {bat-dg2-13}: [DMESG-WARN][20] ([i915#7952]) -> [PASS][21] [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13602/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/bat-dg2-13/igt@kms_chamelium_edid@hdmi-edid-read.html * igt@kms_frontbuffer_tracking@basic: - fi-bsw-nick: [FAIL][22] ([i915#9276]) -> [PASS][23] [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13602/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/fi-bsw-nick/igt@kms_frontbuffer_tracking@basic.html * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1: - bat-rplp-1: [ABORT][24] ([i915#8442] / [i915#8668]) -> [PASS][25] [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13602/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html {name}: This element is suppressed. This means it is ignored when computing the status of the difference (SUCCESS, WARNING, or FAILURE). [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285 [fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189 [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072 [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546 [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555 [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103 [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613 [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334 [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359 [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443 [i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456 [i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561 [i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913 [i915#7952]: https://gitlab.freedesktop.org/drm/intel/issues/7952 [i915#8102]: https://gitlab.freedesktop.org/drm/intel/issues/8102 [i915#8260]: https://gitlab.freedesktop.org/drm/intel/issues/8260 [i915#8442]: https://gitlab.freedesktop.org/drm/intel/issues/8442 [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668 [i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981 [i915#9276]: https://gitlab.freedesktop.org/drm/intel/issues/9276 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_7469 -> IGTPW_9729 CI-20190529: 20190529 CI_DRM_13602: f095f97b2060f654211f8acf213c3606ef6eb6d1 @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_9729: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/index.html IGT_7469: b367c5a34e6198074dfe220437b234441d3b3c5d @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9729/index.html [-- Attachment #2: Type: text/html, Size: 9895 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-09-06 9:40 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-09-06 8:56 [igt-dev] [PATCH i-g-t v2 0/2] IGT XE documentation cleanup Katarzyna Dec 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 1/2] tests/intel: Add missing documentation fields for tests Katarzyna Dec 2023-09-06 9:11 ` Mauro Carvalho Chehab 2023-09-06 8:56 ` [igt-dev] [PATCH i-g-t v2 2/2] test/xe: Clean up of test documentation Katarzyna Dec 2023-09-06 9:14 ` Mauro Carvalho Chehab 2023-09-06 9:40 ` [igt-dev] ✗ Fi.CI.BAT: failure for IGT XE documentation cleanup (rev2) Patchwork
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox