Re: [igt-dev] [i-g-t V2 1/7] tests/intel/pm: Rename i915_pm_backlight to kms_pm_backlight

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On Wed, 6 Sep 2023 13:23:24 +0530
"Sharma, Swati2" <swati2.sharma@intel.com> wrote:

> > --- a/tests/intel/i915_pm_backlight.c
> > +++ b/tests/intel/kms_pm_backlight.c
> > @@ -1,27 +1,6 @@
> > +// SPDX-License-Identifier: MIT
> >   /*
> > - * Copyright © 2015 Intel Corporation
> > - *
> > - * Permission is hereby granted, free of charge, to any person obtaining a
> > - * copy of this software and associated documentation files (the "Software"),
> > - * to deal in the Software without restriction, including without limitation
> > - * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> > - * and/or sell copies of the Software, and to permit persons to whom the
> > - * Software is furnished to do so, subject to the following conditions:
> > - *
> > - * The above copyright notice and this permission notice (including the next
> > - * paragraph) shall be included in all copies or substantial portions of the
> > - * Software.
> > - *
> > - * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> > - * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> > - * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> > - * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> > - * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> > - * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> > - * IN THE SOFTWARE.
> > - *
> > - * Author:
> > - *    Antti Koskipaa <antti.koskipaa@linux.intel.com>
> > + * Copyright © 2023 Intel Corporation
> >    *
> >    */  
> 
> We can't remove old copyright. This has to remain same. With new IGT we 
> are using SPDX, older IGT will continue using already existing copyright.

I'm not a lawyer, but let me give my 2 cents here.

IMO, the best is to have a change like that on a separate patch, as this is
not related to "Rename i915_pm_backlight to kms_pm_backlight".

Now, the above changeset is actually doing two changes:

1. It is replacing a MIT text by a SPDX equivalent. This should be fine,
   provided that you keep the original copyright date - eventually adding
   2023 to it. So:

	 * Copyright © 2015 Intel Corporation
	 *
	 * Permission is hereby granted, free of charge, to any person obtaining a
	 * copy of this software and associated documentation files (the "Software"),
	 * to deal in the Software without restriction, including without limitation
	 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
	 * and/or sell copies of the Software, and to permit persons to whom the
	 * Software is furnished to do so, subject to the following conditions:
	 *
	 * The above copyright notice and this permission notice (including the next
	 * paragraph) shall be included in all copies or substantial portions of the
	 * Software.
	 *
	 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
	 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
	 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
	 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
	 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
	 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
	 * IN THE SOFTWARE.

   can be replaced by either:

	// SPDX-License-Identifier: MIT
	/* Copyright © 2015 Intel Corporation  */

   or:

	// SPDX-License-Identifier: MIT
	/* Copyright © 2015, 2023 Intel Corporation  */

2. It is also stripping authorship rights. Depending on the jurisdiction,
   authorship rights are explicitly protected. Laws may even prevent it to
   be sellable. They're also forever protected.

   So, for instance, even if you buy a picture from Salvador Dali, even
   buying its copyrights, you can't remove his signature and replace by
   yours.

   So, with regards to this change:
	
	- * Author:
	- *    Antti Koskipaa <antti.koskipaa@linux.intel.com>

   NACK.

Regards,
Mauro