Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Bhanuprakash Modem <bhanuprakash.modem@intel.com>,
	igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [i-g-t V2 4/7] tests/intel/kms_pm_dc: Fix testplan documentation
Date: Wed, 6 Sep 2023 13:37:10 +0530	[thread overview]
Message-ID: <fe02f1cb-b319-3f2a-5f8f-20f65ede7d35@intel.com> (raw)
In-Reply-To: <20230905125356.1659246-5-bhanuprakash.modem@intel.com>

LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 05-Sep-23 6:23 PM, Bhanuprakash Modem wrote:
> As kms_pm_dc is moved to display, update the test documentation
> according to the kms testplan kms_test_config.json
> 
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> ---
>   tests/intel/kms_pm_dc.c | 66 ++++++++++++++++++++++++++++-------------
>   1 file changed, 45 insertions(+), 21 deletions(-)
> 
> diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
> index b5b38c976..dd810c0c2 100644
> --- a/tests/intel/kms_pm_dc.c
> +++ b/tests/intel/kms_pm_dc.c
> @@ -19,45 +19,69 @@
>   #include "time.h"
>   #include "igt_pm.h"
>   /**
> - * TEST: i915 pm dc
> + * TEST: kms pm dc
> + * Category: Display
>    * Description: Tests to validate display power DC states.
> - * Run type: FULL
>    *
>    * SUBTEST: dc3co-vpb-simulation
> - * Description:
> - *   In this test we make sure that system enters DC3CO when PSR2 is active and system is in SLEEP
> - *   state
> - * Feature: dc3co, pm_dc
> + * Description: Make sure that system enters DC3CO when PSR2 is active and system
> + *              is in SLEEP state
> + * Driver requirement: i915
> + * Functionality: dc3co, pm_dc, psr2
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: dc5-dpms
> - * Description:
> - *   This test validates display engine entry to DC5 state while all connectors's DPMS property
> - *   set to OFF
> - * Feature: pm_dc
> + * Description: Validate display engine entry to DC5 state while all connectors's
> + *              DPMS property set to OFF
> + * Driver requirement: i915
> + * Functionality: dpms, pm_dc
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: dc5-dpms-negative
> - * Description:
> - *   This test validates negative scenario of DC5 display engine entry to DC5 state while all
> - *   connectors's DPMS property set to ON
> - * Feature: pm_dc
> + * Description: Validate negative scenario of DC5 display engine entry to DC5 state
> + *              while all connectors's DPMS property set to ON
> + * Driver requirement: i915
> + * Functionality: dpms, pm_dc
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: dc5-psr
>    * Description: This test validates display engine entry to DC5 state while PSR is active
> - * Feature: pm_dc
> + * Driver requirement: i915
> + * Functionality: pm_dc, psr
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: dc6-dpms
> - * Description:
> - *   This test validates display engine entry to DC6 state while all connectors's DPMS property
> - *   set to OFF
> - * Feature: pm_dc
> + * Description: Validate display engine entry to DC6 state while all connectors's
> + *              DPMS property set to OFF
> + * Driver requirement: i915
> + * Functionality: dpms, pm_dc
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: dc6-psr
>    * Description: This test validates display engine entry to DC6 state while PSR is active
> - * Feature: pm_dc
> + * Driver requirement: i915
> + * Functionality: pm_dc, psr
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    *
>    * SUBTEST: dc9-dpms
>    * Description: This test validates display engine entry to DC9 state
> - * Feature: pm_dc
> + * Driver requirement: i915
> + * Functionality: dpms, pm_dc
> + * Mega feature: Display Power
> + * Run type: FULL
> + * Test category: functionality test
>    */
>   
>   /* DC State Flags */

  reply	other threads:[~2023-09-06  8:07 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-05 12:53 [igt-dev] [i-g-t V2 0/7] Separate display PM tests from Core Bhanuprakash Modem
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 1/7] tests/intel/pm: Rename i915_pm_backlight to kms_pm_backlight Bhanuprakash Modem
2023-09-06  7:53   ` Sharma, Swati2
2023-09-06  9:33     ` Mauro Carvalho Chehab
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 2/7] tests/intel/kms_pm_backlight: Fix testplan documentation Bhanuprakash Modem
2023-09-06  7:56   ` Sharma, Swati2
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 3/7] tests/intel/pm: Rename i915_pm_dc to kms_pm_dc Bhanuprakash Modem
2023-09-06  7:59   ` Sharma, Swati2
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 4/7] tests/intel/kms_pm_dc: Fix testplan documentation Bhanuprakash Modem
2023-09-06  8:07   ` Sharma, Swati2 [this message]
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 5/7] tests/intel/pm: Rename i915_pm_lpsp to kms_pm_lpsp Bhanuprakash Modem
2023-09-06  8:08   ` Sharma, Swati2
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 6/7] tests/intel/kms_pm_lpsp: Fix testplan documentation Bhanuprakash Modem
2023-09-06  8:12   ` Sharma, Swati2
2023-09-05 12:53 ` [igt-dev] [i-g-t V2 7/7] tests/intel/pm: Separate display specific tests from i915_pm_rpm Bhanuprakash Modem
2023-09-06 13:35   ` Sharma, Swati2
2023-09-05 17:07 ` [igt-dev] ✓ Fi.CI.BAT: success for Separate display PM tests from Core (rev2) Patchwork
2023-09-05 20:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fe02f1cb-b319-3f2a-5f8f-20f65ede7d35@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox