Re: [igt-dev] [Intel-gfx] [PATCH i-g-t v2 05/17] lib/kunit: Fix illegal igt_fail() calls inside subtest body

[Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>]

On Fri, 15 Sep 2023 12:08:50 +0200
Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> wrote:

> Hi Mauro,
> 
> On Friday, 15 September 2023 11:58:36 CEST Mauro Carvalho Chehab wrote:
> > Hi Janusz,
> > 
> > 
> > On 9/11/23 10:52, Mauro Carvalho Chehab wrote:  
> > > On Fri,  8 Sep 2023 14:32:39 +0200
> > > Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com> wrote:
> > >   
> > >   void igt_kunit(const char *module_name, const char *name, const char *opts)
> > >   {
> > > +	struct igt_ktest tst;
> > > +
> > > +	if (igt_ktest_init(&tst, module_name) != 0)
> > > +		return;
> > > Shouldn't it be calling igt_skip() here too?  
> > 
> > Maybe due to that, but running:
> > 
> >      $ cd 
> > /lib/modules/6.5.0-rc7-xe-public-4a9681392cec+/kernel/drivers/gpu/drm/xe/tests
> >      $ sudo mv xe_bo_test.ko xe_blocked_bo_test.ko
> > 
> >      sudo ./build/tests/xe_live_ktest
> >      IGT-Version: 1.28-g3d29cbf02 (x86_64) (Linux: 
> > 6.5.0-rc7-xe-public-4a9681392cec+ x86_64)
> >      Starting subtest: bo
> > 
> >      <IGT hangs forever waiting for module load to complete>
> > 
> > 
> > It seems that something at KUnit modprobe logic require fixes.  
> 
> Please test with 17/17 and 15/17 reverted.

With both reverted, it worked.

Regards,
Mauro