Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_concurrent: remove pipe dependency in subtest name
@ 2023-09-18 14:37 Swati Sharma
  2023-09-18 21:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 8+ messages in thread
From: Swati Sharma @ 2023-09-18 14:37 UTC (permalink / raw)
  To: igt-dev

Remove pipe dependency in subtest name and give some
meaningful name to subtest.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/kms_concurrent.c | 39 ++++++++++++---------------------------
 1 file changed, 12 insertions(+), 27 deletions(-)

diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d9cb197de..e38ee0a4d 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -30,24 +30,13 @@
  * Description: Test atomic mode setting concurrently with multiple planes and
  *              screen resolution
  *
- * SUBTEST: pipe-%s
+ * SUBTEST: multi-plane-atomic-resolution
  * Description: Test atomic mode setting concurrently with multiple planes and
- *              screen resolution on %arg[1].
+ *              screen resolution.
  * Driver requirement: i915, xe
  * Functionality: kms_core
  * Mega feature: General Display Features
  * Test category: functionality test
- *
- * arg[1]:
- *
- * @A:      pipe A
- * @B:      pipe B
- * @C:      pipe C
- * @D:      pipe D
- * @E:      pipe E
- * @F:      pipe F
- * @G:      pipe G
- * @H:      pipe H
  */
 
 IGT_TEST_DESCRIPTION("Test atomic mode setting concurrently with multiple planes and screen resolution");
@@ -61,6 +50,7 @@ typedef struct {
 	igt_display_t display;
 	igt_plane_t **plane;
 	struct igt_fb *fb;
+	enum pipe pipe;
 } data_t;
 
 /* Command line parameters. */
@@ -341,30 +331,30 @@ run_test(data_t *data, enum pipe pipe, igt_output_t *output)
 }
 
 static void
-run_tests_for_pipe(data_t *data, enum pipe pipe)
+run_tests_for_pipe(data_t *data)
 {
 	igt_output_t *output;
 
 	igt_fixture {
-		igt_require_pipe(&data->display, pipe);
-		igt_require(data->display.pipes[pipe].n_planes > 0);
+		igt_require_pipe(&data->display, data->pipe);
+		igt_require(data->display.pipes[data->pipe].n_planes > 0);
 
 		igt_display_require_output(&data->display);
 	}
 
 	igt_describe("Test atomic mode setting concurrently with multiple planes and screen "
 		     "resolution.");
-	igt_subtest_with_dynamic_f("pipe-%s", kmstest_pipe_name(pipe)) {
-		for_each_valid_output_on_pipe(&data->display, pipe, output) {
+	igt_subtest_with_dynamic("multi-plane-atomic-resolution") {
+		for_each_pipe_with_single_output(&data->display, data->pipe, output) {
 			igt_display_reset(&data->display);
 
-			igt_output_set_pipe(output, pipe);
+			igt_output_set_pipe(output, data->pipe);
 			if (!i915_pipe_output_combo_valid(&data->display))
 				continue;
 
 			igt_output_set_pipe(output, PIPE_NONE);
-			igt_dynamic_f("%s", igt_output_name(output))
-				run_test(data, pipe, output);
+			igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(data->pipe), igt_output_name(output))
+				run_test(data, data->pipe, output);
 		}
 	}
 }
@@ -405,8 +395,6 @@ static data_t data;
 
 igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
-	enum pipe pipe;
-
 	igt_fixture {
 		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
 		kmstest_set_vt_graphics_mode();
@@ -416,10 +404,7 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 			intel_allocator_multiprocess_start();
 	}
 
-	for_each_pipe_static(pipe) {
-		igt_subtest_group
-			run_tests_for_pipe(&data, pipe);
-	}
+	run_tests_for_pipe(&data);
 
 	igt_fixture {
 		if (is_intel_device(data.drm_fd))
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-09-26 16:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-18 14:37 [igt-dev] [PATCH i-g-t] tests/kms_concurrent: remove pipe dependency in subtest name Swati Sharma
2023-09-18 21:07 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2023-09-18 22:14 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
2023-09-21  6:57 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-21  7:29 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-09-21 17:38 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-22 14:58 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2023-09-26 16:33 ` [igt-dev] [PATCH i-g-t] " Modem, Bhanuprakash

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox