Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: chris.p.wilson@linux.intel.com
Subject: [igt-dev] [PATCH i-g-t 01/14] lib/igt_device_scan: Xe get integrated/discrete card functions
Date: Tue, 26 Sep 2023 08:44:16 +0000	[thread overview]
Message-ID: <20230926084451.1732748-2-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20230926084451.1732748-1-marcin.bernatowicz@linux.intel.com>

Xe functions to get integrated/discrete card.

v2:
- renamed __find_first_i915_card to __find_first_intel_card_by_driver_name (Zbyszek)
v3:
- added documentation to public functions (Kamil)

Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
---
 lib/igt_device_scan.c | 52 +++++++++++++++++++++++++++++++++++--------
 lib/igt_device_scan.h |  2 ++
 2 files changed, 45 insertions(+), 9 deletions(-)

diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index ae69ed09f..f4f95fef3 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -769,25 +769,27 @@ __copy_dev_to_card(struct igt_device *dev, struct igt_device_card *card)
  * Iterate over all igt_devices array and find first discrete/integrated card.
  * card->pci_slot_name will be updated only if a card is found.
  */
-static bool __find_first_i915_card(struct igt_device_card *card, bool discrete)
+static bool __find_first_intel_card_by_driver_name(struct igt_device_card *card,
+				bool want_discrete, const char *drv_name)
 {
 	struct igt_device *dev;
-	int cmp;
+	int is_integrated;
 
+	igt_assert(drv_name);
 	memset(card, 0, sizeof(*card));
 
 	igt_list_for_each_entry(dev, &igt_devs.all, link) {
 
-		if (!is_pci_subsystem(dev) || strcmp(dev->driver, "i915"))
+		if (!is_pci_subsystem(dev) || strcmp(dev->driver, drv_name))
 			continue;
 
-		cmp = strncmp(dev->pci_slot_name, INTEGRATED_I915_GPU_PCI_ID,
-			      PCI_SLOT_NAME_SIZE);
+		is_integrated = !strncmp(dev->pci_slot_name, INTEGRATED_I915_GPU_PCI_ID,
+					 PCI_SLOT_NAME_SIZE);
 
-		if (discrete && cmp) {
+		if (want_discrete && !is_integrated) {
 			__copy_dev_to_card(dev, card);
 			return true;
-		} else if (!discrete && !cmp) {
+		} else if (!want_discrete && is_integrated) {
 			__copy_dev_to_card(dev, card);
 			return true;
 		}
@@ -800,14 +802,46 @@ bool igt_device_find_first_i915_discrete_card(struct igt_device_card *card)
 {
 	igt_assert(card);
 
-	return __find_first_i915_card(card, true);
+	return __find_first_intel_card_by_driver_name(card, true, "i915");
+}
+
+/**
+ * igt_device_find_first_xe_discrete_card
+ * @card: pointer to igt_device_card structure
+ *
+ * Iterate over all igt_devices array and find first xe discrete card.
+ * card will be updated only if a device is found.
+ *
+ * Returns: true if device is found, false otherwise.
+ */
+bool igt_device_find_first_xe_discrete_card(struct igt_device_card *card)
+{
+	igt_assert(card);
+
+	return __find_first_intel_card_by_driver_name(card, true, "xe");
 }
 
 bool igt_device_find_integrated_card(struct igt_device_card *card)
 {
 	igt_assert(card);
 
-	return __find_first_i915_card(card, false);
+	return __find_first_intel_card_by_driver_name(card, false, "i915");
+}
+
+/**
+ * igt_device_find_xe_integrated_card
+ * @card: pointer to igt_device_card structure
+ *
+ * Iterate over all igt_devices array and find first xe integrated card.
+ * card will be updated only if a device is found.
+ *
+ * Returns: true if device is found, false otherwise.
+ */
+bool igt_device_find_xe_integrated_card(struct igt_device_card *card)
+{
+	igt_assert(card);
+
+	return __find_first_intel_card_by_driver_name(card, false, "xe");
 }
 
 static struct igt_device *igt_device_from_syspath(const char *syspath)
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index e6b0f1b90..b8f6a843d 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -87,6 +87,8 @@ bool igt_device_card_match_pci(const char *filter,
 	struct igt_device_card *card);
 bool igt_device_find_first_i915_discrete_card(struct igt_device_card *card);
 bool igt_device_find_integrated_card(struct igt_device_card *card);
+bool igt_device_find_first_xe_discrete_card(struct igt_device_card *card);
+bool igt_device_find_xe_integrated_card(struct igt_device_card *card);
 char *igt_device_get_pretty_name(struct igt_device_card *card, bool numeric);
 int igt_open_card(struct igt_device_card *card);
 int igt_open_render(struct igt_device_card *card);
-- 
2.42.0

  reply	other threads:[~2023-09-26  9:18 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-26  8:44 [igt-dev] [PATCH i-g-t 00/14] [RFC] benchmarks/gem_wsim: added basic xe support Marcin Bernatowicz
2023-09-26  8:44 ` Marcin Bernatowicz [this message]
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 02/14] benchmarks/gem_wsim: reposition the unbound duration boolean Marcin Bernatowicz
2023-09-26 10:23   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 03/14] benchmarks/gem_wsim: fix scaling of period steps Marcin Bernatowicz
2023-09-26 10:28   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 04/14] benchmarks/gem_wsim: fix duration range check Marcin Bernatowicz
2023-09-26 10:40   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 05/14] benchmarks/gem_wsim: extract duration parsing code to new function Marcin Bernatowicz
2023-09-26 10:48   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 06/14] benchmarks/gem_wsim: fix conflicting SSEU #define and enum Marcin Bernatowicz
2023-09-26 10:51   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 07/14] benchmarks/gem_wsim: cleanups Marcin Bernatowicz
2023-09-26 11:08   ` Tvrtko Ursulin
2023-09-27 19:03     ` Bernatowicz, Marcin
2023-09-28  8:37       ` Bernatowicz, Marcin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 08/14] benchmarks/gem_wsim: reposition repeat_start variable Marcin Bernatowicz
2023-09-26 11:10   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 09/14] benchmarks/gem_wsim: use lib code to query engines Marcin Bernatowicz
2023-09-26 11:23   ` Tvrtko Ursulin
2023-09-27 19:09     ` Bernatowicz, Marcin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 10/14] benchmarks/gem_wsim: allow comments in workload description files Marcin Bernatowicz
2023-09-26 11:33   ` Tvrtko Ursulin
2023-09-26 11:48     ` Bernatowicz, Marcin
2023-09-26 12:10       ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 11/14] benchmarks/gem_wsim: introduce w_step_sync function Marcin Bernatowicz
2023-09-26 11:37   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 12/14] benchmarks/gem_wsim: extract prepare contexts code to new function Marcin Bernatowicz
2023-09-26 11:43   ` Tvrtko Ursulin
2023-09-26 11:58     ` Bernatowicz, Marcin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 13/14] benchmarks/gem_wsim: extract prepare working sets " Marcin Bernatowicz
2023-09-26 11:46   ` Tvrtko Ursulin
2023-09-26  8:44 ` [igt-dev] [PATCH i-g-t 14/14] benchmarks/gem_wsim: added basic xe support Marcin Bernatowicz
2023-09-26 13:10   ` Tvrtko Ursulin
2023-09-26 18:52     ` Bernatowicz, Marcin
2023-09-27 13:17       ` Tvrtko Ursulin
2023-09-26 10:03 ` [igt-dev] ✓ CI.xeBAT: success for benchmarks/gem_wsim: added basic xe support (rev3) Patchwork
2023-09-26 10:11 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-09-26 11:56 ` [igt-dev] ✗ Fi.CI.BUILD: failure for benchmarks/gem_wsim: added basic xe support (rev4) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230926084451.1732748-2-marcin.bernatowicz@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=chris.p.wilson@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox