From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 2/4] lib/igt_kms: Expose helper to convert rotation to string
Date: Fri, 6 Oct 2023 13:28:17 +0530 [thread overview]
Message-ID: <20231006075819.3055887-3-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231006075819.3055887-1-bhanuprakash.modem@intel.com>
Expose helper to convert rotation to string.
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
lib/igt_kms.c | 20 +++++++++++++-------
lib/igt_kms.h | 1 +
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index c2f3728a6..ec4cd78cd 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -4902,17 +4902,23 @@ void igt_fb_set_size(struct igt_fb *fb, igt_plane_t *plane,
igt_plane_set_prop_value(plane, IGT_PLANE_SRC_H, IGT_FIXED(h, 0));
}
-static const char *rotation_name(igt_rotation_t rotation)
+/**
+ * igt_plane_rotation_name:
+ * @rotation: Plane rotation value (0, 90, 180, 270)
+ *
+ * Returns: Plane rotation value as a string
+ */
+const char *igt_plane_rotation_name(igt_rotation_t rotation)
{
switch (rotation & IGT_ROTATION_MASK) {
case IGT_ROTATION_0:
- return "0°";
+ return "0";
case IGT_ROTATION_90:
- return "90°";
+ return "90";
case IGT_ROTATION_180:
- return "180°";
+ return "180";
case IGT_ROTATION_270:
- return "270°";
+ return "270";
default:
igt_assert(0);
}
@@ -4932,9 +4938,9 @@ void igt_plane_set_rotation(igt_plane_t *plane, igt_rotation_t rotation)
igt_pipe_t *pipe = plane->pipe;
igt_display_t *display = pipe->display;
- LOG(display, "%s.%d: plane_set_rotation(%s)\n",
+ LOG(display, "%s.%d: plane_set_rotation(%s°)\n",
kmstest_pipe_name(pipe->pipe),
- plane->index, rotation_name(rotation));
+ plane->index, igt_plane_rotation_name(rotation));
igt_plane_set_prop_value(plane, IGT_PLANE_ROTATION, rotation);
}
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index f2c3741fc..4bcaf3f73 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -536,6 +536,7 @@ static inline bool igt_plane_has_rotation(igt_plane_t *plane, igt_rotation_t rot
{
return (plane->rotations & rotation) == rotation;
}
+const char *igt_plane_rotation_name(igt_rotation_t rotation);
void igt_wait_for_vblank(int drm_fd, int crtc_offset);
void igt_wait_for_vblank_count(int drm_fd, int crtc_offset, int count);
--
2.40.0
next prev parent reply other threads:[~2023-10-06 8:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 7:58 [igt-dev] [i-g-t 0/4] KMS: Minor cleanups Bhanuprakash Modem
2023-10-06 7:58 ` [igt-dev] [i-g-t 1/4] lib/igt_fb: Use small case for modifier name Bhanuprakash Modem
2023-10-06 8:18 ` B, Jeevan
2023-10-06 7:58 ` Bhanuprakash Modem [this message]
2023-10-06 8:23 ` [igt-dev] [i-g-t 2/4] lib/igt_kms: Expose helper to convert rotation to string B, Jeevan
2023-10-06 7:58 ` [igt-dev] [i-g-t 3/4] tests/intel/kms_ccs: Rename subtests Bhanuprakash Modem
2023-10-06 8:21 ` B, Jeevan
2023-10-06 7:58 ` [igt-dev] [i-g-t 4/4] tests/kms_rotation_crc: Use helpers from lib Bhanuprakash Modem
2023-10-10 14:51 ` Sharma, Swati2
2023-10-06 9:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for KMS: Minor cleanups Patchwork
2023-10-06 10:07 ` Modem, Bhanuprakash
2023-10-06 12:01 ` Yedireswarapu, SaiX Nandan
2023-10-06 10:45 ` [igt-dev] ✗ CI.xeBAT: " Patchwork
2023-10-06 11:53 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-06 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006075819.3055887-3-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox