Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [i-g-t 4/4] tests/kms_rotation_crc: Use helpers from lib
Date: Fri,  6 Oct 2023 13:28:19 +0530	[thread overview]
Message-ID: <20231006075819.3055887-5-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20231006075819.3055887-1-bhanuprakash.modem@intel.com>

Instead of having local implementations, use helpers from lib.

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/kms_rotation_crc.c | 40 ++++------------------------------------
 1 file changed, 4 insertions(+), 36 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index f171fcd22..c48e0d672 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -1178,38 +1178,6 @@ static const char *plane_test_str(unsigned plane)
 	}
 }
 
-static const char *rot_test_str(igt_rotation_t rot)
-{
-	switch (rot) {
-	case IGT_ROTATION_0:
-		return "0";
-	case IGT_ROTATION_90:
-		return "90";
-	case IGT_ROTATION_180:
-		return "180";
-	case IGT_ROTATION_270:
-		return "270";
-	default:
-		igt_assert(0);
-	}
-}
-
-static const char *modifier_test_str(uint64_t modifier)
-{
-	switch (modifier) {
-	case I915_FORMAT_MOD_X_TILED:
-		return "x-tiled";
-	case I915_FORMAT_MOD_Y_TILED:
-		return "y-tiled";
-	case I915_FORMAT_MOD_Yf_TILED:
-		return "yf-tiled";
-	case I915_FORMAT_MOD_4_TILED:
-		return "4-tiled";
-	default:
-		igt_assert(0);
-	}
-}
-
 static int opt_handler(int opt, int opt_index, void *_data)
 {
 	data_t *data = _data;
@@ -1289,7 +1257,7 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	for (subtest = subtests; subtest->rot; subtest++) {
 		igt_subtest_f("%s-rotation-%s",
 			      plane_test_str(subtest->plane),
-			      rot_test_str(subtest->rot)) {
+			      igt_plane_rotation_name(subtest->rot)) {
 			if (is_amdgpu_device(data.gfx_fd)) {
 				data.override_fmt = DRM_FORMAT_XRGB8888;
 				if (igt_rotation_90_or_270(subtest->rot))
@@ -1339,9 +1307,9 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 		igt_fixture
 			igt_require_intel(data.gfx_fd);
 
-		igt_subtest_f("primary-%s-reflect-x-%s",
-			      modifier_test_str(reflect_x->modifier),
-			      rot_test_str(reflect_x->rot)) {
+		igt_subtest_f("primary-%s-tiled-reflect-x-%s",
+			      igt_fb_modifier_name(reflect_x->modifier),
+			      igt_plane_rotation_name(reflect_x->rot)) {
 			data.rotation = (IGT_REFLECT_X | reflect_x->rot);
 			data.override_modifier = reflect_x->modifier;
 			test_plane_rotation(&data, DRM_PLANE_TYPE_PRIMARY, false);
-- 
2.40.0

  parent reply	other threads:[~2023-10-06  8:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06  7:58 [igt-dev] [i-g-t 0/4] KMS: Minor cleanups Bhanuprakash Modem
2023-10-06  7:58 ` [igt-dev] [i-g-t 1/4] lib/igt_fb: Use small case for modifier name Bhanuprakash Modem
2023-10-06  8:18   ` B, Jeevan
2023-10-06  7:58 ` [igt-dev] [i-g-t 2/4] lib/igt_kms: Expose helper to convert rotation to string Bhanuprakash Modem
2023-10-06  8:23   ` B, Jeevan
2023-10-06  7:58 ` [igt-dev] [i-g-t 3/4] tests/intel/kms_ccs: Rename subtests Bhanuprakash Modem
2023-10-06  8:21   ` B, Jeevan
2023-10-06  7:58 ` Bhanuprakash Modem [this message]
2023-10-10 14:51   ` [igt-dev] [i-g-t 4/4] tests/kms_rotation_crc: Use helpers from lib Sharma, Swati2
2023-10-06  9:58 ` [igt-dev] ✗ Fi.CI.BAT: failure for KMS: Minor cleanups Patchwork
2023-10-06 10:07   ` Modem, Bhanuprakash
2023-10-06 12:01     ` Yedireswarapu, SaiX Nandan
2023-10-06 10:45 ` [igt-dev] ✗ CI.xeBAT: " Patchwork
2023-10-06 11:53 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-06 21:14 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006075819.3055887-5-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox