From: Helen Koike <helen.koike@collabora.com>
To: igt-dev@lists.freedesktop.org
Cc: robdclark@chromium.org, emma@anholt.net,
Helen Koike <helen.koike@collabora.com>
Subject: [igt-dev] [PATCH 1/2] lib/drmtest: add igt_debug when forced and dev_name doesn't match
Date: Sun, 8 Oct 2023 19:23:05 -0300 [thread overview]
Message-ID: <20231008222306.145122-1-helen.koike@collabora.com> (raw)
Make it easier to understand what was the expected string.
Signed-off-by: Helen Koike <helen.koike@collabora.com>
---
lib/drmtest.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index e1da66c87..98910a84c 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -260,8 +260,11 @@ static int open_device(const char *name, unsigned int chipset)
goto err;
forced = forced_driver();
- if (forced && chipset == DRIVER_ANY && strcmp(forced, dev_name))
+ if (forced && chipset == DRIVER_ANY && strcmp(forced, dev_name)) {
+ igt_debug("Expected driver \"%s\" but got \"%s\"\n",
+ forced, dev_name);
goto err;
+ }
for (int start = 0, end = ARRAY_SIZE(modules) - 1; start < end; ){
int mid = start + (end - start) / 2;
--
2.34.1
next reply other threads:[~2023-10-08 22:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-08 22:23 Helen Koike [this message]
2023-10-08 22:23 ` [igt-dev] [PATCH 2/2] core_getversion: drop unused assert Helen Koike
2023-10-09 16:09 ` Kamil Konieczny
2023-10-08 23:17 ` [igt-dev] ✓ CI.xeBAT: success for series starting with [1/2] lib/drmtest: add igt_debug when forced and dev_name doesn't match Patchwork
2023-10-08 23:18 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-10-09 16:58 ` Kamil Konieczny
2023-10-10 11:09 ` Yedireswarapu, SaiX Nandan
2023-10-09 17:08 ` Kamil Konieczny
2023-10-09 16:08 ` [igt-dev] [PATCH 1/2] " Kamil Konieczny
2023-10-10 9:32 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2023-10-10 9:51 ` Patchwork
2023-11-07 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] lib/drmtest: add igt_debug when forced and dev_name doesn't match (rev2) Patchwork
2023-11-07 11:02 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-07 22:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231008222306.145122-1-helen.koike@collabora.com \
--to=helen.koike@collabora.com \
--cc=emma@anholt.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox