Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: igt-dev@lists.freedesktop.org
Cc: robdclark@chromium.org, emma@anholt.net,
	Helen Koike <helen.koike@collabora.com>
Subject: [igt-dev] [PATCH 2/2] core_getversion: drop unused assert
Date: Sun,  8 Oct 2023 19:23:06 -0300	[thread overview]
Message-ID: <20231008222306.145122-2-helen.koike@collabora.com> (raw)
In-Reply-To: <20231008222306.145122-1-helen.koike@collabora.com>

If IGT_FORCE_DRIVER is used, open_device() already checks if the name
matches, so igt_assert_fd(fd) is already enough.

Signed-off-by: Helen Koike <helen.koike@collabora.com>
---
 tests/core_getversion.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/tests/core_getversion.c b/tests/core_getversion.c
index 8c8e0c9a3..9945c3855 100644
--- a/tests/core_getversion.c
+++ b/tests/core_getversion.c
@@ -48,7 +48,6 @@ igt_simple_main
 {
 	int fd;
 	drmVersionPtr v;
-	const char *name = getenv("IGT_FORCE_DRIVER");
 
 	fd = __drm_open_driver(DRIVER_ANY);
 	igt_assert_fd(fd);
@@ -58,11 +57,6 @@ igt_simple_main
 	igt_assert_neq(strlen(v->desc), 0);
 	if (is_i915_device(fd))
 		igt_assert_lte(1, v->version_major);
-	if (name) {
-		igt_assert_f(!strcmp(name, v->name),
-			     "Expected driver \"%s\" but got \"%s\"\n",
-			     name, v->name);
-	}
 
 	drmFree(v);
 	drm_close_driver(fd);
-- 
2.34.1

  reply	other threads:[~2023-10-08 22:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-08 22:23 [igt-dev] [PATCH 1/2] lib/drmtest: add igt_debug when forced and dev_name doesn't match Helen Koike
2023-10-08 22:23 ` Helen Koike [this message]
2023-10-09 16:09   ` [igt-dev] [PATCH 2/2] core_getversion: drop unused assert Kamil Konieczny
2023-10-08 23:17 ` [igt-dev] ✓ CI.xeBAT: success for series starting with [1/2] lib/drmtest: add igt_debug when forced and dev_name doesn't match Patchwork
2023-10-08 23:18 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-10-09 16:58   ` Kamil Konieczny
2023-10-10 11:09     ` Yedireswarapu, SaiX Nandan
2023-10-09 17:08   ` Kamil Konieczny
2023-10-09 16:08 ` [igt-dev] [PATCH 1/2] " Kamil Konieczny
2023-10-10  9:32 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2] " Patchwork
2023-10-10  9:51 ` Patchwork
2023-11-07 11:02 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] lib/drmtest: add igt_debug when forced and dev_name doesn't match (rev2) Patchwork
2023-11-07 11:02 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-07 22:30 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231008222306.145122-2-helen.koike@collabora.com \
    --to=helen.koike@collabora.com \
    --cc=emma@anholt.net \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=robdclark@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox