Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Subject: [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest
Date: Thu, 12 Oct 2023 09:01:33 +0200	[thread overview]
Message-ID: <20231012070133.31106-1-zbigniew.kempczynski@intel.com> (raw)

Test exercises kernel returns EINVAL on bo create ioctl with unaligned
size what was never merged and according to discussion with Thomas
will never be. Lets remove this test as it is incorrect in this case.

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/intel/xe_create.c | 52 -----------------------------------------
 1 file changed, 52 deletions(-)

diff --git a/tests/intel/xe_create.c b/tests/intel/xe_create.c
index 8d845e5c86..541fc2b335 100644
--- a/tests/intel/xe_create.c
+++ b/tests/intel/xe_create.c
@@ -39,54 +39,6 @@ static int __create_bo(int fd, uint32_t vm, uint64_t size, uint32_t flags,
 	return ret;
 }
 
-/**
- * SUBTEST: create-invalid-size
- * Functionality: ioctl
- * Test category: negative test
- * Description: Verifies xe bo create returns expected error code on invalid
- *              buffer sizes.
- */
-static void create_invalid_size(int fd)
-{
-	struct drm_xe_query_mem_region *memregion;
-	uint64_t memreg = all_memory_regions(fd), region;
-	uint32_t vm;
-	uint32_t handle;
-	int ret;
-
-	vm = xe_vm_create(fd, DRM_XE_VM_CREATE_ASYNC_BIND_OPS, 0);
-
-	xe_for_each_mem_region(fd, memreg, region) {
-		memregion = xe_mem_region(fd, region);
-
-		/* first try, use half of possible min page size */
-		ret = __create_bo(fd, vm, memregion->min_page_size >> 1,
-				  region, &handle);
-		if (!ret) {
-			gem_close(fd, handle);
-			xe_vm_destroy(fd, vm);
-		}
-		igt_assert_eq(ret, -EINVAL);
-
-		/*
-		 * second try, add page size to min page size if it is
-		 * bigger than page size.
-		 */
-		if (memregion->min_page_size > PAGE_SIZE) {
-			ret = __create_bo(fd, vm,
-					  memregion->min_page_size + PAGE_SIZE,
-					  region, &handle);
-			if (!ret) {
-				gem_close(fd, handle);
-				xe_vm_destroy(fd, vm);
-			}
-			igt_assert_eq(ret, -EINVAL);
-		}
-	}
-
-	xe_vm_destroy(fd, vm);
-}
-
 enum exec_queue_destroy {
 	NOLEAK,
 	LEAK
@@ -214,10 +166,6 @@ igt_main
 	igt_fixture
 		xe = drm_open_driver(DRIVER_XE);
 
-	igt_subtest("create-invalid-size") {
-		create_invalid_size(xe);
-	}
-
 	igt_subtest("create-execqueues-noleak")
 		create_execqueues(xe, NOLEAK);
 
-- 
2.34.1

             reply	other threads:[~2023-10-12  7:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12  7:01 Zbigniew Kempczyński [this message]
2023-10-12 10:02 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/xe_create: Remove create-invalid-size subtest (rev2) Patchwork
2023-10-12 10:40 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-12 10:43 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-10-13  5:07 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-16 15:19 ` [igt-dev] [PATCH i-g-t] tests/xe_create: Remove create-invalid-size subtest Thomas Hellström
  -- strict thread matches above, loose matches on Subject: below --
2023-06-26 14:23 Zbigniew Kempczyński
2023-06-26 15:23 ` Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231012070133.31106-1-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox