From: Hersen Wu <hersenxs.wu@amd.com>
To: <igt-dev@lists.freedesktop.org>, <juhapekka.heikkila@gmail.com>,
<kamil.konieczny@linux.intel.com>, <rodrigo.siqueira@amd.com>,
<aurabindo.pillai@amd.com>, <alex.hung@amd.com>,
<hamza.mahfooz@amd.com>, <sunpeng.li@amd.com>
Cc: Hersen Wu <hersenxs.wu@amd.com>, markyacoub@google.com
Subject: [igt-dev] [PATCH 1/2] [i-g-t] tests/kms_cursor_crc: Fix cursor crop on AMD gpu
Date: Mon, 16 Oct 2023 16:58:04 -0400 [thread overview]
Message-ID: <20231016205805.86100-1-hersenxs.wu@amd.com> (raw)
Remove extra line when create cursor fb for AMD gpu.
AMD gpu does not support cursor buffer crop. AMD driver
fails validation with fb size not equal to cursor size.
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_cursor_crc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 76c01f557..ba29ff65d 100644
--- a/tests/kms_cursor_crc.c
+++ b/tests/kms_cursor_crc.c
@@ -560,14 +560,18 @@ static void create_cursor_fb(data_t *data, int cur_w, int cur_h)
{
cairo_t *cr;
uint32_t fb_id;
+ int cur_h_extra_line = 1;
+ /* Cropping is not supported for cursor plane by AMD */
+ if (is_amdgpu_device(data->drm_fd))
+ cur_h_extra_line = 0;
/*
* Make the FB slightly taller and leave the extra
* line opaque white, so that we can see that the
* hardware won't scan beyond what it should (esp.
* with non-square cursors).
*/
- fb_id = igt_create_color_fb(data->drm_fd, cur_w, cur_h + 1,
+ fb_id = igt_create_color_fb(data->drm_fd, cur_w, cur_h + cur_h_extra_line,
DRM_FORMAT_ARGB8888,
DRM_FORMAT_MOD_LINEAR,
1.0, 1.0, 1.0,
--
2.25.1
next reply other threads:[~2023-10-16 20:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 20:58 Hersen Wu [this message]
2023-10-16 20:58 ` [igt-dev] [PATCH 2/2] [i-g-t] tests/kms_cursor_crc: Fix test intermittent failures on AMD gpu Hersen Wu
2023-10-16 23:36 ` [igt-dev] ✓ CI.xeBAT: success for series starting with [1/2,i-g-t] tests/kms_cursor_crc: Fix cursor crop " Patchwork
2023-10-16 23:36 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-10-17 7:31 ` Kamil Konieczny
2023-10-17 10:22 ` Yedireswarapu, SaiX Nandan
2023-10-17 16:33 ` Illipilli, TejasreeX
2023-10-17 16:09 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-17 21:19 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-10-18 14:20 ` Patchwork
2023-10-18 16:18 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,i-g-t] tests/kms_cursor_crc: Fix cursor crop on AMD gpu (rev2) Patchwork
2023-10-19 4:14 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [1/2,i-g-t] tests/kms_cursor_crc: Fix cursor crop on AMD gpu Patchwork
2023-10-23 20:08 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [1/2,i-g-t] tests/kms_cursor_crc: Fix cursor crop on AMD gpu (rev3) Patchwork
2023-10-23 21:08 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-10-16 20:53 [igt-dev] [PATCH 1/2] [i-g-t] tests/kms_cursor_crc: Fix cursor crop on AMD gpu Hersen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016205805.86100-1-hersenxs.wu@amd.com \
--to=hersenxs.wu@amd.com \
--cc=alex.hung@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=markyacoub@google.com \
--cc=rodrigo.siqueira@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox