[igt-dev] [PATCH i-g-t] drm-uapi/xe: Add check for access counter granularity

[igt-dev] [PATCH i-g-t] drm-uapi/xe: Add check for access counter granularity

[Francois Dugast]

Align with commit ("drm/xe/xe_exec_queue: Add check for access counter granularity")

CC: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
Signed-off-by: Francois Dugast <francois.dugast@intel.com>
---
 include/drm-uapi/xe_drm.h | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
index d6dd9a388..b316868de 100644
--- a/include/drm-uapi/xe_drm.h
+++ b/include/drm-uapi/xe_drm.h
@@ -730,6 +730,20 @@ struct drm_xe_vm_bind {
 	__u64 reserved[2];
 };
 
+/* For use with XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY */
+
+/* Monitor 128KB contiguous region with 4K sub-granularity */
+#define XE_ACC_GRANULARITY_128K 0
+
+/* Monitor 2MB contiguous region with 64KB sub-granularity */
+#define XE_ACC_GRANULARITY_2M 1
+
+/* Monitor 16MB contiguous region with 512KB sub-granularity */
+#define XE_ACC_GRANULARITY_16M 2
+
+/* Monitor 64MB contiguous region with 2M sub-granularity */
+#define XE_ACC_GRANULARITY_64M 3
+
 /**
  * struct drm_xe_exec_queue_set_property - exec queue set property
  *
-- 
2.34.1

[igt-dev] ✓ CI.xeBAT: success for drm-uapi/xe: Add check for access counter granularity

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2135 bytes --]

== Series Details ==

Series: drm-uapi/xe: Add check for access counter granularity
URL   : https://patchwork.freedesktop.org/series/126274/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7582_BAT -> XEIGTPW_10164_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (3 -> 3)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in XEIGTPW_10164_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1:
    - bat-adlp-7:         [PASS][1] -> [FAIL][2] ([Intel XE#480]) +2 other tests fail
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7582/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10164/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1.html

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@basic:
    - bat-adlp-7:         [FAIL][3] ([Intel XE#616] / [Intel XE#750]) -> [DMESG-FAIL][4] ([Intel XE#282] / [i915#2017])
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7582/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10164/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html

  
  [Intel XE#282]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/282
  [Intel XE#480]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/480
  [Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
  [Intel XE#750]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/750
  [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017


Build changes
-------------

  * IGT: IGT_7582 -> IGTPW_10164

  IGTPW_10164: 10164
  IGT_7582: 453b9df12fbc9fff561bdb4eb97992983e74c3d4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-485-b3890fb4386dcef68a96888141c4cc773f6241ce: b3890fb4386dcef68a96888141c4cc773f6241ce

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10164/index.html

[-- Attachment #2: Type: text/html, Size: 2706 bytes --]

Re: [igt-dev] [PATCH i-g-t] drm-uapi/xe: Add check for access counter granularity

[Kamil Konieczny]

Hi Francois,
On 2023-11-10 at 14:24:40 +0000, Francois Dugast wrote:
> Align with commit ("drm/xe/xe_exec_queue: Add check for access counter granularity")
> 
> CC: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
- ^^
s/CC/Cc/

With or without that:
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
> ---
>  include/drm-uapi/xe_drm.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/include/drm-uapi/xe_drm.h b/include/drm-uapi/xe_drm.h
> index d6dd9a388..b316868de 100644
> --- a/include/drm-uapi/xe_drm.h
> +++ b/include/drm-uapi/xe_drm.h
> @@ -730,6 +730,20 @@ struct drm_xe_vm_bind {
>  	__u64 reserved[2];
>  };
>  
> +/* For use with XE_EXEC_QUEUE_SET_PROPERTY_ACC_GRANULARITY */
> +
> +/* Monitor 128KB contiguous region with 4K sub-granularity */
> +#define XE_ACC_GRANULARITY_128K 0
> +
> +/* Monitor 2MB contiguous region with 64KB sub-granularity */
> +#define XE_ACC_GRANULARITY_2M 1
> +
> +/* Monitor 16MB contiguous region with 512KB sub-granularity */
> +#define XE_ACC_GRANULARITY_16M 2
> +
> +/* Monitor 64MB contiguous region with 2M sub-granularity */
> +#define XE_ACC_GRANULARITY_64M 3
> +
>  /**
>   * struct drm_xe_exec_queue_set_property - exec queue set property
>   *
> -- 
> 2.34.1
>