[igt-dev] [PATCH i-g-t 0/1] lib/igt_core: initialize srandom seed on startup

[igt-dev] [PATCH i-g-t 0/1] lib/igt_core: initialize srandom seed on startup

[Lukasz Laguna]

Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>

Lukasz Laguna (1):
  lib/igt_core: initialize srandom seed on startup

 lib/igt_core.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.40.0

[igt-dev] [PATCH i-g-t 1/1] lib/igt_core: initialize srandom seed on startup

[Lukasz Laguna]

Init seed for random number generator on IGT startup.

Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
---
 lib/igt_core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/igt_core.c b/lib/igt_core.c
index 041e4b328..1abe3d337 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1283,6 +1283,7 @@ out:
 		bind_fbcon(false);
 		igt_kmsg(KMSG_INFO "%s: executing\n", command_str);
 		print_version();
+		igt_srandom();
 
 		sync();
 		oom_adjust_for_doom();
-- 
2.40.0

[igt-dev] ✗ Fi.CI.BAT: failure for lib/igt_core: initialize srandom seed on startup

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6341 bytes --]

== Series Details ==

Series: lib/igt_core: initialize srandom seed on startup
URL   : https://patchwork.freedesktop.org/series/126757/
State : failure

== Summary ==

CI Bug Log - changes from IGT_7596 -> IGTPW_10242
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_10242 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_10242, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/index.html

Participating hosts (37 -> 37)
------------------------------

  Additional (2): bat-rpls-1 bat-kbl-2 
  Missing    (2): bat-mtlp-8 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_10242:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_module_load@load:
    - bat-rpls-1:         NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-rpls-1/igt@i915_module_load@load.html
    - bat-dg1-7:          [PASS][2] -> [ABORT][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7596/bat-dg1-7/igt@i915_module_load@load.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-dg1-7/igt@i915_module_load@load.html

  
Known issues
------------

  Here are the changes found in IGTPW_10242 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-jsl-1:          NOTRUN -> [SKIP][4] ([i915#9318])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-jsl-1/igt@debugfs_test@basic-hwmon.html

  * igt@fbdev@info:
    - bat-kbl-2:          NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#1849])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-kbl-2/igt@fbdev@info.html

  * igt@gem_huc_copy@huc-copy:
    - bat-jsl-1:          NOTRUN -> [SKIP][6] ([i915#2190])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-jsl-1/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - bat-kbl-2:          NOTRUN -> [SKIP][7] ([fdo#109271]) +20 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-kbl-2/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_lmem_swapping@verify-random:
    - bat-jsl-1:          NOTRUN -> [SKIP][8] ([i915#4613]) +3 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-jsl-1/igt@gem_lmem_swapping@verify-random.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-jsl-1:          NOTRUN -> [SKIP][9] ([i915#4103]) +1 other test skip
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-jsl-1/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - bat-jsl-1:          NOTRUN -> [SKIP][10] ([i915#3555]) +1 other test skip
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-jsl-1/igt@kms_dsc@dsc-basic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-jsl-1:          NOTRUN -> [SKIP][11] ([fdo#109285])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-jsl-1/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_hdmi_inject@inject-audio:
    - fi-kbl-guc:         [PASS][12] -> [FAIL][13] ([IGT#3])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7596/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence:
    - bat-kbl-2:          NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#1845]) +14 other tests skip
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-kbl-2/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
    - bat-rplp-1:         [PASS][15] -> [ABORT][16] ([i915#8668])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7596/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][17] ([i915#5334]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_7596/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
  [i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_7596 -> IGTPW_10242

  CI-20190529: 20190529
  CI_DRM_13910: a6fa1fefc44d92897a3be86430dde647f665f3a3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_10242: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/index.html
  IGT_7596: 9179b4310586865a1308634c22f19f7ebca98f61 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/index.html

[-- Attachment #2: Type: text/html, Size: 7379 bytes --]

[igt-dev] ✓ CI.xeBAT: success for lib/igt_core: initialize srandom seed on startup

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 1936 bytes --]

== Series Details ==

Series: lib/igt_core: initialize srandom seed on startup
URL   : https://patchwork.freedesktop.org/series/126757/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_7596_BAT -> XEIGTPW_10242_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (4 -> 4)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in XEIGTPW_10242_BAT that come from known issues:

### IGT changes ###

#### Warnings ####

  * igt@kms_frontbuffer_tracking@basic:
    - bat-adlp-7:         [DMESG-FAIL][1] ([Intel XE#282] / [i915#2017]) -> [FAIL][2] ([Intel XE#616] / [Intel XE#750])
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7596/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10242/bat-adlp-7/igt@kms_frontbuffer_tracking@basic.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [Intel XE#282]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/282
  [Intel XE#524]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/524
  [Intel XE#616]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/616
  [Intel XE#750]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/750
  [i915#2017]: https://gitlab.freedesktop.org/drm/intel/issues/2017


Build changes
-------------

  * IGT: IGT_7596 -> IGTPW_10242

  IGTPW_10242: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_10242/index.html
  IGT_7596: 9179b4310586865a1308634c22f19f7ebca98f61 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  xe-515-a9ee4928479a5449991149cc38747e8e20376db9: a9ee4928479a5449991149cc38747e8e20376db9

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_10242/index.html

[-- Attachment #2: Type: text/html, Size: 2420 bytes --]

Re: [igt-dev] [PATCH i-g-t 1/1] lib/igt_core: initialize srandom seed on startup

[Kamil Konieczny]

Hi Lukasz,
On 2023-11-22 at 13:40:52 +0100, Lukasz Laguna wrote:
> Init seed for random number generator on IGT startup.
> 
> Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>

LGTM
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

> ---
>  lib/igt_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/igt_core.c b/lib/igt_core.c
> index 041e4b328..1abe3d337 100644
> --- a/lib/igt_core.c
> +++ b/lib/igt_core.c
> @@ -1283,6 +1283,7 @@ out:
>  		bind_fbcon(false);
>  		igt_kmsg(KMSG_INFO "%s: executing\n", command_str);
>  		print_version();
> +		igt_srandom();
>  
>  		sync();
>  		oom_adjust_for_doom();
> -- 
> 2.40.0
> 

[igt-dev] [PATCH i-g-t 0/1] lib/igt_core: initialize srandom seed on startup

[Lukasz Laguna]

Lukasz Laguna (1):
  lib/igt_core: initialize srandom seed on startup

 lib/igt_core.c | 1 +
 1 file changed, 1 insertion(+)

-- 
2.40.0

Re: [igt-dev] [PATCH i-g-t 1/1] lib/igt_core: initialize srandom seed on startup

[Laguna, Lukasz]

On 11/23/2023 18:35, Kamil Konieczny wrote:
> Hi Lukasz,
> On 2023-11-22 at 13:40:52 +0100, Lukasz Laguna wrote:
>> Init seed for random number generator on IGT startup.
>>
>> Signed-off-by: Lukasz Laguna <lukasz.laguna@intel.com>
> LGTM
> Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Hi Kamil,
Thanks for review. I've just sent a patch with rb added. Can you please 
merge it?
>> ---
>>   lib/igt_core.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/igt_core.c b/lib/igt_core.c
>> index 041e4b328..1abe3d337 100644
>> --- a/lib/igt_core.c
>> +++ b/lib/igt_core.c
>> @@ -1283,6 +1283,7 @@ out:
>>   		bind_fbcon(false);
>>   		igt_kmsg(KMSG_INFO "%s: executing\n", command_str);
>>   		print_version();
>> +		igt_srandom();
>>   
>>   		sync();
>>   		oom_adjust_for_doom();
>> -- 
>> 2.40.0
>>