From: Nidhi Gupta <nidhi1.gupta@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Nidhi Gupta <nidhi1.gupta@intel.com>
Subject: [igt-dev] [PATCH i-g-t v3] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe
Date: Tue, 28 Nov 2023 08:03:48 +0530 [thread overview]
Message-ID: <20231128023348.19418-1-nidhi1.gupta@intel.com> (raw)
Added a new subtest as kms_frontbuffer_tracking@pipe-fbc-rte.
It will execute on each pipe with valid output and check if FBC is
enabled or not.
v2: Change the test design to reuse the existing
rte_subtest() code for each pipe (Bhanu)
v3: Use igt_fixture to restore the default
parameters (Bhanu)
Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
tests/intel/kms_frontbuffer_tracking.c | 53 ++++++++++++++++++++++++++
1 file changed, 53 insertions(+)
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index 259dfd136..257ba4273 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -1163,6 +1163,15 @@
* @y: Y tiling
*/
+/**
+ * SUBTEST: pipe-fbc-rte
+ * Description: Sanity test to enable FBC on each pipe.
+ * Driver requirement: i915, xe
+ * Functionality: fbc
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
#define TIME SLOW_QUICK(1000, 10000)
IGT_TEST_DESCRIPTION("Test the Kernel's frontbuffer tracking mechanism and "
@@ -4459,11 +4468,15 @@ struct option long_options[] = {
igt_main_args("", long_options, help_str, opt_handler, NULL)
{
struct test_mode t;
+ struct modeset_params default_mode_params;
int devid;
+ enum pipe pipe;
+ igt_output_t *output;
igt_fixture {
setup_environment();
devid = intel_get_drm_devid(drm.fd);
+ default_mode_params = prim_mode_params;
}
for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
@@ -4500,6 +4513,46 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
plane_fbc_rte_subtest(&t);
}
+ igt_subtest_with_dynamic("pipe-fbc-rte") {
+
+ t.pipes = PIPE_SINGLE;
+ t.feature = FEATURE_FBC;
+ t.screen = SCREEN_PRIM;
+ t.fbs = FBS_INDIVIDUAL;
+ t.format = FORMAT_DEFAULT;
+ t.method = IGT_DRAW_BLT;
+ /* Make sure nothing is using these values. */
+ t.flip = -1;
+ t.tiling = opt.tiling;
+
+ for_each_pipe(&drm.display, pipe) {
+
+ if (pipe == default_mode_params.pipe) {
+ igt_info("pipe-%s: FBC validated in other subtest\n", kmstest_pipe_name(pipe));
+ continue;
+ }
+
+ if (!intel_fbc_supported_on_chipset(drm.fd, pipe)) {
+ igt_info("Can't test FBC: not supported on pipe-%s\n", kmstest_pipe_name(pipe));
+ continue;
+ }
+
+ for_each_valid_output_on_pipe(&drm.display, pipe, output) {
+ init_mode_params(&prim_mode_params, output, pipe);
+ setup_fbc();
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
+ igt_output_name(output))
+ rte_subtest(&t);
+ break; /* One output is enough. */
+ }
+
+ }
+ }
+
+ igt_fixture
+ prim_mode_params = default_mode_params;
+
+
TEST_MODE_ITER_BEGIN(t)
igt_subtest_f("%s-%s-%s-%s-%s-draw-%s",
--
2.39.0
next reply other threads:[~2023-11-28 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 2:33 Nidhi Gupta [this message]
2023-11-28 2:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe (rev3) Patchwork
2023-11-28 3:24 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-11-28 3:24 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-28 5:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-11-28 8:13 ` [igt-dev] [PATCH i-g-t v3] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128023348.19418-1-nidhi1.gupta@intel.com \
--to=nidhi1.gupta@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox