Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v3] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe
@ 2023-11-28  2:33 Nidhi Gupta
  2023-11-28  2:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe (rev3) Patchwork
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Nidhi Gupta @ 2023-11-28  2:33 UTC (permalink / raw)
  To: igt-dev; +Cc: Nidhi Gupta

Added a new subtest as kms_frontbuffer_tracking@pipe-fbc-rte.
It will execute on each pipe with valid output and check if FBC is
enabled or not.

v2: Change the test design to reuse the existing
    rte_subtest() code for each pipe (Bhanu)

v3: Use igt_fixture to restore the default
    parameters (Bhanu)

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 53 ++++++++++++++++++++++++++
 1 file changed, 53 insertions(+)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index 259dfd136..257ba4273 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -1163,6 +1163,15 @@
  * @y:              Y tiling
  */
 
+/**
+ * SUBTEST: pipe-fbc-rte
+ * Description: Sanity test to enable FBC on each pipe.
+ * Driver requirement: i915, xe
+ * Functionality: fbc
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
 #define TIME SLOW_QUICK(1000, 10000)
 
 IGT_TEST_DESCRIPTION("Test the Kernel's frontbuffer tracking mechanism and "
@@ -4459,11 +4468,15 @@ struct option long_options[] = {
 igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
 	struct test_mode t;
+	struct modeset_params default_mode_params;
 	int devid;
+	enum pipe pipe;
+	igt_output_t *output;
 
 	igt_fixture {
 		setup_environment();
 		devid = intel_get_drm_devid(drm.fd);
+		default_mode_params = prim_mode_params;
 	}
 
 	for (t.feature = 0; t.feature < FEATURE_COUNT; t.feature++) {
@@ -4500,6 +4513,46 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		plane_fbc_rte_subtest(&t);
 	}
 
+	igt_subtest_with_dynamic("pipe-fbc-rte") {
+
+		t.pipes = PIPE_SINGLE;
+		t.feature = FEATURE_FBC;
+		t.screen = SCREEN_PRIM;
+		t.fbs = FBS_INDIVIDUAL;
+		t.format = FORMAT_DEFAULT;
+		t.method = IGT_DRAW_BLT;
+		/* Make sure nothing is using these values. */
+		t.flip = -1;
+		t.tiling = opt.tiling;
+
+		for_each_pipe(&drm.display, pipe) {
+
+			if (pipe == default_mode_params.pipe) {
+				igt_info("pipe-%s: FBC validated in other subtest\n", kmstest_pipe_name(pipe));
+				continue;
+			}
+
+			if (!intel_fbc_supported_on_chipset(drm.fd, pipe)) {
+				igt_info("Can't test FBC: not supported on pipe-%s\n", kmstest_pipe_name(pipe));
+				continue;
+			}
+
+			for_each_valid_output_on_pipe(&drm.display, pipe, output) {
+				init_mode_params(&prim_mode_params, output, pipe);
+				setup_fbc();
+				igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
+					      igt_output_name(output))
+					rte_subtest(&t);
+				break; /* One output is enough. */
+			}
+
+		}
+	}
+
+	igt_fixture
+		prim_mode_params = default_mode_params;
+
+
 	TEST_MODE_ITER_BEGIN(t)
 
 		igt_subtest_f("%s-%s-%s-%s-%s-draw-%s",
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-28  8:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28  2:33 [igt-dev] [PATCH i-g-t v3] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe Nidhi Gupta
2023-11-28  2:51 ` [igt-dev] ✗ GitLab.Pipeline: warning for tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe (rev3) Patchwork
2023-11-28  3:24 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-11-28  3:24 ` [igt-dev] ✓ CI.xeBAT: " Patchwork
2023-11-28  5:54 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-11-28  8:13 ` [igt-dev] [PATCH i-g-t v3] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe Modem, Bhanuprakash

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox