Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t v5] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe
@ 2023-11-28  9:31 Nidhi Gupta
  2023-11-28 10:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe (rev5) Patchwork
  2023-11-28 10:43 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork
  0 siblings, 2 replies; 3+ messages in thread
From: Nidhi Gupta @ 2023-11-28  9:31 UTC (permalink / raw)
  To: igt-dev; +Cc: Nidhi Gupta

Added a new subtest as kms_frontbuffer_tracking@pipe-fbc-rte.
It will execute on each pipe with valid output and check if FBC is
enabled or not.

v2: Change the test design to reuse the existing
    rte_subtest() code for each pipe (Bhanu)

v3: Use igt_fixture to restore the default
    parameters (Bhanu)

v4: fixed nitpicks (Bhanu)

v5: create igt_subtest_group and move igt_fixture
    inside the group (Bhanu)

Signed-off-by: Nidhi Gupta <nidhi1.gupta@intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 51 ++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index 259dfd136..405a8a178 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -57,6 +57,10 @@
  * Description: Sanity test to enable FBC on a plane.
  * Functionality: fbc
  *
+ * SUBTEST: pipe-fbc-rte
+ * Description: Sanity test to enable FBC on each pipe.
+ * Functionality: fbc
+ *
  * SUBTEST: drrs-%dp-rte
  * Description: Sanity test to enable DRRS with %arg[1] panels.
  * Functionality: fbt, drrs
@@ -4459,7 +4463,10 @@ struct option long_options[] = {
 igt_main_args("", long_options, help_str, opt_handler, NULL)
 {
 	struct test_mode t;
+	struct modeset_params default_mode_params;
 	int devid;
+	enum pipe pipe;
+	igt_output_t *output;
 
 	igt_fixture {
 		setup_environment();
@@ -4500,6 +4507,50 @@ igt_main_args("", long_options, help_str, opt_handler, NULL)
 		plane_fbc_rte_subtest(&t);
 	}
 
+	igt_subtest_group {
+		igt_subtest_with_dynamic("pipe-fbc-rte") {
+
+			t.pipes = PIPE_SINGLE;
+			t.feature = FEATURE_FBC;
+			t.screen = SCREEN_PRIM;
+			t.fbs = FBS_INDIVIDUAL;
+			t.format = FORMAT_DEFAULT;
+			t.method = IGT_DRAW_BLT;
+			/* Make sure nothing is using these values. */
+			t.flip = -1;
+			t.tiling = opt.tiling;
+
+			default_mode_params.pipe = prim_mode_params.pipe;
+
+			for_each_pipe(&drm.display, pipe) {
+
+				if (pipe == default_mode_params.pipe) {
+					igt_info("pipe-%s: FBC validated in other subtest\n", kmstest_pipe_name(pipe));
+					continue;
+				}
+
+				if (!intel_fbc_supported_on_chipset(drm.fd, pipe)) {
+					igt_info("Can't test FBC: not supported on pipe-%s\n", kmstest_pipe_name(pipe));
+					continue;
+				}
+
+				for_each_valid_output_on_pipe(&drm.display, pipe, output) {
+					init_mode_params(&prim_mode_params, output, pipe);
+					setup_fbc();
+
+					igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe),
+						      igt_output_name(output))
+						rte_subtest(&t);
+
+					break; /* One output is enough. */
+				}
+			}
+		}
+
+		igt_fixture
+			init_modeset_cached_params();
+	}
+
 	TEST_MODE_ITER_BEGIN(t)
 
 		igt_subtest_f("%s-%s-%s-%s-%s-draw-%s",
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-28 10:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-28  9:31 [igt-dev] [PATCH i-g-t v5] tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe Nidhi Gupta
2023-11-28 10:13 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/intel/kms_frontbuffer_tracking: Add new subtest to test FBC on each pipe (rev5) Patchwork
2023-11-28 10:43 ` [igt-dev] ✓ CI.xeBAT: success " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox