From: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t] benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing
Date: Thu, 7 Dec 2023 17:35:16 +0100 [thread overview]
Message-ID: <20231207163516.8036-1-marcin.bernatowicz@intel.com> (raw)
During the split of xe_sync types from flags introduced in commit ce4e53b0faecde8884f1d4eac81d604b6e1904b8,
the array index of xe_sync objects was unnecessarily incremented in one of the lines.
This caused the next line to reference the wrong xe_sync object.
This patch fixes the array index issue, ensuring the correct xe_sync object is referenced.
Fixes: ce4e53b0faecde8884f1d4eac81d604b6e1904b8 ("drm-uapi/xe: Split xe_sync types from flags")
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@intel.com>
---
benchmarks/gem_wsim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c
index e937e1027..30673da8f 100644
--- a/benchmarks/gem_wsim.c
+++ b/benchmarks/gem_wsim.c
@@ -1784,7 +1784,7 @@ xe_alloc_step_batch(struct workload *wrk, struct w_step *w)
i = 0;
/* out fence */
w->xe.syncs[i].handle = syncobj_create(fd, 0);
- w->xe.syncs[i++].type = DRM_XE_SYNC_TYPE_SYNCOBJ;
+ w->xe.syncs[i].type = DRM_XE_SYNC_TYPE_SYNCOBJ;
w->xe.syncs[i++].flags = DRM_XE_SYNC_FLAG_SIGNAL;
/* in fence(s) */
for_each_dep(dep, w->data_deps) {
--
2.31.1
next reply other threads:[~2023-12-07 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 16:35 Marcin Bernatowicz [this message]
2023-12-07 18:14 ` [PATCH i-g-t] benchmarks/gem_wsim: Fix array index issue in xe_sync object referencing Kamil Konieczny
2023-12-07 20:12 ` ✓ Fi.CI.BAT: success for " Patchwork
2023-12-07 21:44 ` ✓ CI.xeBAT: " Patchwork
2023-12-08 6:41 ` ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231207163516.8036-1-marcin.bernatowicz@intel.com \
--to=marcin.bernatowicz@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox