From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: <igt-dev@lists.freedesktop.org>, Petri Latvala <adrinael@adrinael.net>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
Simon Ser <contact@emersion.fr>, Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH i-g-t 4/4] tests/kms_atomic: Add subtest for solid fill cursor planes
Date: Fri, 15 Dec 2023 16:40:24 -0800 [thread overview]
Message-ID: <20231215-solid-fill-v1-4-12932f9f452d@quicinc.com> (raw)
In-Reply-To: <20231215-solid-fill-v1-0-12932f9f452d@quicinc.com>
Add a subtest for testing solid fill cursor planes.
This test will commit a solid fill cursor plane on top of a normal
framebuffer primary plane and compare the resulting CRC with the CRC
value of a framebuffer cursor and primary plane of the same contents.
Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
tests/kms_atomic.c | 34 ++++++++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 8f81e65ad84f..057fba0d6767 100755
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -1349,10 +1349,18 @@ static void test_solid_fill_plane(data_t *data, igt_output_t *output, igt_plane
.pad = 0x0,
};
- rect.x1 = 0;
- rect.x2 = mode->hdisplay;
- rect.y1 = 0;
- rect.y2 = mode->vdisplay;
+ if (plane->type == DRM_PLANE_TYPE_PRIMARY)
+ {
+ rect.x1 = 0;
+ rect.x2 = mode->hdisplay;
+ rect.y1 = 0;
+ rect.y2 = mode->vdisplay;
+ } else {
+ rect.x1 = mode->hdisplay / 2 - 50;
+ rect.x2 = mode->hdisplay / 2 + 50;
+ rect.y1 = mode->vdisplay / 2 - 50;
+ rect.y2 = mode->vdisplay / 2 + 50;
+ }
height = rect.y2 - rect.y1;
width = rect.x2 - rect.x1;
@@ -1728,6 +1736,24 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
}
+ igt_describe("Test case for solid fill cursor planes");
+ igt_subtest_with_dynamic("plane-cursor-solid-fill") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ igt_plane_t *cursor =
+ igt_pipe_get_plane_type(&data.display.pipes[pipe], DRM_PLANE_TYPE_CURSOR);
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+ if (!cursor)
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ atomic_setup(&data, pipe, output);
+ test_solid_fill_plane(&data, output, cursor);
+ atomic_clear(&data, pipe, output);
+ }
+ }
+ }
+
igt_fixture {
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
--
2.43.0
WARNING: multiple messages have this Message-ID (diff)
From: Jessica Zhang <quic_jesszhan@quicinc.com>
To: igt-dev@lists.freedesktop.org, Petri Latvala <adrinael@adrinael.net>
Cc: Pekka Paalanen <pekka.paalanen@collabora.com>,
Simon Ser <contact@emersion.fr>, Rob Clark <robdclark@gmail.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: [PATCH i-g-t 4/4] tests/kms_atomic: Add subtest for solid fill cursor planes
Date: Fri, 15 Dec 2023 16:40:24 -0800 [thread overview]
Message-ID: <20231215-solid-fill-v1-4-12932f9f452d@quicinc.com> (raw)
Message-ID: <20231216004024.5uJFZlnK4KnNf2VkHv3_kK4fk--IUkjmrb-RnbODbtE@z> (raw)
In-Reply-To: <20231215-solid-fill-v1-0-12932f9f452d@quicinc.com>
Add a subtest for testing solid fill cursor planes.
This test will commit a solid fill cursor plane on top of a normal
framebuffer primary plane and compare the resulting CRC with the CRC
value of a framebuffer cursor and primary plane of the same contents.
Signed-off-by: Jessica Zhang <quic_jesszhan@quicinc.com>
---
tests/kms_atomic.c | 34 ++++++++++++++++++++++++++++++----
1 file changed, 30 insertions(+), 4 deletions(-)
diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c
index 8f81e65ad84f..057fba0d6767 100755
--- a/tests/kms_atomic.c
+++ b/tests/kms_atomic.c
@@ -1349,10 +1349,18 @@ static void test_solid_fill_plane(data_t *data, igt_output_t *output, igt_plane
.pad = 0x0,
};
- rect.x1 = 0;
- rect.x2 = mode->hdisplay;
- rect.y1 = 0;
- rect.y2 = mode->vdisplay;
+ if (plane->type == DRM_PLANE_TYPE_PRIMARY)
+ {
+ rect.x1 = 0;
+ rect.x2 = mode->hdisplay;
+ rect.y1 = 0;
+ rect.y2 = mode->vdisplay;
+ } else {
+ rect.x1 = mode->hdisplay / 2 - 50;
+ rect.x2 = mode->hdisplay / 2 + 50;
+ rect.y1 = mode->vdisplay / 2 - 50;
+ rect.y2 = mode->vdisplay / 2 + 50;
+ }
height = rect.y2 - rect.y1;
width = rect.x2 - rect.x1;
@@ -1728,6 +1736,24 @@ igt_main_args("e", NULL, help_str, opt_handler, NULL)
}
}
+ igt_describe("Test case for solid fill cursor planes");
+ igt_subtest_with_dynamic("plane-cursor-solid-fill") {
+ for_each_pipe_with_single_output(&data.display, pipe, output) {
+ igt_plane_t *cursor =
+ igt_pipe_get_plane_type(&data.display.pipes[pipe], DRM_PLANE_TYPE_CURSOR);
+ if (!pipe_output_combo_valid(&data.display, pipe, output))
+ continue;
+ if (!cursor)
+ continue;
+
+ igt_dynamic_f("pipe-%s-%s", kmstest_pipe_name(pipe), igt_output_name(output)) {
+ atomic_setup(&data, pipe, output);
+ test_solid_fill_plane(&data, output, cursor);
+ atomic_clear(&data, pipe, output);
+ }
+ }
+ }
+
igt_fixture {
igt_display_fini(&data.display);
drm_close_driver(data.drm_fd);
--
2.43.0
next prev parent reply other threads:[~2023-12-16 0:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-16 0:40 [PATCH i-g-t 0/4] Add tests for solid fill planes Jessica Zhang
2023-12-16 0:40 ` Jessica Zhang
2023-12-16 0:40 ` [PATCH i-g-t 1/4] tests/kms_atomic: Free pipe_crc object Jessica Zhang
2023-12-16 0:40 ` Jessica Zhang
2023-12-16 0:40 ` [PATCH i-g-t 2/4] lib: Add support for solid_fill and pixel_source plane properties Jessica Zhang
2023-12-16 0:40 ` Jessica Zhang
2023-12-19 13:51 ` Kamil Konieczny
2023-12-22 0:00 ` Jessica Zhang
2023-12-22 0:00 ` Jessica Zhang
2023-12-16 0:40 ` [PATCH i-g-t 3/4] tests/kms_atomic: Add solid fill plane subtest Jessica Zhang
2023-12-16 0:40 ` Jessica Zhang
2023-12-18 10:12 ` Pekka Paalanen
2023-12-19 13:47 ` Kamil Konieczny
2024-01-11 9:19 ` Pekka Paalanen
2023-12-21 23:57 ` Jessica Zhang
2024-01-11 9:20 ` Pekka Paalanen
2024-01-18 23:35 ` Jessica Zhang
2024-01-19 9:00 ` Pekka Paalanen
2024-01-19 17:40 ` Abhinav Kumar
2024-01-22 7:56 ` Pekka Paalanen
2024-01-23 23:28 ` Jessica Zhang
2023-12-19 13:59 ` Kamil Konieczny
2023-12-16 0:40 ` Jessica Zhang [this message]
2023-12-16 0:40 ` [PATCH i-g-t 4/4] tests/kms_atomic: Add subtest for solid fill cursor planes Jessica Zhang
2023-12-16 0:49 ` ✗ Fi.CI.BUILD: failure for Add tests for solid fill planes Patchwork
2023-12-16 0:53 ` ✗ GitLab.Pipeline: warning " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231215-solid-fill-v1-4-12932f9f452d@quicinc.com \
--to=quic_jesszhan@quicinc.com \
--cc=adrinael@adrinael.net \
--cc=contact@emersion.fr \
--cc=dmitry.baryshkov@linaro.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=pekka.paalanen@collabora.com \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox