From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 12/12] tests/kms_big_fb: Also test some CCS modifiers
Date: Wed, 20 Dec 2023 19:59:34 +0200 [thread overview]
Message-ID: <20231220175934.22849-13-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20231220175934.22849-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Panning inside compressed framebuffers has similar challenges
as planar YCbCr framebuffers. So let's test this as well.
The difference is that i915 can't do GGTT remapping for CCS,
so we must limit the fb size to fit insie the hw limits.
Only enable this for the pre-TGL modifiers for now as testing
on TGL didn't go well. I suspect the problem lies with rendercopy
but until that is sorted let's not add tons of failures to CI.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
tests/intel/kms_big_fb.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/tests/intel/kms_big_fb.c b/tests/intel/kms_big_fb.c
index f8dd5a015ee1..f7551fe0e873 100644
--- a/tests/intel/kms_big_fb.c
+++ b/tests/intel/kms_big_fb.c
@@ -73,6 +73,8 @@
* @x-tiled: TILE-X modifier
* @y-tiled: TILE-Y modifier
* @yf-tiled: TILE-YF modifier
+ * @y-tiled-ccs: TILE-Y+CCS modifier
+ * @yf-tiled-ccs: TILE-YF+CCS modifier
*
* arg[2].values: 8bpp, 16bpp, 32bpp, 64bpp, nv12, p016
* arg[3].values: 0, 90, 180, 270
@@ -110,6 +112,8 @@
* @x-tiled: TILE-X modifier
* @y-tiled: TILE-Y modifier
* @yf-tiled: TILE-YF modifier
+ * @y-tiled-ccs: TILE-Y+CCS modifier
+ * @yf-tiled-ccs: TILE-YF+CCS modifier
*
* arg[2].values: 32, 64
* arg[3].values: 0, 180
@@ -134,6 +138,8 @@
* @x-tiled: TILE-X modifier
* @y-tiled: TILE-Y modifier
* @yf-tiled: TILE-YF modifier
+ * @y-tiled-ccs: TILE-Y+CCS modifier
+ * @yf-tiled-ccs: TILE-YF+CCS modifier
*
* arg[2].values: 32, 64
* arg[3].values: 0, 180
@@ -171,6 +177,8 @@
* @x-tiled: TILE-X
* @y-tiled: TILE-Y
* @yf-tiled: TILE-YF
+ * @y-tiled-ccs: TILE-Y+CCS modifier
+ * @yf-tiled-ccs: TILE-YF+CCS modifier
*/
IGT_TEST_DESCRIPTION("Test big framebuffers");
@@ -371,7 +379,11 @@ static void max_fb_size(data_t *data, int *width, int *height,
struct igt_fb fb;
int i = 0;
- if (data->max_hw_stride_test) {
+ if (igt_fb_is_ccs_modifier(data->modifier)) {
+ /* FIXME figure out what's correct */
+ *width = 8192;
+ *height = 8192;
+ } else if (data->max_hw_stride_test) {
igt_output_t *output;
*width = data->max_hw_fb_width;
@@ -957,6 +969,9 @@ static bool has_async_flip(data_t *data)
* TODO: preferably probe all this stuff with
* TEST_ONLY rather than hardcoding it...
*/
+ if (igt_fb_is_ccs_modifier(data->modifier))
+ return false;
+
if (igt_format_is_yuv_semiplanar(data->format))
return false;
@@ -978,6 +993,8 @@ static const struct {
{ I915_FORMAT_MOD_Y_TILED, "y-tiled", },
{ I915_FORMAT_MOD_Yf_TILED, "yf-tiled", },
{ I915_FORMAT_MOD_4_TILED, "4-tiled", },
+ { I915_FORMAT_MOD_Y_TILED_CCS, "y-tiled-ccs", },
+ { I915_FORMAT_MOD_Yf_TILED_CCS, "yf-tiled-ccs", },
};
static const struct {
--
2.41.0
prev parent reply other threads:[~2023-12-20 18:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 17:59 [PATCH i-g-t 00/12] tests/kms_big_fb: Test planar formats, and CCS Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 01/12] lib/rendercopy: Add deltas to all surface relocs Ville Syrjala
2023-12-22 5:03 ` [PATCH i-g-t v2 " Ville Syrjala
2023-12-22 5:37 ` [PATCH i-g-t " Zbigniew Kempczyński
2023-12-22 6:01 ` Ville Syrjälä
2023-12-22 6:06 ` Ville Syrjälä
2023-12-22 6:52 ` Ville Syrjälä
2023-12-22 7:26 ` Zbigniew Kempczyński
2023-12-22 8:33 ` Ville Syrjälä
2023-12-20 17:59 ` [PATCH i-g-t 02/12] tests/kms_big_fb: Use igt_fb_create_intel_buf() Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 03/12] lib/igt_fb: Expose igt_fb_is_ccs_modifier() Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 04/12] tests/kms_big_fb: Fix async Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 05/12] tests/kms_big_fb: Test async flips + linear on tgl+ Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 06/12] tests/kms_big_fb: Determine the max fb size the same way always Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 07/12] tests/kms_frontbuffer_tracking: Use igt_create_fb() Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 08/12] lib/igt_fb: Make igt_calc_fb_size() somewhat usable Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 09/12] tests/kms_big_fb: Nuke fliptab[] Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 10/12] tests/kms_big_fb: Replace 'bpp' with 'name' Ville Syrjala
2023-12-20 17:59 ` [PATCH i-g-t 11/12] tests/kms_big_fb: Test planar YCbCr formats Ville Syrjala
2023-12-20 17:59 ` Ville Syrjala [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220175934.22849-13-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox