Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>
Subject: [PATCH] tests/msm_submit: Fix invalid-duplicate-bo-submit errno
Date: Mon,  8 Jan 2024 10:56:38 -0800	[thread overview]
Message-ID: <20240108185638.154998-1-robdclark@gmail.com> (raw)

From: Rob Clark <robdclark@chromium.org>

With the drm_exec conversion[1], this now returns EALREADY.  Which is
arguablly a fix (better error return code).

[1] kernel commit a6397e63877e ("drm/msm/gem: Convert to drm_exec")

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
I'm not sure how much to care about newer igt on older kernel.  I think
I'd be willing to just let this test fail in that case.

 tests/msm/msm_submit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/msm/msm_submit.c b/tests/msm/msm_submit.c
index 95f8318facb0..48cffab6940b 100644
--- a/tests/msm/msm_submit.c
+++ b/tests/msm/msm_submit.c
@@ -102,7 +102,7 @@ igt_main
 				.nr_bos  = ARRAY_SIZE(bos),
 				.bos     = VOID2U64(bos),
 		};
-		do_ioctl_err(dev->fd, DRM_IOCTL_MSM_GEM_SUBMIT, &req, EINVAL);
+		do_ioctl_err(dev->fd, DRM_IOCTL_MSM_GEM_SUBMIT, &req, EALREADY);
 	}
 
 	igt_describe("Check that submit with cmdstream referencing an invalid bo fails");
-- 
2.43.0

             reply	other threads:[~2024-01-08 18:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-08 18:56 Rob Clark [this message]
2024-01-08 21:16 ` ✓ Fi.CI.BAT: success for tests/msm_submit: Fix invalid-duplicate-bo-submit errno Patchwork
2024-01-08 21:22 ` ✓ CI.xeBAT: " Patchwork
2024-01-09  9:42 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-09 12:59 ` [PATCH] " Kamil Konieczny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240108185638.154998-1-robdclark@gmail.com \
    --to=robdclark@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=robdclark@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox