Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tests/msm_submit: Fix invalid-duplicate-bo-submit errno
@ 2024-01-08 18:56 Rob Clark
  2024-01-08 21:16 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Rob Clark @ 2024-01-08 18:56 UTC (permalink / raw)
  To: igt-dev; +Cc: Rob Clark

From: Rob Clark <robdclark@chromium.org>

With the drm_exec conversion[1], this now returns EALREADY.  Which is
arguablly a fix (better error return code).

[1] kernel commit a6397e63877e ("drm/msm/gem: Convert to drm_exec")

Signed-off-by: Rob Clark <robdclark@chromium.org>
---
I'm not sure how much to care about newer igt on older kernel.  I think
I'd be willing to just let this test fail in that case.

 tests/msm/msm_submit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/msm/msm_submit.c b/tests/msm/msm_submit.c
index 95f8318facb0..48cffab6940b 100644
--- a/tests/msm/msm_submit.c
+++ b/tests/msm/msm_submit.c
@@ -102,7 +102,7 @@ igt_main
 				.nr_bos  = ARRAY_SIZE(bos),
 				.bos     = VOID2U64(bos),
 		};
-		do_ioctl_err(dev->fd, DRM_IOCTL_MSM_GEM_SUBMIT, &req, EINVAL);
+		do_ioctl_err(dev->fd, DRM_IOCTL_MSM_GEM_SUBMIT, &req, EALREADY);
 	}
 
 	igt_describe("Check that submit with cmdstream referencing an invalid bo fails");
-- 
2.43.0

^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-01-09 12:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-08 18:56 [PATCH] tests/msm_submit: Fix invalid-duplicate-bo-submit errno Rob Clark
2024-01-08 21:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-01-08 21:22 ` ✓ CI.xeBAT: " Patchwork
2024-01-09  9:42 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-01-09 12:59 ` [PATCH] " Kamil Konieczny

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox