Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [i-g-t] tests/intel/i915_suspend: Fix WARN of invalid fd
Date: Tue,  9 Jan 2024 15:57:03 +0530	[thread overview]
Message-ID: <20240109102703.2529736-1-bhanuprakash.modem@intel.com> (raw)

Move "basic-s2idle-without-i915" & "basic-s3-without-i915" to
end of the file to avoid WARNs:

(i915_suspend:7563) drmtest-WARNING: Don't attempt to close standard/invalid file descriptor: -1

Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
 tests/intel/i915_suspend.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/tests/intel/i915_suspend.c b/tests/intel/i915_suspend.c
index c25805584..bf5a170d3 100644
--- a/tests/intel/i915_suspend.c
+++ b/tests/intel/i915_suspend.c
@@ -320,14 +320,6 @@ int fd;
 
 igt_main
 {
-	igt_describe("Validate suspend-to-idle without i915 module");
-	igt_subtest("basic-s2idle-without-i915")
-		test_suspend_without_i915(SUSPEND_STATE_FREEZE);
-
-	igt_describe("Validate S3 without i915 module");
-	igt_subtest("basic-s3-without-i915")
-		test_suspend_without_i915(SUSPEND_STATE_S3);
-
 	igt_fixture {
 		/*
 		 * Since above subtests may fail, leaving i915 module unloaded
@@ -384,4 +376,12 @@ igt_main
 
 	igt_fixture
 		drm_close_driver(fd);
+
+	igt_describe("Validate suspend-to-idle without i915 module");
+	igt_subtest("basic-s2idle-without-i915")
+		test_suspend_without_i915(SUSPEND_STATE_FREEZE);
+
+	igt_describe("Validate S3 without i915 module");
+	igt_subtest("basic-s3-without-i915")
+		test_suspend_without_i915(SUSPEND_STATE_S3);
 }
-- 
2.40.0

             reply	other threads:[~2024-01-09 10:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-09 10:27 Bhanuprakash Modem [this message]
2024-01-09 12:19 ` ✗ Fi.CI.BAT: failure for tests/intel/i915_suspend: Fix WARN of invalid fd Patchwork
2024-01-09 12:58 ` ✓ CI.xeBAT: success " Patchwork
2024-01-09 13:10 ` [i-g-t V2] " Bhanuprakash Modem
2024-01-09 13:59 ` ✓ Fi.CI.BAT: success for tests/intel/i915_suspend: Fix WARN of invalid fd (rev2) Patchwork
2024-01-09 14:27 ` ✗ CI.xeBAT: failure " Patchwork
2024-01-09 15:34 ` ✗ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240109102703.2529736-1-bhanuprakash.modem@intel.com \
    --to=bhanuprakash.modem@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox