From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [i-g-t V2] tests/intel/i915_suspend: Fix WARN of invalid fd
Date: Tue, 9 Jan 2024 18:40:46 +0530 [thread overview]
Message-ID: <20240109131046.2616465-1-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20240109102703.2529736-1-bhanuprakash.modem@intel.com>
Skip if fd < 0, else drm_close_driver() will throw WARN:
(i915_suspend:7563) drmtest-WARNING: Don't attempt to close standard/invalid file descriptor: -1
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/intel/i915_suspend.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/intel/i915_suspend.c b/tests/intel/i915_suspend.c
index c25805584..0d216741d 100644
--- a/tests/intel/i915_suspend.c
+++ b/tests/intel/i915_suspend.c
@@ -287,6 +287,7 @@ test_suspend_without_i915(int state)
int fd;
fd = __drm_open_driver(DRIVER_INTEL);
+ igt_skip_on_f(fd < 0, "No known gpu found.\n");
igt_devices_scan(false);
/*
--
2.40.0
next prev parent reply other threads:[~2024-01-09 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 10:27 [i-g-t] tests/intel/i915_suspend: Fix WARN of invalid fd Bhanuprakash Modem
2024-01-09 12:19 ` ✗ Fi.CI.BAT: failure for " Patchwork
2024-01-09 12:58 ` ✓ CI.xeBAT: success " Patchwork
2024-01-09 13:10 ` Bhanuprakash Modem [this message]
2024-01-09 13:59 ` ✓ Fi.CI.BAT: success for tests/intel/i915_suspend: Fix WARN of invalid fd (rev2) Patchwork
2024-01-09 14:27 ` ✗ CI.xeBAT: failure " Patchwork
2024-01-09 15:34 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240109131046.2616465-1-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox