From: Hersen Wu <hersenxs.wu@amd.com>
To: igt-dev@lists.freedesktop.org, rodrigo.siqueira@amd.com,
aurabindo.pillai@amd.com, alex.hung@amd.com,
hamza.mahfooz@amd.com, wayne.lin@amd.com
Cc: Hersen Wu <hersenxs.wu@amd.com>, markyacoub@google.com
Subject: [PATCH 3/3] [i-g-t] tests/amdgpu/amd_ilr: Fix psr edp rx crc read timeout
Date: Wed, 17 Jan 2024 21:36:08 -0500 [thread overview]
Message-ID: <20240118023608.55865-3-hersenxs.wu@amd.com> (raw)
In-Reply-To: <20240118023608.55865-1-hersenxs.wu@amd.com>
With debugfs disallow_edp_enter_psr, disable edp
psr before tx read rx crc.
With set_all_output_pipe_to_none of test_init,
tx write dpcd 0x600=2. this will let dpcd 0x170=0.
rx psr and crc check for rx internal logic are disabled.
with disallow_edp_enter_psr, when set test patterns
are committed by igt_display_commit_atomic, kernel
driver will turn on edp with dpcd 0x170=0. then tx
read rx crc successfully.
Signed-off-by: Hersen Wu <hersenxs.wu@amd.com>
---
tests/amdgpu/amd_ilr.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/tests/amdgpu/amd_ilr.c b/tests/amdgpu/amd_ilr.c
index b2c0f294d..1f048d665 100644
--- a/tests/amdgpu/amd_ilr.c
+++ b/tests/amdgpu/amd_ilr.c
@@ -205,11 +205,32 @@ static void test_flow(data_t *data, enum sub_test option)
continue;
}
+ /* igt_amd_output_has_ilr_setting check if debugfs exist,
+ * but ilr settings could be all 0s -- not supported.
+ * need check if ilr settings values are supported.
+ */
+ igt_amd_read_ilr_setting(data->drm_fd, output->name, data->supported_ilr);
+ if (data->supported_ilr[0] == 0)
+ continue;
+
igt_info("Testing on output: %s\n", output->name);
/* Init only if display supports ilr link settings */
test_init(data, output);
+ /* with set_all_output_pipe_to_none within test_init,
+ * kernel driver tx write dpcd 0x600=2 to rx. edp rx
+ * exit psr state and stop verify crc from main link.
+ * with disabllow edp enter psr within kernel, when run
+ * set test pattern, display is turned on. kernel driver
+ * tx will not notify rx psr enable and crc checking by
+ * rx. by this, when tx want to read crc from rx, rx will
+ * check crc and response right away. timeout will not
+ * happens.
+ */
+ if (option == ILR_POLICY)
+ igt_amd_disallow_edp_enter_psr(data->drm_fd, output->name, true);
+
mode = igt_output_get_mode(output);
igt_assert(mode);
@@ -243,6 +264,10 @@ static void test_flow(data_t *data, enum sub_test option)
igt_remove_fb(data->drm_fd, &data->fb);
test_fini(data);
+
+ /* restore allow kernel driver eDP PSR */
+ if (option == ILR_POLICY)
+ igt_amd_disallow_edp_enter_psr(data->drm_fd, output->name, false);
}
}
--
2.25.1
next prev parent reply other threads:[~2024-01-18 2:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 2:36 [PATCH 1/3] [i-g-t] lib/igt_amd: add debugfs disallow edp enter psr Hersen Wu
2024-01-18 2:36 ` [PATCH 2/3] [i-g-t] tests/amdgpu/amd_bypass: Fix psr edp r/x crc read timeout Hersen Wu
2024-01-18 2:36 ` Hersen Wu [this message]
2024-01-18 10:16 ` [PATCH 3/3] [i-g-t] tests/amdgpu/amd_ilr: Fix psr edp rx " Lin, Wayne
2024-01-18 3:20 ` ✓ CI.xeBAT: success for series starting with [1/3,i-g-t] lib/igt_amd: add debugfs disallow edp enter psr Patchwork
2024-01-18 3:34 ` ✓ Fi.CI.BAT: " Patchwork
2024-01-18 5:21 ` ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-01-18 13:14 [PATCH 1/3] [i-g-t] " Hersen Wu
2024-01-18 13:14 ` [PATCH 3/3] [i-g-t] tests/amdgpu/amd_ilr: Fix psr edp rx crc read timeout Hersen Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240118023608.55865-3-hersenxs.wu@amd.com \
--to=hersenxs.wu@amd.com \
--cc=alex.hung@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=markyacoub@google.com \
--cc=rodrigo.siqueira@amd.com \
--cc=wayne.lin@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox